Re: [VOTE] KIP-160: Augment KStream.print() to allow users pass in extra parameters in the printed string

+1 On Fri, Jun 23, 2017 at 3:16 AM, Eno Thereska wrote: > +1 thanks! > > Eno > > On 23 Jun 2017, at 05:29, James Chain wrote: > > > > Hi all, > > > > I apply original idea on KStream#writeAsText() and also update my pull > > request. > >

Re: KIP-160 - Augment KStream.print() to allow users pass in extra parameters in the printed string

James, Does it make sense to include `writeAsText` also in your KIP? Other than that the proposal lgtm. Re-casting my +1 here. Guozhang On Mon, Jun 12, 2017 at 6:59 PM, James Chain wrote: > Agree with Guozhang, +1 > > James Chien > -- -- Guozhang

join

-- = fuyou001 Best Regards

Jenkins build is back to normal : kafka-0.11.0-jdk7 #191

See

[jira] [Resolved] (KAFKA-4829) Improve logging of StreamTask commits

[ https://issues.apache.org/jira/browse/KAFKA-4829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang resolved KAFKA-4829. -- Resolution: Fixed Fix Version/s: 0.11.0.0 Issue resolved by pull request 3354

[GitHub] kafka pull request #3354: KAFKA-4829: Improve log4j on Streams thread / task...

Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/3354 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] kafka pull request #3426: MINOR: Fix race condition in KafkaConsumer close

GitHub user hachikuji opened a pull request: https://github.com/apache/kafka/pull/3426 MINOR: Fix race condition in KafkaConsumer close We intended to make `KafkaConsumer.close()` idempotent, but due to the fact that the `closed` variable is checked without a lock prior to

Re: Pause and max.poll.records

Fetches for each partition are sent once all the pending data for that partition has been consumed. The only difference that pause makes is that we do not bother fetching paused partitions. So in your example, p2 would be fetched even if p1 is paused and has fetched records > max.poll.records

Pause and max.poll.records

How the pause influences max.poll.records? If I have two partitions, say p1 and p2. p1 has number local fetched records > max.poll.records. p2 has no data in local but in the server (not fetched yet). Now, if I pause P1. Does the next poll send fetch request to the server so that I can get data

[GitHub] kafka pull request #3425: Kafka 3368

GitHub user andrasbeni opened a pull request: https://github.com/apache/kafka/pull/3425 Kafka 3368 Added Message set / Record set documentation to protocol.html. Also added short description of new types used in 0.11 You can merge this pull request into a Git repository by

Build failed in Jenkins: kafka-0.11.0-jdk7 #190

See Changes: [jason] MINOR: SaslChannelBuilder should be idempotent -- [...truncated 2.56 MB...] org.apache.kafka.connect.runtime.rest.resources.ConnectorsResourceTest >

Re: [VOTE] 0.11.0.0 RC2

Hi Ismael, Not sure if my response on RC1 was lost or this issue is not a show-stopper: I checked again and with RC2, tests still fail in my Windown 64 bit environment. :clients:checkstyleMain [ant:checkstyle] [ERROR]

Re: [VOTE] 0.11.0.0 RC2

Hi, As previously, Heroku has been doing performance testing of 0.11.0.0 RC2. Now that the ProducerPerformance.java tool supports it, we've even been doing testing with the new transactional/idempotence features in KIP-98. We've tested with idempotency and read_committed consumers and note no

[GitHub] kafka pull request #3424: MINOR: Typo in comments makes debug confusing

GitHub user enothereska opened a pull request: https://github.com/apache/kafka/pull/3424 MINOR: Typo in comments makes debug confusing You can merge this pull request into a Git repository by running: $ git pull https://github.com/enothereska/kafka minor-typo-debug

[GitHub] kafka pull request #3422: MINOR: SaslChannelBuilder should be idempotent

Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/3422 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: Mirroring documentation improvement

Hi Damian, I would like to edit this page: https://cwiki.apache.org/confluence/display/KAFKA/System+Tools Could I also have edit access please? My username is tashoyan. Thanks, Arseniy 23.06.2017 19:28, Damian Guy пишет: Done! Thanks On Fri, 23 Jun 2017 at 15:14 Paolo Patierno

[GitHub] kafka-site pull request #63: Do not use hyphens in wrapping property names i...

GitHub user derrickdoo opened a pull request: https://github.com/apache/kafka-site/pull/63 Do not use hyphens in wrapping property names in tables Hyphenating long property names that wrap inside of tables cells is causing confusion. CSS to prevent this from happening. (mentioned

Re: [DISCUSS] KIP-170: Enhanced TopicCreatePolicy and introduction of TopicDeletePolicy

Thanks for the thoughts Ismael > 1. Have you considered extending RequestMetadata with the additional > information you need? We could add Cluster to it, which has topic > assignment information, for example. This way, there would be no need for a > V2 interface. 1. I hadn't thought of it -

Re: [VOTE] KIP-161: streams deserialization exception handlers

+1. On Fri, Jun 23, 2017 at 6:42 AM, Bill Bejeck wrote: > Thanks for the KIP! > > +1 > > -Bill > > On Fri, Jun 23, 2017 at 7:15 AM, Damian Guy wrote: > > > Thanks for the KIP Eno. > > +1 (binding) > > > > On Fri, 23 Jun 2017 at 11:00 Eno Thereska

Re: Mirroring documentation improvement

Done! Thanks On Fri, 23 Jun 2017 at 15:14 Paolo Patierno wrote: > Hi Damina, > > my username is ppatierno ... thank you very much ! > > > Paolo Patierno > Senior Software Engineer (IoT) @ Red Hat > Microsoft MVP on Windows Embedded & IoT > Microsoft Azure Advisor > > Twitter

Build failed in Jenkins: kafka-0.10.2-jdk7 #176

See Changes: [damian.guy] HOTFIX: Don't check metadata unless you are creating topic -- [...truncated 158.67 KB...] kafka.server.KafkaConfigTest >

[GitHub] kafka pull request #3418: HOTFIX: Don't check metadata unless you are creati...

Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/3418 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Jenkins build is back to normal : kafka-trunk-jdk8 #1753

See

[jira] [Created] (KAFKA-5508) Documentation for altering topics

Tom Bentley created KAFKA-5508: -- Summary: Documentation for altering topics Key: KAFKA-5508 URL: https://issues.apache.org/jira/browse/KAFKA-5508 Project: Kafka Issue Type: Bug

Jenkins build is back to normal : kafka-trunk-jdk7 #2456

See

Re: Mirroring documentation improvement

Hi Damina, my username is ppatierno ... thank you very much ! Paolo Patierno Senior Software Engineer (IoT) @ Red Hat Microsoft MVP on Windows Embedded & IoT Microsoft Azure Advisor Twitter : @ppatierno Linkedin :

Re: Mirroring documentation improvement

Hi Damian, my username is tombentley Thanks Tom On 23 June 2017 at 14:57, Damian Guy wrote: > Evgeniy, you should now have access. > > Tom & Paolo what are your wiki usernames? > > Thanks, > Damian > > On Fri, 23 Jun 2017 at 14:52 Tom Bentley

Re: Mirroring documentation improvement

Evgeniy, you should now have access. Tom & Paolo what are your wiki usernames? Thanks, Damian On Fri, 23 Jun 2017 at 14:52 Tom Bentley wrote: > If any of the committers see this: Could I also have edit access please? > > On 23 June 2017 at 14:47, Evgeniy Veretennikov

Re: Mirroring documentation improvement

I'm interested as well ! Thank you ! Paolo Patierno Senior Software Engineer (IoT) @ Red Hat Microsoft MVP on Windows Embedded & IoT Microsoft Azure Advisor Twitter : @ppatierno Linkedin : paolopatierno Blog :

Re: Mirroring documentation improvement

If any of the committers see this: Could I also have edit access please? On 23 June 2017 at 14:47, Evgeniy Veretennikov wrote: > Hi Tom, > > Thanks for correction, I meant, that I want to edit this page in fact. > Initially I copy-pasted wrong link. > > My confluence

Re: Mirroring documentation improvement

Hi Tom, Thanks for correction, I meant, that I want to edit this page in fact. Initially I copy-pasted wrong link. My confluence username is evis. Best regards, Evgeny С уважением, Евгений Веретенников 2017-06-23 16:43 GMT+03:00 Tom Bentley : > Hi Evgeniy, > > The wiki

Re: Mirroring documentation improvement

Hi Evgeniy, The wiki page you link to there is about contributing improvements for kafka.apache.org. But since you say "mirroring doc in Confluence" I assume you want to edit https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=27846330, if so you will need one of the committers to

Re: [VOTE] KIP-161: streams deserialization exception handlers

Thanks for the KIP! +1 -Bill On Fri, Jun 23, 2017 at 7:15 AM, Damian Guy wrote: > Thanks for the KIP Eno. > +1 (binding) > > On Fri, 23 Jun 2017 at 11:00 Eno Thereska wrote: > > > Starting voting thread for: > > > >

Mirroring documentation improvement

Hi all, I want to improve a bit mirroring doc in Confluence: https://cwiki.apache.org/confluence/display/KAFKA/Contributing+Website+Documentation+Changes How can I change this page? Do I need some specific access rights? Best regards, Evgeny Veretennikov

[GitHub] kafka pull request #3423: KAFKA-5157: Options for handling corrupt data duri...

GitHub user enothereska opened a pull request: https://github.com/apache/kafka/pull/3423 KAFKA-5157: Options for handling corrupt data during deserialization [WiP] This is the implementation of KIP-161:

[GitHub] kafka pull request #3419: MINOR: Fixed way how logging methods are used for ...

Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/3419 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] kafka pull request #3422: MINOR: SaslChannelBuilder should be idempotent

GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/3422 MINOR: SaslChannelBuilder should be idempotent You can merge this pull request into a Git repository by running: $ git pull https://github.com/ijuma/kafka sasl-channel-builder-idempotent

[GitHub] kafka pull request #3421: KAFKA-5507: Check classpath empty in kafka-run-cla...

GitHub user evis opened a pull request: https://github.com/apache/kafka/pull/3421 KAFKA-5507: Check classpath empty in kafka-run-class.sh You can merge this pull request into a Git repository by running: $ git pull https://github.com/evis/kafka kafka-run-class-check-classpath

Build failed in Jenkins: kafka-trunk-jdk7 #2455

See Changes: [damian.guy] KAFKA-4653; Improve test coverage of RocksDBStore -- [...truncated 2.59 MB...] org.apache.kafka.connect.runtime.WorkerConnectorTest >

Build failed in Jenkins: kafka-trunk-jdk8 #1752

See Changes: [damian.guy] KAFKA-4656; Improve test coverage of CompositeReadOnlyKeyValueStore -- [...truncated 4.28 MB...] kafka.utils.CommandLineUtilsTest >

[jira] [Created] (KAFKA-5507) kafka-run-class.sh doesn't check for empty $CLASSPATH

Evgeny Veretennikov created KAFKA-5507: -- Summary: kafka-run-class.sh doesn't check for empty $CLASSPATH Key: KAFKA-5507 URL: https://issues.apache.org/jira/browse/KAFKA-5507 Project: Kafka

[jira] [Reopened] (KAFKA-5506) bin/kafka-consumer-groups.sh failing to query offsets

[ https://issues.apache.org/jira/browse/KAFKA-5506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma reopened KAFKA-5506: Assignee: Ismael Juma Nice catch, there are 2 bugs here. See the PR for the details. >

[GitHub] kafka pull request #3420: KAFKA-5506: Fix NPE in OffsetFetchRequest.toString

GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/3420 KAFKA-5506: Fix NPE in OffsetFetchRequest.toString Also avoid eager toString call in parameter passed to log.debug. You can merge this pull request into a Git repository by running: $ git pull

Re: [VOTE] KIP-168: Add TotalTopicCount metric per cluster

+1 (non-binding) Thanks On Thu, Jun 22, 2017 at 6:07 PM, Onur Karaman wrote: > +1 > > On Thu, Jun 22, 2017 at 10:05 AM, Dong Lin wrote: > >> Thanks for the KIP. +1 (non-binding) >> >> On Wed, Jun 21, 2017 at 1:17 PM, Abhishek Mendhekar < >>

Re: [VOTE] KIP-161: streams deserialization exception handlers

Thanks for the KIP Eno. +1 (binding) On Fri, 23 Jun 2017 at 11:00 Eno Thereska wrote: > Starting voting thread for: > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-161%3A+streams+deserialization+exception+handlers > < >

[GitHub] kafka pull request #3294: KAFKA-4653: Improve test coverage of RocksDBStore

Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/3294 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] kafka pull request #3292: KAFKA-4656: Improve test coverage of CompositeRead...

Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/3292 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: Minimum Replication Factor

That’s the first time I see this setting, wow it was burried! I think it makes sense to implement one to get full control. I wonder if it’s still not worth implementing a simple setting, or implementing a few “simple” topic creation policies that users can just reference. I don’t see that

[jira] [Resolved] (KAFKA-5506) bin/kafka-consumer-groups.sh failing to query offsets

[ https://issues.apache.org/jira/browse/KAFKA-5506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paolo Patierno resolved KAFKA-5506. --- Resolution: Not A Problem > bin/kafka-consumer-groups.sh failing to query offsets >

Re: [VOTE] KIP-160: Augment KStream.print() to allow users pass in extra parameters in the printed string

+1 thanks! Eno > On 23 Jun 2017, at 05:29, James Chain wrote: > > Hi all, > > I apply original idea on KStream#writeAsText() and also update my pull > request. > Please re-review and re-cast the vote. > > James Chien

[GitHub] kafka pull request #3419: MINOR: Fixed way how logging methods are used for ...

GitHub user ppatierno opened a pull request: https://github.com/apache/kafka/pull/3419 MINOR: Fixed way how logging methods are used for having a consistent one In the stream library there are few cases where we don't leverage on logging methods features (i.e. using {} placeholder

[VOTE] KIP-161: streams deserialization exception handlers

Starting voting thread for: https://cwiki.apache.org/confluence/display/KAFKA/KIP-161%3A+streams+deserialization+exception+handlers Thanks Eno

Re: [DISCUSS]: KIP-161: streams record processing exception handlers

Done, thanks. I'll open a vote thread now. Eno > On 23 Jun 2017, at 02:15, Matthias J. Sax wrote: > > I also think, that one config is better, with two default > implementations: failing and log-and-continue > > However, I think we should fail by default. Similar to

[jira] [Created] (KAFKA-5506) bin/kafka-consumer-groups.sh failing to query offsets

Yousef Amar created KAFKA-5506: -- Summary: bin/kafka-consumer-groups.sh failing to query offsets Key: KAFKA-5506 URL: https://issues.apache.org/jira/browse/KAFKA-5506 Project: Kafka Issue Type:

[GitHub] kafka pull request #3418: HOTFIX: Don't check metadata unless you are creati...

GitHub user enothereska opened a pull request: https://github.com/apache/kafka/pull/3418 HOTFIX: Don't check metadata unless you are creating topic During a broker rolling upgrade, it's likely we don't have enough brokers ready yet. If streams does not need to create a topic it

Re: Minimum Replication Factor

Hi Stephane, we enforce the constraint in a custom create topic policy (see ' create.topic.policy.class.name') -- Edoardo Comar IBM Message Hub eco...@uk.ibm.com IBM UK Ltd, Hursley Park, SO21 2JN From: Stephane Maarek

[jira] [Created] (KAFKA-5505) Connect: Do not restart connector and existing tasks on task-set change

Per Steffensen created KAFKA-5505: - Summary: Connect: Do not restart connector and existing tasks on task-set change Key: KAFKA-5505 URL: https://issues.apache.org/jira/browse/KAFKA-5505 Project:

[GitHub] kafka pull request #3410: KAFKA-4913: prevent creation of window stores with...

Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/3410 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Resolved] (KAFKA-4913) creating a window store with one segment throws division by zero error

[ https://issues.apache.org/jira/browse/KAFKA-4913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Damian Guy resolved KAFKA-4913. --- Resolution: Fixed Fix Version/s: (was: 0.11.0.1) 0.11.1.0 Issue

Re: Kafka streams KStream and ktable join issue

My guess is it is because the record doesn't have a key, i.e., the key is null. We have a fix for this in 0.11, in that we will skip records with a null key during restore. On Fri, 23 Jun 2017 at 03:57 Matthias J. Sax wrote: > Hi, > > can you reproduce the error reliably?