[GitHub] kafka pull request #3614: KAFKA-5695; Test DeleteRecordsRequest in Authorize...

2017-08-02 Thread lindong28
GitHub user lindong28 opened a pull request: https://github.com/apache/kafka/pull/3614 KAFKA-5695; Test DeleteRecordsRequest in AuthorizerIntegrationTest You can merge this pull request into a Git repository by running: $ git pull https://github.com/lindong28/kafka KAFKA-5695

[jira] [Created] (KAFKA-5695) Test DeleteRecordsRequest in AuthorizerIntegrationTest

2017-08-02 Thread Dong Lin (JIRA)
Dong Lin created KAFKA-5695: --- Summary: Test DeleteRecordsRequest in AuthorizerIntegrationTest Key: KAFKA-5695 URL: https://issues.apache.org/jira/browse/KAFKA-5695 Project: Kafka Issue Type:

Re: 答复: [DISCUSS] KIP-178: Size-based log directory selection strategy

2017-08-02 Thread Dong Lin
Hu, I think this is worth discussion even if it doesn't require new config. Could you also read my second email? On Wed, Aug 2, 2017 at 6:17 PM, Hu Xi wrote: > Thanks Dong, do you mean it is more like a naive improvement and no KIP > is needed then? > >

[GitHub] kafka pull request #3613: KAFKA-2360: Extract producer-specific configs out ...

2017-08-02 Thread huxihx
GitHub user huxihx opened a pull request: https://github.com/apache/kafka/pull/3613 KAFKA-2360: Extract producer-specific configs out of the common PerfConfig Separate `batch.size`, `message-size` and `compression-code` from PerfConfig to a newly-created ProducerPerfConfig in order

答复: [DISCUSS] KIP-178: Size-based log directory selection strategy

2017-08-02 Thread Hu Xi
Thanks Dong, do you mean it is more like a naive improvement and no KIP is needed then? 发件人: Dong Lin 发送时间: 2017年8月3日 9:10 收件人: dev@kafka.apache.org 主题: Re: [DISCUSS] KIP-178: Size-based log directory selection strategy Hey Xu, Thanks

Re: [DISCUSS] KIP-178: Size-based log directory selection strategy

2017-08-02 Thread Dong Lin
Hey Hu, Actually, the solution suggested in the KIP would not work. A broker may receive LeaderAndIsrRequest to create a large number of partitions when user rebalance the load across brokers. All these partitions will be created in the same log directory if the broker selects the log directory

Re: [DISCUSS] KIP-178: Size-based log directory selection strategy

2017-08-02 Thread Dong Lin
Hey Xu, Thanks for the KIP. This is a very good idea to select log directory based on the free disk space. Do you think we can simply simply change the implementation to select log directory based on the free disk space instead of adding a new config? Or is there any good reason that user will

转发: [DISCUSS] KIP-178: Size-based log directory selection strategy

2017-08-02 Thread Hu Xi
Hi all, how do you think of this KIP? Any comments are welcomed. 发件人: Hu Xi 发送时间: 2017年7月18日 15:21 收件人: dev@kafka.apache.org 主题: [DISCUSS] KIP-178: Size-based log directory selection strategy Hi all, KIP-178 is created for a

[GitHub] kafka pull request #3612: MINOR: Remove legacy ControlledShutdown request/re...

2017-08-02 Thread hachikuji
GitHub user hachikuji opened a pull request: https://github.com/apache/kafka/pull/3612 MINOR: Remove legacy ControlledShutdown request/response objects You can merge this pull request into a Git repository by running: $ git pull https://github.com/hachikuji/kafka

Jenkins build is back to normal : kafka-trunk-jdk8 #1871

2017-08-02 Thread Apache Jenkins Server
See

[jira] [Resolved] (KAFKA-5663) LogDirFailureTest system test fails

2017-08-02 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5663?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma resolved KAFKA-5663. Resolution: Fixed Fix Version/s: 1.0.0 > LogDirFailureTest system test fails >

[GitHub] kafka pull request #3594: KAFKA-5663; Fix LogDirFailureTest system test

2017-08-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/3594 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] kafka pull request #3603: KAFKA-5671 Followup: Remove reflections in unit te...

2017-08-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/3603 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[VOTE] KIP-163: Lower the Minimum Required ACL Permission of OffsetFetch

2017-08-02 Thread Vahid S Hashemian
Hi all, Thanks to everyone who participated in the discussion on KIP-163, and provided feedback. The KIP can be found at https://cwiki.apache.org/confluence/display/KAFKA/KIP-163%3A+Lower+the+Minimum+Required+ACL+Permission+of+OffsetFetch . I believe the concerns have been addressed in the

[GitHub] kafka pull request #3534: KAFKA-5006: Improve thrown exception

2017-08-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/3534 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Resolved] (KAFKA-5006) KeyValueStore.put may throw exception unrelated to the current put attempt

2017-08-02 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5006?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang resolved KAFKA-5006. -- Resolution: Fixed Fix Version/s: (was: 0.11.0.1) 1.0.0 Issue

[GitHub] kafka-site pull request #69: Hyperlink 3 callouts on the homepage

2017-08-02 Thread derrickdoo
GitHub user derrickdoo opened a pull request: https://github.com/apache/kafka-site/pull/69 Hyperlink 3 callouts on the homepage Hyperlinks on the 3 homepage callouts to specific sections of documentation. You can merge this pull request into a Git repository by running: $ git

[jira] [Created] (KAFKA-5694) Add ChangeReplicaDirRequest and DescribeReplicaDirRequest (KIP-113)

2017-08-02 Thread Dong Lin (JIRA)
Dong Lin created KAFKA-5694: --- Summary: Add ChangeReplicaDirRequest and DescribeReplicaDirRequest (KIP-113) Key: KAFKA-5694 URL: https://issues.apache.org/jira/browse/KAFKA-5694 Project: Kafka

Jenkins build is back to normal : kafka-trunk-jdk7 #2596

2017-08-02 Thread Apache Jenkins Server
See

Re: [DISCUSS] KAFKA-1944 Rename LogCleaner to LogCompactor

2017-08-02 Thread Jason Gustafson
Hey Pranav, Thanks for raising this. I already commented on the JIRA, but I'll reiterate my thoughts here. The "log cleaner" naming may not be ideal, but it is not incorrect and some of the terminology used elsewhere makes more sense given this name (e.g. cleanable ratio, dirty offset). I

[DISCUSS] KIP-183 - Change PreferredReplicaLeaderElectionCommand to use AdminClient

2017-08-02 Thread Tom Bentley
In a similar vein to KIP-179 I've created KIP-183 ( https://cwiki.apache.org/confluence/display/KAFKA/KIP-183+-+Change+PreferredReplicaLeaderElectionCommand+to+use+AdminClient) which is about deprecating the --zookeeper option to kafka-preferred-replica-election.sh and replacing it with an option

Re: KStreamPrintTest : no differences in the unit tests

2017-08-02 Thread Damian Guy
Yes - they are basically the same. Feel free to submit a patch to remove one of them On Wed, 2 Aug 2017 at 15:28 Paolo Patierno wrote: > Hi devs, > > taking a look at KStreamPrintTest I can't find any substantial difference > between the two tests : > > >

Build failed in Jenkins: kafka-trunk-jdk7 #2595

2017-08-02 Thread Apache Jenkins Server
See Changes: [damian.guy] KAFKA-5096; Log invalid user configs and use defaults -- [...truncated 985.78 KB...] kafka.utils.json.JsonValueTest > testJsonValueEquals

[jira] [Created] (KAFKA-5693) TopicCreationPolicy and AlterConfigsPolicy overlap

2017-08-02 Thread Tom Bentley (JIRA)
Tom Bentley created KAFKA-5693: -- Summary: TopicCreationPolicy and AlterConfigsPolicy overlap Key: KAFKA-5693 URL: https://issues.apache.org/jira/browse/KAFKA-5693 Project: Kafka Issue Type: Bug

Build failed in Jenkins: kafka-trunk-jdk8 #1870

2017-08-02 Thread Apache Jenkins Server
See Changes: [ismael] MINOR: Support versions with 3 segments in _kafka_jar_versions -- [...truncated 2.73 MB...]

Jenkins build is back to normal : kafka-trunk-jdk8 #1869

2017-08-02 Thread Apache Jenkins Server
See

[GitHub] kafka pull request #3611: MINOR: Added a couple of unit tests for KStreamPri...

2017-08-02 Thread ppatierno
GitHub user ppatierno opened a pull request: https://github.com/apache/kafka/pull/3611 MINOR: Added a couple of unit tests for KStreamPrint node when values are bytes With current tests, the deserialization inside the KStreamPrint node processor which happens when key and/or

[GitHub] kafka pull request #3587: MINOR: Support versions with 3 segments in _kafka_...

2017-08-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/3587 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

KStreamPrintTest : no differences in the unit tests

2017-08-02 Thread Paolo Patierno
Hi devs, taking a look at KStreamPrintTest I can't find any substantial difference between the two tests : testPrintStreamWithProvidedKeyValueMapper testPrintKeyValueWithName The only tiny difference is the mapper output "%d, %s" instead of "(%d, %s)" but then all the code seems to be the

[GitHub] kafka pull request #3610: KAFKA-5674: max.connections.per.ip minimum should ...

2017-08-02 Thread viktorsomogyi
GitHub user viktorsomogyi opened a pull request: https://github.com/apache/kafka/pull/3610 KAFKA-5674: max.connections.per.ip minimum should be 0 You can merge this pull request into a Git repository by running: $ git pull https://github.com/viktorsomogyi/kafka KAFKA-5674

[GitHub] kafka pull request #2990: KAFKA-5096: Log invalid user configs and use defau...

2017-08-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/2990 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Created] (KAFKA-5692) Refactor PreferredReplicaLeaderElectionCommand to use AdminClient

2017-08-02 Thread Tom Bentley (JIRA)
Tom Bentley created KAFKA-5692: -- Summary: Refactor PreferredReplicaLeaderElectionCommand to use AdminClient Key: KAFKA-5692 URL: https://issues.apache.org/jira/browse/KAFKA-5692 Project: Kafka

Re: [DISCUSS] KIP-179: Change ReassignPartitionsCommand to use AdminClient

2017-08-02 Thread Tom Bentley
Hi again Ismael, 1. It's worth emphasising that reassigning partitions is a different >> process than what happens when a topic is created, so not sure trying to >> make it symmetric is beneficial. In addition to what was already >> discussed, >> one should also enable replication throttling

[GitHub] kafka pull request #3609: MINOR: Only log about marking replicas as offline ...

2017-08-02 Thread ijuma
GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/3609 MINOR: Only log about marking replicas as offline if there is a replica I noticed a bunch of these log messages with an empty set for the replicas. You can merge this pull request into a Git

[jira] [Resolved] (KAFKA-5641) Metadata request should always be allowed to send no regardless of value for max.in.flight.requests.per.connection

2017-08-02 Thread huxihx (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] huxihx resolved KAFKA-5641. --- Resolution: Not A Problem > Metadata request should always be allowed to send no regardless of value for >

Re: Command tools : from Scala to Java, from Zookeeper utils to Admin Client API

2017-08-02 Thread Ismael Juma
Hi Arseniy, At some point (before I joined), it was decided that clients would be written in Java for a few reasons: 1. It's easier to maintain binary compatibility 2. Calling Java from Scala is easier than calling Scala from Java (without extra effort) 3. A single artifact instead of one

Re: Command tools : from Scala to Java, from Zookeeper utils to Admin Client API

2017-08-02 Thread Paolo Patierno
Hi Arseniy, I opened this JIRA about one month ago (https://issues.apache.org/jira/browse/KAFKA-5536) asking why we have some tools in Java and other in Scala. As Ismael pointed out the end state should be having tools written in Java (as already happened to clients from Scala to Java)

Re: Command tools : from Scala to Java, from Zookeeper utils to Admin Client API

2017-08-02 Thread Arseniy Tashoyan
Hi Paolo, I doubt that rewriting in Java makes value by itself. What is the reason of redoing the things that are already done? The switching to new API can be done without the switching to another language. Less new code - less new bugs. In some cases, Scala may be more convenient than Java. For

[DISCUSS] KAFKA-1944 Rename LogCleaner to LogCompactor

2017-08-02 Thread Pranav Maniar
Hi All, I am planning to take up [KAFKA-1944 ] : Rename LogCleaner to LogCompactor. Renaming will cover LogCleander, LogCleanerManager, related Testcases and all method/variable/documentations inside it. It also requires configuration name change