答复: [ANNOUNCE] New Kafka PMC member: Jiangjie (Becket) Qin

2017-08-23 Thread Hu Xi
Congrats Becket! 发件人: Guozhang Wang 发送时间: 2017年8月24日 13:32 收件人: dev@kafka.apache.org 主题: Re: [ANNOUNCE] New Kafka PMC member: Jiangjie (Becket) Qin Congrats Jiangjie! Guozhang On Wed, Aug 23, 2017 at 10:20 PM, Joel Koshy

Re: [ANNOUNCE] New Kafka PMC member: Jiangjie (Becket) Qin

2017-08-23 Thread Guozhang Wang
Congrats Jiangjie! Guozhang On Wed, Aug 23, 2017 at 10:20 PM, Joel Koshy wrote: > Hi everyone, > > Jiangjie (Becket) Qin has been a Kafka committer in October 2016 and has > contributed significantly to several major patches, reviews and discussions > since. I am glad to

[ANNOUNCE] New Kafka PMC member: Jiangjie (Becket) Qin

2017-08-23 Thread Joel Koshy
Hi everyone, Jiangjie (Becket) Qin has been a Kafka committer in October 2016 and has contributed significantly to several major patches, reviews and discussions since. I am glad to announce that Becket is now a member of the Apache Kafka PMC. Congratulations Becket! Joel

Re: [DISCUSS] KIP-91 Provide Intuitive User Timeouts in The Producer

2017-08-23 Thread Becket Qin
Hi Jun, If TCP timeout is longer than request.timeout.ms, the producer will always hit request.timeout.ms before hitting TCP timeout, right? That is why we added request.timeout.ms in the first place. You are right. Currently we are reset the PID and resend the batches to avoid

[GitHub] kafka pull request #3664: KAFKA-5733: ensure clean RocksDB directory before ...

2017-08-23 Thread bbejeck
Github user bbejeck closed the pull request at: https://github.com/apache/kafka/pull/3664 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: [DISCUSS] KIP-182: Reduce Streams DSL overloads and allow easier use of custom storage engines

2017-08-23 Thread Guozhang Wang
I have a couple of comments but otherwise it LGTM: 1. For these two functions in StreamsBuilder, the topic String is set as the second parameter in between of two options. Would that be better to be set as the first or the last one instead? public synchronized KTable table(final

[GitHub] kafka pull request #3726: KAFKA-5777. Add ducktape integration for Trogdor

2017-08-23 Thread cmccabe
GitHub user cmccabe opened a pull request: https://github.com/apache/kafka/pull/3726 KAFKA-5777. Add ducktape integration for Trogdor You can merge this pull request into a Git repository by running: $ git pull https://github.com/cmccabe/kafka KAFKA-5777 Alternatively you

Re: [DISCUSS] KIP-189: Improve principal builder interface and add support for SASL

2017-08-23 Thread Jun Rao
Hi, Mayuresh, Since this KIP covers the requirement in KIP-111, could you review it too? Thanks, Jun On Tue, Aug 22, 2017 at 3:04 PM, Jason Gustafson wrote: > Bump. I'll open a vote in a few days if there are no comments. > > Thanks, > Jason > > On Sat, Aug 19, 2017 at

[jira] [Created] (KAFKA-5777) Add ducktape integration for the Trogdor Fault injection daemon

2017-08-23 Thread Colin P. McCabe (JIRA)
Colin P. McCabe created KAFKA-5777: -- Summary: Add ducktape integration for the Trogdor Fault injection daemon Key: KAFKA-5777 URL: https://issues.apache.org/jira/browse/KAFKA-5777 Project: Kafka

[jira] [Created] (KAFKA-5776) Add the Trogdor fault injection daemon

2017-08-23 Thread Colin P. McCabe (JIRA)
Colin P. McCabe created KAFKA-5776: -- Summary: Add the Trogdor fault injection daemon Key: KAFKA-5776 URL: https://issues.apache.org/jira/browse/KAFKA-5776 Project: Kafka Issue Type:

Re: [DISCUSS] KIP-91 Provide Intuitive User Timeouts in The Producer

2017-08-23 Thread Jun Rao
Hi, Becket, If a message expires while it's in an inflight produce request, the producer will get a new PID if idempotent is enabled. This will prevent subsequent messages from hitting OutOfOrderSequenceException. The issue of not expiring an inflight request is that if a broker server goes down

Re: [DISCUSS] KIP-183 - Change PreferredReplicaLeaderElectionCommand to use AdminClient

2017-08-23 Thread Jun Rao
H, Collin, That's a good point. I agree that Alter on Cluster resource is more appropriate. Thanks, Jun On Tue, Aug 22, 2017 at 1:42 PM, Colin McCabe wrote: > Hi, > > Thanks for the KIP. It looks good overall. > > On Tue, Aug 22, 2017, at 08:54, Tom Bentley wrote: > >

[jira] [Created] (KAFKA-5775) Implement Fault Injection testing for Kafka

2017-08-23 Thread Colin P. McCabe (JIRA)
Colin P. McCabe created KAFKA-5775: -- Summary: Implement Fault Injection testing for Kafka Key: KAFKA-5775 URL: https://issues.apache.org/jira/browse/KAFKA-5775 Project: Kafka Issue Type:

Jenkins build is back to normal : kafka-trunk-jdk7 #2669

2017-08-23 Thread Apache Jenkins Server
See

[jira] [Created] (KAFKA-5774) WorkerSinkTask failure exception should include cause

2017-08-23 Thread Randall Hauch (JIRA)
Randall Hauch created KAFKA-5774: Summary: WorkerSinkTask failure exception should include cause Key: KAFKA-5774 URL: https://issues.apache.org/jira/browse/KAFKA-5774 Project: Kafka Issue

Re: [DISCUSS] KIP-91 Provide Intuitive User Timeouts in The Producer

2017-08-23 Thread Sumant Tambe
OK. Looks like starting the clock after closing the batch has quite a few pitfalls. I can't think of a way of to work around it without adding yet another config. So I won't discuss that here. Anyone? As I said earlier, I'm not hung up on super-accurate notification times. If we are going down

Build failed in Jenkins: kafka-trunk-jdk8 #1937

2017-08-23 Thread Apache Jenkins Server
See Changes: [jason] KAFKA-5644; Fix Reset Consumer Group Offset tool to handle minute -- [...truncated 922.52 KB...] kafka.security.auth.SimpleAclAuthorizerTest >

Build failed in Jenkins: kafka-trunk-jdk7 #2668

2017-08-23 Thread Apache Jenkins Server
See Changes: [jason] KAFKA-5644; Fix Reset Consumer Group Offset tool to handle minute -- [...truncated 916.94 KB...] kafka.server.epoch.LeaderEpochFileCacheTest >

[GitHub] kafka pull request #3626: KAFKA-5644: Fix Reset Consumer Group Offset tool t...

2017-08-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/3626 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Resolved] (KAFKA-5644) Transient test failure: ResetConsumerGroupOffsetTest.testResetOffsetsToZonedDateTime

2017-08-23 Thread Jason Gustafson (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5644?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-5644. Resolution: Fixed Fix Version/s: 0.11.0.1 1.0.0 Issue resolved by

Jenkins build is back to normal : kafka-trunk-jdk7 #2667

2017-08-23 Thread Apache Jenkins Server
See

Build failed in Jenkins: kafka-trunk-jdk8 #1936

2017-08-23 Thread Apache Jenkins Server
See Changes: [damian.guy] HOTFIX: reduce streams benchmark input records to 10 million -- [...truncated 921.37 KB...] kafka.integration.AutoOffsetResetTest >

Re: [DISCUSS] KIP-182: Reduce Streams DSL overloads and allow easier use of custom storage engines

2017-08-23 Thread Damian Guy
We already have GlobalKTable and i can't rename KGroupedStream, which really should be GroupedKStream. So I think we should name new things correctly, i.e., WindowedKStream etc and fix the others when we can. On Wed, 23 Aug 2017 at 20:38 Matthias J. Sax wrote: > About

Re: [DISCUSS] KIP-182: Reduce Streams DSL overloads and allow easier use of custom storage engines

2017-08-23 Thread Damian Guy
Thanks Bill On Wed, 23 Aug 2017 at 20:24 Bill Bejeck wrote: > Thanks for all the work on this KIP Damian. > > Both `Produced` and `Joined` have a `with` method accepting all parameters, > but `Consumed` doesn't. Should we add one for consistency? > > Yep, i'll update it >

[GitHub] kafka pull request #3725: HOTFIX: reduce streams benchmark input records to ...

2017-08-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/3725 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: [DISCUSS] KIP-182: Reduce Streams DSL overloads and allow easier use of custom storage engines

2017-08-23 Thread Matthias J. Sax
About KGroupedStream vs GroupedKStream: shouldn't we keep the naming convention consistent? And if we change the naming schema just change all at once? I personally don't care which naming scheme is better, but I think consistency is super important! About Bill's comment: I agree, and had a

Re: [DISCUSS] KIP-182: Reduce Streams DSL overloads and allow easier use of custom storage engines

2017-08-23 Thread Bill Bejeck
Thanks for all the work on this KIP Damian. Both `Produced` and `Joined` have a `with` method accepting all parameters, but `Consumed` doesn't. Should we add one for consistency? Thanks, Bill On Wed, Aug 23, 2017 at 4:15 AM, Damian Guy wrote: > KIP has been updated.

[jira] [Created] (KAFKA-5773) ConnectRecord.equals() doesn't properly handle array keys/values

2017-08-23 Thread Ryan Kennedy (JIRA)
Ryan Kennedy created KAFKA-5773: --- Summary: ConnectRecord.equals() doesn't properly handle array keys/values Key: KAFKA-5773 URL: https://issues.apache.org/jira/browse/KAFKA-5773 Project: Kafka

Build failed in Jenkins: kafka-trunk-jdk8 #1935

2017-08-23 Thread Apache Jenkins Server
See Changes: [me] MINOR: Verify startup of zookeeper service in system tests -- [...truncated 2.46 MB...] org.apache.kafka.streams.kstream.internals.KTableImplTest >

Build failed in Jenkins: kafka-trunk-jdk7 #2666

2017-08-23 Thread Apache Jenkins Server
See Changes: [me] MINOR: Verify startup of zookeeper service in system tests -- [...truncated 914.98 KB...] kafka.server.epoch.LeaderEpochFileCacheTest >

[GitHub] kafka pull request #3707: MINOR: Verify startup of zookeeper service in syst...

2017-08-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/3707 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] kafka pull request #3725: HOTFIX: reduce streams benchmark input records to ...

2017-08-23 Thread dguy
GitHub user dguy opened a pull request: https://github.com/apache/kafka/pull/3725 HOTFIX: reduce streams benchmark input records to 10 million We are occasionally hitting some timeouts due to processing not finishing. So rather than failing the build for these reasons it would be

Re: [DISCUSS] KIP-91 Provide Intuitive User Timeouts in The Producer

2017-08-23 Thread Ismael Juma
Thanks Becket, that seems reasonable. Sumant, would you be willing to update the KIP based on the discussion or are you still not convinced? Ismael On Wed, Aug 23, 2017 at 6:04 AM, Becket Qin wrote: > In general max.message.delivery.wait.ms is a cleaner approach. That

Jenkins build is back to normal : kafka-trunk-jdk8 #1934

2017-08-23 Thread Apache Jenkins Server
See

Build failed in Jenkins: kafka-trunk-jdk7 #2665

2017-08-23 Thread Apache Jenkins Server
See Changes: [ismael] KAFKA-5417; Fix Selector's handling of some failures during prepare -- [...truncated 2.43 MB...]

[jira] [Created] (KAFKA-5771) org.apache.kafka.streams.state.internals.Segments#segments method returns incorrect results when segments were added out of order

2017-08-23 Thread Alexander Radzishevsky (JIRA)
Alexander Radzishevsky created KAFKA-5771: - Summary: org.apache.kafka.streams.state.internals.Segments#segments method returns incorrect results when segments were added out of order Key: KAFKA-5771 URL:

[GitHub] kafka pull request #3282: [KAFKA-5417] Clients get inconsistent connection s...

2017-08-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/3282 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] kafka pull request #3724: KAFKA-5769: Transient test failure org.apache.kafk...

2017-08-23 Thread dguy
GitHub user dguy opened a pull request: https://github.com/apache/kafka/pull/3724 KAFKA-5769: Transient test failure org.apache.kafka.streams.integration.KStreamRepartitionJoinTest.shouldCorrectlyRepartitionOnJoinOperationsWithZeroSizedCache Don't start the consumer until streams

[jira] [Created] (KAFKA-5770) AdminClient.deleteTopics future complete but topic is still here

2017-08-23 Thread Vincent Maurin (JIRA)
Vincent Maurin created KAFKA-5770: - Summary: AdminClient.deleteTopics future complete but topic is still here Key: KAFKA-5770 URL: https://issues.apache.org/jira/browse/KAFKA-5770 Project: Kafka

Re: [DISCUSS] KIP-183 - Change PreferredReplicaLeaderElectionCommand to use AdminClient

2017-08-23 Thread Tom Bentley
Hi Colin, Thanks for your input. A couple of comments inline. On 22 August 2017 at 21:42, Colin McCabe wrote: > Hi, > > Thanks for the KIP. It looks good overall. > > On Tue, Aug 22, 2017, at 08:54, Tom Bentley wrote: > > Hi Jun, > > > > Thanks for the feedback. > > > >

Re: each file of the kafka data will be opened 70+ times

2017-08-23 Thread Tom Bentley
I think your lsof output is listing threads, not simply processes (if you look at the output instead of piping it to wc you'll see that the PID is the same and only the TID is different). If you use `lsof /opt/kafka/data/...` (i.e without the grep) instead it will just show the processes. On 22

[jira] [Created] (KAFKA-5769) Transient test failure org.apache.kafka.streams.integration.KStreamRepartitionJoinTest.shouldCorrectlyRepartitionOnJoinOperationsWithZeroSizedCache

2017-08-23 Thread Damian Guy (JIRA)
Damian Guy created KAFKA-5769: - Summary: Transient test failure org.apache.kafka.streams.integration.KStreamRepartitionJoinTest.shouldCorrectlyRepartitionOnJoinOperationsWithZeroSizedCache Key: KAFKA-5769 URL:

Re: [DISCUSS] KIP-182: Reduce Streams DSL overloads and allow easier use of custom storage engines

2017-08-23 Thread Damian Guy
KIP has been updated. thanks On Wed, 23 Aug 2017 at 09:10 Damian Guy wrote: > Hi Matthias, > > >> KStream: >> leftJoin and outerJoin for KStream/KTable join should not have >> `JoinWindows` parameter >> >> Thanks! > > >> >> Nit: TopologyBuilder -> Topology >> >> Ack > > >>

Re: [DISCUSS] KIP-182: Reduce Streams DSL overloads and allow easier use of custom storage engines

2017-08-23 Thread Damian Guy
Hi Matthias, > KStream: > leftJoin and outerJoin for KStream/KTable join should not have > `JoinWindows` parameter > > Thanks! > > Nit: TopologyBuilder -> Topology > > Ack > Nit: new class Serialized list static method #with twice > > Ack > WindowedKStream -> for consistency we should