Jenkins build is back to normal : kafka-trunk-jdk8 #2514

2018-03-29 Thread Apache Jenkins Server
See

Re: [VOTE] KIP-272: Add API version tag to broker's RequestsPerSec metric

2018-03-29 Thread Jun Rao
Hi, Allen, Thanks for the KIP. It seems the main motivation of the KIP is to estimate the ratio of the clients doing down conversion. I am wondering if we can do that by relying on the metrics we added in 1.0.0 (

Jenkins build is back to normal : kafka-trunk-jdk9 #518

2018-03-29 Thread Apache Jenkins Server
See

Re: [DISCUSS] KIP-274: Kafka Streams Skipped Records Metrics

2018-03-29 Thread Guozhang Wang
> One thing you mention is the notion of setting alerts on coarser metrics being easier than finer ones. All the metric alerting systems I have used make it equally easy to alert on metrics by-tag or over tags. So my experience doesn't say that this is a use case. Were you thinking of an alerting

Re: [DISCUSS] KIP-274: Kafka Streams Skipped Records Metrics

2018-03-29 Thread John Roesler
Hey Guozhang, Thanks for the review. 1. Matthias raised the same question about the "reason" tag values. I can list all possible values of the "reason" tag, but I'm thinking this level of detail may not be KIP-worthy, maybe the code and documentation review would be sufficient. If you all

Re: [DISCUSS] KIP-255: OAuth Authentication via SASL/OAUTHBEARER

2018-03-29 Thread Rajini Sivaram
Hi Ron, Thanks for the updates. I had a quick look and it is looking good. I have updated KIP-86 and the associated PR to with a new config sasl.login.callback.handler.class that matches what you are using in this KIP. On Thu, Mar 29, 2018 at 6:27 AM, Ron Dagostino wrote: >

Re: [DISCUSS] KIP-86: Configurable SASL callback handlers

2018-03-29 Thread Rajini Sivaram
To support extensibility for SASL/OAuth as described in KIP-255 , I have added an extra config sasl.login.callback.handler.class. This implements the same interface as the other callback handlers. Default behaviour will be

Re: [DISCUSS] KIP-274: Kafka Streams Skipped Records Metrics

2018-03-29 Thread John Roesler
Hi Matthias, Thanks for the review. Regarding the "reason" tags, I listed "deserialization-error" and "negative-timestamp" to capture the two skips we already account for. More generally, I would like to establish a pattern in which we could add new values for the "reason" tags without needing a

Re: [DISCUSS] KIP-274: Kafka Streams Skipped Records Metrics

2018-03-29 Thread Guozhang Wang
Hello John, Thanks for the KIP. Some comments: 1. Could you list all the possible values of the "reason" tag? In the JIRA ticket I left some potential reasons but I'm not clear if you're going to categorize each of them as a separate reason, or is there any additional ones you have in mind.

Re: [DISCUSS] KIP-277 - Fine Grained ACL for CreateTopics API

2018-03-29 Thread Matt Farmer
Thanks for this KIP. I can think of some ways we would apply this. I, too, am ~ on the compatibility story though, however I'm not sure which way I'd prefer we go at this moment. On Thu, Mar 29, 2018 at 4:36 PM, Ismael Juma wrote: > Thanks for the KIP. I think this is going

Re: [DISCUSS] KIP-277 - Fine Grained ACL for CreateTopics API

2018-03-29 Thread Edoardo Comar
Thanks Ismael, in the 'rejected' section we describe an approach that would allow for compatibility but we'd keep the authz checks simple rather than establish a precedent of a logical OR between different checks (cluster or topic(t)) . What would be your ideal story for compatibility ? I

Re: [DISCUSS] KIP-277 - Fine Grained ACL for CreateTopics API

2018-03-29 Thread Edoardo Comar
Thanks for your comments Stephane. I too would like to get 'wildcard' support. I'd like to associate an acl to a regex instead of a specific resource name (or everything), and then the authz check is then performed against the actual resource name. This could be attainable with a more

[jira] [Resolved] (KAFKA-6612) Added logic to prevent increasing partition counts during topic deletion

2018-03-29 Thread Lucas Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-6612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucas Wang resolved KAFKA-6612. --- Resolution: Fixed > Added logic to prevent increasing partition counts during topic deletion >

Re: [DISCUSS] KIP-253: Support in-order message delivery with partition expansion

2018-03-29 Thread John Roesler
Hey Dong, Congrats on becoming a committer!!! Since I just sent a novel-length email, I'll try and keep this one brief ;) Regarding producer coordination, I'll grant that in that case, producers may coordinate among themselves to produce into the same topic or to produce co-partitioned topics.

[jira] [Resolved] (KAFKA-6395) KIP: Add Record Header support to Kafka Streams

2018-03-29 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-6395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang resolved KAFKA-6395. -- Resolution: Duplicate > KIP: Add Record Header support to Kafka Streams >

Re: [DISCUSS] KIP-253: Support in-order message delivery with partition expansion

2018-03-29 Thread John Roesler
Hi Jun, Thanks for the response. I'm very new to this project, but I will share my perspective. I'm going to say a bunch of stuff that I know you know already, but just so we're on the same page... This may also be a good time to get feedback from the other KStreams folks. Using KStreams as a

Re: [DISCUSS] KIP-274: Kafka Streams Skipped Records Metrics

2018-03-29 Thread Matthias J. Sax
Thanks for the KIP John. Reading the material on the related Jiras, I am wondering what `reason` tags you want to introduce? Can you elaborate? The KIP should list those IMHO. About the fine grained metrics vs the roll-up: you say that > the coarse metric aggregates across two dimensions

Re: [DISCUSS] KIP-277 - Fine Grained ACL for CreateTopics API

2018-03-29 Thread Ismael Juma
Thanks for the KIP. I think this is going in the right direction, but we need a better compatibility story. Also, it's worth considering whether we want to tackle better wildcard support at the same time. Ismael On Thu, Mar 29, 2018 at 6:51 AM, Edoardo Comar wrote: > Hi all,

Re: [DISCUSS] KIP-277 - Fine Grained ACL for CreateTopics API

2018-03-29 Thread Stephane Maarek
Not against, but this needs to support regex for support for Kafka streams application that create many topics with complex names On Thu., 29 Mar. 2018, 7:21 pm Edoardo Comar, wrote: > Hi all, > > We have submitted KIP-277 to give users permission to manage the lifecycle > of

Re: [ANNOUNCE] Apache Kafka 1.1.0 Released

2018-03-29 Thread Dong Lin
Great news! Thanks Damian and Rajini for running this release! On Thu, Mar 29, 2018 at 8:47 AM, James Cheng wrote: > Thanks Damian and Rajini for running the release! Congrats and good job > everyone! > > -James > > Sent from my iPhone > > > On Mar 29, 2018, at 2:27 AM,

Re: Expiring record(s) for topic: 30011 ms has passed since last append

2018-03-29 Thread cosmin . ciobanu12
We're consistently seeing this on Kafka Streams 1.0.0, even when not under load, exclusively for state change log topics. Tried changing `request.timeout.ms` to 60s but it doesn't help. The exception is thrown continuously for what looks to be every attempt to update any of the state change

Persistent TimeoutException when updating Kafka Streams state change logs

2018-03-29 Thread cosmin . ciobanu12
We're consistently seeing TimeoutExceptions on Kafka Streams 1.0.0, even when not under load, exclusively for state change log topic updates. Tried changing `request.timeout.ms` to 60s but it doesn't help. The exception is thrown continuously for what looks to be every attempt to update any of

Re: [VOTE] KIP-249: Add Delegation Token Operations to Kafka Admin Client

2018-03-29 Thread Gwen Shapira
+1 Thank you and sorry for missing it the first time around. On Thu, Mar 29, 2018 at 3:05 AM, Manikumar wrote: > I'm bumping this up to get some attention. > > > On Wed, Jan 24, 2018 at 3:36 PM, Satish Duggana > wrote: > > > +1, thanks for

Re: [DISCUSS] KIP-273 Kafka to support using ETCD beside Zookeeper

2018-03-29 Thread Gwen Shapira
Few other concerns that were raised in the previous discussion were around the challenges both to maintainers and users in making this API pluggable and how does making the interface pluggable aligns with future goals for the project. At the time this was difficult to discuss because there wasn't

Re: [ANNOUNCE] Apache Kafka 1.1.0 Released

2018-03-29 Thread James Cheng
Thanks Damian and Rajini for running the release! Congrats and good job everyone! -James Sent from my iPhone > On Mar 29, 2018, at 2:27 AM, Rajini Sivaram wrote: > > The Apache Kafka community is pleased to announce the release for > > Apache Kafka 1.1.0. > > > Kafka

Re: [ANNOUNCE] Apache Kafka 1.1.0 Released

2018-03-29 Thread Ismael Juma
Thanks to Damian and Rajini for running the release and thanks to everyone who helped make it happen! Ismael On Thu, Mar 29, 2018 at 2:27 AM, Rajini Sivaram wrote: > The Apache Kafka community is pleased to announce the release for > > Apache Kafka 1.1.0. > > > Kafka 1.1.0

Re: [DISCUSS] KIP-273 Kafka to support using ETCD beside Zookeeper

2018-03-29 Thread Molnár Bálint
Thanks, for the feedback. Developing an internal consensus service inside Kafka would require a team dedicated to this task. We second what Flavio said in https://lists.apache.org/thread.html/24ae56e073104c4531cf64f7a1f1c0a84f895d139d334c88e9fe6028@1449008733@%3Cdev.kafka.apache.org%3E that

[DISCUSS] KIP-277 - Fine Grained ACL for CreateTopics API

2018-03-29 Thread Edoardo Comar
Hi all, We have submitted KIP-277 to give users permission to manage the lifecycle of a defined set of topics; the current ACL checks are for permission to create *any* topic and on delete for permission against the *named* topics.

Re: 答复: [ANNOUNCE] New Committer: Dong Lin

2018-03-29 Thread Viktor Somogyi
Congrats Dong! :) On Thu, Mar 29, 2018 at 2:12 PM, Satish Duggana wrote: > Congratulations Dong! > > > On Thu, Mar 29, 2018 at 5:12 PM, Sandor Murakozi > wrote: > > > Congrats, Dong! > > > > > > On Thu, Mar 29, 2018 at 2:15 AM, Dong Lin

Re: [VOTE] KIP-249: Add Delegation Token Operations to Kafka Admin Client

2018-03-29 Thread Viktor Somogyi
+1 (non-binding) Thanks for the KIP, Manikumar On Thu, Mar 29, 2018 at 12:05 PM, Manikumar wrote: > I'm bumping this up to get some attention. > > > On Wed, Jan 24, 2018 at 3:36 PM, Satish Duggana > wrote: > > > +1, thanks for the KIP. > >

[jira] [Created] (KAFKA-6727) org.apache.kafka.clients.admin.Config has broken equals and hashCode method.

2018-03-29 Thread Andy Coates (JIRA)
Andy Coates created KAFKA-6727: -- Summary: org.apache.kafka.clients.admin.Config has broken equals and hashCode method. Key: KAFKA-6727 URL: https://issues.apache.org/jira/browse/KAFKA-6727 Project:

Re: [VOTE] KIP-272: Add API version tag to broker's RequestsPerSec metric

2018-03-29 Thread Manikumar
+1 (non-binding) On Thu, Mar 29, 2018 at 6:16 PM, Thomas Crayford wrote: > +1 (non-binding) > > On Wed, Mar 28, 2018 at 9:15 PM, Ted Yu wrote: > > > +1 > > > > On Wed, Mar 28, 2018 at 12:05 PM, Mickael Maison < > mickael.mai...@gmail.com > > > > >

Re: [VOTE] KIP-272: Add API version tag to broker's RequestsPerSec metric

2018-03-29 Thread Thomas Crayford
+1 (non-binding) On Wed, Mar 28, 2018 at 9:15 PM, Ted Yu wrote: > +1 > > On Wed, Mar 28, 2018 at 12:05 PM, Mickael Maison > > wrote: > > > +1 (non binding) > > Thanks for the KIP > > > > On Wed, Mar 28, 2018 at 6:25 PM, Gwen Shapira

[jira] [Created] (KAFKA-6726) KIP-277 - Fine Grained ACL for CreateTopics A

2018-03-29 Thread Edoardo Comar (JIRA)
Edoardo Comar created KAFKA-6726: Summary: KIP-277 - Fine Grained ACL for CreateTopics A Key: KAFKA-6726 URL: https://issues.apache.org/jira/browse/KAFKA-6726 Project: Kafka Issue Type:

Re: [DISCUSS] KIP-253: Support in-order message delivery with partition expansion

2018-03-29 Thread Jan Filipiak
Hi Dong. I do disagree here. I think we are fooling ourselfs! This KIP lays the foundation for the wrong path and I am heavily against it. We should have state full producers in mind at this very moment. One can clearly see that you are on a wrong path when you talk about taking away custom

Re: [VOTE] #2 KIP-248: Create New ConfigCommand That Uses The New AdminClient

2018-03-29 Thread zhenya Sun
+1 (non-binding) | | zhenya Sun 邮箱:toke...@126.com | 签名由 网易邮箱大师 定制 On 03/29/2018 19:40, Sandor Murakozi wrote: +1 (non-binding) Thanks for the KIP, Viktor On Wed, Mar 21, 2018 at 5:41 PM, Viktor Somogyi wrote: > Hi Everyone, > > I've started a vote on KIP-248 >

Re: [VOTE] #2 KIP-248: Create New ConfigCommand That Uses The New AdminClient

2018-03-29 Thread Sandor Murakozi
+1 (non-binding) Thanks for the KIP, Viktor On Wed, Mar 21, 2018 at 5:41 PM, Viktor Somogyi wrote: > Hi Everyone, > > I've started a vote on KIP-248 >

Re: [ANNOUNCE] Apache Kafka 1.1.0 Released

2018-03-29 Thread Edoardo Comar
Great to hear! thanks for driving the release process. -- Edoardo Comar IBM Message Hub IBM UK Ltd, Hursley Park, SO21 2JN From: Mickael Maison To: Users Cc: kafka-clients

Re: [VOTE] KIP-249: Add Delegation Token Operations to Kafka Admin Client

2018-03-29 Thread Manikumar
I'm bumping this up to get some attention. On Wed, Jan 24, 2018 at 3:36 PM, Satish Duggana wrote: > +1, thanks for the KIP. > > ~Satish. > > On Wed, Jan 24, 2018 at 5:09 AM, Jun Rao wrote: > > > Hi, Mani, > > > > Thanks for the KIP. +1 > > > > Jun

Re: [VOTE] KIP-257 - Configurable Quota Management

2018-03-29 Thread Rajini Sivaram
The vote has passed with three binding votes (Jun, Gwen, Rajini) and 5 non-binding votes (Ted, Edo, Mickael, Viktor, Kaushik). Many thanks to all of you for the feedback and votes. I will update the KIP page and get the PR ready for review. Many thanks, Rajini On Wed, Mar 28, 2018 at 6:42 PM,

Re: [ANNOUNCE] Apache Kafka 1.1.0 Released

2018-03-29 Thread Manikumar
Thanks for running the release. On Thu, Mar 29, 2018 at 3:21 PM, zhenya Sun wrote: > good !! > > > 在 2018年3月29日,下午5:45,Mickael Maison 写道: > > > > Great news, thanks Damian and Rajini for running this release! > > > > On Thu, Mar 29, 2018 at 10:33 AM,

Re: [ANNOUNCE] Apache Kafka 1.1.0 Released

2018-03-29 Thread zhenya Sun
good !! > 在 2018年3月29日,下午5:45,Mickael Maison 写道: > > Great news, thanks Damian and Rajini for running this release! > > On Thu, Mar 29, 2018 at 10:33 AM, Rajini Sivaram > wrote: >> Resending to kaka-clients group: >> >> -- Forwarded

Re: [ANNOUNCE] Apache Kafka 1.1.0 Released

2018-03-29 Thread Mickael Maison
Great news, thanks Damian and Rajini for running this release! On Thu, Mar 29, 2018 at 10:33 AM, Rajini Sivaram wrote: > Resending to kaka-clients group: > > -- Forwarded message -- > From: Rajini Sivaram > Date: Thu, Mar 29, 2018 at

Fwd: [ANNOUNCE] Apache Kafka 1.1.0 Released

2018-03-29 Thread Rajini Sivaram
Resending to kaka-clients group: -- Forwarded message -- From: Rajini Sivaram Date: Thu, Mar 29, 2018 at 10:27 AM Subject: [ANNOUNCE] Apache Kafka 1.1.0 Released To: annou...@apache.org, Users , dev < dev@kafka.apache.org>,

[ANNOUNCE] Apache Kafka 1.1.0 Released

2018-03-29 Thread Rajini Sivaram
The Apache Kafka community is pleased to announce the release for Apache Kafka 1.1.0. Kafka 1.1.0 includes a number of significant new features. Here is a summary of some notable changes: ** Kafka 1.1.0 includes significant improvements to the Kafka Controller that speed up controlled

Re: [DISCUSS] KIP-273 Kafka to support using ETCD beside Zookeeper

2018-03-29 Thread Jakub Scholz
I can understand the concerns about the plugability of Zookeeper/Etcd. It would not be good for Kafka community if it splits into several groups using different implementations. On the other hand, Zookeeper development seems to be a bit stalled. So maybe there should be at least a discussion

Re: [ANNOUNCE] New Committer: Dong Lin

2018-03-29 Thread Attila Sasvári
Congratulations Dong. Keep up the good work! Becket Qin ezt írta (időpont: 2018. márc. 28., Sze 19:58): > Hello everyone, > > The PMC of Apache Kafka is pleased to announce that Dong Lin has accepted > our invitation to be a new Kafka committer. > > Dong started working

Re: 答复: [ANNOUNCE] New Committer: Dong Lin

2018-03-29 Thread Edoardo Comar
congratulations Dong! -- Edoardo Comar IBM Message Hub IBM UK Ltd, Hursley Park, SO21 2JN From: Hu Xi To: "us...@kafka.apache.org" , "dev@kafka.apache.org" Date:

Build failed in Jenkins: kafka-trunk-jdk8 #2513

2018-03-29 Thread Apache Jenkins Server
See Changes: [wangguoz] HOTFIX: ignoring tests using old versions of Streams until KIP-268 is -- [...truncated 3.53 MB...] kafka.zookeeper.ZooKeeperClientTest >