Re: [DISCUSS] KIP-482: The Kafka Protocol should Support Optional Fields

2019-08-18 Thread Satish Duggana
Please read struct type as a complex record type in my earlier mail. The complex type seems to be defined as Schema[1] in the protocol types. 1. https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/common/protocol/types/Schema.java#L27 On Mon, Aug 19, 2019 at 9:46

Re: [DISCUSS] KIP-482: The Kafka Protocol should Support Optional Fields

2019-08-18 Thread Satish Duggana
Sorry! Colin, I may not have been clear in my earlier query about optional field type restriction. It is mentioned in one of your replies "optional fields are serialized starting with their total length". This brings the question of whether optional fields support struct types (with or without

[jira] [Created] (KAFKA-8814) Consumer benchmark test for paused partitions

2019-08-18 Thread Sean Glover (JIRA)
Sean Glover created KAFKA-8814: -- Summary: Consumer benchmark test for paused partitions Key: KAFKA-8814 URL: https://issues.apache.org/jira/browse/KAFKA-8814 Project: Kafka Issue Type: New

[jira] [Created] (KAFKA-8813) Race condition when creating topics and changing their configuration

2019-08-18 Thread Gwen Shapira (JIRA)
Gwen Shapira created KAFKA-8813: --- Summary: Race condition when creating topics and changing their configuration Key: KAFKA-8813 URL: https://issues.apache.org/jira/browse/KAFKA-8813 Project: Kafka

Re: [VOTE] KIP-504 - Add new Java Authorizer Interface

2019-08-18 Thread Mickael Maison
+1 (non binding) Thanks for the KIP! On Sun, Aug 18, 2019 at 3:05 PM Ron Dagostino wrote: > > +1 (non-binding) > > Thanks, Rajini. > > Ron > > On Sat, Aug 17, 2019 at 10:16 AM Harsha Chintalapani > wrote: > > > +1 (binding). > > > > Thanks, > > Harsha > > > > > > On Sat, Aug 17, 2019 at 2:53

Re: [DISCUSS] KIP-504 - Add new Java Authorizer Interface

2019-08-18 Thread Don Bosco Durai
Hi Rajini Thanks for clarifying. I am good for now. Regards Bosco On 8/16/19, 11:30 AM, "Rajini Sivaram" wrote: Hi Don, That should be fine. I guess Ranger loads policies from the database synchronously when the authorizer is configured, similar to SimpleAclAuthorizer

Re: [VOTE] KIP-503: deleted topics metric

2019-08-18 Thread Gwen Shapira
+1 (binding) This will be most useful. Thank you. On Tue, Aug 13, 2019 at 12:08 PM David Arthur wrote: > > Hello all, > > I'd like to start the vote on KIP-503 > https://cwiki.apache.org/confluence/display/KAFKA/KIP-503%3A+Add+metric+for+number+of+topics+marked+for+deletion > > Thanks! > David

Re: [VOTE] KIP-503: deleted topics metric

2019-08-18 Thread Satish Duggana
+1(non-binding), very useful metrics for admin/ops. Thanks, Satish. On Sat, Aug 17, 2019 at 4:08 PM Manikumar wrote: > +1 (binding). > > Thanks for the KIP. LGTM. > > Thanks, > Manikumar > > On Wed, Aug 14, 2019 at 11:54 PM David Jacot wrote: > > > +1 (non-binding) > > > > Thanks for the

Re: all tests passed but still got ‘Some checks were not successful’

2019-08-18 Thread M. Manna
Could you send a retest ? Add “Retest this please” comment. It’ll kick off. On Sun, 18 Aug 2019 at 16:16, hong mao wrote: > Hi all, > I submitted a PR and all testcases passed in Jenkins, but I still got a > 'Some checks were not successful' tip. Could anybody give some advices? > Here's the PR

all tests passed but still got ‘Some checks were not successful’

2019-08-18 Thread hong mao
Hi all, I submitted a PR and all testcases passed in Jenkins, but I still got a 'Some checks were not successful' tip. Could anybody give some advices? Here's the PR link https://github.com/apache/kafka/pull/7153 [image: image.png] Thanks!

[jira] [Resolved] (KAFKA-8812) Rebalance Producers - yes, I mean it ;-)

2019-08-18 Thread Werner Daehn (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-8812?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Werner Daehn resolved KAFKA-8812. - Resolution: Invalid Will create a KIP. > Rebalance Producers - yes, I mean it ;-) >

Re: [VOTE] KIP-504 - Add new Java Authorizer Interface

2019-08-18 Thread Ron Dagostino
+1 (non-binding) Thanks, Rajini. Ron On Sat, Aug 17, 2019 at 10:16 AM Harsha Chintalapani wrote: > +1 (binding). > > Thanks, > Harsha > > > On Sat, Aug 17, 2019 at 2:53 AM, Manikumar > wrote: > > > Hi, > > > > +1 (binding). > > > > Thanks for the KIP. LGTM. > > > > Regards, > > Manikumar > >

[jira] [Created] (KAFKA-8812) Rebalance Producers - yes, I mean it ;-)

2019-08-18 Thread Werner Daehn (JIRA)
Werner Daehn created KAFKA-8812: --- Summary: Rebalance Producers - yes, I mean it ;-) Key: KAFKA-8812 URL: https://issues.apache.org/jira/browse/KAFKA-8812 Project: Kafka Issue Type: Improvement