Re: [VOTE] KIP-724: Drop support for message formats v0 and v1

2021-06-09 Thread David Jacot
+1 (binding), Thanks! Le jeu. 10 juin 2021 à 05:52, Gwen Shapira a écrit : > +1 (binding) > > Exciting to see this. > > On Wed, Jun 9, 2021, 11:29 AM Ismael Juma wrote: > > > Hi all, > > > > Consensus was reached in the discussion thread and part of what is > proposed > > has to happen by 3.0,

Re: [VOTE] KIP-618: Exactly-once support for source connectors

2021-06-09 Thread Tom Bentley
Hi Chris, Thanks for the KIP and the discussion. +1 (binding) Kind regards, Tom On Thu, Jun 10, 2021 at 4:15 AM Randall Hauch wrote: > +1 (binding) > > I still have a few minor questions/suggestions about wording (e.g., in > JavaDoc), but those can be handled via the discussion thread and

Re: [VOTE] KIP-752: Support --bootstrap-server in ReplicaVerificationTool

2021-06-09 Thread Ismael Juma
KAFKA-12600 was a general change, not related to this tool specifically. I am not convinced this tool is actually useful, I haven't seen anyone using it in years. Ismael On Wed, Jun 9, 2021 at 9:51 PM Dongjin Lee wrote: > Hi Ismael, > > Before I submit this KIP, I reviewed some history. When

Re: [VOTE] KIP-752: Support --bootstrap-server in ReplicaVerificationTool

2021-06-09 Thread Dongjin Lee
Hi Ismael, Before I submit this KIP, I reviewed some history. When KIP-499 tried to resolve the inconsistencies between the command line tools, two tools were omitted, probably by

Re: [DISCUSS] KIP-726: Make the CooperativeStickyAssignor as the default assignor

2021-06-09 Thread Ryan Leslie
Thanks for the quick replies, Luke and Sophie. I've not voted, but I agree with accepting the KIP since it's a superior feature. I was just reacting mostly to this comment since it didn't mention open issues: > > > Thanks Luke. We may as well get this KIP in to 3.0 so that we can fully > > >

Re: [VOTE] KIP-752: Support --bootstrap-server in ReplicaVerificationTool

2021-06-09 Thread Ismael Juma
Hi Dongjin, Does this tool still work? I recall that there were some doubts about it and that's why it wasn't updated previously. Ismael On Sat, Jun 5, 2021 at 2:38 PM Dongjin Lee wrote: > Hi all, > > I'd like to call for a vote on KIP-752: Support --bootstrap-server in >

Re: [VOTE] KIP-752: Support --bootstrap-server in ReplicaVerificationTool

2021-06-09 Thread Randall Hauch
Thanks for the straightforward KIP, Dongjin. +1 (binding) Best regards, Randall On Wed, Jun 9, 2021 at 9:41 PM wenbing shen wrote: > Hi Dongjin, > Thanks for the KIP. > +1 (non-binding) > > Thanks. > Wenbing > > Dongjin Lee 于2021年6月10日周四 上午10:04写道: > > > Thanks, Gwen and Luke, > > > > As of

Re: [VOTE] KIP-724: Drop support for message formats v0 and v1

2021-06-09 Thread Gwen Shapira
+1 (binding) Exciting to see this. On Wed, Jun 9, 2021, 11:29 AM Ismael Juma wrote: > Hi all, > > Consensus was reached in the discussion thread and part of what is proposed > has to happen by 3.0, so starting the vote for KIP-724: > > >

Re: [VOTE] KIP-618: Exactly-once support for source connectors

2021-06-09 Thread Randall Hauch
+1 (binding) I still have a few minor questions/suggestions about wording (e.g., in JavaDoc), but those can be handled via the discussion thread and won't change the intent of those API methods or the KIP. Best regards, Randall On Wed, Jun 9, 2021 at 7:32 AM Chris Egerton wrote: > Hi all, >

Re: [VOTE] KIP-745: Connect API to restart connector and tasks

2021-06-09 Thread Dongjin Lee
+1 (non-binding). As of present: - binding: +2 (Randall, Konstantine) - non-binding: +3 (Ryanne, Kalpesh, Dongjin) We need one more +1 binding. Thanks, Dongjin On Tue, Jun 8, 2021 at 6:31 AM Kalpesh Patel wrote: > +1 (non-binding) > > Regards > -Kalpesh > > On Mon, Jun 7, 2021 at 3:10 PM

Re: [VOTE] KIP-752: Support --bootstrap-server in ReplicaVerificationTool

2021-06-09 Thread wenbing shen
Hi Dongjin, Thanks for the KIP. +1 (non-binding) Thanks. Wenbing Dongjin Lee 于2021年6月10日周四 上午10:04写道: > Thanks, Gwen and Luke, > > As of present: > - binding: +1 (Gwen) > - non-binding: +1 (Luke) > > Anyone else? > > Regards, > Dongjin > > On Thu, Jun 10, 2021 at 1:24 AM Gwen Shapira > wrote:

Re: [VOTE] KIP-752: Support --bootstrap-server in ReplicaVerificationTool

2021-06-09 Thread Dongjin Lee
Thanks, Gwen and Luke, As of present: - binding: +1 (Gwen) - non-binding: +1 (Luke) Anyone else? Regards, Dongjin On Thu, Jun 10, 2021 at 1:24 AM Gwen Shapira wrote: > +1 (binding) > > On Wed, Jun 9, 2021 at 8:28 AM Dongjin Lee wrote: > > > Bumping up the voting thread. > > > > Please note

Re: [VOTE] KIP-390: Support Compression Level (rebooted)

2021-06-09 Thread Dongjin Lee
Thanks Ismel, Tom and Ryanne, I am now updating the KIP about the further works. Sure, You won't be disappointed. As of Present: - binding: +2 (Ismael, Tom) - non-binding: +1 (Ryanne) Anyone else? Best, Dongjin On Thu, Jun 10, 2021 at 2:03 AM Tom Bentley wrote: > Hi Dongjin, > > Thanks for

Build failed in Jenkins: Kafka » Kafka Branch Builder » trunk #208

2021-06-09 Thread Apache Jenkins Server
See Changes: -- [...truncated 474334 lines...] [2021-06-10T01:45:02.804Z] > Task :clients:jar UP-TO-DATE [2021-06-10T01:45:03.735Z] > Task :server-common:compileJava

[jira] [Created] (KAFKA-12927) Kafka account no authentication failure anti-theft cracking mechanism

2021-06-09 Thread SingleThread (Jira)
SingleThread created KAFKA-12927: Summary: Kafka account no authentication failure anti-theft cracking mechanism Key: KAFKA-12927 URL: https://issues.apache.org/jira/browse/KAFKA-12927 Project: Kafka

[jira] [Resolved] (KAFKA-12920) Consumer's cooperative sticky assignor need to clear generation / assignment data upon `onPartitionsLost`

2021-06-09 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12920?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman resolved KAFKA-12920. Resolution: Not A Bug > Consumer's cooperative sticky assignor need to

Re: [VOTE] KIP-750: Drop support for Java 8 in Kafka 4.0 (deprecate in 3.0)

2021-06-09 Thread Colin McCabe
+1 (binding). Looking forward to 4.0 (heh) best, Colin On Wed, Jun 9, 2021, at 02:45, Tom Bentley wrote: > Hi Ismael, > > Thanks for the KIP, +1 (binding). > > Cheers, > > Tom > > On Wed, Jun 9, 2021 at 10:04 AM Mickael Maison > wrote: > > > +1 (binding) > > Thanks > > > > On Wed, Jun 9,

Re: [VOTE] KIP-724: Drop support for message formats v0 and v1

2021-06-09 Thread Colin McCabe
+1 (binding) Thanks, Ismael. best, Colin On Wed, Jun 9, 2021, at 17:41, Dongjin Lee wrote: > +1 (non-binding). > > Best, > Dongjin > > On Thu, Jun 10, 2021, 7:20 AM Jason Gustafson > wrote: > > > +1 Thanks Ismael! > > > > On Wed, Jun 9, 2021 at 11:29 AM Ismael Juma wrote: > > > > > Hi all,

Re: [VOTE] KIP-746: Revise KRaft Metadata Records

2021-06-09 Thread David Arthur
Thanks, Colin, looks good to me. +1 On Wed, Jun 9, 2021 at 8:32 PM Israel Ekpo wrote: > Makes sense to me > > +1 (non-binding) > > > On Wed, Jun 9, 2021 at 7:05 PM Jun Rao wrote: > > > Hi, Colin, > > > > Thanks for the KIP. +1 from me. > > > > Jun > > > > On Wed, Jun 9, 2021 at 9:36 AM Jason

Re: [VOTE] KIP-724: Drop support for message formats v0 and v1

2021-06-09 Thread Dongjin Lee
+1 (non-binding). Best, Dongjin On Thu, Jun 10, 2021, 7:20 AM Jason Gustafson wrote: > +1 Thanks Ismael! > > On Wed, Jun 9, 2021 at 11:29 AM Ismael Juma wrote: > > > Hi all, > > > > Consensus was reached in the discussion thread and part of what is > proposed > > has to happen by 3.0, so

Re: [VOTE] KIP-746: Revise KRaft Metadata Records

2021-06-09 Thread Israel Ekpo
Makes sense to me +1 (non-binding) On Wed, Jun 9, 2021 at 7:05 PM Jun Rao wrote: > Hi, Colin, > > Thanks for the KIP. +1 from me. > > Jun > > On Wed, Jun 9, 2021 at 9:36 AM Jason Gustafson > > wrote: > > > +1 Thanks Colin! > > > > On Thu, Jun 3, 2021 at 4:30 PM Colin McCabe wrote: > > > > >

[jira] [Created] (KAFKA-12926) ConsumerGroupCommand's java.lang.NullPointerException at negative offsets while running kafka-consumer-groups.sh

2021-06-09 Thread Ignacio Acuna (Jira)
Ignacio Acuna created KAFKA-12926: - Summary: ConsumerGroupCommand's java.lang.NullPointerException at negative offsets while running kafka-consumer-groups.sh Key: KAFKA-12926 URL:

Re: [DISCUSS] KIP-756: Move StreamsResetter tool outside of core

2021-06-09 Thread Matthias J. Sax
Thanks for the KIP. The KIP seems to post quite some implementation details, why? We should focus on the public API only to make it easier to read. The new class also does not contain a `main()` method that we need to run the resetter as command line tool. nit: can we use `applicationId`

Build failed in Jenkins: Kafka » Kafka Branch Builder » trunk #207

2021-06-09 Thread Apache Jenkins Server
See Changes: -- [...truncated 473998 lines...] [2021-06-09T23:21:55.759Z] [INFO]

[jira] [Created] (KAFKA-12925) StateStore::prefixScan missing from intermediate interfaces

2021-06-09 Thread Michael Viamari (Jira)
Michael Viamari created KAFKA-12925: --- Summary: StateStore::prefixScan missing from intermediate interfaces Key: KAFKA-12925 URL: https://issues.apache.org/jira/browse/KAFKA-12925 Project: Kafka

Re: [VOTE] KIP-726: Make the "cooperative-sticky, range" as the default assignor

2021-06-09 Thread Konstantine Karantasis
Thanks for the KIP Luke. +1 (binding) Konstantine On Wed, Jun 9, 2021 at 6:36 AM Luke Chen wrote: > Hi all, > Bump this thread to see if there's anyone wants to vote or have questions. > > Thank you. > Luke > > Sophie Blee-Goldman 於 2021年6月8日 週二 上午4:40 > 寫道: > > > +1 (binding) > > > >

Re: [VOTE] KIP-746: Revise KRaft Metadata Records

2021-06-09 Thread Jun Rao
Hi, Colin, Thanks for the KIP. +1 from me. Jun On Wed, Jun 9, 2021 at 9:36 AM Jason Gustafson wrote: > +1 Thanks Colin! > > On Thu, Jun 3, 2021 at 4:30 PM Colin McCabe wrote: > > > Hi all, > > > > I'd like to call a vote for KIP-746: Revise KRaft Metadata Records. This > > is a minor KIP

Re: [VOTE] KIP-724: Drop support for message formats v0 and v1

2021-06-09 Thread Jason Gustafson
+1 Thanks Ismael! On Wed, Jun 9, 2021 at 11:29 AM Ismael Juma wrote: > Hi all, > > Consensus was reached in the discussion thread and part of what is proposed > has to happen by 3.0, so starting the vote for KIP-724: > > >

[jira] [Resolved] (KAFKA-12874) Increase default consumer session timeout to 45s (KIP-735)

2021-06-09 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12874?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-12874. - Fix Version/s: 3.0.0 Resolution: Fixed > Increase default consumer session

[VOTE] KIP-724: Drop support for message formats v0 and v1

2021-06-09 Thread Ismael Juma
Hi all, Consensus was reached in the discussion thread and part of what is proposed has to happen by 3.0, so starting the vote for KIP-724: https://cwiki.apache.org/confluence/display/KAFKA/KIP-724%3A+Drop+support+for+message+formats+v0+and+v1 If there are concerns or objections, feel free to

Re: [DISCUSS] KIP-746: Revise KRaft Metadata Records

2021-06-09 Thread Colin McCabe
On Tue, Jun 8, 2021, at 09:53, Jun Rao wrote: > Hi, Colin, > > Thanks for the update KIP. > > 2. BrokerRegistrationChangeRecord: > 2.1 Should the listeners field be named EndPoints to be consistent with > RegisterBrokerRecord? Good point. I'll change this. > 2.2 Does the listeners field

Re: [DISCUSS] KIP-618: Atomic commit of source connector records and offsets

2021-06-09 Thread Chris Egerton
Hi Randall, That's a fair assessment; if a user upgrades their cluster to 3.0 with no changes to worker or connector configs, it's possible that their cluster will break if their worker principal(s) lack the necessary ACLs on the Kafka cluster that hosts the config topic. If we wanted to take a

Re: [VOTE] KIP-390: Support Compression Level (rebooted)

2021-06-09 Thread Tom Bentley
Hi Dongjin, Thanks for the KIP, +1 (binding). Kind regards, Tom On Wed, Jun 9, 2021 at 5:16 PM Ismael Juma wrote: > I'm +1 on the proposed change. As I stated in the discuss thread, I don't > think we should rule out the buffer size config, but we could list that as > future work vs rejected

Re: [DISCUSS] KIP-618: Atomic commit of source connector records and offsets

2021-06-09 Thread Randall Hauch
Chris, Sorry for the late question/comment. But the "Breaking Changes" concerns me. IIUC, when a user upgrades their 1.x or 2.x Connect cluster, then when they restart their 3.0 worker(s) the workers will fail due to this producer requirement even if they make no changes to their worker configs

Re: [DISCUSS] KIP-724: Drop support for message formats v0 and v1

2021-06-09 Thread Jun Rao
Hi, Ismael, Sounds good. The KIP looks good to me. Thanks, Jun On Wed, Jun 9, 2021 at 9:16 AM Ismael Juma wrote: > Thanks Jun. After further thought and discussion with Jason, we decided to > move `log.record.version.force.upgrade` to a "Future Work" section. > > There are more details in

Re: [VOTE] KIP-746: Revise KRaft Metadata Records

2021-06-09 Thread Jason Gustafson
+1 Thanks Colin! On Thu, Jun 3, 2021 at 4:30 PM Colin McCabe wrote: > Hi all, > > I'd like to call a vote for KIP-746: Revise KRaft Metadata Records. This > is a minor KIP which revises the KRaft metadata records slightly for the > upcoming 3.0 release. > > The KIP is at:

Re: [VOTE] KIP-752: Support --bootstrap-server in ReplicaVerificationTool

2021-06-09 Thread Gwen Shapira
+1 (binding) On Wed, Jun 9, 2021 at 8:28 AM Dongjin Lee wrote: > Bumping up the voting thread. > > Please note that today is the KIP freeze day. +1 non-binding until now. > > Thanks, > Dongjin > > On Sun, Jun 6, 2021 at 4:10 PM Luke Chen wrote: > > > Hi Dongjin, > > Thanks for the KIP. > > +1

Re: [DISCUSS] KIP-724: Drop support for message formats v0 and v1

2021-06-09 Thread Ismael Juma
Thanks Jun. After further thought and discussion with Jason, we decided to move `log.record.version.force.upgrade` to a "Future Work" section. There are more details in the KIP, but there are some complexities in making it possible to remove read support for v0/v1 formats. Given that, we decided

Re: [VOTE] KIP-390: Support Compression Level (rebooted)

2021-06-09 Thread Ismael Juma
I'm +1 on the proposed change. As I stated in the discuss thread, I don't think we should rule out the buffer size config, but we could list that as future work vs rejected alternatives. Ismael On Sat, Jun 5, 2021 at 2:37 PM Dongjin Lee wrote: > Hi all, > > I'd like to open a voting thread for

Re: [VOTE] KIP-719: Add Log4J2 Appender

2021-06-09 Thread Dongjin Lee
Bumping up the voting thread. Please note that today is the KIP freeze day. Thanks, Dongjin On Mon, Jun 7, 2021 at 9:28 PM Dongjin Lee wrote: > Bumping up the voting thread. > > > As a reminder: Please note that without the Log4j2 appender, we can't > complete KIP-653: Upgrade log4j to log4j2

Re: [VOTE] KIP-752: Support --bootstrap-server in ReplicaVerificationTool

2021-06-09 Thread Dongjin Lee
Bumping up the voting thread. Please note that today is the KIP freeze day. +1 non-binding until now. Thanks, Dongjin On Sun, Jun 6, 2021 at 4:10 PM Luke Chen wrote: > Hi Dongjin, > Thanks for the KIP. > +1 (non-binding) > > Thanks. > Luke > > On Sun, Jun 6, 2021 at 5:38 AM Dongjin Lee

Re: [VOTE] KIP-390: Support Compression Level (rebooted)

2021-06-09 Thread Dongjin Lee
Bumping up the voting thread. Please note that today is the KIP freeze day. +1 non-binding until now. Thanks, Dongjin On Sun, Jun 6, 2021 at 11:47 PM Ryanne Dolan wrote: > +1 (non-binding), thanks! > > Ryanne > > On Sat, Jun 5, 2021, 4:37 PM Dongjin Lee wrote: > > > Hi all, > > > > I'd like

Re: [DISCUSS] KIP-390: Support Compression Level (rebooted)

2021-06-09 Thread Ismael Juma
Thanks! We could move that to a "Future Work" section instead of "Rejected Alternatives" if the results are inconclusive. Ismael On Wed, Jun 9, 2021 at 8:09 AM Dongjin Lee wrote: > > I am OK with doing compression level first, but I don't want to rule out > the buffer size change without

Re: [DISCUSS] KIP-390: Support Compression Level (rebooted)

2021-06-09 Thread Dongjin Lee
> I am OK with doing compression level first, but I don't want to rule out the buffer size change without understanding better. I see. I am now retrying buffer size configuration & benchmark. As soon as I get a promising result, I will update the KIP. Thanks, Dongjin On Wed, Jun 9, 2021 at

Re: [VOTE] KIP-726: Make the "cooperative-sticky, range" as the default assignor

2021-06-09 Thread Luke Chen
Hi all, Bump this thread to see if there's anyone wants to vote or have questions. Thank you. Luke Sophie Blee-Goldman 於 2021年6月8日 週二 上午4:40 寫道: > +1 (binding) > > Thanks Luke > > On Mon, Jun 7, 2021 at 3:26 AM Luke Chen wrote: > > > Hi Ismael, > > Thanks for your comments. I updated the KIP

Re: [VOTE] KIP-738: Removal of Connect's internal converter properties

2021-06-09 Thread Chris Egerton
Hi all, The KIP passes with three binding +1s from Randall, Tom, and Konstantine, and one non-binding +1 from Ryanne. I'll have a PR out shortly. Thanks to all who participated! Cheers, Chris On Fri, Jun 4, 2021 at 9:28 PM Konstantine Karantasis wrote: > +1 (binding) but also with the note

Re: [VOTE] KIP-618: Exactly-once support for source connectors

2021-06-09 Thread Chris Egerton
Hi all, Friendly reminder that the KIP freeze is today; please cast your votes if you'd like to see this feature introduced in time for 3.0. Cheers, Chris On Mon, Jun 7, 2021 at 1:49 AM Dongjin Lee wrote: > +1 (non-binding). > > Thanks, > Dongjin > > On Fri, Jun 4, 2021 at 2:35 PM Ryanne

Re: [VOTE] KIP-750: Drop support for Java 8 in Kafka 4.0 (deprecate in 3.0)

2021-06-09 Thread Tom Bentley
Hi Ismael, Thanks for the KIP, +1 (binding). Cheers, Tom On Wed, Jun 9, 2021 at 10:04 AM Mickael Maison wrote: > +1 (binding) > Thanks > > On Wed, Jun 9, 2021 at 1:25 AM Israel Ekpo wrote: > > > > This is great! > > > > Thanks for the KIP > > > > +1 (non-binding) > > > > > > On Tue, Jun 8,

Re: [VOTE] KIP-751: Drop support for Scala 2.12 in Kafka 4.0 (deprecate in 3.0)

2021-06-09 Thread Tom Bentley
Hi Ismael, Thanks for the KIP, +1 (binding). Cheers, Tom On Wed, Jun 9, 2021 at 10:29 AM David Jacot wrote: > +1 (binding) > > Thanks for the KIP, Ismael! > > Le mer. 9 juin 2021 à 11:06, Mickael Maison a > écrit : > > > +1 (binding) > > Thanks for the KIP > > > > On Tue, Jun 8, 2021 at

[jira] [Created] (KAFKA-12924) Replace EasyMock and PowerMock with Mockito in streams module(metrics)

2021-06-09 Thread YI-CHEN WANG (Jira)
YI-CHEN WANG created KAFKA-12924: Summary: Replace EasyMock and PowerMock with Mockito in streams module(metrics) Key: KAFKA-12924 URL: https://issues.apache.org/jira/browse/KAFKA-12924 Project:

Re: [VOTE] KIP-751: Drop support for Scala 2.12 in Kafka 4.0 (deprecate in 3.0)

2021-06-09 Thread David Jacot
+1 (binding) Thanks for the KIP, Ismael! Le mer. 9 juin 2021 à 11:06, Mickael Maison a écrit : > +1 (binding) > Thanks for the KIP > > On Tue, Jun 8, 2021 at 9:15 AM Bruno Cadonna wrote: > > > > Hi Ismael, > > > > Thank you for the KIP! > > > > +1 (binding) > > > > Best, > > Bruno > > > > On

Re: [VOTE] KIP-751: Drop support for Scala 2.12 in Kafka 4.0 (deprecate in 3.0)

2021-06-09 Thread Mickael Maison
+1 (binding) Thanks for the KIP On Tue, Jun 8, 2021 at 9:15 AM Bruno Cadonna wrote: > > Hi Ismael, > > Thank you for the KIP! > > +1 (binding) > > Best, > Bruno > > On 08.06.21 10:11, Matthew de Detrich wrote: > > +1 (non binding) > > > > On Tue, Jun 8, 2021 at 4:34 AM Luke Chen wrote: > > > >>

[jira] [Created] (KAFKA-12923) Log.splitOverflowedSegment logic can skip producer state snapshot deletion

2021-06-09 Thread Kowshik Prakasam (Jira)
Kowshik Prakasam created KAFKA-12923: Summary: Log.splitOverflowedSegment logic can skip producer state snapshot deletion Key: KAFKA-12923 URL: https://issues.apache.org/jira/browse/KAFKA-12923

Re: [VOTE] KIP-750: Drop support for Java 8 in Kafka 4.0 (deprecate in 3.0)

2021-06-09 Thread Mickael Maison
+1 (binding) Thanks On Wed, Jun 9, 2021 at 1:25 AM Israel Ekpo wrote: > > This is great! > > Thanks for the KIP > > +1 (non-binding) > > > On Tue, Jun 8, 2021 at 3:13 AM Bruno Cadonna wrote: > > > Hi Ismael, > > > > Thank you for the KIP! > > > > +1 (binding) > > > > Best, > > Bruno > > > > On

[jira] [Created] (KAFKA-12922) MirrorCheckpointTask should close topic filter

2021-06-09 Thread Viktor Somogyi-Vass (Jira)
Viktor Somogyi-Vass created KAFKA-12922: --- Summary: MirrorCheckpointTask should close topic filter Key: KAFKA-12922 URL: https://issues.apache.org/jira/browse/KAFKA-12922 Project: Kafka