[jira] [Created] (KAFKA-15563) Provide informative error messages when Connect REST requests time out

2023-10-06 Thread Chris Egerton (Jira)
Chris Egerton created KAFKA-15563: - Summary: Provide informative error messages when Connect REST requests time out Key: KAFKA-15563 URL: https://issues.apache.org/jira/browse/KAFKA-15563 Project

[VOTE] KIP-976: Cluster-wide dynamic log adjustment for Kafka Connect

2023-10-06 Thread Chris Egerton
Hi all, I'd like to call for a vote on KIP-976, which augments the existing dynamic logger adjustment REST API for Kafka Connect to apply changes cluster-wide instead on a per-worker basis. The KIP: https://cwiki.apache.org/confluence/display/KAFKA/KIP-976:+Cluster-wide+dynamic+log+adjustment+for

Re: [DISCUSS] KIP-980: Allow creating connectors in a stopped state

2023-10-05 Thread Chris Egerton
won't really see any errors > on attempting to parse a JSON file into Java properties). > > Thanks, > Yash > > On Thu, Oct 5, 2023 at 1:39 AM Chris Egerton > wrote: > > > Hi Yash, > > > > Looking great! Few more thoughts: > > > > > >

Re: [DISCUSS] KIP-980: Allow creating connectors in a stopped state

2023-10-04 Thread Chris Egerton
ectors that fail to generate task > configurations, connectors that are paused right after being created etc.). > I did also try out a small prototype before publishing this KIP and things > do work as expected when creating a connector in the PAUSED / STOPPED state > by simply writing the

Re: [DISCUSS] KIP-980: Allow creating connectors in a stopped state

2023-10-03 Thread Chris Egerton
end for it to be > the sole purpose of this KIP. However, that said, I really like the idea of > accepting an "offsets" field in the connector creation request since it'd > reduce the number of user operations required from 3 (create the connector > in a STOPPED state; al

Re: [VOTE] 3.6.0 RC2

2023-10-03 Thread Chris Egerton
Hi Satish, Thanks for running this release! To verify, I: - Built from source using Java 11 with both: - - the 3.6.0-rc2 tag on GitHub - - the kafka-3.6.0-src.tgz artifact from https://home.apache.org/~satishd/kafka-3.6.0-rc2/ - Checked signatures and checksums - Ran the quickstart using the kafk

Re: [DISCUSS] KIP-980: Allow creating connectors in a stopped state

2023-10-02 Thread Chris Egerton
Hi Yash, Thanks for the KIP! Frankly this feels like an oversight in 875 and I'm glad we're closing that loop ASAP. Here are my thoughts: 1. (Nit): IMO "start.state", "initial.state", or "target.state" might be better than just "state" for the field name in the connector creation request. 2. W

Re: [ANNOUNCE] New Kafka PMC Member: Justine Olshan

2023-09-22 Thread Chris Egerton
Congrats Justine! On Fri, Sep 22, 2023, 20:47 Guozhang Wang wrote: > Congratulations! > > On Fri, Sep 22, 2023 at 8:44 PM Tzu-Li (Gordon) Tai > wrote: > > > > Congratulations Justine! > > > > On Fri, Sep 22, 2023, 19:25 Philip Nee wrote: > > > > > Congrats Justine! > > > > > > On Fri, Sep 22, 2

Re: [ANNOUNCE] New committer: Yash Mayya

2023-09-21 Thread Chris Egerton
Congratulations Yash, well-deserved! On Thu, Sep 21, 2023, 11:28 Bruno Cadonna wrote: > Hi all, > > The PMC of Apache Kafka is pleased to announce a new Kafka committer > Yash Mayya. > > Yash's major contributions are around Connect. > > Yash authored the following KIPs: > > KIP-793: Allow sink

Re: [VOTE] 3.6.0 RC0

2023-09-19 Thread Chris Egerton
Hi all, Given the regression raised by Greg Harris ( https://issues.apache.org/jira/browse/KAFKA-15473) on the release thread, I believe we should generate a new candidate with a fix. I'm -1 (binding) on this RC. Best, Chris On Tue, Sep 19, 2023 at 10:30 AM Christo Lolov wrote: > Heya, > > I

[jira] [Resolved] (KAFKA-15473) Connect connector-plugins endpoint shows duplicate plugins

2023-09-19 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton resolved KAFKA-15473. --- Fix Version/s: 3.7.0 (was: 3.6.0) Resolution: Fixed > Conn

Re: Apache Kafka 3.6.0 release

2023-09-19 Thread Chris Egerton
Hi Satish, I think this qualifies as a blocker. This API has been around for years now and, while we don't document it as not exposing duplicates*, it has come with that implicit contract since its inception. More importantly, it has also never exposed plugins that cannot be used on the worker. Th

[jira] [Resolved] (KAFKA-15416) Flaky test TopicAdminTest::retryEndOffsetsShouldRetryWhenTopicNotFound

2023-09-07 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton resolved KAFKA-15416. --- Fix Version/s: 3.7.0 Resolution: Fixed > Flaky test TopicAdminT

Re: KIP-976: Cluster-wide dynamic log adjustment for Kafka Connect

2023-09-07 Thread Chris Egerton
was to not have the prefix org.apache.kafka.connect in the keys > considering > > it is the root namespace. But since logging can be enabled at a root > level, > > can we just use initials like (o.a.k.c) which is also a standard > practice. > > Let me know what you th

[jira] [Created] (KAFKA-15436) Custom ConfigDef validators are invoked with null when user-provided value does not match type

2023-09-05 Thread Chris Egerton (Jira)
Chris Egerton created KAFKA-15436: - Summary: Custom ConfigDef validators are invoked with null when user-provided value does not match type Key: KAFKA-15436 URL: https://issues.apache.org/jira/browse/KAFKA-15436

Re: KIP-976: Cluster-wide dynamic log adjustment for Kafka Connect

2023-09-05 Thread Chris Egerton
plan, should we also add a test when the scope parameter > passed is non-null and neither worker nor cluster? In this case the > behaviour should be similar to the default case. > > 4) I had the same question as Yash regarding persistent cluster-wide > logging level. I think you ha

Re: KIP-976: Cluster-wide dynamic log adjustment for Kafka Connect

2023-09-05 Thread Chris Egerton
future. > > Don't you foresee a future scope type which may require cluster metadata > ? > > In that case, isn't it better to forward the requests to the leader in > the > > initial implementation ? > > > > I would also recommend an additional system

KIP-976: Cluster-wide dynamic log adjustment for Kafka Connect

2023-09-01 Thread Chris Egerton
Hi all, Can't imagine a worse time to publish a new KIP (it's late on a Friday and we're in the middle of the 3.6.0 release), but I wanted to put forth KIP-976 for discussion: https://cwiki.apache.org/confluence/display/KAFKA/KIP-976%3A+Cluster-wide+dynamic+log+adjustment+for+Kafka+Connect TL;DR:

[jira] [Created] (KAFKA-15428) Cluster-wide dynamic log adjustments for Connect

2023-09-01 Thread Chris Egerton (Jira)
Chris Egerton created KAFKA-15428: - Summary: Cluster-wide dynamic log adjustments for Connect Key: KAFKA-15428 URL: https://issues.apache.org/jira/browse/KAFKA-15428 Project: Kafka Issue

Re: Apache Kafka 3.6.0 release

2023-08-31 Thread Chris Egerton
Cheers, Chris On Wed, Aug 30, 2023 at 1:01 PM Chris Egerton wrote: > Hi Satish, > > Wanted to let you know that KAFKA-12879 ( > https://issues.apache.org/jira/browse/KAFKA-12879), a breaking change in > Admin::listOffsets, has been reintroduced into the code base. Since we > hav

[jira] [Resolved] (KAFKA-12879) Compatibility break in Admin.listOffsets()

2023-08-31 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12879?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton resolved KAFKA-12879. --- Resolution: Fixed > Compatibility break in Admin.listOffs

[jira] [Created] (KAFKA-15425) Compatibility break in Admin.listOffsets() (2)

2023-08-31 Thread Chris Egerton (Jira)
Chris Egerton created KAFKA-15425: - Summary: Compatibility break in Admin.listOffsets() (2) Key: KAFKA-15425 URL: https://issues.apache.org/jira/browse/KAFKA-15425 Project: Kafka Issue Type

Re: [VOTE] KIP-970: Deprecate and remove Connect's redundant task configurations endpoint

2023-08-30 Thread Chris Egerton
+1 (binding), thanks Yash! On Wed, Aug 30, 2023 at 1:34 PM Andrew Schofield < andrew_schofield_j...@outlook.com> wrote: > Thanks for the KIP. Looks good to me. > > +1 (non-binding). > > Andrew > > > On 30 Aug 2023, at 18:07, Hector Geraldino (BLOOMBERG/ 919 3RD A) < > hgerald...@bloomberg.net> wr

Re: Apache Kafka 3.6.0 release

2023-08-30 Thread Chris Egerton
atish. > > > > > > > > > > On Wed, 16 Aug 2023 at 15:58, Satish Duggana < > satish.dugg...@gmail.com > > > > > > > > > wrote: > > > > > > > > > > > > Hi, > > > > > > Please

[jira] [Reopened] (KAFKA-12879) Compatibility break in Admin.listOffsets()

2023-08-30 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12879?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton reopened KAFKA-12879: --- Assignee: (was: Philip Nee) Reopening due to https://github.com/apache/kafka/pull

[jira] [Resolved] (KAFKA-13327) Preflight validations of connectors leads to 500 responses

2023-08-29 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton resolved KAFKA-13327. --- Fix Version/s: 3.7.0 Resolution: Fixed > Preflight validations of connectors le

[jira] [Created] (KAFKA-15416) Flaky test TopicAdminTest::retryEndOffsetsShouldRetryWhenTopicNotFound

2023-08-29 Thread Chris Egerton (Jira)
Chris Egerton created KAFKA-15416: - Summary: Flaky test TopicAdminTest::retryEndOffsetsShouldRetryWhenTopicNotFound Key: KAFKA-15416 URL: https://issues.apache.org/jira/browse/KAFKA-15416 Project

Re: [DISCUSS] KIP-970: Deprecate and remove Connect's redundant task configurations endpoint

2023-08-22 Thread Chris Egerton
Hi Yash, Thanks for driving this, and for putting out a well-written KIP. LGTM! Cheers, Chris On Tue, Aug 22, 2023 at 6:13 AM Yash Mayya wrote: > Hi all, > > I'd like to start a discussion thread for this KIP - > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-970%3A+Deprecate+and+rem

[jira] [Created] (KAFKA-15342) Considering upgrading to Mockito 5.4.1 or later

2023-08-14 Thread Chris Egerton (Jira)
Chris Egerton created KAFKA-15342: - Summary: Considering upgrading to Mockito 5.4.1 or later Key: KAFKA-15342 URL: https://issues.apache.org/jira/browse/KAFKA-15342 Project: Kafka Issue Type

[jira] [Resolved] (KAFKA-14682) Unused stubbings are not reported by Mockito during CI builds

2023-08-14 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton resolved KAFKA-14682. --- Fix Version/s: 3.6.0 Resolution: Fixed > Unused stubbings are not reported

Re: [VOTE] KIP-953: partition method to be overloaded to accept headers as well.

2023-08-11 Thread Chris Egerton
Hi Jack, +1 (binding) Some friendly, non-blocking suggestions: - IMO it's still worth specifying that the headers will be read-only; this clarifies the intended API contract both for reviewers of the KIP who haven't read the GitHub PR yet, and for developers who may leverage this new method - Ma

[jira] [Resolved] (KAFKA-13187) Replace EasyMock and PowerMock with Mockito for DistributedHerderTest

2023-08-10 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton resolved KAFKA-13187. --- Fix Version/s: 3.6.0 Resolution: Done > Replace EasyMock and PowerMock with Mock

[jira] [Resolved] (KAFKA-10334) Transactions not working properly

2023-08-05 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton resolved KAFKA-10334. --- Resolution: Duplicate > Transactions not working prope

Re: Apache Kafka 3.6.0 release

2023-08-04 Thread Chris Egerton
also > > useful for backward compatibility. I added it to the release plan as > > an exceptional case. > > > > ~Satish. > > > > On Thu, 3 Aug 2023 at 21:34, Chris Egerton > wrote: > > > > > > Hi Satish, > > > > > > Would it b

Re: Apache Kafka 3.6.0 release

2023-08-03 Thread Chris Egerton
Hi Satish, Would it be possible to include KIP-949 ( https://cwiki.apache.org/confluence/display/KAFKA/KIP-949%3A+Add+flag+to+enable+the+usage+of+topic+separator+in+MM2+DefaultReplicationPolicy) in the 3.6.0 release? It passed voting yesterday, and is a very small, low-risk change that we'd like t

Re: [ANNOUNCE] Apache Kafka 3.5.1

2023-07-26 Thread Chris Egerton
; >>>>> > >>>>> ** The Connector API allows building and running reusable producers > or > >>>>> consumers that connect Kafka topics to existing applications or data > >>>>> systems. For example, a connector to a relational dat

Re: [VOTE] KIP-959 Add BooleanConverter to Kafka Connect

2023-07-26 Thread Chris Egerton
+1 (binding) Thanks Hector! On Wed, Jul 26, 2023 at 3:18 AM Kamal Chandraprakash < kamal.chandraprak...@gmail.com> wrote: > +1 (non-binding). Thanks for the KIP! > > On Tue, Jul 25, 2023 at 11:12 PM Yash Mayya wrote: > > > Hi Hector, > > > > Thanks for the KIP! > > > > +1 (non-binding) > > > >

Re: [DISCUSS] KIP-959 Add BooleanConverter to Kafka Connect

2023-07-25 Thread Chris Egerton
Thanks Hector! LGTM On Tue, Jul 25, 2023 at 11:47 AM Hector Geraldino (BLOOMBERG/ 919 3RD A) < hgerald...@bloomberg.net> wrote: > Thanks Chris for your quick reply. > > Your suggestions make sense, I amended the KIP and added a note to the > class JavaDocs. Also added unit tests to the companion

Re: [DISCUSS] KIP-959 Add BooleanConverter to Kafka Connect

2023-07-25 Thread Chris Egerton
Hi Hector, Thanks for the KIP! Really appreciate the tight scope, hoping this will be easy to review :) I only have one question: it looks like our existing primitive converters (string converter + subclasses of NumberConverter) are hardcoded to play nicely with null values during deserialization

[jira] [Created] (KAFKA-15249) Verify Connect test-plugins artifact is published to Maven Central

2023-07-25 Thread Chris Egerton (Jira)
Chris Egerton created KAFKA-15249: - Summary: Verify Connect test-plugins artifact is published to Maven Central Key: KAFKA-15249 URL: https://issues.apache.org/jira/browse/KAFKA-15249 Project: Kafka

Re: [VOTE] KIP-949: Add flag to enable the usage of topic separator in MM2 DefaultReplicationPolicy

2023-07-24 Thread Chris Egerton
Hi Omnia, I think there's a few clarifications that should still be made on the KIP, but assuming these are agreeable, I'm +1 (binding) - In the description for the replication.policy.internal.topic.separator.enabled property (in the "Public Interfaces" section), we should specify that it affects

Re: [VOTE] KIP-944 Support async runtimes in consumer, votes needed!

2023-07-22 Thread Chris Egerton
implement > Chris' idea. > > Kind regards, > Erik. > > > Op 22-07-2023 om 16:39 schreef Chris Egerton: > > Hi Erik, > > > > I don't think Matthias is bringing FUD to the discussion. Many of the > > people who maintain Kafka are famili

Re: [VOTE] KIP-944 Support async runtimes in consumer, votes needed!

2023-07-22 Thread Chris Egerton
Hi Erik, I don't think Matthias is bringing FUD to the discussion. Many of the people who maintain Kafka are familiar with Kafka client internals and the Java programming language, but not necessarily other JVM languages or asynchronous runtimes. I think it's reasonable to ask for a code snippet o

[jira] [Resolved] (KAFKA-13431) Sink Connectors: Support topic-mutating SMTs for async connectors (preCommit users)

2023-07-21 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton resolved KAFKA-13431. --- Fix Version/s: 3.6.0 Resolution: Done > Sink Connectors: Support topic-mutating S

Re: [DISCUSS] KIP-949: Add flag to enable the usage of topic separator in MM2 DefaultReplicationPolicy

2023-07-21 Thread Chris Egerton
keep old mirrors using the old > internal topics. > > Hope this is reasonable for the time being. > > Cheers, > Omnia > > On Wed, Jul 19, 2023 at 11:16 PM Chris Egerton > wrote: > > > Hi Federico, > > > > Ah yes, sorry about that! You're correct t

[jira] [Resolved] (KAFKA-14669) Include MirrorMaker connector configurations in docs

2023-07-20 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton resolved KAFKA-14669. --- Resolution: Done > Include MirrorMaker connector configurations in d

Re: [DISCUSS] KIP-949: Add flag to enable the usage of topic separator in MM2 DefaultReplicationPolicy

2023-07-19 Thread Chris Egerton
IP says it would be a subclass of DefaultReplicationPolicy > that overrides the ReplicationPolicy.offsetSyncsTopic and > ReplicationPolicy.checkpointsTopic. So, not much to maintain and it would > be more intuitive, as you say. > > On Wed, Jul 19, 2023, 4:50 PM Chris Egerton > wrote:

Re: [DISCUSS] KIP-949: Add flag to enable the usage of topic separator in MM2 DefaultReplicationPolicy

2023-07-19 Thread Chris Egerton
Federico Valeri > wrote: > > > Hi, one way to avoid the "fix the bug property" would be to provide > > and document an additional LegacyReplicationPolicy, but still keeping > > the current DefaultReplicationPolicy as replication.policy.class > > default val

Re: [DISCUSS] KIP-949: Add flag to enable the usage of topic separator in MM2 DefaultReplicationPolicy

2023-07-18 Thread Chris Egerton
Omnia Ibrahim > > wrote: > > > > > > Hi Chris, I added a section for backport plan here > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-949%3A+Add+flag+to+enable+the+usage+of+topic+separator+in+MM2+DefaultReplicationPolicy#KIP949:Addflagtoenabletheusageofto

[jira] [Reopened] (KAFKA-14669) Include MirrorMaker connector configurations in docs

2023-07-18 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton reopened KAFKA-14669: --- > Include MirrorMaker connector configurations in d

[jira] [Resolved] (KAFKA-14669) Include MirrorMaker connector configurations in docs

2023-07-18 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton resolved KAFKA-14669. --- Fix Version/s: 3.6.0 Resolution: Done > Include MirrorMaker connector configurati

Re: [VOTE] 3.5.1 RC1

2023-07-17 Thread Chris Egerton
Hi Divij, Thanks for running this release! To verify, I: - Built from source using Java 11 with both: - - the 3.5.1-rc1 tag on GitHub - - the kafka-3.5.1-src.tgz artifact from https://home.apache.org/~divijv/kafka-3.5.1-rc1/ - Checked signatures and checksums - Ran the quickstart using the kafka_

Re: [DISCUSS] KIP-949: Add flag to enable the usage of topic separator in MM2 DefaultReplicationPolicy

2023-07-13 Thread Chris Egerton
IP as well or not? > > Also, I’ll open a vote for the KIP today and prepare the pr for it so we > can merge it as soon as we can. > > Thanks, > > Omnia > > On Wed, Jul 12, 2023 at 4:31 PM Chris Egerton > wrote: > > > Hi Omnia, > > > > Thanks for

Re: [DISCUSS] KIP-949: Add flag to enable the usage of topic separator in MM2 DefaultReplicationPolicy

2023-07-12 Thread Chris Egerton
ch versions can we backport these to? Usually, > Kafka supports bugfix releases as needed for the last 3 releases. Now we @ > 3.5 so the last 3 are 3.4, 3.3 and 3.2 is this correct? > 3. I'll add a Jira for updating the docs for this KIP so we don't forget > about it. >

[jira] [Resolved] (KAFKA-14059) Replace EasyMock and PowerMock with Mockito in WorkerSourceTaskTest

2023-07-10 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton resolved KAFKA-14059. --- Resolution: Done > Replace EasyMock and PowerMock with Mockito in WorkerSourceTaskT

Re: [DISCUSS] KIP-949: Add flag to enable the usage of topic separator in MM2 DefaultReplicationPolicy

2023-07-10 Thread Chris Egerton
Hi Omnia, Thanks for taking this on! I have some thoughts but the general approach looks good. 1. Default value One thing I'm wrestling with is what the default value of the new property should be. I know on the Jira ticket I proposed that it should be false, but I'm having second thoughts. Tech

[ANNOUNCE] New committer: Greg Harris

2023-07-10 Thread Chris Egerton
Hi all, The PMC for Apache Kafka has invited Greg Harris to become a committer, and we are happy to announce that he has accepted! Greg has been contributing to Kafka since 2019. He has made over 50 commits mostly around Kafka Connect and Mirror Maker 2. His most notable contributions include KIP

Re: Permission to contribute to Apache Kafka

2023-07-06 Thread Chris Egerton
Hi, Thanks for your interest in contributing! You should be all set to go now. Cheers, Chris On Thu, Jul 6, 2023 at 9:18 AM Jacob wrote: > Hi master, > > Could you help grant me permissions to contribute to Kafka? > > Wiki ID: zixuanbai > Jira ID: zixuan > > Thanks a lot! > > Best regards, >

Re: [DISCUSS] KIP-910: Update Source offsets for Source Connectors without producing records

2023-07-05 Thread Chris Egerton
never reached and the connector can't > > >>>> commit > > >>>> > offsets > > >>>> > >for that source partition(file). If there was a mechanism to > > >>>> update > > >>>> > offsets > > >>

Re: [VOTE] KIP-793: Allow sink connectors to be used with topic-mutating SMTs

2023-07-03 Thread Chris Egerton
Hi Yash, Thanks for the KIP! +1 (binding) Cheers, Chris On Mon, Jul 3, 2023 at 7:02 AM Yash Mayya wrote: > Hi all, > > I'd like to start a vote on KIP-793 which enables sink connector > implementations to be used with SMTs that mutate the topic / partition / > offset information of a record.

Re: [DISCUSS] KIP-793: Sink Connectors: Support topic-mutating SMTs for async connectors (preCommit users)

2023-06-29 Thread Chris Egerton
be affected by things like log compaction, control records > for transactional use cases etc.) right? Overall, I think that the only > benefit of the overloaded open / close methods approach is that the > framework can enable the eventual closure of any post-transform topic > partitio

Re: [DISCUSS] Apache Kafka 3.5.1 release

2023-06-28 Thread Chris Egerton
Thanks for volunteering, Divij! On Wed, Jun 28, 2023 at 7:52 AM Divij Vaidya wrote: > Hey folks > > Looks like we are ready to perform a release for 3.5.1 to provide a fix for > the vulnerability in snappy-java [1] > > I would like to volunteer as release manager for the 3.5.1 release. > > If th

Re: Permissions to contribute to Apache Kafka

2023-06-26 Thread Chris Egerton
Hi Erik, Thanks for contributing to Apache Kafka! You should be good to go now. I also took the liberty of assigning KAFKA-14972 to you; feel free to unassign if you do not plan to work on that ticket. Cheers, Chris On Mon, Jun 26, 2023 at 9:57 AM Erik van Oosten wrote: > Dear reader, > > I w

Re: Apache Kafka 3.6.0 release

2023-06-24 Thread Chris Egerton
Thanks Satish! On Sat, Jun 24, 2023 at 7:34 AM Satish Duggana wrote: > Thanks Chris for the update. I added KIP-875 to the 3.6.0 release plan > wiki. Please feel free to update it. > > ~Satish. > > On Fri, 23 Jun 2023 at 23:10, Chris Egerton > wrote: > > > > Hi

Re: Apache Kafka 3.6.0 release

2023-06-23 Thread Chris Egerton
Hi Satish, Could we add KIP-875 [1] to the release plan? It was partially released in 3.5.0 and mentioned in the release plan [2], and since the rest (APIs to reset and alter offsets for connectors) has now been merged to trunk, we can let people know that the remainder should be available in the

[jira] [Resolved] (KAFKA-4107) Support offset reset capability in Kafka Connect

2023-06-23 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-4107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton resolved KAFKA-4107. -- Resolution: Done > Support offset reset capability in Kafka Conn

Re: [ANNOUNCE] Apache Kafka 3.5.0

2023-06-15 Thread Chris Egerton
ache Kafka is in use at large and small companies worldwide, > including > > > Capital One, Goldman Sachs, ING, LinkedIn, Netflix, Pinterest, > Rabobank, > > > Target, The New York Times, Uber, Yelp, and Zalando, among others. > > > > > > A big th

[jira] [Created] (KAFKA-15091) Javadocs for SourceTask::commit are incorrect

2023-06-14 Thread Chris Egerton (Jira)
Chris Egerton created KAFKA-15091: - Summary: Javadocs for SourceTask::commit are incorrect Key: KAFKA-15091 URL: https://issues.apache.org/jira/browse/KAFKA-15091 Project: Kafka Issue Type

[jira] [Created] (KAFKA-15090) Source tasks are no longer stopped on a separate thread

2023-06-14 Thread Chris Egerton (Jira)
Chris Egerton created KAFKA-15090: - Summary: Source tasks are no longer stopped on a separate thread Key: KAFKA-15090 URL: https://issues.apache.org/jira/browse/KAFKA-15090 Project: Kafka

Re: [ANNOUNCE] New committer: Divij Vaidya

2023-06-14 Thread Chris Egerton
Congrats, Divij! On Wed, Jun 14, 2023 at 9:06 AM Edoardo Comar wrote: > Congratulations Divij ! > > > On Wed, 14 Jun 2023 at 10:51, Josep Prat > wrote: > > > Congrats Divij! > > > > On Wed, Jun 14, 2023 at 11:45 AM Lucas Brutschy > > wrote: > > > > > Congrats!! > > > > > > On Wed, Jun 14, 2023

Re: [DISCUSS] Conventional commits

2023-06-08 Thread Chris Egerton
Hi Ismael, I haven't worked on too many projects with conventional commits before, so forgive my ignorance. Could you share some of the advantages of this style of commit message over the existing style? Cheers, Chris On Thu, Jun 8, 2023 at 12:34 PM Ismael Juma wrote: > Hi Josep and Bruno, >

Re: [DISCUSS] Partial CI builds - Reducing flakiness with fewer tests

2023-06-07 Thread Chris Egerton
Hi Greg, I can see the point about enabling partial runs as a temporary measure to fight flakiness, and it does carry some merit. In that case, though, we should have an idea of what the desired end state is once we've stopped relying on any temporary measures. Do you think we should aim to disabl

Re: [ANNOUNCE] Apache Kafka 3.4.1

2023-06-06 Thread Chris Egerton
lications. > > ** Building real-time streaming applications that transform or react > to the streams of data. > > Apache Kafka is in use at large and small companies worldwide, > including Capital One, Goldman Sachs, ING, LinkedIn, Netflix, > Pinterest, Rabobank, Target, The N

Re: [DISCUSS] Regarding Old PRs

2023-06-06 Thread Chris Egerton
Hi Josep, Thanks for bringing this up! Will try to keep things brief. I'm generally in favor of this initiative. A couple ideas that I really liked: requiring a component label (producer, consumer, connect, streams, etc.) before closing, and disabling auto-close (i.e., automatically tagging PRs a

Re: [DISCUSS] KIP-918: MM2 Topic And Group Listener

2023-06-06 Thread Chris Egerton
Hi Daniel, Thanks for the KIP! I see the value in exposing information on replicated topics and groups. For one, it matches a similar feature added to Kafka Connect in KIP-558 [1], where we started tracking the set of topics that connectors interacted with over their lifetime. And there's also the

[jira] [Created] (KAFKA-15059) Exactly-once source tasks fail to start during pending rebalances

2023-06-05 Thread Chris Egerton (Jira)
Chris Egerton created KAFKA-15059: - Summary: Exactly-once source tasks fail to start during pending rebalances Key: KAFKA-15059 URL: https://issues.apache.org/jira/browse/KAFKA-15059 Project: Kafka

Re: [DISCUSS] KIP-916: MM2 distributed mode flow log context

2023-06-05 Thread Chris Egerton
; > > > Thank you for your comments! > > > > I agree that the toString based logging is not ideal, and I believe all > > occurrences are within a proper logging context, so they can be ignored. > > If thread names can be changed unconditionally, I agree, using a

Re: [DISCUSS] KIP-916: MM2 distributed mode flow log context

2023-06-02 Thread Chris Egerton
Hi Daniel, Are there any cases of Object::toString being used by internal classes for logging context that can't be covered by MDC contexts? For example, anything logged by WorkerSinkTask (or any WorkerTask subclass) already has the MDC set for the task [1]. Since the Object::toString-prefixed sty

[jira] [Resolved] (KAFKA-15012) JsonConverter fails when there are leading Zeros in a field

2023-06-02 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton resolved KAFKA-15012. --- Fix Version/s: 3.6.0 Resolution: Fixed > JsonConverter fails when there are lead

[jira] [Resolved] (KAFKA-14863) Plugins which do not have a valid no-args constructor are visible in the REST API

2023-06-02 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14863?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton resolved KAFKA-14863. --- Fix Version/s: 3.6.0 Resolution: Fixed > Plugins which do not have a valid no-a

Re: [VOTE] 3.4.1 RC3

2023-05-30 Thread Chris Egerton
Hi Luke, Many thanks for your continued work on this release! To verify, I: - Built from source using Java 11 with both: - - the 3.4.1-rc3 tag on GitHub - - the kafka-3.4.1-src.tgz artifact from https://home.apache.org/~showuon/kafka-3.4.1-rc3/ - Checked signatures and checksums - Ran the quickst

Re: [VOTE] 3.4.1 RC2

2023-05-24 Thread Chris Egerton
Hi Luke, Thanks again for running this release! Echoing your hopes that this will be the final 3.4.1 release candidate :) To verify, I: - Built from source with Java 11 with both: - - the 3.4.1-rc2 tag on GitHub - - the kafka-3.4.1-src.tgz artifact from https://home.apache.org/~showuon/kafka-3.4.

[jira] [Created] (KAFKA-15018) Potential tombstone offsets corruption for exactly-once source connectors

2023-05-23 Thread Chris Egerton (Jira)
Chris Egerton created KAFKA-15018: - Summary: Potential tombstone offsets corruption for exactly-once source connectors Key: KAFKA-15018 URL: https://issues.apache.org/jira/browse/KAFKA-15018 Project

Re: [DISCUSS] KIP-916: MM2 distributed mode flow log context

2023-05-22 Thread Chris Egerton
Hi Daniel, Thanks for the KIP! A few thoughts: 1. This change is similar to when we added connector contexts to Connect in KIPs 449 [1] and 721 [2]. I wonder if we can follow a similar approach (combining both KIPs' changes into this single one), by doing the following: - Disabling the changes in

Re: [VOTE] 3.4.1 RC1

2023-05-22 Thread Chris Egerton
Hi Luke, Thanks for running the release! Steps I took to verify: - Built from source with Java 11 - Checked signatures and checksums - Ran the quickstart with Java 11 in KRaft mode - Ran all unit tests - - The org.apache.kafka.common.utils.UtilsTest.testToLogDateTimeDormat test case failed consi

Re: [DISCUSS] KIP-793: Sink Connectors: Support topic-mutating SMTs for async connectors (preCommit users)

2023-05-22 Thread Chris Egerton
t; > transformation > > > > chain as being in "virtual partitions" with "virtual offsets". > > > > For example, with identity-routing SMTs, the virtual coordinates are > > > > exactly the same as the underlying physical coordinates. For 1-1

Re: Feature Discussion: Enhancing Kafka Connect's transformation interface to 1 -> Many / Many -> Many

2023-05-16 Thread Chris Egerton
Hi Rabin, I like this idea but it presents challenges for delivery semantics, especially (though not exclusively) with sink connectors. If a sink connector uses the SinkTask::preCommit method [1] to explicitly notify the Connect runtime about which offsets are safe to commit, it may mistakenly re

Re: Apache Kafka 3.6.0 release

2023-04-17 Thread Chris Egerton
Thanks Satish, +1! On Mon, Apr 17, 2023 at 5:09 AM Bruno Cadonna wrote: > Thanks Satish! > > +1 > > Best, > Bruno > > On 16.04.23 20:02, Ismael Juma wrote: > > Thanks for volunteering Satish. +1. > > > > Ismael > > > > On Sun, Apr 16, 2023 at 10:08 AM Satish Duggana < > satish.dugg...@gmail.com>

Re: [DISCUSS] Apache Kafka 3.5.0 release

2023-04-17 Thread Chris Egerton
>>>>>>> KIP Freeze was yesterday. The next milestone is feature > >>>>>> freeze on > >>>>>>>>>> April > >>>>>>>>>>>>> 12. > >>>>>>>>>

Re: [VOTE] KIP-875: First-class offsets support in Kafka Connect

2023-04-12 Thread Chris Egerton
gt; producer instantiated for altering offsets? > > Thanks, > Yash > > On Wed, Apr 12, 2023 at 9:02 PM Chris Egerton wrote: > > > Hi Greg, > > > > I hadn't considered the implications W/R/T zombie fencing. I agree that > > using the transactional ID for ta

Re: [DISCUSS] KIP-910: Update Source offsets for Source Connectors without producing records

2023-04-12 Thread Chris Egerton
once > we get SourceRecords, then the rest of the code is already in place to > write it to a topic of interest and commit offsets and that seemed the most > non invasive in terms of framework level changes. If in the future we want > to do a framework-only heartbeat record support, then t

Re: [VOTE] KIP-875: First-class offsets support in Kafka Connect

2023-04-12 Thread Chris Egerton
27;s relevant right now. Let me know if there are any other ways that the > connector transaction ID would be useful. > > Thanks for all the effort on this feature! > Greg > > On Tue, Apr 11, 2023 at 7:52 AM Chris Egerton > wrote: > > > Hi all, > > &g

Re: [VOTE] KIP-875: First-class offsets support in Kafka Connect

2023-04-11 Thread Chris Egerton
lly running. Discussed in [2]. [1] - https://github.com/apache/kafka/pull/13465/#issuecomment-1486718538 [2] - https://github.com/apache/kafka/pull/13465/#discussion_r1159694956 Cheers, Chris On Fri, Mar 3, 2023 at 10:22 AM Chris Egerton wrote: > Hi all, > > Thanks for the votes! I&#

[jira] [Resolved] (KAFKA-14783) Implement new STOPPED state for connectors

2023-04-11 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton resolved KAFKA-14783. --- Fix Version/s: 3.5.0 Resolution: Done > Implement new STOPPED state for connect

[jira] [Resolved] (KAFKA-14838) MM2 Worker/Connector/Task clients should specify client ID based on flow and role

2023-03-31 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14838?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton resolved KAFKA-14838. --- Resolution: Done > MM2 Worker/Connector/Task clients should specify client ID based on f

[jira] [Reopened] (KAFKA-14838) MM2 Worker/Connector/Task clients should specify client ID based on flow and role

2023-03-31 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14838?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton reopened KAFKA-14838: --- > MM2 Worker/Connector/Task clients should specify client ID based on flow and >

[jira] [Resolved] (KAFKA-14843) Connector plugins config endpoint does not include Common configs

2023-03-28 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton resolved KAFKA-14843. --- Fix Version/s: 3.5.0 Resolution: Fixed > Connector plugins config endpoint does

Re: [DISCUSS] KIP-910: Update Source offsets for Source Connectors without producing records

2023-03-28 Thread Chris Egerton
Hi Sagar, Thanks for the KIP! I have some thoughts. Nits: 1. Shouldn't KAFKA-3821 [1] be linked as the Jira ticket on the KIP? Or is there a different ticket that should be associated with it? 2. The current state is listed as "Draft". Considering it's been brought up for discussion, maybe the K

[jira] [Resolved] (KAFKA-14842) MirrorCheckpointTask can reduce the rpc calls of "listConsumerGroupOffsets(group)" of irrelevant groups at each poll

2023-03-28 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton resolved KAFKA-14842. --- Fix Version/s: 3.5.0 Resolution: Done > MirrorCheckpointTask can reduce the

[jira] [Created] (KAFKA-14858) Standalone herder does not handle exceptions thrown from connector taskConfigs method

2023-03-28 Thread Chris Egerton (Jira)
Chris Egerton created KAFKA-14858: - Summary: Standalone herder does not handle exceptions thrown from connector taskConfigs method Key: KAFKA-14858 URL: https://issues.apache.org/jira/browse/KAFKA-14858

<    1   2   3   4   5   6   7   8   >