Re: Review Request 34170: Patch for KAFKA-2191

2015-05-14 Thread Dong Lin
agree you'll get discontinuities as the > > measured time shrinks to zero but why is giving back 0 the right answer? In > > the case you guys were testing 0 was safe, but imagine a case where the > > monitoring was checking that the value didn't fall below some threshold.

Re: Review Request 34170: Patch for KAFKA-2191

2015-05-13 Thread Dong Lin
y, visit: https://reviews.apache.org/r/34170/#review83687 --- On May 13, 2015, 10:32 p.m., Dong Lin wrote: > > --- > This is an automatically generated e-mail. To

Re: Review Request 34170: Patch for KAFKA-2191

2015-05-13 Thread Dong Lin
agree you'll get discontinuities as the > > measured time shrinks to zero but why is giving back 0 the right answer? In > > the case you guys were testing 0 was safe, but imagine a case where the > > monitoring was checking that the value didn't fall below some threshold.

[jira] [Commented] (KAFKA-2191) Measured rate should not be infinite

2015-05-13 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14542851#comment-14542851 ] Dong Lin commented on KAFKA-2191: - Updated reviewboard https://reviews.apache.org/r/3

[jira] [Updated] (KAFKA-2191) Measured rate should not be infinite

2015-05-13 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated KAFKA-2191: Attachment: KAFKA-2191_2015-05-13_15:32:15.patch > Measured rate should not be infin

Re: Review Request 34170: Patch for KAFKA-2191

2015-05-13 Thread Dong Lin
/main/java/org/apache/kafka/common/metrics/stats/SampledStat.java b341b7daaa10204906d78b812fb05fd27bc69373 Diff: https://reviews.apache.org/r/34170/diff/ Testing --- Thanks, Dong Lin

Re: Review Request 34170: Patch for KAFKA-2191

2015-05-13 Thread Dong Lin
you think is the best? Thank you. - Dong --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34170/#review83629 --- On May 13, 2015, 3:

[jira] [Commented] (KAFKA-2191) Measured rate should not be infinite

2015-05-13 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14542135#comment-14542135 ] Dong Lin commented on KAFKA-2191: - Created reviewboard https://reviews.apache.org/r/3

[jira] [Updated] (KAFKA-2191) Measured rate should not be infinite

2015-05-13 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated KAFKA-2191: Attachment: KAFKA-2191.patch > Measured rate should not be infin

[jira] [Updated] (KAFKA-2191) Measured rate should not be infinite

2015-05-13 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated KAFKA-2191: Status: Patch Available (was: Open) > Measured rate should not be infin

Review Request 34170: Patch for KAFKA-2191

2015-05-13 Thread Dong Lin
/stats/SampledStat.java b341b7daaa10204906d78b812fb05fd27bc69373 Diff: https://reviews.apache.org/r/34170/diff/ Testing --- Thanks, Dong Lin

[jira] [Created] (KAFKA-2191) Measured rate should not be infinite

2015-05-12 Thread Dong Lin (JIRA)
Dong Lin created KAFKA-2191: --- Summary: Measured rate should not be infinite Key: KAFKA-2191 URL: https://issues.apache.org/jira/browse/KAFKA-2191 Project: Kafka Issue Type: Bug

Re: Review Request 33378: Patch for KAFKA-2136

2015-05-12 Thread Dong Lin
tps://reviews.apache.org/r/33378/#comment134427> Will readFromLocalLog() read data into memory before the cilent's quota is checked? - Dong Lin On May 11, 2015, 9:51 p.m., Aditya Auradkar wrote: > > --- > This is an autom

Re: Review Request 33049: Patch for KAFKA-2084

2015-05-12 Thread Dong Lin
first quota violaation, and calculate delayTime based on this violation. Should we enumerate all metric in this.metrics() and set delayTime of the QuotaViolationException to be the largest delayTime of all violatoins? - Dong Lin On May 11, 2015, 11:17 p.m., Aditya Au

Re: Review Request 33557: Patch for KAFKA-1936

2015-05-12 Thread Dong Lin
I have renamed these functions. Thank you. - Dong --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33557/#review83398 ---------

[jira] [Updated] (KAFKA-1936) Track offset commit requests separately from produce requests

2015-05-12 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated KAFKA-1936: Attachment: KAFKA-1936_2015-05-12_08:02:32.patch > Track offset commit requests separately from prod

[jira] [Commented] (KAFKA-1936) Track offset commit requests separately from produce requests

2015-05-12 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14539974#comment-14539974 ] Dong Lin commented on KAFKA-1936: - Updated reviewboard https://reviews.apache.org/r/3

Re: Review Request 33557: Patch for KAFKA-1936

2015-05-12 Thread Dong Lin
/unit/kafka/server/OffsetCommitTest.scala 528525b719ec916e16f8b3ae3715bec4b5dcc47d Diff: https://reviews.apache.org/r/33557/diff/ Testing --- Thanks, Dong Lin

Re: Review Request 33557: Patch for KAFKA-1936

2015-05-12 Thread Dong Lin
-mail. To reply, visit: https://reviews.apache.org/r/33557/#review83234 --- On May 12, 2015, 2:32 p.m., Dong Lin wrote: > > --- > This is an automatically generated e-mail. To

[jira] [Commented] (KAFKA-1936) Track offset commit requests separately from produce requests

2015-05-12 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14539906#comment-14539906 ] Dong Lin commented on KAFKA-1936: - Updated reviewboard https://reviews.apache.org/r/3

[jira] [Updated] (KAFKA-1936) Track offset commit requests separately from produce requests

2015-05-12 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated KAFKA-1936: Attachment: KAFKA-1936_2015-05-12_07:32:07.patch > Track offset commit requests separately from prod

Re: Review Request 33557: Patch for KAFKA-1936

2015-05-12 Thread Dong Lin
/test/scala/unit/kafka/server/OffsetCommitTest.scala 528525b719ec916e16f8b3ae3715bec4b5dcc47d Diff: https://reviews.apache.org/r/33557/diff/ Testing --- Thanks, Dong Lin

Re: Review Request 33378: Patch for KAFKA-2136

2015-05-11 Thread Dong Lin
tps://reviews.apache.org/r/33378/#comment134302> Should delayTimeSize be deducted from expectedBytesToWrite? - Dong Lin On May 11, 2015, 9:51 p.m., Aditya Auradkar wrote: > > --- > This is an automatically generated e-mail.

[jira] [Created] (KAFKA-2171) System Test for Quotas

2015-05-05 Thread Dong Lin (JIRA)
Dong Lin created KAFKA-2171: --- Summary: System Test for Quotas Key: KAFKA-2171 URL: https://issues.apache.org/jira/browse/KAFKA-2171 Project: Kafka Issue Type: Sub-task Reporter: Dong

Re: Review Request 33557: Patch for KAFKA-1936

2015-05-04 Thread Dong Lin
-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33557/#review82392 ------- On May 4, 2015, 10:18 p.m., Dong Lin wrote: > >

Re: Review Request 33557: Patch for KAFKA-1936

2015-05-04 Thread Dong Lin
/test/scala/unit/kafka/server/OffsetCommitTest.scala 652208a70f66045b854549d93cbbc2b77c24b10b Diff: https://reviews.apache.org/r/33557/diff/ Testing --- Thanks, Dong Lin

[jira] [Updated] (KAFKA-1936) Track offset commit requests separately from produce requests

2015-05-04 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated KAFKA-1936: Attachment: KAFKA-1936_2015-05-04_15:17:50.patch > Track offset commit requests separately from prod

[jira] [Commented] (KAFKA-1936) Track offset commit requests separately from produce requests

2015-05-04 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14527454#comment-14527454 ] Dong Lin commented on KAFKA-1936: - Updated reviewboard https://reviews.apache.org/r/3

[jira] [Commented] (KAFKA-2084) byte rate metrics per client ID (producer and consumer)

2015-04-30 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14522757#comment-14522757 ] Dong Lin commented on KAFKA-2084: - Here is my 2 cents. I vote for your 2nd appr

[jira] [Commented] (KAFKA-2103) kafka.producer.AsyncProducerTest failure.

2015-04-27 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14514983#comment-14514983 ] Dong Lin commented on KAFKA-2103: - This test case fails because a local proces

[jira] [Commented] (KAFKA-2103) kafka.producer.AsyncProducerTest failure.

2015-04-26 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14513558#comment-14513558 ] Dong Lin commented on KAFKA-2103: - Of course. Let me work on this ti

[jira] [Updated] (KAFKA-1936) Track offset commit requests separately from produce requests

2015-04-26 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated KAFKA-1936: Attachment: KAFKA-1936_2015-04-26_21:26:34.patch > Track offset commit requests separately from prod

[jira] [Commented] (KAFKA-1936) Track offset commit requests separately from produce requests

2015-04-26 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14513508#comment-14513508 ] Dong Lin commented on KAFKA-1936: - Updated reviewboard https://reviews.apache.org/r/3

Re: Review Request 33557: Patch for KAFKA-1936

2015-04-26 Thread Dong Lin
- On April 27, 2015, 4:26 a.m., Dong Lin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33557/ > --

Re: Review Request 33557: Patch for KAFKA-1936

2015-04-26 Thread Dong Lin
://reviews.apache.org/r/33557/diff/ Testing --- Thanks, Dong Lin

[jira] [Updated] (KAFKA-1936) Track offset commit requests separately from produce requests

2015-04-26 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated KAFKA-1936: Attachment: KAFKA-1936_2015-04-26_21:20:28.patch > Track offset commit requests separately from prod

[jira] [Commented] (KAFKA-1936) Track offset commit requests separately from produce requests

2015-04-26 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14513503#comment-14513503 ] Dong Lin commented on KAFKA-1936: - Updated reviewboard https://reviews.apache.org/r/3

Re: Review Request 33557: Patch for KAFKA-1936

2015-04-26 Thread Dong Lin
://reviews.apache.org/r/33557/diff/ Testing --- Thanks, Dong Lin

[jira] [Commented] (KAFKA-1936) Track offset commit requests separately from produce requests

2015-04-25 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14512768#comment-14512768 ] Dong Lin commented on KAFKA-1936: - Created reviewboard https://reviews.apache.org/r/3

[jira] [Updated] (KAFKA-1936) Track offset commit requests separately from produce requests

2015-04-25 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated KAFKA-1936: Status: Patch Available (was: Open) > Track offset commit requests separately from produce reque

[jira] [Updated] (KAFKA-1936) Track offset commit requests separately from produce requests

2015-04-25 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated KAFKA-1936: Attachment: KAFKA-1936.patch > Track offset commit requests separately from produce reque

Review Request 33557: Patch for KAFKA-1936

2015-04-25 Thread Dong Lin
8ddd325015de4245fd2cf500d8b0e8c1fd2bc7e8 core/src/test/scala/unit/kafka/server/OffsetCommitTest.scala 652208a70f66045b854549d93cbbc2b77c24b10b Diff: https://reviews.apache.org/r/33557/diff/ Testing --- Thanks, Dong Lin

[jira] [Commented] (KAFKA-1936) Track offset commit requests separately from produce requests

2015-04-24 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14511392#comment-14511392 ] Dong Lin commented on KAFKA-1936: - Thanks! I will work on this ticket. On Fri, Ap

Re: Review Request 24992: Patch for KAFKA-1609

2014-08-22 Thread Dong Lin
------- On Aug. 22, 2014, 11:22 p.m., Dong Lin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24992/ > ---

[jira] [Commented] (KAFKA-1609) New producer metadata response handling should only exclude a PartitionInfo when its error is LEADER_NOT_AVAILABLE

2014-08-22 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14107690#comment-14107690 ] Dong Lin commented on KAFKA-1609: - Updated reviewboard https://reviews.apache.org/r/2

Re: Review Request 24992: Patch for KAFKA-1609

2014-08-22 Thread Dong Lin
/requests/MetadataResponse.java 7d90fceffd4a92460c616f8bacd78057a38a3c16 Diff: https://reviews.apache.org/r/24992/diff/ Testing --- Thanks, Dong Lin

[jira] [Updated] (KAFKA-1609) New producer metadata response handling should only exclude a PartitionInfo when its error is LEADER_NOT_AVAILABLE

2014-08-22 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated KAFKA-1609: Attachment: KAFKA-1609_2014-08-22_16:22:00.patch > New producer metadata response handling should o

Re: Review Request 24992: Patch for KAFKA-1609

2014-08-22 Thread Dong Lin
---------- On Aug. 22, 2014, 8:04 p.m., Dong Lin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24992/ > ---

Re: Review Request 24992: Patch for KAFKA-1609

2014-08-22 Thread Dong Lin
-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24992/#review51317 ------- On Aug. 22, 2014, 8:04 p.m., Dong Lin wrote: > >

[jira] [Updated] (KAFKA-1609) New producer metadata response handling should only exclude a PartitionInfo when its error is LEADER_NOT_AVAILABLE

2014-08-22 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated KAFKA-1609: Attachment: KAFKA-1609_2014-08-22_13:04:10.patch > New producer metadata response handling should o

[jira] [Commented] (KAFKA-1609) New producer metadata response handling should only exclude a PartitionInfo when its error is LEADER_NOT_AVAILABLE

2014-08-22 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14107402#comment-14107402 ] Dong Lin commented on KAFKA-1609: - Updated reviewboard https://reviews.apache.org/r/2

Re: Review Request 24992: Patch for KAFKA-1609

2014-08-22 Thread Dong Lin
/kafka/common/requests/MetadataResponse.java 7d90fceffd4a92460c616f8bacd78057a38a3c16 Diff: https://reviews.apache.org/r/24992/diff/ Testing --- Thanks, Dong Lin

Re: Review Request 24992: Patch for KAFKA-1609

2014-08-22 Thread Dong Lin
/requests/MetadataResponse.java 7d90fceffd4a92460c616f8bacd78057a38a3c16 Diff: https://reviews.apache.org/r/24992/diff/ Testing --- Thanks, Dong Lin

[jira] [Updated] (KAFKA-1609) Metadata response should only exclude a PartitionInfo when its error is LEADER_NOT_AVAILABLE

2014-08-22 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated KAFKA-1609: Status: Patch Available (was: Open) > Metadata response should only exclude a PartitionInfo when

[jira] [Commented] (KAFKA-1609) Metadata response should only exclude a PartitionInfo when its error is LEADER_NOT_AVAILABLE

2014-08-22 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14107390#comment-14107390 ] Dong Lin commented on KAFKA-1609: - Created reviewboard https://reviews.apache.org/r/2

[jira] [Updated] (KAFKA-1609) Metadata response should only exclude a PartitionInfo when its error is LEADER_NOT_AVAILABLE

2014-08-22 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated KAFKA-1609: Attachment: KAFKA-1609.patch > Metadata response should only exclude a PartitionInfo when its error

Review Request 24992: Patch for KAFKA-1609

2014-08-22 Thread Dong Lin
7d90fceffd4a92460c616f8bacd78057a38a3c16 Diff: https://reviews.apache.org/r/24992/diff/ Testing --- Thanks, Dong Lin

[jira] [Created] (KAFKA-1609) Metadata response should only exclude a PartitionInfo when its error is LEADER_NOT_AVAILABLE

2014-08-22 Thread Dong Lin (JIRA)
Dong Lin created KAFKA-1609: --- Summary: Metadata response should only exclude a PartitionInfo when its error is LEADER_NOT_AVAILABLE Key: KAFKA-1609 URL: https://issues.apache.org/jira/browse/KAFKA-1609

[jira] [Commented] (KAFKA-1601) ConsoleConsumer/SimpleConsumerPerformance should be transaction-aware

2014-08-20 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14104065#comment-14104065 ] Dong Lin commented on KAFKA-1601: - Updated reviewboard https://reviews.apache.org/r/2

[jira] [Updated] (KAFKA-1601) ConsoleConsumer/SimpleConsumerPerformance should be transaction-aware

2014-08-20 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated KAFKA-1601: Attachment: KAFKA-1601_2014-08-20_08:57:29.patch > ConsoleConsumer/SimpleConsumerPerformance should

Re: Review Request 24856: Patch for KAFKA-1601

2014-08-20 Thread Dong Lin
: https://reviews.apache.org/r/24856/diff/ Testing --- Thanks, Dong Lin

[jira] [Updated] (KAFKA-1604) System Test for Transaction Management

2014-08-19 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1604?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated KAFKA-1604: Attachment: (was: KAFKA-1604_2014-08-19_17:28:19.patch) > System Test for Transaction Managem

Re: Review Request 24856: Patch for KAFKA-1601

2014-08-19 Thread Dong Lin
ically generated e-mail. To reply, visit: https://reviews.apache.org/r/24856/#review51050 ------- On Aug. 20, 2014, 4:10 a.m., Dong Lin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.o

[jira] [Updated] (KAFKA-1601) ConsoleConsumer/SimpleConsumerPerformance should be transaction-aware

2014-08-19 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated KAFKA-1601: Attachment: KAFKA-1601_2014-08-19_21:10:12.patch > ConsoleConsumer/SimpleConsumerPerformance should

[jira] [Commented] (KAFKA-1601) ConsoleConsumer/SimpleConsumerPerformance should be transaction-aware

2014-08-19 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14103346#comment-14103346 ] Dong Lin commented on KAFKA-1601: - Updated reviewboard https://reviews.apache.org/r/2

Re: Review Request 24856: Patch for KAFKA-1601

2014-08-19 Thread Dong Lin
: https://reviews.apache.org/r/24856/diff/ Testing --- Thanks, Dong Lin

[jira] [Commented] (KAFKA-1604) System Test for Transaction Management

2014-08-19 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14103343#comment-14103343 ] Dong Lin commented on KAFKA-1604: - Updated reviewboard https://reviews.apache.org/r/2

[jira] [Updated] (KAFKA-1604) System Test for Transaction Management

2014-08-19 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1604?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated KAFKA-1604: Attachment: KAFKA-1604_2014-08-19_21:07:35.patch > System Test for Transaction Managem

Re: Review Request 24874: Patch for KAFKA-1604

2014-08-19 Thread Dong Lin
/kafka_system_test_utils.py 6edd64a92ce749421b5ab60fbea5b55e2ccbfe94 Diff: https://reviews.apache.org/r/24874/diff/ Testing --- Thanks, Dong Lin

Re: Review Request 24874: Patch for KAFKA-1601

2014-08-19 Thread Dong Lin
323fc8566d974acc4e5c7d7c2a065794f3b5df4a core/src/main/scala/kafka/tools/SimpleConsumerPerformance.scala 7602b8d705970a5dab49ed36d117346a960701ac Diff: https://reviews.apache.org/r/24874/diff/ Testing --- Thanks, Dong Lin

[jira] [Commented] (KAFKA-1565) Transaction manager failover handling

2014-08-19 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14103232#comment-14103232 ] Dong Lin commented on KAFKA-1565: - Sure. The JIRA is closed. > Transaction

[jira] [Closed] (KAFKA-1582) System Test should wait for producer to finish

2014-08-19 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin closed KAFKA-1582. --- > System Test should wait for producer to fin

[jira] [Closed] (KAFKA-1550) Patch review tool should use git format-patch to generate patch

2014-08-19 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1550?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin closed KAFKA-1550. --- > Patch review tool should use git format-patch to generate pa

[jira] [Closed] (KAFKA-1565) Transaction manager failover handling

2014-08-19 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin closed KAFKA-1565. --- Merged into KAFKA-1523: Implement transaction manager module > Transaction manager failover handl

[jira] [Resolved] (KAFKA-1565) Transaction manager failover handling

2014-08-19 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin resolved KAFKA-1565. - Resolution: Duplicate Merged into KAFKA-1523: Implement transaction manager module. > Transact

[jira] [Updated] (KAFKA-1523) Implement transaction manager module

2014-08-19 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated KAFKA-1523: Description: * Entry point for transaction requests * Appends transaction control records to the

[jira] [Commented] (KAFKA-1604) System Test for Transaction Management

2014-08-19 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14103141#comment-14103141 ] Dong Lin commented on KAFKA-1604: - Updated reviewboard https://reviews.apache.org/r/2

[jira] [Updated] (KAFKA-1604) System Test for Transaction Management

2014-08-19 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1604?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated KAFKA-1604: Attachment: KAFKA-1604_2014-08-19_17:31:16.patch > System Test for Transaction Managem

Re: Review Request 24874: Patch for KAFKA-1604

2014-08-19 Thread Dong Lin
6edd64a92ce749421b5ab60fbea5b55e2ccbfe94 Diff: https://reviews.apache.org/r/24874/diff/ Testing --- Thanks, Dong Lin

[jira] [Updated] (KAFKA-1604) System Test for Transaction Management

2014-08-19 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1604?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated KAFKA-1604: Attachment: KAFKA-1604_2014-08-19_17:28:19.patch > System Test for Transaction Managem

[jira] [Commented] (KAFKA-1604) System Test for Transaction Management

2014-08-19 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14103136#comment-14103136 ] Dong Lin commented on KAFKA-1604: - Created reviewboard https://reviews.apache.org/r/2

[jira] [Commented] (KAFKA-1604) System Test for Transaction Management

2014-08-19 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14103137#comment-14103137 ] Dong Lin commented on KAFKA-1604: - Updated reviewboard https://reviews.apache.org/r/2

Re: Review Request 24874: Patch for KAFKA-1604

2014-08-19 Thread Dong Lin
/tools/SimpleConsumerPerformance.scala 7602b8d705970a5dab49ed36d117346a960701ac Diff: https://reviews.apache.org/r/24874/diff/ Testing --- Thanks, Dong Lin

Re: Review Request 24874: Patch for KAFKA-1604

2014-08-19 Thread Dong Lin
7602b8d705970a5dab49ed36d117346a960701ac Diff: https://reviews.apache.org/r/24874/diff/ Testing --- Thanks, Dong Lin

Re: Review Request 24874: Patch for KAFKA-1601

2014-08-19 Thread Dong Lin
://reviews.apache.org/r/24874/diff/ Testing --- Thanks, Dong Lin

[jira] [Updated] (KAFKA-1601) ConsoleConsumer/SimpleConsumerPerformance should be transaction-aware

2014-08-19 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated KAFKA-1601: Attachment: (was: KAFKA-1601.patch) > ConsoleConsumer/SimpleConsumerPerformance should be transact

[jira] [Commented] (KAFKA-1601) ConsoleConsumer/SimpleConsumerPerformance should be transaction-aware

2014-08-19 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14103123#comment-14103123 ] Dong Lin commented on KAFKA-1601: - Created reviewboard https://reviews.apache.org/r/2

[jira] [Updated] (KAFKA-1601) ConsoleConsumer/SimpleConsumerPerformance should be transaction-aware

2014-08-19 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated KAFKA-1601: Attachment: KAFKA-1601.patch > ConsoleConsumer/SimpleConsumerPerformance should be transaction-aw

[jira] [Issue Comment Deleted] (KAFKA-1601) ConsoleConsumer/SimpleConsumerPerformance should be transaction-aware

2014-08-19 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated KAFKA-1601: Comment: was deleted (was: Created reviewboard https://reviews.apache.org/r/24874/diff/ against branch

Review Request 24874: Patch for KAFKA-1601

2014-08-19 Thread Dong Lin
/diff/ Testing --- Thanks, Dong Lin

[jira] [Created] (KAFKA-1604) System Test for Transaction Management

2014-08-19 Thread Dong Lin (JIRA)
Dong Lin created KAFKA-1604: --- Summary: System Test for Transaction Management Key: KAFKA-1604 URL: https://issues.apache.org/jira/browse/KAFKA-1604 Project: Kafka Issue Type: Test

[jira] [Updated] (KAFKA-1601) ConsoleConsumer/SimpleConsumerPerformance should be transaction-aware

2014-08-19 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated KAFKA-1601: Description: Implement buffered consumer logic in ConsumerTransactionBuffer class. The class takes as

[jira] [Updated] (KAFKA-1601) ConsoleConsumer/SimpleConsumerPerformance should be transaction-aware

2014-08-19 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated KAFKA-1601: Description: Implement buffered consumer logic in ConsumerTransactionBuffer class. The class takes as

[jira] [Commented] (KAFKA-1601) ConsoleConsumer/SimpleConsumerPerformance should be transaction-aware

2014-08-19 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14102540#comment-14102540 ] Dong Lin commented on KAFKA-1601: - Created reviewboard https://reviews.apache.org/r/2

[jira] [Updated] (KAFKA-1601) ConsoleConsumer/SimpleConsumerPerformance should be transaction-aware

2014-08-19 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated KAFKA-1601: Attachment: KAFKA-1601.patch > ConsoleConsumer/SimpleConsumerPerformance should be transaction-aw

Review Request 24856: Patch for KAFKA-1601

2014-08-19 Thread Dong Lin
/diff/ Testing --- Thanks, Dong Lin

[jira] [Updated] (KAFKA-1601) ConsoleConsumer/SimpleConsumerPerformance should be transaction-aware

2014-08-19 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated KAFKA-1601: Assignee: Dong Lin > ConsoleConsumer/SimpleConsumerPerformance should be transaction-aw

[jira] [Created] (KAFKA-1601) ConsoleConsumer/SimpleConsumerPerformance should be transaction-aware

2014-08-19 Thread Dong Lin (JIRA)
Dong Lin created KAFKA-1601: --- Summary: ConsoleConsumer/SimpleConsumerPerformance should be transaction-aware Key: KAFKA-1601 URL: https://issues.apache.org/jira/browse/KAFKA-1601 Project: Kafka

[jira] [Updated] (KAFKA-1525) DumpLogSegments should print transaction IDs

2014-08-15 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated KAFKA-1525: Attachment: KAFKA-1525_2014-08-15_11:49:25.patch > DumpLogSegments should print transaction

[jira] [Commented] (KAFKA-1525) DumpLogSegments should print transaction IDs

2014-08-15 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14098921#comment-14098921 ] Dong Lin commented on KAFKA-1525: - Updated reviewboard https://reviews.apache.org/r/2

<    5   6   7   8   9   10   11   12   >