[jira] [Updated] (KAFKA-1729) add doc for Kafka-based offset management in 0.8.2

2014-11-05 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-1729: -- Status: Patch Available (was: In Progress) add doc for Kafka-based offset management in 0.8.2

[jira] [Commented] (KAFKA-1729) add doc for Kafka-based offset management in 0.8.2

2014-11-05 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14199616#comment-14199616 ] Joel Koshy commented on KAFKA-1729: --- Incorporated comments. I would actually like to get

[jira] [Updated] (KAFKA-1706) Adding a byte bounded blocking queue to util.

2014-11-04 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-1706: -- Resolution: Fixed Status: Resolved (was: Patch Available) Thanks for the patch. Committed to

[jira] [Updated] (KAFKA-1634) Improve semantics of timestamp in OffsetCommitRequests and update documentation

2014-11-04 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-1634: -- Reviewer: Joel Koshy (was: Neha Narkhede) Improve semantics of timestamp in OffsetCommitRequests and

[jira] [Commented] (KAFKA-1729) add doc for Kafka-based offset management in 0.8.2

2014-11-04 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14197243#comment-14197243 ] Joel Koshy commented on KAFKA-1729: --- Thanks for reviewing. Re: offsets in ZK Yes we can

[jira] [Updated] (KAFKA-1729) add doc for Kafka-based offset management in 0.8.2

2014-11-04 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-1729: -- Status: In Progress (was: Patch Available) add doc for Kafka-based offset management in 0.8.2

[jira] [Commented] (KAFKA-1481) Stop using dashes AND underscores as separators in MBean names

2014-11-04 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14197412#comment-14197412 ] Joel Koshy commented on KAFKA-1481: --- Sorry I ran out of time - will look tomorrow.

[jira] [Commented] (KAFKA-960) Upgrade Metrics to 3.x

2014-11-03 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14194979#comment-14194979 ] Joel Koshy commented on KAFKA-960: -- Also, we should plan on removing our dependency on

[jira] [Commented] (KAFKA-1555) provide strong consistency with reasonable availability

2014-11-03 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14195029#comment-14195029 ] Joel Koshy commented on KAFKA-1555: --- Sounds good. In that case, can you modify it a bit?

[jira] [Updated] (KAFKA-1481) Stop using dashes AND underscores as separators in MBean names

2014-11-03 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-1481: -- Reviewer: Joel Koshy (was: Jun Rao) Stop using dashes AND underscores as separators in MBean names

[jira] [Commented] (KAFKA-1481) Stop using dashes AND underscores as separators in MBean names

2014-11-03 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14195573#comment-14195573 ] Joel Koshy commented on KAFKA-1481: --- Yes thanks - I'll take a look at this tomorrow.

[jira] [Updated] (KAFKA-1729) add doc for Kafka-based offset management in 0.8.2

2014-11-03 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-1729: -- Status: Patch Available (was: Open) add doc for Kafka-based offset management in 0.8.2

[jira] [Updated] (KAFKA-1729) add doc for Kafka-based offset management in 0.8.2

2014-11-03 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-1729: -- Attachment: KAFKA-1782-doc-v1.patch Uploading v1 for review add doc for Kafka-based offset management

[jira] [Commented] (KAFKA-1555) provide strong consistency with reasonable availability

2014-10-31 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14192223#comment-14192223 ] Joel Koshy commented on KAFKA-1555: --- Given the current implementation, I think the

[jira] [Updated] (KAFKA-1742) ControllerContext removeTopic does not correctly update state

2014-10-31 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-1742: -- Priority: Blocker (was: Major) Fix Version/s: 0.8.2 ControllerContext removeTopic does not

[jira] [Commented] (KAFKA-1647) Replication offset checkpoints (high water marks) can be lost on hard kills and restarts

2014-10-30 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14190490#comment-14190490 ] Joel Koshy commented on KAFKA-1647: --- Patch is good, but could you rebase? Replication

[jira] [Updated] (KAFKA-1647) Replication offset checkpoints (high water marks) can be lost on hard kills and restarts

2014-10-30 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-1647: -- Resolution: Fixed Status: Resolved (was: Patch Available) Thanks for the patch - committed to

[jira] [Assigned] (KAFKA-1729) add doc for Kafka-based offset management in 0.8.2

2014-10-30 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy reassigned KAFKA-1729: - Assignee: Joel Koshy add doc for Kafka-based offset management in 0.8.2

[jira] [Commented] (KAFKA-1555) provide strong consistency with reasonable availability

2014-10-30 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14191196#comment-14191196 ] Joel Koshy commented on KAFKA-1555: --- Sorry for the late feedback. configuration.html: -

[jira] [Commented] (KAFKA-1555) provide strong consistency with reasonable availability

2014-10-30 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14191239#comment-14191239 ] Joel Koshy commented on KAFKA-1555: --- Yeah what I wrote earlier was incorrect - sorry. It

[jira] [Commented] (KAFKA-1555) provide strong consistency with reasonable availability

2014-10-30 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14191241#comment-14191241 ] Joel Koshy commented on KAFKA-1555: --- ack never mind.. I see what you mean.

[jira] [Commented] (KAFKA-1583) Kafka API Refactoring

2014-10-29 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14188577#comment-14188577 ] Joel Koshy commented on KAFKA-1583: --- Ok cool - I will re-review the latest patch and

[jira] [Updated] (KAFKA-1583) Kafka API Refactoring

2014-10-29 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-1583: -- Resolution: Fixed Fix Version/s: (was: 0.9.0) 0.8.3 Status:

[jira] [Commented] (KAFKA-1583) Kafka API Refactoring

2014-10-28 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14187118#comment-14187118 ] Joel Koshy commented on KAFKA-1583: --- Thanks for the updated patch. I will do this today.

[jira] [Commented] (KAFKA-1555) provide strong consistency with reasonable availability

2014-10-24 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14183086#comment-14183086 ] Joel Koshy commented on KAFKA-1555: --- Jun, you can just diff configuration.html,

[jira] [Commented] (KAFKA-1555) provide strong consistency with reasonable availability

2014-10-24 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14183304#comment-14183304 ] Joel Koshy commented on KAFKA-1555: --- Looks good - I just have a few minor edits to what

[jira] [Updated] (KAFKA-1641) Log cleaner exits if last cleaned offset is lower than earliest offset

2014-10-23 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-1641: -- Resolution: Fixed Status: Resolved (was: Patch Available) Thanks for the patch. Pushed to

[jira] [Commented] (KAFKA-391) Producer request and response classes should use maps

2014-10-23 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14182240#comment-14182240 ] Joel Koshy commented on KAFKA-391: -- You mean two responses to the caller of send? I don't

[jira] [Commented] (KAFKA-391) Producer request and response classes should use maps

2014-10-23 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14182276#comment-14182276 ] Joel Koshy commented on KAFKA-391: -- Yeah I see your point. That's interesting - I actually

[jira] [Commented] (KAFKA-1647) Replication offset checkpoints (high water marks) can be lost on hard kills and restarts

2014-10-22 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14180328#comment-14180328 ] Joel Koshy commented on KAFKA-1647: --- [~becket_qin] here are some steps to reproduce

[jira] [Updated] (KAFKA-1555) provide strong consistency with reasonable availability

2014-10-21 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-1555: -- Reviewer: Joel Koshy (was: Jun Rao) provide strong consistency with reasonable availability

[jira] [Reopened] (KAFKA-1555) provide strong consistency with reasonable availability

2014-10-21 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy reopened KAFKA-1555: --- I'm reopening this so we won't forget about the documentation patch. If you prefer, we can open a

[jira] [Commented] (KAFKA-1583) Kafka API Refactoring

2014-10-21 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14179460#comment-14179460 ] Joel Koshy commented on KAFKA-1583: --- I posted review comments, mostly minor. Did you

[jira] [Commented] (KAFKA-1583) Kafka API Refactoring

2014-10-17 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14175763#comment-14175763 ] Joel Koshy commented on KAFKA-1583: --- Reviewing is taking a bit longer than expected -

[jira] [Commented] (KAFKA-1583) Kafka API Refactoring

2014-10-15 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14173215#comment-14173215 ] Joel Koshy commented on KAFKA-1583: --- Yes please. I will be able to do this on Friday.

[jira] [Commented] (KAFKA-979) Add jitter for time based rolling

2014-10-14 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14171962#comment-14171962 ] Joel Koshy commented on KAFKA-979: -- Just had one more comment in the RB on how to use the

[jira] [Commented] (KAFKA-1637) SimpleConsumer.fetchOffset returns wrong error code when no offset exists for topic/partition/consumer group

2014-10-14 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14172020#comment-14172020 ] Joel Koshy commented on KAFKA-1637: --- -1 on this patch per the comment in the RB.

[jira] [Commented] (KAFKA-1634) Improve semantics of timestamp in OffsetCommitRequests and update documentation

2014-10-13 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14169648#comment-14169648 ] Joel Koshy commented on KAFKA-1634: --- [~junrao] yes you are right. The

[jira] [Assigned] (KAFKA-1634) Update protocol wiki to reflect the new offset management feature

2014-10-10 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy reassigned KAFKA-1634: - Assignee: Joel Koshy (was: Jun Rao) Update protocol wiki to reflect the new offset management

[jira] [Commented] (KAFKA-1634) Update protocol wiki to reflect the new offset management feature

2014-10-10 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14167696#comment-14167696 ] Joel Koshy commented on KAFKA-1634: --- Actually, one more potential source of confusion is

[jira] [Commented] (KAFKA-1634) Update protocol wiki to reflect the new offset management feature

2014-10-10 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14167700#comment-14167700 ] Joel Koshy commented on KAFKA-1634: --- (BTW, I'm looking for a +1 or -1 on the above

[jira] [Updated] (KAFKA-1634) Improve semantics of timestamp in OffsetCommitRequests and update documentation

2014-10-10 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-1634: -- Summary: Improve semantics of timestamp in OffsetCommitRequests and update documentation (was: Improve

[jira] [Updated] (KAFKA-1634) Improve semantics of timestamp in OffsetCommitRequests

2014-10-10 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-1634: -- Summary: Improve semantics of timestamp in OffsetCommitRequests (was: Update protocol wiki to reflect

[jira] [Updated] (KAFKA-1648) Round robin consumer balance throws an NPE when there are no topics

2014-10-09 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-1648: -- Resolution: Fixed Status: Resolved (was: Patch Available) Committed to trunk Round robin

[jira] [Commented] (KAFKA-1499) Broker-side compression configuration

2014-10-07 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14162336#comment-14162336 ] Joel Koshy commented on KAFKA-1499: --- Talked to Jay offline and here is a summary of what

[jira] [Commented] (KAFKA-1555) provide strong consistency with reasonable availability

2014-10-07 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14162942#comment-14162942 ] Joel Koshy commented on KAFKA-1555: --- +1 (took a quick look at it) We could improve the

[jira] [Commented] (KAFKA-1499) Broker-side compression configuration

2014-10-03 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14158091#comment-14158091 ] Joel Koshy commented on KAFKA-1499: --- [~jkreps] Regarding the two approaches, both are

[jira] [Commented] (KAFKA-1499) Broker-side compression configuration

2014-10-03 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14158097#comment-14158097 ] Joel Koshy commented on KAFKA-1499: --- [~guozhang] I do believe we can avoid the need to

[jira] [Commented] (KAFKA-1499) Broker-side compression configuration

2014-10-03 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14158111#comment-14158111 ] Joel Koshy commented on KAFKA-1499: --- Yes that is correct. However, in practice I think

[jira] [Updated] (KAFKA-1647) Replication offset checkpoints (high water marks) can be lost on hard kills and restarts

2014-10-01 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-1647: -- Assignee: Jiangjie Qin Replication offset checkpoints (high water marks) can be lost on hard kills

[jira] [Commented] (KAFKA-1499) Broker-side compression configuration

2014-09-30 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14154209#comment-14154209 ] Joel Koshy commented on KAFKA-1499: --- If we provide a broker-compression-enabled config:

[jira] [Commented] (KAFKA-1499) Broker-side compression configuration

2014-09-29 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14151947#comment-14151947 ] Joel Koshy commented on KAFKA-1499: --- Yes I understand that the LogConfig is at the topic

[jira] [Commented] (KAFKA-1647) Replication offset checkpoints (high water marks) can be lost on hard kills and restarts

2014-09-29 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14151955#comment-14151955 ] Joel Koshy commented on KAFKA-1647: --- Yes that is exactly why it happens and the fix is

[jira] [Commented] (KAFKA-1634) Update protocol wiki to reflect the new offset management feature

2014-09-29 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14152466#comment-14152466 ] Joel Koshy commented on KAFKA-1634: --- [~nehanarkhede] I agree that timestamp in the

[jira] [Updated] (KAFKA-1577) Exception in ConnectionQuotas while shutting down

2014-09-29 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-1577: -- Resolution: Fixed Status: Resolved (was: Patch Available) Committed to trunk Exception in

[jira] [Commented] (KAFKA-1577) Exception in ConnectionQuotas while shutting down

2014-09-26 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14149798#comment-14149798 ] Joel Koshy commented on KAFKA-1577: --- Oh now I remember this - the root cause is as

[jira] [Commented] (KAFKA-1577) Exception in ConnectionQuotas while shutting down

2014-09-26 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14149803#comment-14149803 ] Joel Koshy commented on KAFKA-1577: --- I think selectNow is a good option. Exception in

[jira] [Commented] (KAFKA-1577) Exception in ConnectionQuotas while shutting down

2014-09-26 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14149888#comment-14149888 ] Joel Koshy commented on KAFKA-1577: --- Hmm.. that is really weird - since the swallow

[jira] [Commented] (KAFKA-1499) Broker-side compression configuration

2014-09-26 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14150181#comment-14150181 ] Joel Koshy commented on KAFKA-1499: --- That sounds reasonable. Another option would be to

[jira] [Commented] (KAFKA-1555) provide strong consistency with reasonable availability

2014-09-25 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14147943#comment-14147943 ] Joel Koshy commented on KAFKA-1555: --- I'm +1 on the concept of min.isr and acks -1, 0, 1.

[jira] [Commented] (KAFKA-1652) NoSuchElementException on server shutdown

2014-09-25 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14148263#comment-14148263 ] Joel Koshy commented on KAFKA-1652: --- Are you sure you have the fix in KAFKA-1577 ? If so

[jira] [Commented] (KAFKA-1647) Replication offset checkpoints (high water marks) can be lost on hard kills and restarts

2014-09-25 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14148336#comment-14148336 ] Joel Koshy commented on KAFKA-1647: --- If b1 aborts the follower transition the high

[jira] [Updated] (KAFKA-1647) Replication offset checkpoints (high water marks) can be lost on hard kills and restarts

2014-09-25 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-1647: -- Labels: newbie++ (was: ) Replication offset checkpoints (high water marks) can be lost on hard kills

[jira] [Commented] (KAFKA-1499) Broker-side compression configuration

2014-09-25 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14148598#comment-14148598 ] Joel Koshy commented on KAFKA-1499: --- Thanks - it works now. Sorry I had forgotten to

[jira] [Commented] (KAFKA-1555) provide strong consistency with reasonable availability

2014-09-25 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14148795#comment-14148795 ] Joel Koshy commented on KAFKA-1555: --- This is an implementation detail but wrt the

[jira] [Commented] (KAFKA-1647) Replication offset checkpoints (high water marks) can be lost on hard kills and restarts

2014-09-25 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14148802#comment-14148802 ] Joel Koshy commented on KAFKA-1647: --- Yes that is one possibility but not the only one.

[jira] [Commented] (KAFKA-1499) Broker-side compression configuration

2014-09-24 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14147187#comment-14147187 ] Joel Koshy commented on KAFKA-1499: --- [~omkreddy] I thought I would try this locally but

[jira] [Commented] (KAFKA-1367) Broker topic metadata not kept in sync with ZooKeeper

2014-09-23 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14144434#comment-14144434 ] Joel Koshy commented on KAFKA-1367: --- I definitely agree with [~edenhill] that if such a

[jira] [Created] (KAFKA-1647) Replication offset checkpoints (high water marks) can be lost on hard kills and restarts

2014-09-23 Thread Joel Koshy (JIRA)
Joel Koshy created KAFKA-1647: - Summary: Replication offset checkpoints (high water marks) can be lost on hard kills and restarts Key: KAFKA-1647 URL: https://issues.apache.org/jira/browse/KAFKA-1647

[jira] [Updated] (KAFKA-1013) Modify existing tools as per the changes in KAFKA-1000

2014-09-23 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-1013: -- Reviewer: Joel Koshy Modify existing tools as per the changes in KAFKA-1000

[jira] [Updated] (KAFKA-1469) Util.abs function does not return correct absolute values for negative values

2014-09-22 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-1469: -- Description: Reported by Russell Melick. [edit1: I don't think this affects correctness of the places

[jira] [Commented] (KAFKA-1499) Broker-side compression configuration

2014-09-16 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14135957#comment-14135957 ] Joel Koshy commented on KAFKA-1499: --- Sorry you are right - I mixed up the two. For some

[jira] [Commented] (KAFKA-1499) Broker-side compression configuration

2014-09-15 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14134184#comment-14134184 ] Joel Koshy commented on KAFKA-1499: --- Yes I will take a look. However, [~omkreddy] can

[jira] [Assigned] (KAFKA-1013) Modify existing tools as per the changes in KAFKA-1000

2014-09-15 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy reassigned KAFKA-1013: - Assignee: Mayuresh Gharat (was: Tejas Patil) ConsumerOffsetChecker is already done. Mayuresh

[jira] [Commented] (KAFKA-1625) Sample Java code contains Scala syntax

2014-09-09 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14127529#comment-14127529 ] Joel Koshy commented on KAFKA-1625: --- Thanks for pointing out the reference to scala code

[jira] [Commented] (KAFKA-1625) Sample Java code contains Scala syntax

2014-09-09 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14127553#comment-14127553 ] Joel Koshy commented on KAFKA-1625: --- Not that I know of, but the new producer is

[jira] [Commented] (KAFKA-1577) Exception in ConnectionQuotas while shutting down

2014-09-05 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14123408#comment-14123408 ] Joel Koshy commented on KAFKA-1577: --- The exception would only occur if the socket and

[jira] [Updated] (KAFKA-1510) Force offset commits when migrating consumer offsets from zookeeper to kafka

2014-09-05 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-1510: -- Resolution: Fixed Status: Resolved (was: Patch Available) Thanks for the patch. +1 and

[jira] [Commented] (KAFKA-1577) Exception in ConnectionQuotas while shutting down

2014-09-05 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14123543#comment-14123543 ] Joel Koshy commented on KAFKA-1577: --- I think the main reason to allow the exception (as

[jira] [Commented] (KAFKA-1577) Exception in ConnectionQuotas while shutting down

2014-09-05 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14123613#comment-14123613 ] Joel Koshy commented on KAFKA-1577: --- We can do that, but it does allow the error to go

[jira] [Commented] (KAFKA-1510) Force offset commits when migrating consumer offsets from zookeeper to kafka

2014-09-04 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14122243#comment-14122243 ] Joel Koshy commented on KAFKA-1510: --- [~nmarasoi] Your patch looks good to me - however,

[jira] [Updated] (KAFKA-1374) LogCleaner (compaction) does not support compressed topics

2014-08-29 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-1374: -- Reviewer: Joel Koshy Assignee: Manikumar Reddy (was: Joel Koshy) LogCleaner (compaction) does

[jira] [Updated] (KAFKA-687) Rebalance algorithm should consider partitions from all topics

2014-08-29 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-687: - Reviewer: Jun Rao Rebalance algorithm should consider partitions from all topics

[jira] [Updated] (KAFKA-1510) Force offset commits when migrating consumer offsets from zookeeper to kafka

2014-08-29 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-1510: -- Reviewer: Joel Koshy Force offset commits when migrating consumer offsets from zookeeper to kafka

[jira] [Updated] (KAFKA-1577) Exception in ConnectionQuotas while shutting down

2014-08-29 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-1577: -- Reviewer: Joel Koshy Exception in ConnectionQuotas while shutting down

[jira] [Updated] (KAFKA-1577) Exception in ConnectionQuotas while shutting down

2014-08-29 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-1577: -- Resolution: Fixed Status: Resolved (was: Patch Available) Exception in ConnectionQuotas

[jira] [Updated] (KAFKA-687) Rebalance algorithm should consider partitions from all topics

2014-08-29 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-687: - Resolution: Fixed Status: Resolved (was: Patch Available) Addressed follow-up comments and

[jira] [Updated] (KAFKA-687) Rebalance algorithm should consider partitions from all topics

2014-08-28 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-687: - Attachment: KAFKA-687_2014-08-28_16:20:25.patch Rebalance algorithm should consider partitions from all

[jira] [Commented] (KAFKA-687) Rebalance algorithm should consider partitions from all topics

2014-08-28 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14114578#comment-14114578 ] Joel Koshy commented on KAFKA-687: -- Updated reviewboard

[jira] [Commented] (KAFKA-1510) Force offset commits when migrating consumer offsets from zookeeper to kafka

2014-08-25 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14108852#comment-14108852 ] Joel Koshy commented on KAFKA-1510: --- [~nmarasoi] do you think you will have time to wrap

[jira] [Commented] (KAFKA-1510) Force offset commits when migrating consumer offsets from zookeeper to kafka

2014-08-25 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14109432#comment-14109432 ] Joel Koshy commented on KAFKA-1510: --- [~nmarasoi] that's right - whenever storage=kafka,

[jira] [Commented] (KAFKA-687) Rebalance algorithm should consider partitions from all topics

2014-08-25 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14109615#comment-14109615 ] Joel Koshy commented on KAFKA-687: -- Updated reviewboard

[jira] [Updated] (KAFKA-687) Rebalance algorithm should consider partitions from all topics

2014-08-25 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-687: - Attachment: KAFKA-687_2014-08-25_12:36:48.patch Rebalance algorithm should consider partitions from all

[jira] [Updated] (KAFKA-1609) New producer metadata response handling should only exclude a PartitionInfo when its error is LEADER_NOT_AVAILABLE

2014-08-22 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-1609: -- Summary: New producer metadata response handling should only exclude a PartitionInfo when its error is

[jira] [Updated] (KAFKA-687) Rebalance algorithm should consider partitions from all topics

2014-08-20 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-687: - Attachment: KAFKA-687_2014-08-20_18:09:28.patch Rebalance algorithm should consider partitions from all

[jira] [Commented] (KAFKA-687) Rebalance algorithm should consider partitions from all topics

2014-08-20 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14104897#comment-14104897 ] Joel Koshy commented on KAFKA-687: -- Updated reviewboard

[jira] [Commented] (KAFKA-1510) Force offset commits when migrating consumer offsets from zookeeper to kafka

2014-08-19 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14101929#comment-14101929 ] Joel Koshy commented on KAFKA-1510: --- [~nmarasoi] can you update your patch to do

[jira] [Commented] (KAFKA-687) Rebalance algorithm should consider partitions from all topics

2014-08-19 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14102664#comment-14102664 ] Joel Koshy commented on KAFKA-687: -- Updated reviewboard

[jira] [Updated] (KAFKA-687) Rebalance algorithm should consider partitions from all topics

2014-08-19 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-687: - Attachment: KAFKA-687_2014-08-19_12:07:37.patch Rebalance algorithm should consider partitions from all

[jira] [Updated] (KAFKA-687) Rebalance algorithm should consider partitions from all topics

2014-08-19 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-687: - Status: Patch Available (was: Open) Rebalance algorithm should consider partitions from all topics

<    1   2   3   4   5   6   7   8   >