[jira] [Resolved] (KAFKA-13536) Log4J2 Vulnerability zero-day exploit is going on. Will it impact kafka_2.12-2.3.0 version and do we need to upgrade?

2021-12-11 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen resolved KAFKA-13536. --- Resolution: Duplicate > Log4J2 Vulnerability zero-day exploit is going on. Will it imp

[jira] [Resolved] (KAFKA-13535) Workaround for mitigating CVE-2021-44228 Kafka

2021-12-11 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen resolved KAFKA-13535. --- Resolution: Won't Fix [~akansh] , thanks for reporting the issue. I've confirmed that Kafka

Re: [DISCUSS] Please review the 3.1.0 blog post

2021-12-11 Thread Luke Chen
Oh, sorry! I have a typo in your name! Sorry, David! >.< Luke On Sat, Dec 11, 2021 at 4:42 PM Luke Chen wrote: > Hi Davie, > > Thanks for drafting the release announcement post. > I've checked the content, and looks good to me. > But I think the header section:

Re: [DISCUSS] Please review the 3.1.0 blog post

2021-12-11 Thread Luke Chen
Hi Davie, Thanks for drafting the release announcement post. I've checked the content, and looks good to me. But I think the header section: "What's New in Apache..." is not formatted properly. I checked the previous blog post, and it should be a hyperlink just like the "Main" kind of font.

Re: [DISCUSS] KIP-782: Expandable batch size in producer

2021-12-09 Thread Luke Chen
haps we could > > > > introduce a new config max.record.size that defaults to 1MB. We could > > > then > > > > increase max.request.size to sth like 10MB. > > > > > > > > Thanks, > > > > > > > > Jun > > > >

Re: [VOTE] KIP-792: Add "generation" field into consumer protocol

2021-12-09 Thread Luke Chen
ithout crashing. Other than that, the KIP > lgtm. > > Guozhang > > On Tue, Dec 7, 2021 at 6:16 PM Luke Chen wrote: > > > Hi Colin, > > > > I'm not quite sure if I understand your thoughts correctly. > > If I was wrong, please let me know. > > > > Also,

Re: AccessDeniedException Kafka 3.0.0 on Windows

2021-12-09 Thread Luke Chen
leased? > Regards, > Martijn > > -Original Message- > From: Luke Chen > Sent: donderdag 9 december 2021 10:30 > To: dev > Subject: Re: AccessDeniedException Kafka 3.0.0 on Windows > > Hi Martijn de Bruijn > > Thanks for reporting the issue. This is a kn

Re: AccessDeniedException Kafka 3.0.0 on Windows

2021-12-09 Thread Luke Chen
Hi Martijn de Bruijn Thanks for reporting the issue. This is a known issue and it will be fixed in V3.0.1/V3.1.0 in this ticket: https://issues.apache.org/jira/browse/KAFKA-13391. FYI Thank you. Luke On Thu, Dec 9, 2021 at 4:08 PM de Bruijn, M. (Martijn) wrote: > On Windows, Kafka 3.0.0 is

Re: [VOTE] KIP-792: Add "generation" field into consumer protocol

2021-12-07 Thread Luke Chen
ck the IBP version, how should I do? Thank you. Luke On Tue, Dec 7, 2021 at 9:41 PM Luke Chen wrote: > Hi Colin, > > Thanks for your comments. I've updated the KIP to mention about the KIP > won't affect current broker side behavior. > > > One scenario that we need to

Re: [VOTE] KIP-792: Add "generation" field into consumer protocol

2021-12-07 Thread Luke Chen
Ps, it seems that the same epoch numbers could be reused for a > group, if things are done in the obvious manner (old IBP = don't read or > write epoch, new IBP = do). > > best, > Colin > > > On Fri, Dec 3, 2021, at 18:46, Luke Chen wrote: > > Hi Colin, > &g

Re: [VOTE] KIP-805: Add range and scan query support in IQ v2

2021-12-05 Thread Luke Chen
Hi Vasiliki, Thanks for the KIP! It makes sense to have the range and scan query in IQv2, as in IQv1. +1 (non-binding) Thank you. Luke On Thu, Dec 2, 2021 at 5:41 AM John Roesler wrote: > Thanks for the KIP, Vicky! > > I’m +1 (binding) > > -John > > On Tue, Nov 30, 2021, at 14:51, Vasiliki

Re: [VOTE] KIP-799: Align behaviour for producer callbacks with documented behaviour

2021-12-03 Thread Luke Chen
he KIP itself what placeholder value would be > returned. > > Regards, > Séamus. > > On Tue, 30 Nov 2021 at 09:52, Luke Chen wrote: > > > Hi Séamus, > > Thanks for the KIP! > > We definitely want to keep the producer callback consistent for all

Re: [VOTE] KIP-792: Add "generation" field into consumer protocol

2021-12-03 Thread Luke Chen
ank you. Luke On Fri, Dec 3, 2021 at 6:30 AM Colin McCabe wrote: > How are we going to avoid the situation where the broker restarts, and the > same generation number is reused? > > best, > Colin > > On Tue, Nov 30, 2021, at 16:36, Luke Chen wrote: > > Hi all, > > &

[DISCUSS] KIP-591: Add Kafka Streams config to set default state store

2021-12-01 Thread Luke Chen
Hi devs, I'd like to propose a KIP to allow users to set default store implementation class (built-in RocksDB/InMemory, or custom one), and default to RocksDB state store, to keep backward compatibility. Detailed description can be found here:

[VOTE] KIP-792: Add "generation" field into consumer protocol

2021-11-30 Thread Luke Chen
Hi all, I'd like to start the vote for KIP-792: Add "generation" field into consumer protocol. The goal of this KIP is to allow the assignor/consumer coordinator to have a way to identify the out-of-date members/assignments, to avoid rebalance stuck issues in current protocol. Detailed

Re: [VOTE] KIP-799: Align behaviour for producer callbacks with documented behaviour

2021-11-30 Thread Luke Chen
Hi Séamus, Thanks for the KIP! We definitely want to keep the producer callback consistent for all types of errors. Just one comment for the KIP: In the "Proposed Changes" section, could you please "explicitly" describe what placeholder you'll return, in addition to adding a hyperlink to other

Re: [DISCUSS] KIP-792: Add "generation" field into consumer protocol

2021-11-28 Thread Luke Chen
Hi devs, Welcome to provide feedback. If there are no other comments, I'll start a vote tomorrow. Thank you. Luke On Mon, Nov 22, 2021 at 4:16 PM Luke Chen wrote: > Hello David, > > For (3): > > > > * I suppose that we could add a `generation` field to the JoinGroupRe

Re: Handling retriable exceptions during Connect source task start

2021-11-28 Thread Luke Chen
Hi Gunnar and Sergei, I think it's good to have a retriable exception handling during task#start. > are retriable exceptions during start disallowed by design, and the task must not throw retriable exceptions during start, or it's just currently not supported by the Connect framework and I just

Re: [DISCUSS] KIP-753: ACL authentication, Host field support IP network segment

2021-11-26 Thread Luke Chen
Hi Lobo, Thanks for the KIP! I like the idea to allow "IP subnet" to be passed into `--allow-host` option to set for a principle. It will be useful in production environment. Here's some comments: 1. I think "IP subnet" is more specific than "network segment", is that right? 2. Since you allow

Re: KIP-800: Add reason to LeaveGroupRequest

2021-11-25 Thread Luke Chen
Hi David, Thanks for the update. Just voted! :) Thank you. Luke On Thu, Nov 25, 2021 at 8:42 PM David Jacot wrote: > Hi Luke, > > Good point. I have renamed the KIP. > > Thanks, > David > > On Thu, Nov 25, 2021 at 4:28 AM Luke Chen wrote: > > > > Hi

Re: [VOTE] KIP-800: Add reason to LeaveGroupRequest

2021-11-25 Thread Luke Chen
Hi David, Thanks for the KIP! It is good to have the joinGroup/leaveGroup reason sent to brokers for better troubleshooting. +1 (non-binding) Thank you. Luke On Thu, Nov 25, 2021 at 8:14 AM Gwen Shapira wrote: > +1 > > Thanks for driving David. Super useful. > > On Wed, Nov 24, 2021 at 8:53

Re: Errors thrown from a KStream transformer are swallowed, eg. StackOverflowError

2021-11-24 Thread Luke Chen
Yes, I confirmed that in KAFKA-9331 ( https://github.com/apache/kafka/pull/9487), we removed the `catch (exception)` block for adding uncaught exception handler. Then, in KAFKA-12537(https://github.com/apache/kafka/pull/10387), we added `catch (Thrwoable)` (in v2.8.0). So, @Sinclair, if you

Re: poll block question

2021-11-24 Thread Luke Chen
Hi xusheng, I checked the code stack, and mapped to the kafka code, I can see we either use Selector#selectNow, or Selector#select(timeoutMs), which should never hang forever. If so, I think it might be the `timeoutMS` is too large, and from your code stack, the timeoutMS came from the

Re: KIP-800: Add reason to LeaveGroupRequest

2021-11-24 Thread Luke Chen
Hi David, Sorry for the late reply. Thanks for the update. It looks good now. I love the idea to add joinGroup request reason, as well as the `enforceRebalance` API! One minor comment, since we extended the original KIP from leaveGroup to joinGroup request, Could you please update the KIP title

Re: [DISCUSS] KIP-782: Expandable batch size in producer

2021-11-24 Thread Luke Chen
it more > random), some partitions would experience higher latency than others (not > sure how much it would matter in practice -- in the end of the day some > bytes produced to a topic would have higher latency and some bytes would > have lower latency). This pattern is easily fixed b

Re: [VOTE] KIP-798 Add possibility to write kafka headers in Kafka Console Producer

2021-11-23 Thread Luke Chen
gt; 4 binding +1 > 1 non-binding +1 > no vetoes > > Thanks, > Florin > > > On Tue, 23 Nov 2021 at 06:59, Luke Chen wrote: > > > Hi Florin, > > Thanks for the update! > > > > +1 (non-binding) > > > > Thank you. > > Luke > >

Re: [DISCUSS] KIP-782: Expandable batch size in producer

2021-11-23 Thread Luke Chen
other partitions each get their turn at being the first. But isn't > > there the risk that drainBatchesForOneNode would end up not sending ready > > batches well past when they ought to be sent (according to their > linger.ms > > ), > > because it's sending buffers for ear

Re: [VOTE] KIP-798 Add possibility to write kafka headers in Kafka Console Producer

2021-11-22 Thread Luke Chen
(email from 21 Nov > 2021, > > > > 11:29 UTC) I also added an explanation why I limited the scope to > UTF-8 > > > > only. > > > > > > > > Thanks, > > > > Florin > > > > > > > > > > > > > > > > On Mon, 22 Nov 202

Re: [VOTE] KIP-797: Accept duplicate listener on port for IPv4/IPv6

2021-11-22 Thread Luke Chen
Hi Matthew, Thanks for the KIP. It makes sense to allow IPv4 and IPv6 listening on the same port for the listener config. +1 (non-binding) Thank you. Luke On Mon, Nov 22, 2021 at 6:28 PM Matthew de Detrich wrote: > Hello everyone, > > I would like to start a vote for KIP-797: Accept duplicate

Re: [DISCUSS] KIP-792: Add "generation" field into consumer protocol

2021-11-22 Thread Luke Chen
the `generationId` field into Subscription protocol to achieve what we want. Thank you. Luke On Thu, Nov 18, 2021 at 8:51 PM Luke Chen wrote: > Hi David, > Thanks for your feedback. > > I've updated the KIP for your comments (1)(2). > For (3), it's a good point! Yes, we didn't deserialize t

Re: [RESULTS] [VOTE] Release Kafka version 2.7.2

2021-11-21 Thread Luke Chen
dy now? > > > > > > > > > > > > > > > > > > At 2021-11-12 17:43:23, "Mickael Maison" wrote: > >This vote passes with 6 +1 votes (3 bindings) and no 0 or -1 votes. > > > >+1 votes > >PMC Members: > >* Bill Bejeck > >* Manikumar Reddy &g

Re: [VOTE] KIP-798 Add possibility to write kafka headers in Kafka Console Producer

2021-11-21 Thread Luke Chen
Hi Florin, Thanks for the KIP. This KIP makes sense to me. Just a comment that the motivation section is not clearly explain why this KIP is important. I think John already mentioned a good motivation, which is to support "not only UTF-8". You should put that into the KIP, and of course if you

Re: [ANNOUNCE] New Kafka PMC Member: Tom Bentley

2021-11-18 Thread Luke Chen
Congrats, Tom! Guozhang Wang 於 2021年11月19日 週五 上午1:13 寫道: > Congrats Tom! > > Guozhang > > On Thu, Nov 18, 2021 at 7:49 AM Jun Rao wrote: > > > Hi, Everyone, > > > > Tom Bentley has been a Kafka committer since Mar. 15, 2021. He has been > > very instrumental to the community since becoming a

Re: [DISCUSS] KIP-792: Add "generation" field into consumer protocol

2021-11-18 Thread Luke Chen
that we could add a `generation` field to the JoinGroupRequest instead > to do the fencing that you describe while handling the sentinel in the > assignor directly. If we would add the `generation` to the request itself, > would we need the `generation` in the subscription protocol as well?

Re: [DISCUSS] KIP-797 Accept duplicate listener on port for IPv4/IPv6

2021-11-18 Thread Luke Chen
missed something). > > Let me know if anything else is needed. > > Regards > > On Thu, Nov 18, 2021 at 3:58 AM Luke Chen wrote: > > > Hi Matthew, > > Thanks for the KIP. > > > > I have a question: > > If I remembered correctly, the "advertised li

Re: [DISCUSS] KIP-797 Accept duplicate listener on port for IPv4/IPv6

2021-11-17 Thread Luke Chen
Hi Matthew, Thanks for the KIP. I have a question: If I remembered correctly, the "advertised listeners" already support duplicated ports, so your KIP should only focus on "listeners" configuration, is that right? If so, could you please make it clear in KIP, to mention that your change only

Re: [DISCUSS] Brokers disconnect intermittently with TLS1.3

2021-11-15 Thread Luke Chen
Hi Shylaja, Thanks for reporting the issue. > Given that TLS1.3 does not support renegotiation, can I make it applicable just for TLS1.2? Are you saying you're trying to make Kafka default supports to TLS1.2, instead of TLS1.3? If so, I don't think it's a good idea to fall back to an older and

Re: KIP-800: Add reason to LeaveGroupRequest

2021-11-11 Thread Luke Chen
Hi David, Thanks for the KIP. It makes sense to me. Some comments: 1. Should we bump the `LeaveGroupRequest` protocol version to 5? 2. the description in the new field: "about": "The reason" -> "about": "The reason why the member left the group" 3. For the `removeMembersFromConsumerGroup` case,

[DISCUSS] KIP-792: Add "generation" field into consumer protocol

2021-11-11 Thread Luke Chen
Hi all, I'd like to start the discussion for KIP-792: Add "generation" field into consumer protocol. The goal of this KIP is to allow assignor/consumer coordinator/group coordinator to have a way to identify the out-of-date members/assignments. Detailed description can be found here:

Re: [VOTE] KIP-782: Expandable batch size in producer

2021-11-09 Thread Luke Chen
+Expandable+batch+size+in+producer Any feedback and comments is welcome. Thank you. Luke On Fri, Nov 5, 2021 at 4:37 PM Luke Chen wrote: > Hi Mickael, > Thanks for the good comments! Answering them below: > > - When under load, the producer may allocate extra buffers. Are these > buffer

Re: [VOTE] KIP-791: Add Record Metadata to State Store Context

2021-11-08 Thread Luke Chen
Hi Patrick, Thanks for the KIP. Adding RecordMetadata into StateStoreContext for offset updating makes sense to me. +1 (non-binding) Thank you. Luke On Mon, Nov 8, 2021 at 5:18 PM Patrick Stuedi wrote: > Hi all, > > Thanks for the feedback on KIP-791, I have updated the KIP and would like >

Re: [DISCUSS] KIP-794: Strictly Uniform Sticky Partitioner

2021-11-08 Thread Luke Chen
bution) is described in the linked jira, > copied an example from jira into the KIP as well. > > -Artem > > > On Thu, Nov 4, 2021 at 8:34 PM Luke Chen wrote: > > > Hi Artem, > > Thanks for the KIP! And thanks for reminding me to complete KIP-782, > soon. > > :

Re: [VOTE] KIP-782: Expandable batch size in producer

2021-11-05 Thread Luke Chen
eleased if the load drops? > - Do we really need batch.initial.size? It's not clear that having > this extra setting adds a lot of value. > > Thanks, > Mickael > > On Tue, Oct 26, 2021 at 11:12 AM Luke Chen wrote: > > > > Thank you, Artem! > > > > @devs, welcome t

Re: [DISCUSS] KIP-794: Strictly Uniform Sticky Partitioner

2021-11-04 Thread Luke Chen
Hi Artem, Thanks for the KIP! And thanks for reminding me to complete KIP-782, soon. :) Back to the KIP, I have some comments: 1. You proposed to have a new config: "partitioner.sticky.batch.size", but I can't see how we're going to use it to make the partitioner better. Please explain more in

Re: [DISCUSS] KIP-786: Emit Metric Client Quota Values

2021-11-04 Thread Luke Chen
Hi Mason, Thanks for the KIP. But I think since the quota value won't change from time to time unless admin alter it, it might be waste of resources to record it on each produce/fetch API. It can alternatively be achieved by using the kafka-configs.sh to describe ALL users/clients/default to have

Re: [VOTE] KIP-788: Allow configuring num.network.threads per listener

2021-11-04 Thread Luke Chen
Hi Mickael, Thanks for the KIP. It's great to have the capability to fine tune the number of threads per listener! Just 2 minor comments for the KIP: 1. The discussion thread is not attached in KIP 2. Israel raised the case-sensitive comment and your response didn't put into the KIP Otherwise,

[jira] [Created] (KAFKA-13420) consumer protocol should include "generation" field for assignor to distinguish between new/old OwnedPartitions

2021-10-29 Thread Luke Chen (Jira)
Luke Chen created KAFKA-13420: - Summary: consumer protocol should include "generation" field for assignor to distinguish between new/old OwnedPartitions Key: KAFKA-13420 URL: https://issues.apache.org/j

[jira] [Created] (KAFKA-13419) sync group failed with retriable error might cause out-of-date ownedPartition in Cooperative protocol

2021-10-29 Thread Luke Chen (Jira)
Luke Chen created KAFKA-13419: - Summary: sync group failed with retriable error might cause out-of-date ownedPartition in Cooperative protocol Key: KAFKA-13419 URL: https://issues.apache.org/jira/browse/KAFKA-13419

Re: New Kafka Consumer : unknown member id

2021-10-28 Thread Luke Chen
Hi, Which version of kafka client are you using? I can't find this error message in the source code. When googling this error message, it showed the error is in Kafka v0.9. Could you try to use the V3.0.0 and see if that issue still exist? Thank you. Luke On Thu, Oct 28, 2021 at 11:15 PM Kafka

Re: [VOTE] KIP-784: Add top-level error code field to DescribeLogDirsResponse

2021-10-27 Thread Luke Chen
Hi Mickael, Thanks for the KIP. It's good to keep it consistent with others, to have top-level error field. + 1 (non-binding) Thank you. Luke On Wed, Oct 27, 2021 at 9:01 PM Mickael Maison wrote: > Hi all, > > I'd like to start the vote on this minor KIP. > >

Re: [VOTE] KIP-780: Support fine-grained compression options

2021-10-27 Thread Luke Chen
Hi Dongjin, Thanks for the KIP. +1 (non-binding) Luke On Wed, Oct 27, 2021 at 8:44 PM Dongjin Lee wrote: > Bumping up the voting thread. > > If you have any questions or opinions, don't hesitate to leave them in the > discussion thread. > > Best, > Dongjin > > On Thu, Oct 14, 2021 at 3:02 AM

[jira] [Created] (KAFKA-13406) Cooperative sticky assignor got stuck due to assignment validation failed

2021-10-27 Thread Luke Chen (Jira)
Luke Chen created KAFKA-13406: - Summary: Cooperative sticky assignor got stuck due to assignment validation failed Key: KAFKA-13406 URL: https://issues.apache.org/jira/browse/KAFKA-13406 Project: Kafka

Re: [VOTE] KIP-782: Expandable batch size in producer

2021-10-26 Thread Luke Chen
atch+size+in+producer And, any comments and feedback are welcome. Thank you. Luke On Tue, Oct 26, 2021 at 6:35 AM Artem Livshits wrote: > Hi Luke, > > I've looked at the updated KIP-782, it looks good to me. > > -Artem > > On Sun, Oct 24, 2021 at 1:46 AM Luke Chen wro

Re: [kafka-clients] [VOTE] 2.7.2 RC0

2021-10-26 Thread Luke Chen
Hi Mickael, Thanks for the release. I did: 1. Verified checksums and signatures 2. Run quick start steps 3. Verified the CVE-2021-38153 is indeed fixed in kafka-2.7.2-src.tgz . +1 (non-binding) Thank you. Luke On Tue, Oct

Re: [VOTE] KIP-782: Expandable batch size in producer

2021-10-24 Thread Luke Chen
iled description can be found here: https://cwiki.apache.org/confluence/display/KAFKA/KIP-782%3A+Expandable+batch+size+in+producer Let me know if you have other suggestions. Thank you. Luke On Sat, Oct 23, 2021 at 10:50 AM Luke Chen wrote: > Hi Artem, > Thanks for the suggestion. Let m

[jira] [Created] (KAFKA-13396) kafka-topics.sh --create should not require the partitions/replication-factor argument

2021-10-23 Thread Luke Chen (Jira)
Luke Chen created KAFKA-13396: - Summary: kafka-topics.sh --create should not require the partitions/replication-factor argument Key: KAFKA-13396 URL: https://issues.apache.org/jira/browse/KAFKA-13396

Re: [VOTE] KIP-782: Expandable batch size in producer

2021-10-22 Thread Luke Chen
B by > default. > 2. When we drain, consider batch 'ready' if it exceeds batch.size, which is > 16KB by default. > > For memory conservation we may introduce batch.initial.size if we want to > have a flexibility to make it even smaller than batch.size, or we can just > always use batch.size

[VOTE] KIP-782: Expandable batch size in producer

2021-10-22 Thread Luke Chen
Hi Kafka dev, I'd like to start a vote for the proposal: KIP-782: Expandable batch size in producer. The main purpose for this KIP is to have better memory usage in producer, and also save users from the dilemma while setting the batch size configuration. After this KIP, users can set a higher

Re: [DISCUSS] KIP-782: Expandable batch size in producer

2021-10-20 Thread Luke Chen
Hi Ismael and all devs, Is there any comments/suggestions to this KIP? If no, I'm going to update the KIP based on my previous mail, and start a vote tomorrow or next week. Thank you. Luke On Mon, Oct 18, 2021 at 2:40 PM Luke Chen wrote: > Hi Ismael, > Thanks for your comments. > &g

[jira] [Resolved] (KAFKA-13372) failed authentication due to: SSL handshake failed

2021-10-18 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen resolved KAFKA-13372. --- Resolution: Resolved > failed authentication due to: SSL handshake fai

Re: [VOTE] KIP-764 Configurable backlog size for creating Acceptor

2021-10-18 Thread Luke Chen
Hi Okada, Thanks for the KIP. +1 (non-binding) One thing to add is that you should add ServerSocket#bind java doc link into the KIP. I don't think everyone is familiar with the definition of the method parameters. Thank you. Luke On Mon, Oct 18, 2021 at 3:43 PM Haruki Okada wrote: > Hi Kafka.

Re: [VOTE] Add TaskId field to StreamsException

2021-10-18 Thread Luke Chen
Hi Sophie, Add taskId to make the exception much clear is a good improvement. + 1 (non-binding) Thank you. Luke On Mon, Oct 18, 2021 at 12:10 PM Sophie Blee-Goldman wrote: > Hey all, > > I'd like to kick off the vote on this small KIP which adds a TaskId field > to the StreamsException class.

Re: [DISCUSS] KIP-782: Expandable batch size in producer

2021-10-18 Thread Luke Chen
he KIP. Why do we have to reallocate the buffer? We can keep > a > > list of buffers instead and avoid reallocation. > > > > Ismael > > > > On Sun, Oct 17, 2021, 2:02 AM Luke Chen wrote: > > > >> Hi Kafka dev, > >> I'd like to start the discussion for th

[DISCUSS] KIP-782: Expandable batch size in producer

2021-10-17 Thread Luke Chen
Hi Kafka dev, I'd like to start the discussion for the proposal: KIP-782: Expandable batch size in producer. The main purpose for this KIP is to have better memory usage in producer, and also save users from the dilemma while setting the batch size configuration. After this KIP, users can set a

Re: [SPAM] Re: Why does Kafka have a higher throughput than Redis?

2021-10-14 Thread Luke Chen
Hi Vitor, I'm not the expert, either, but I think Andrew's answer is pretty much the reasons why Kafka is doing good. And I'm not too familiar with Redis, either. But I'd say, there are many configurations in each product to increase the throughput, and the use cases are different, the comparison

Re: Kafka client 2.7.1 missing JaasUtils.isZkSecurityEnabled() method

2021-10-14 Thread Luke Chen
Hi Alexandre Yes, you're right. We renamed the `isZkSecurityEnabled` method name into `isZkSaslEnabled`, because it checked sasl config only. You can check here . If you want

Re: [DISCUSS] Apache Kafka 3.1.0 release

2021-10-14 Thread Luke Chen
Hi David, KIP-766 is merged into trunk. Please help add it into the release plan. Thank you. Luke On Mon, Oct 11, 2021 at 10:50 PM David Jacot wrote: > Hi Michael, > > Sure. I have updated the release plan to include it. Thanks for the > heads up. > > Best, > David > > On Mon, Oct 11, 2021 at

Re: [DISCUSS] KIP-780: Support fine-grained compression options

2021-10-13 Thread Luke Chen
Hi Dongjin, Thanks for the KIP, and the benchmark results. It makes sense to me. Just one question: > compression.zstd.window: enables long mode; the log of the window size that zstd uses to memorize the compressing data. (available: [10, 22], default: 0 (disables long mode.)) It said, available

Re: Why need handle delete topic in topic change event

2021-10-11 Thread Luke Chen
geHandler to only handle child add events? > > > 2021年10月12日 上午10:23,Luke Chen 写道: > > > > Hi 晓兵, > > Are you saying we should not call `removeTopic` because the topic znode > is > > deleted? > > Have a quick look at the `controllerContext#removeTopic` impl

Re: Why need handle delete topic in topic change event

2021-10-11 Thread Luke Chen
Hi 晓兵, Are you saying we should not call `removeTopic` because the topic znode is deleted? Have a quick look at the `controllerContext#removeTopic` implementation, it looks like we only clean up the metrics, and local maps. Why is it a problem we called it here? Does it caused any error? Could you

Re: [DISCUSS] KIP-776: Add Consumer#peek for debugging/tuning

2021-10-05 Thread Luke Chen
existing APIs, for example with poll/seek or with > listOffsets. Can you list them in the rejected alternatives section > and explain why they were rejected. > > Thanks > > > On Tue, Sep 21, 2021 at 9:47 AM Luke Chen wrote: > > > > Thanks for your feedback, Sagar,

[VOTE] KIP-776: Add Consumer#peek for debugging/tuning

2021-10-04 Thread Luke Chen
Hi everyone, I'd like to start a vote for the following proposal to add Consumer#peek for debugging/tuning. The main purpose for Consumer#peek is to allow users: 1. peek what records existed at broker side and not increasing the position offsets. 2. throw exceptions when there is

Re: [VOTE] KIP-774: Deprecate public access to Admin client's *Result constructors

2021-09-21 Thread Luke Chen
Hi Tom, Thanks for the KIP. I agree with you that we should change it back to non-public for future enhancement. +1 (non-binding) Thank you. Luke On Mon, Sep 20, 2021 at 9:05 PM Josep Prat wrote: > Hi Tom, > > Thanks for the KIP. It's a +1 (non binding) from my side. > > Best, > ——— > Josep

Re: [DISCUSS] KIP-776: Add Consumer#peek for debugging/tuning

2021-09-21 Thread Luke Chen
ide any new functionality IMHO, weakening the > > motivation a bit. > > > > Additionally, for the peek() case, I believe that users may want to have > > more fine-grained exposure of records, such as from specific partitions > > instead of getting random records. It's proba

Re: Contribution help please

2021-09-20 Thread Luke Chen
Hi Jon, I checked your PR. I think you didn't set the "indent" correctly. It looks like your indent setting is to 2, but we use 4. Please update the setting in IntelliJ. REF: https://www.jetbrains.com/help/idea/reformat-and-rearrange-code.html Thank you. Luke On Mon, Sep 20, 2021 at 2:47 PM Jon

[DISCUSS] KIP-776: Add Consumer#peek for debugging/tuning

2021-09-19 Thread Luke Chen
Hi everyone, I'd like to discuss the following proposal to add Consumer#peek for debugging/tuning. The main purpose for Consumer#peek is to allow users: 1. peek what records existed at broker side and not increasing the position offsets. 2. throw exceptions when there is connection

Re: [DISCUSS] Apache Kafka 3.1.0 release

2021-09-18 Thread Luke Chen
Thanks for volunteering! +1 (non-binding) Look forward to V3.1.0! Thank you. Luke On Sat, Sep 18, 2021 at 8:55 PM Israel Ekpo wrote: > Thanks for volunteering David. It’s great that we are already planning the > 3.1.0 release. > > > On Thu, Sep 16, 2021 at 3:38 PM Bill Bejeck wrote: > > >

[jira] [Created] (KAFKA-13309) InMemorySessionStore#fetch/backwardFetch doesn't return in correct order

2021-09-17 Thread Luke Chen (Jira)
Luke Chen created KAFKA-13309: - Summary: InMemorySessionStore#fetch/backwardFetch doesn't return in correct order Key: KAFKA-13309 URL: https://issues.apache.org/jira/browse/KAFKA-13309 Project: Kafka

Re: [VOTE] KIP-770: Replace "buffered.records.per.partition" with "input.buffer.max.bytes"

2021-09-08 Thread Luke Chen
Thanks for the KIP. + 1 (non-binding) Thanks. Luke On Wed, Sep 8, 2021 at 2:48 PM Josep Prat wrote: > +1 (non binding). > > Thanks for the KIP Sagar! > ——— > Josep Prat > > Aiven Deutschland GmbH > > Immanuelkirchstraße 26, 10405 Berlin > > Amtsgericht Charlottenburg, HRB 209739 B > >

Re: [VOTE] KIP-773 Differentiate consistently metric latency measured in millis and nanos

2021-09-03 Thread Luke Chen
Thanks for the KIP. +1 (non-binding) Thanks. Luke On Sat, Sep 4, 2021 at 10:32 AM Guozhang Wang wrote: > Thanks Josep, > > Took a look at the KIP, LGTM. > > On Fri, Sep 3, 2021 at 11:25 AM Josep Prat > wrote: > > > Hi there, > > > > Since it's a rather small KIP, I'd like to start a vote for

[jira] [Created] (KAFKA-13264) backwardFetch in InMemoryWindowStore doesn't return in reverse order

2021-09-02 Thread Luke Chen (Jira)
Luke Chen created KAFKA-13264: - Summary: backwardFetch in InMemoryWindowStore doesn't return in reverse order Key: KAFKA-13264 URL: https://issues.apache.org/jira/browse/KAFKA-13264 Project: Kafka

Re: [VOTE] KIP-761: Add Total Blocked Time Metric to Streams

2021-09-01 Thread Luke Chen
Thanks for the KIP. +1 (non-binding) Thank you. Luke On Wed, Sep 1, 2021 at 2:36 AM Guozhang Wang wrote: > Thanks for letting us know, Rohan. > > On Tue, Aug 31, 2021 at 1:08 AM Rohan Desai > wrote: > > > FYI I've updated the metric names in the KIP to the form > ".*-time-ns-total" > > and

Re: [DISCUSS] KIP-770: Replace "buffered.records.per.partition" with "input.buffer.max.bytes"

2021-09-01 Thread Luke Chen
Thanks for the KIP. Overall LGTM. Just one thought, if we "rename" the config directly as mentioned in the KIP, would that break existing applications? Should we deprecate the old one first, and make the old/new names co-exist for some period of time? Public Interfaces - Adding a new config

Re: [EXTERNAL] Re: Security vulnerabilities in kafka:2.13-2.6.0/2.7.0 docker image

2021-09-01 Thread Luke Chen
t; *Sent:* 01 September 2021 09:31 > *To:* Ashish Patil > *Subject:* RE: [EXTERNAL] Re: Security vulnerabilities in > kafka:2.13-2.6.0/2.7.0 docker image > > > > > > > > *From:* Luke Chen > *Sent:* 01 September 2021 04:11 > *To:* Kafka Users > *Cc:* dev@kaf

Re: Security vulnerabilities in kafka:2.13-2.6.0/2.7.0 docker image

2021-08-31 Thread Luke Chen
Hi Ashish, I suggested that you upgrade to V2.8. I checked 2 of the CVEs, and are fixed (or not used, like libfetch) in V2.8. If you still found the CVEs existed in V2.8, please raise it. Thank you. Luke On Wed, Sep 1, 2021 at 4:07 AM Ashish Patil wrote: > Hi Team > > I wanted to use the

[jira] [Created] (KAFKA-13230) port EmbeddedKafkaCluster back to auto clean up way

2021-08-26 Thread Luke Chen (Jira)
Luke Chen created KAFKA-13230: - Summary: port EmbeddedKafkaCluster back to auto clean up way Key: KAFKA-13230 URL: https://issues.apache.org/jira/browse/KAFKA-13230 Project: Kafka Issue Type

Re: [VOTE] KIP-748: Add Broker Count Metrics (restarted)

2021-08-25 Thread Luke Chen
+1 (non-binding) Thanks for the KIP! Thank you. Luke On Wed, Aug 25, 2021 at 4:55 AM Jason Gustafson wrote: > Thanks Colin! +1 > > On Mon, Aug 23, 2021 at 1:37 PM David Arthur wrote: > > > Thanks, Colin. Looks good to me! > > > > +1 binding > > > > -David > > > > On Mon, Aug 16, 2021 at 3:37

Re: Kafka Issue

2021-08-20 Thread Luke Chen
s > > Makati City, 1226 > > +63 2753 8865 > > > > > > *Next OOO planned: * > > > > > > *From:* Adam Bellemare > *Sent:* Thursday, 19 August 2021 9:39 pm > *To:* dev@kafka.apache.org > *Cc:* Luke Chen ; Errol Pontillas < > errol.pontil...@

Re: [VOTE] KIP-766: fetch/findSessions queries with open endpoints for SessionStore/WindowStore

2021-08-19 Thread Luke Chen
Hi all, Thanks for the discussion and votes. The KIP passed with: 3 binding votes: Guozhang Wang Bill Bejeck John Roesler 1 non-binding votes: Luke Chen I'll close the vote and start the implementation. Thank you all. Luke On Thu, Aug 19, 2021 at 10:47 PM Bill Bejeck wrote: > Tha

Re: Kafka Issue

2021-08-19 Thread Luke Chen
Hi Roel, I'm not sure if it's just me or not, but I can't see your screenshots, so I don't know what happened. Thanks. Luke On Wed, Aug 18, 2021 at 10:12 PM Jason Kamdon wrote: > Hi Team, > > > > Can we have an update regarding below concern. > > > > > > Thanks! > > > > Regards, > > [image:

Re: Failed Unit testings in ReassignPartitionsIntegrationTest

2021-08-19 Thread Luke Chen
Hi Yanwen, Welcome to Kafka! Usually, we posted flaky tests on JIRA when we saw failed tests on Jenkins build, either on trunk build, or PR build. What you mentioned 2 (flaky) failed tests have not failed in Jenkins for a long time (since build # 364, check below link). Besides, it also passed in

[jira] [Created] (KAFKA-13212) findSessions queries with open endpoints for SessionStore

2021-08-18 Thread Luke Chen (Jira)
Luke Chen created KAFKA-13212: - Summary: findSessions queries with open endpoints for SessionStore Key: KAFKA-13212 URL: https://issues.apache.org/jira/browse/KAFKA-13212 Project: Kafka Issue

[jira] [Created] (KAFKA-13211) fetch queries with open endpoints for WindowStore

2021-08-18 Thread Luke Chen (Jira)
Luke Chen created KAFKA-13211: - Summary: fetch queries with open endpoints for WindowStore Key: KAFKA-13211 URL: https://issues.apache.org/jira/browse/KAFKA-13211 Project: Kafka Issue Type: Sub

[jira] [Created] (KAFKA-13210) fetch/findSessions queries with open endpoints for SessionStore/WindowStore

2021-08-17 Thread Luke Chen (Jira)
Luke Chen created KAFKA-13210: - Summary: fetch/findSessions queries with open endpoints for SessionStore/WindowStore Key: KAFKA-13210 URL: https://issues.apache.org/jira/browse/KAFKA-13210 Project: Kafka

[VOTE] KIP-766: fetch/findSessions queries with open endpoints for SessionStore/WindowStore

2021-08-17 Thread Luke Chen
Hi all, I'd like to start to vote for *KIP-766: fetch/findSessions queries with open endpoints for WindowStore/SessionStore*. This is a follow-up KIP for KIP-763: Range queries with open endpoints . In

Re: Request contributor permission

2021-08-16 Thread Luke Chen
Hi Yanwen, I think Matthias has already granted your permission to jira. Please try to log in and see if you can assign a Kafka ticket to yourselves. Thanks. Luke On Tue, Aug 17, 2021 at 11:15 AM Yanwen Lin wrote: > Hi Kafka team, > > Please help take a look. I’d like to contribute to Apache

[jira] [Created] (KAFKA-13204) wrong assignor selected if the assignor name is identical

2021-08-16 Thread Luke Chen (Jira)
Luke Chen created KAFKA-13204: - Summary: wrong assignor selected if the assignor name is identical Key: KAFKA-13204 URL: https://issues.apache.org/jira/browse/KAFKA-13204 Project: Kafka Issue

Re: [DISCUSS] KIP-766: fetch/findSessions queries with open endpoints for SessionStore/WindowStore

2021-08-08 Thread Luke Chen
Hi all, Sorry that I found the KIP link I provided in the previous email is wrong. Updated link is as below. https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=186876596 Thank you. Luke On Thu, Aug 5, 2021 at 2:31 PM Luke Chen wrote: > Hi everyone, > > I'd like

[DISCUSS] KIP-766: fetch/findSessions queries with open endpoints for SessionStore/WindowStore

2021-08-05 Thread Luke Chen
Hi everyone, I'd like to start the discussion for *KIP-766: fetch/findSessions queries with open endpoints for WindowStore/SessionStore*. This is a follow-up KIP for KIP-763: Range queries with open endpoints

[jira] [Resolved] (KAFKA-13145) Renaming the time interval window for better understanding

2021-08-03 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen resolved KAFKA-13145. --- Resolution: Won't Fix > Renaming the time interval window for better understand

<    3   4   5   6   7   8   9   10   >