Re: Review Request 36858: Patch for KAFKA-2120

sconnect(id)? It seems that we can just replace the > > usage in test with close(id) and remove disconnect from selectable and > > KafkaChannel? We have to implement close(id) in MockSelector(). > > Mayuresh Gharat wrote: > Hi Jun, > Thats a very good suggestion. I had

Re: Review Request 36858: Patch for KAFKA-2120

kedList would be better in this case. - Mayuresh --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36858/#review98438 -------

Re: Review Request 36858: Patch for KAFKA-2120

mail. To reply, visit: https://reviews.apache.org/r/36858/#review98526 ------- On Sept. 10, 2015, 1:56 a.m., Mayuresh Gharat wrote: > > --- > This is an automatically gener

Re: Review Request 36858: Patch for KAFKA-2120

, Mayuresh Gharat

[jira] [Updated] (KAFKA-2120) Add a request timeout to NetworkClient

[ https://issues.apache.org/jira/browse/KAFKA-2120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mayuresh Gharat updated KAFKA-2120: --- Attachment: KAFKA-2120_2015-09-10_21:38:55.patch > Add a request timeout to NetworkCli

[jira] [Commented] (KAFKA-2120) Add a request timeout to NetworkClient

[ https://issues.apache.org/jira/browse/KAFKA-2120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14740166#comment-14740166 ] Mayuresh Gharat commented on KAFKA-2120: Updated reviewboard https://reviews.apache.org/r/36858

Re: Review Request 36858: Patch for KAFKA-2120

/TestUtils.scala 09b8444c2add87f0f70dbb182e892977a6b5c243 Diff: https://reviews.apache.org/r/36858/diff/ Testing --- Thanks, Mayuresh Gharat

[jira] [Updated] (KAFKA-2120) Add a request timeout to NetworkClient

[ https://issues.apache.org/jira/browse/KAFKA-2120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mayuresh Gharat updated KAFKA-2120: --- Attachment: KAFKA-2120_2015-09-09_16:45:44.patch > Add a request timeout to NetworkCli

[jira] [Commented] (KAFKA-2120) Add a request timeout to NetworkClient

[ https://issues.apache.org/jira/browse/KAFKA-2120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14737819#comment-14737819 ] Mayuresh Gharat commented on KAFKA-2120: Updated reviewboard https://reviews.apache.org/r/36858

Re: Review Request 36858: Patch for KAFKA-2120

it: https://reviews.apache.org/r/36858/#review98136 ------- On Sept. 9, 2015, 11:46 p.m., Mayuresh Gharat wrote: > > --- > This is an automatically generated e

Re: Review Request 36858: Patch for KAFKA-2120

core/src/test/scala/unit/kafka/utils/TestUtils.scala 09b8444c2add87f0f70dbb182e892977a6b5c243 Diff: https://reviews.apache.org/r/36858/diff/ Testing --- Thanks, Mayuresh Gharat

Re: Review Request 36858: Patch for KAFKA-2120

/RecordAccumulator.java (line 208) <https://reviews.apache.org/r/36858/#comment154711> I am going to upload a new patch for breaking out of this iteration early if possible. I am going to test it out and upload a new patch if that works. - Mayuresh Gharat On Sept. 9, 2015, 11:

[jira] [Commented] (KAFKA-2120) Add a request timeout to NetworkClient

[ https://issues.apache.org/jira/browse/KAFKA-2120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14737994#comment-14737994 ] Mayuresh Gharat commented on KAFKA-2120: Updated reviewboard https://reviews.apache.org/r/36858

[jira] [Updated] (KAFKA-2120) Add a request timeout to NetworkClient

[ https://issues.apache.org/jira/browse/KAFKA-2120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mayuresh Gharat updated KAFKA-2120: --- Attachment: KAFKA-2120_2015-09-09_18:56:18.patch > Add a request timeout to NetworkCli

Re: Review Request 36858: Patch for KAFKA-2120

/test/scala/unit/kafka/server/KafkaConfigTest.scala 5b4f2db4607ae6d17696c1140f1a771ce75c80e0 core/src/test/scala/unit/kafka/utils/TestUtils.scala 09b8444c2add87f0f70dbb182e892977a6b5c243 Diff: https://reviews.apache.org/r/36858/diff/ Testing --- Thanks, Mayuresh Gharat

[jira] [Assigned] (KAFKA-2526) Console Producer / Consumer's serde config is not working

[ https://issues.apache.org/jira/browse/KAFKA-2526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mayuresh Gharat reassigned KAFKA-2526: -- Assignee: Mayuresh Gharat > Console Producer / Consumer's serde config is not work

Re: Maybe 0.8.3 should really be 0.9.0?

+1 for 0.9 - we may want to get rid of deprecated configs if possible in this, instead of waiting for 1.0. Thanks, Mayuresh On Tue, Sep 8, 2015 at 2:07 PM, Joel Koshy wrote: > +1 on 0.9 - we may want to adjust our ApiVersions accordingly (i.e., > 0.8.3 -> 0.9.0) > > > On

[jira] [Commented] (KAFKA-2120) Add a request timeout to NetworkClient

[ https://issues.apache.org/jira/browse/KAFKA-2120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14735899#comment-14735899 ] Mayuresh Gharat commented on KAFKA-2120: Hi [~junrao], I have uploaded a new patch addressing

Re: Review Request 36858: Patch for KAFKA-2120

of introduced some changes and I will need to rebase this patch with that. I am facing some issues when I rebased (test failures), so I will try to get those solved, include the approach that you have suggested above and upload a new patch. - Mayuresh --------

[jira] [Updated] (KAFKA-2120) Add a request timeout to NetworkClient

[ https://issues.apache.org/jira/browse/KAFKA-2120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mayuresh Gharat updated KAFKA-2120: --- Attachment: KAFKA-2120_2015-09-04_17:49:01.patch > Add a request timeout to NetworkCli

Re: Review Request 36858: Patch for KAFKA-2120

/ Testing --- Thanks, Mayuresh Gharat

[jira] [Commented] (KAFKA-2120) Add a request timeout to NetworkClient

[ https://issues.apache.org/jira/browse/KAFKA-2120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14731670#comment-14731670 ] Mayuresh Gharat commented on KAFKA-2120: Updated reviewboard https://reviews.apache.org/r/36858

[jira] [Updated] (KAFKA-2120) Add a request timeout to NetworkClient

[ https://issues.apache.org/jira/browse/KAFKA-2120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mayuresh Gharat updated KAFKA-2120: --- Status: Patch Available (was: In Progress) > Add a request timeout to NetworkCli

[jira] [Updated] (KAFKA-2120) Add a request timeout to NetworkClient

[ https://issues.apache.org/jira/browse/KAFKA-2120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mayuresh Gharat updated KAFKA-2120: --- Attachment: KAFKA-2120_2015-09-03_15:12:02.patch > Add a request timeout to NetworkCli

[jira] [Commented] (KAFKA-2120) Add a request timeout to NetworkClient

[ https://issues.apache.org/jira/browse/KAFKA-2120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14729893#comment-14729893 ] Mayuresh Gharat commented on KAFKA-2120: Updated reviewboard https://reviews.apache.org/r/36858

Re: Review Request 36858: Patch for KAFKA-2120

be replaced by requestTimeout. "request.timeout.ms - the maximum time to wait for the response of a message AFTER the batch is ready, including: actual network RTT, server replication time" - Mayuresh Gharat On Sept. 3, 2015, 10:12 p.m.,

Re: Review Request 36858: Patch for KAFKA-2120

tate. This will make the state in > > networkClient consistent after each poll() call. If we have that, we can > > just call networkClient.disconnect() in handleTimedOutRequests() and handle > > those disconnected connections immediately. Then, we don't need to maintain > > th

Re: Review Request 36858: Patch for KAFKA-2120

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36858/#review97213 --- On Aug. 12, 2015, 5:59 p.m., Mayuresh Gharat wrote: > > -

Re: Review Request 36652: Patch for KAFKA-2351

/diff/ Testing --- Thanks, Mayuresh Gharat

[jira] [Commented] (KAFKA-2351) Brokers are having a problem shutting down correctly

[ https://issues.apache.org/jira/browse/KAFKA-2351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14710205#comment-14710205 ] Mayuresh Gharat commented on KAFKA-2351: Updated reviewboard https

[jira] [Updated] (KAFKA-2351) Brokers are having a problem shutting down correctly

[ https://issues.apache.org/jira/browse/KAFKA-2351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mayuresh Gharat updated KAFKA-2351: --- Attachment: KAFKA-2351_2015-08-24_15:50:41.patch Brokers are having a problem shutting down

[jira] [Commented] (KAFKA-2391) Blocking call such as position(), partitionsFor(), committed() and listTopics() should have a timeout

[ https://issues.apache.org/jira/browse/KAFKA-2391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14708710#comment-14708710 ] Mayuresh Gharat commented on KAFKA-2391: [~jkreps] that is right. Was just

Problem with Kafka Review Board

The kafka review board returns a 500. https://reviews.apache.org/r/36652 returns this : Something broke! (Error 500) It appears something broke when you tried to go to here. This is either a bug in Review Board or a server configuration error. Please report this to your administrator

Re: Review Request 36652: Patch for KAFKA-2351

, visit: https://reviews.apache.org/r/36652/#review95824 --- On Aug. 13, 2015, 8:10 p.m., Mayuresh Gharat wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 36652: Patch for KAFKA-2351

) https://reviews.apache.org/r/36652/#comment151020 I referred this : https://www.sumologic.com/2014/05/05/why-you-should-never-catch-throwable-in-scala/ from the kafka 2353 patch. http://www.tzavellas.com/techblog/2010/09/20/catching-throwable-in-scala/ - Mayuresh Gharat On Aug. 13

Re: [DISCUSSION] Interface change notes in commit messages?

+1 for this. Also we can put description of what changes might be required to make in the current running release. But that might be cumbersome. Just a thought. Thanks, Mayuresh On Wed, Aug 19, 2015 at 2:29 PM, Jiangjie Qin j...@linkedin.com.invalid wrote: I am thinking can we put some notes

[jira] [Updated] (KAFKA-2432) Controlled shutdown does not proceed successfully while shutting down the broker.

[ https://issues.apache.org/jira/browse/KAFKA-2432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mayuresh Gharat updated KAFKA-2432: --- Description: {code} [2015-08-05 00:19:09,998] INFO [Offset Manager on Broker 0]: Removed 0

[jira] [Updated] (KAFKA-2432) Controlled shutdown does not proceed successfully while shutting down the broker.

[ https://issues.apache.org/jira/browse/KAFKA-2432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mayuresh Gharat updated KAFKA-2432: --- Description: [2015-08-05 00:19:09,998] INFO [Offset Manager on Broker 0]: Removed 0 expired

[jira] [Updated] (KAFKA-2432) Controlled shutdown does not proceed successfully while shutting down the broker.

[ https://issues.apache.org/jira/browse/KAFKA-2432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mayuresh Gharat updated KAFKA-2432: --- Description: {format} [2015-08-05 00:19:09,998] INFO [Offset Manager on Broker 0]: Removed 0

[jira] [Created] (KAFKA-2432) Controlled shutdown does not proceed successfully while shutting down the broker.

Mayuresh Gharat created KAFKA-2432: -- Summary: Controlled shutdown does not proceed successfully while shutting down the broker. Key: KAFKA-2432 URL: https://issues.apache.org/jira/browse/KAFKA-2432

[jira] [Updated] (KAFKA-2432) Controlled shutdown does not proceed successfully while shutting down the broker. Follow up from KAFKA-2351

[ https://issues.apache.org/jira/browse/KAFKA-2432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mayuresh Gharat updated KAFKA-2432: --- Summary: Controlled shutdown does not proceed successfully while shutting down the broker

[jira] [Updated] (KAFKA-2351) Brokers are having a problem shutting down correctly

[ https://issues.apache.org/jira/browse/KAFKA-2351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mayuresh Gharat updated KAFKA-2351: --- Status: Patch Available (was: In Progress) Brokers are having a problem shutting down

[jira] [Updated] (KAFKA-2351) Brokers are having a problem shutting down correctly

[ https://issues.apache.org/jira/browse/KAFKA-2351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mayuresh Gharat updated KAFKA-2351: --- Attachment: KAFKA-2351_2015-08-13_13:10:05.patch Brokers are having a problem shutting down

Re: Review Request 36652: Patch for KAFKA-2351

/network/SocketServer.scala dbe784b63817fd94e1593136926db17fac6fa3d7 Diff: https://reviews.apache.org/r/36652/diff/ Testing --- Thanks, Mayuresh Gharat

[jira] [Commented] (KAFKA-2351) Brokers are having a problem shutting down correctly

[ https://issues.apache.org/jira/browse/KAFKA-2351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14695859#comment-14695859 ] Mayuresh Gharat commented on KAFKA-2351: Updated reviewboard https

[jira] [Updated] (KAFKA-2120) Add a request timeout to NetworkClient

[ https://issues.apache.org/jira/browse/KAFKA-2120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mayuresh Gharat updated KAFKA-2120: --- Attachment: KAFKA-2120_2015-08-12_10:59:09.patch Add a request timeout to NetworkClient

[jira] [Commented] (KAFKA-2120) Add a request timeout to NetworkClient

[ https://issues.apache.org/jira/browse/KAFKA-2120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14693951#comment-14693951 ] Mayuresh Gharat commented on KAFKA-2120: Updated reviewboard https

[jira] [Created] (KAFKA-2428) Add sanity test in kafkaConsumer for the timeouts. This is a followup ticket for Kafka-2120

Mayuresh Gharat created KAFKA-2428: -- Summary: Add sanity test in kafkaConsumer for the timeouts. This is a followup ticket for Kafka-2120 Key: KAFKA-2428 URL: https://issues.apache.org/jira/browse/KAFKA-2428

Re: Review Request 36858: Patch for KAFKA-2120

). Even if we don't address the issue of sanity between the different timeouts in this patch, it would be nice to have compatible defaults to keep the consumer from breaking out of the box. Mayuresh Gharat wrote: Hi Jason, I will upload a new patch with the sanity test

Re: Review Request 36858: Patch for KAFKA-2120

/ProducerFailureHandlingTest.scala ee94011894b46864614b97bbd2a98375a7d3f20b core/src/test/scala/unit/kafka/utils/TestUtils.scala eb169d8b33c27d598cc24e5a2e5f78b789fa38d3 Diff: https://reviews.apache.org/r/36858/diff/ Testing --- Thanks, Mayuresh Gharat

Re: Review Request 36858: Patch for KAFKA-2120

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36858/#review94999 --- On Aug. 11, 2015, 2:55 a.m., Mayuresh Gharat wrote

[jira] [Commented] (KAFKA-1387) Kafka getting stuck creating ephemeral node it has already created when two zookeeper sessions are established in a very short period of time

[ https://issues.apache.org/jira/browse/KAFKA-1387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14682263#comment-14682263 ] Mayuresh Gharat commented on KAFKA-1387: Can the person who uploaded the patch

Re: Kafka Indentation

missed it. +1 on rewriting Kafka in Java. Thanks, Mayuresh On Tue, Aug 11, 2015 at 5:23 PM, Jason Gustafson ja...@confluent.io wrote: Can the java code be indented without affecting the results of git blame? If not, then I'd vote to leave it as it is. (Also +1 on rewriting Kafka in Java)

Re: Kafka Indentation

+1 on consistency. Thanks, Mayuresh On Tue, Aug 11, 2015 at 5:15 PM, Aditya Auradkar aaurad...@linkedin.com.invalid wrote: Bump. Anyone else have an opinion? Neha/Jay - You've made your thoughts clear. Any thoughts on how/if we make any changes? Thanks, Aditya On Fri, Jul 24, 2015

[jira] [Commented] (KAFKA-2120) Add a request timeout to NetworkClient

[ https://issues.apache.org/jira/browse/KAFKA-2120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14681145#comment-14681145 ] Mayuresh Gharat commented on KAFKA-2120: Updated reviewboard https

Re: Review Request 36858: Patch for KAFKA-2120

--- On Aug. 11, 2015, 2:55 a.m., Mayuresh Gharat wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36858

Re: Review Request 36858: Patch for KAFKA-2120

core/src/test/scala/unit/kafka/utils/TestUtils.scala eb169d8b33c27d598cc24e5a2e5f78b789fa38d3 Diff: https://reviews.apache.org/r/36858/diff/ Testing --- Thanks, Mayuresh Gharat

[jira] [Updated] (KAFKA-2120) Add a request timeout to NetworkClient

[ https://issues.apache.org/jira/browse/KAFKA-2120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mayuresh Gharat updated KAFKA-2120: --- Status: Patch Available (was: In Progress) Add a request timeout to NetworkClient

[jira] [Updated] (KAFKA-2120) Add a request timeout to NetworkClient

[ https://issues.apache.org/jira/browse/KAFKA-2120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mayuresh Gharat updated KAFKA-2120: --- Attachment: KAFKA-2120_2015-08-10_19:55:18.patch Add a request timeout to NetworkClient

[jira] [Commented] (KAFKA-1835) Kafka new producer needs options to make blocking behavior explicit

[ https://issues.apache.org/jira/browse/KAFKA-1835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14662476#comment-14662476 ] Mayuresh Gharat commented on KAFKA-1835: [~stevenz3wu] KAFKA-2120 has max.block.ms

[jira] [Commented] (KAFKA-2120) Add a request timeout to NetworkClient

[ https://issues.apache.org/jira/browse/KAFKA-2120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14660276#comment-14660276 ] Mayuresh Gharat commented on KAFKA-2120: [~jasong35] I am not too familiar

[jira] [Commented] (KAFKA-2120) Add a request timeout to NetworkClient

[ https://issues.apache.org/jira/browse/KAFKA-2120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14660397#comment-14660397 ] Mayuresh Gharat commented on KAFKA-2120: [~becket_qin] yes we can do that. I

[jira] [Commented] (KAFKA-2351) Brokers are having a problem shutting down correctly

[ https://issues.apache.org/jira/browse/KAFKA-2351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14660361#comment-14660361 ] Mayuresh Gharat commented on KAFKA-2351: Thanks [~junrao]. I will see if I can

[jira] [Comment Edited] (KAFKA-2351) Brokers are having a problem shutting down correctly

[ https://issues.apache.org/jira/browse/KAFKA-2351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14660361#comment-14660361 ] Mayuresh Gharat edited comment on KAFKA-2351 at 8/6/15 5:11 PM

[jira] [Comment Edited] (KAFKA-2120) Add a request timeout to NetworkClient

[ https://issues.apache.org/jira/browse/KAFKA-2120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14660397#comment-14660397 ] Mayuresh Gharat edited comment on KAFKA-2120 at 8/6/15 5:24 PM

[jira] [Commented] (KAFKA-2120) Add a request timeout to NetworkClient

[ https://issues.apache.org/jira/browse/KAFKA-2120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14660314#comment-14660314 ] Mayuresh Gharat commented on KAFKA-2120: Hi [~jasong35], Cool. So what we can do

[jira] [Commented] (KAFKA-2351) Brokers are having a problem shutting down correctly

[ https://issues.apache.org/jira/browse/KAFKA-2351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14658749#comment-14658749 ] Mayuresh Gharat commented on KAFKA-2351: [~sslavic] I think this is different

[jira] [Commented] (KAFKA-2351) Brokers are having a problem shutting down correctly

[ https://issues.apache.org/jira/browse/KAFKA-2351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14654691#comment-14654691 ] Mayuresh Gharat commented on KAFKA-2351: [~junrao] would you mind taking another

[jira] [Commented] (KAFKA-1860) File system errors are not detected unless Kafka tries to write

[ https://issues.apache.org/jira/browse/KAFKA-1860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14652067#comment-14652067 ] Mayuresh Gharat commented on KAFKA-1860: [~guozhang] ping. File system errors

[jira] [Assigned] (KAFKA-2391) Blocking call such as position(), partitionsFor(), committed() and listTopics() should have a timeout

[ https://issues.apache.org/jira/browse/KAFKA-2391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mayuresh Gharat reassigned KAFKA-2391: -- Assignee: Mayuresh Gharat Blocking call such as position(), partitionsFor

[jira] [Updated] (KAFKA-2120) Add a request timeout to NetworkClient

[ https://issues.apache.org/jira/browse/KAFKA-2120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mayuresh Gharat updated KAFKA-2120: --- Fix Version/s: 0.8.3 Add a request timeout to NetworkClient

[jira] [Updated] (KAFKA-2351) Brokers are having a problem shutting down correctly

[ https://issues.apache.org/jira/browse/KAFKA-2351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mayuresh Gharat updated KAFKA-2351: --- Status: Patch Available (was: In Progress) Brokers are having a problem shutting down

Re: Review Request 36858: Patch for KAFKA-2120

--- Thanks, Mayuresh Gharat

[jira] [Updated] (KAFKA-2120) Add a request timeout to NetworkClient

[ https://issues.apache.org/jira/browse/KAFKA-2120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mayuresh Gharat updated KAFKA-2120: --- Attachment: KAFKA-2120_2015-07-29_15:57:02.patch Add a request timeout to NetworkClient

[jira] [Commented] (KAFKA-2120) Add a request timeout to NetworkClient

[ https://issues.apache.org/jira/browse/KAFKA-2120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14646887#comment-14646887 ] Mayuresh Gharat commented on KAFKA-2120: Updated reviewboard https

Re: Review Request 36858: Patch for KAFKA-2120

://reviews.apache.org/r/36858/diff/ Testing --- Thanks, Mayuresh Gharat

Re: KIP Meeting starting now

Hey Guozhang, Can you forward the invite again? Thanks, Mayuresh On Tue, Jul 28, 2015 at 11:04 AM, Guozhang Wang wangg...@gmail.com wrote: Hi, Just a reminder that today's KIP meeting is on GoToMeeting, not on Hangout. Please find the link on the invite to join. -- Guozhang --

Re: New Producer and acks configuration

So basically this means that with acks = 0, their is no guarantee that the message has been received by Kafka broker. I am just wondering, why would anyone be using acks = 0, since anyone using kafka and doing producer.send() would want that, their message got to kafka brokers. Also as Jay said,

[jira] [Commented] (KAFKA-2260) Allow specifying expected offset on produce

[ https://issues.apache.org/jira/browse/KAFKA-2260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14643065#comment-14643065 ] Mayuresh Gharat commented on KAFKA-2260: I think, when 2 producers are trying

Review Request 36858: Patch for KAFKA-2120

8b1805d3d2bcb9fe2bacb37d870c3236aa9532c4 Diff: https://reviews.apache.org/r/36858/diff/ Testing --- Thanks, Mayuresh Gharat

[jira] [Commented] (KAFKA-2120) Add a request timeout to NetworkClient

[ https://issues.apache.org/jira/browse/KAFKA-2120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14643399#comment-14643399 ] Mayuresh Gharat commented on KAFKA-2120: Created reviewboard https

[jira] [Updated] (KAFKA-2120) Add a request timeout to NetworkClient

[ https://issues.apache.org/jira/browse/KAFKA-2120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mayuresh Gharat updated KAFKA-2120: --- Status: Patch Available (was: Open) Add a request timeout to NetworkClient

[jira] [Updated] (KAFKA-2120) Add a request timeout to NetworkClient

[ https://issues.apache.org/jira/browse/KAFKA-2120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mayuresh Gharat updated KAFKA-2120: --- Attachment: KAFKA-2120.patch Add a request timeout to NetworkClient

Re: Review Request 36858: Patch for KAFKA-2120

/clients/producer/internals/SenderTest.java 8b1805d3d2bcb9fe2bacb37d870c3236aa9532c4 Diff: https://reviews.apache.org/r/36858/diff/ Testing --- Thanks, Mayuresh Gharat

Re: Review Request 36858: Patch for KAFKA-2120

/RecordAccumulatorTest.java 5b2e4ffaeab7127648db608c179703b27b577414 clients/src/test/java/org/apache/kafka/clients/producer/internals/SenderTest.java 8b1805d3d2bcb9fe2bacb37d870c3236aa9532c4 Diff: https://reviews.apache.org/r/36858/diff/ Testing --- Thanks, Mayuresh Gharat

[jira] [Commented] (KAFKA-2120) Add a request timeout to NetworkClient

[ https://issues.apache.org/jira/browse/KAFKA-2120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14643533#comment-14643533 ] Mayuresh Gharat commented on KAFKA-2120: Updated reviewboard https

[jira] [Updated] (KAFKA-2120) Add a request timeout to NetworkClient

[ https://issues.apache.org/jira/browse/KAFKA-2120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mayuresh Gharat updated KAFKA-2120: --- Attachment: KAFKA-2120_2015-07-27_15:31:19.patch Add a request timeout to NetworkClient

Re: error while high level consumer

Try bouncing the host that appears in the stored data section. Thanks, Mayuresh On Mon, Jul 27, 2015 at 3:41 PM, Jiangjie Qin j...@linkedin.com.invalid wrote: This is due to the zookeeper path storing the previous owner info hasn't been deleted at the moment. If the rebalance completes after

Re: Kafka High level consumer rebalancing

? Thanks -Pranay On Tue, Jul 21, 2015 at 11:25 AM, Mayuresh Gharat gharatmayures...@gmail.com wrote: Not sure if you can do that with High level consumer. Thanks, Mayuresh On Tue, Jul 21, 2015 at 10:53 AM, Pranay Agarwal agarwalpran...@gmail.com wrote: Any ideas

[jira] [Commented] (KAFKA-2351) Brokers are having a problem shutting down correctly

[ https://issues.apache.org/jira/browse/KAFKA-2351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14641009#comment-14641009 ] Mayuresh Gharat commented on KAFKA-2351: Hi [~junrao], Thanks for the comments

Re: Query about LogConfigs

configuration during upgrade. On Fri, Jul 24, 2015 at 6:34 PM, Mayuresh Gharat gharatmayures...@gmail.com wrote: I was thinking why we have 3 different configs for the same property (log retention) : log.retention.ms log.retention.minutes log.retention.hours Why don't we

Re: Query about LogConfigs

to avoid break configuration during upgrade. On Fri, Jul 24, 2015 at 6:34 PM, Mayuresh Gharat gharatmayures...@gmail.com wrote: I was thinking why we have 3 different configs for the same property (log retention) : log.retention.ms log.retention.minutes log.retention.hours Why

Re: Query about LogConfigs

)) } else { millisInHour * props.getIntInRange(log.retention.hours, 24*7, (1, Int.MaxValue)) } } On Fri, Jul 24, 2015 at 9:18 PM, Mayuresh Gharat gharatmayures...@gmail.com wrote: Hmm. This creates confusion for people who might be new to kafka or have never used those

Query about LogConfigs

I was thinking why we have 3 different configs for the same property (log retention) : log.retention.ms log.retention.minutes log.retention.hours Why don't we only use the Milliseconds? There are other properties as well like log Jitter, LogRollTime which raise the same question in my mind.

Re: Review Request 36652: Patch for KAFKA-2351

91319fa010b140cca632e5fa8050509bd2295fc9 Diff: https://reviews.apache.org/r/36652/diff/ Testing --- Thanks, Mayuresh Gharat

[jira] [Updated] (KAFKA-2351) Brokers are having a problem shutting down correctly

[ https://issues.apache.org/jira/browse/KAFKA-2351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mayuresh Gharat updated KAFKA-2351: --- Attachment: KAFKA-2351_2015-07-23_21:36:52.patch Brokers are having a problem shutting down

[jira] [Commented] (KAFKA-2351) Brokers are having a problem shutting down correctly

[ https://issues.apache.org/jira/browse/KAFKA-2351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14639910#comment-14639910 ] Mayuresh Gharat commented on KAFKA-2351: Updated reviewboard https

[jira] [Commented] (KAFKA-2351) Brokers are having a problem shutting down correctly

[ https://issues.apache.org/jira/browse/KAFKA-2351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14639097#comment-14639097 ] Mayuresh Gharat commented on KAFKA-2351: Hi [~ijuma], thanks a lot for pointing me

[jira] [Commented] (KAFKA-2351) Brokers are having a problem shutting down correctly

[ https://issues.apache.org/jira/browse/KAFKA-2351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14638076#comment-14638076 ] Mayuresh Gharat commented on KAFKA-2351: [~junrao], [~guozhang] can you take

Submitting a patch (Jira errors)

Hi, I had to clean up existing kafka repo on my linux box and start with a fresh one. I followed the instructions here : https://cwiki.apache.org/confluence/display/KAFKA/Patch+submission+and+review I am trying to upload a patch and I am getting these errors : Configuring reviewboard url to

<    1   2   3   4   5   6   >