> On Aug. 19, 2015, 5:48 a.m., Joel Koshy wrote: > > core/src/main/scala/kafka/network/SocketServer.scala, line 265 > > <https://reviews.apache.org/r/36652/diff/4/?file=1039545#file1039545line265> > > > > I'm also unclear at this point on what the right thing to do here would > > be - i.e., log and continue or make it fatal as Becket suggested. I'm > > leaning toward the latter but I agree we could revisit this.
By fatal do you mean that we should shutdown the broker? - Mayuresh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36652/#review95824 ----------------------------------------------------------- On Aug. 13, 2015, 8:10 p.m., Mayuresh Gharat wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36652/ > ----------------------------------------------------------- > > (Updated Aug. 13, 2015, 8:10 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-2351 > https://issues.apache.org/jira/browse/KAFKA-2351 > > > Repository: kafka > > > Description > ------- > > Added a try-catch to catch any exceptions thrown by the nioSelector > > > Addressed comments on the Jira ticket > > > Addressed Jun's comments > > > Diffs > ----- > > core/src/main/scala/kafka/network/SocketServer.scala > dbe784b63817fd94e1593136926db17fac6fa3d7 > > Diff: https://reviews.apache.org/r/36652/diff/ > > > Testing > ------- > > > Thanks, > > Mayuresh Gharat > >
