Re: [DISCUSS] KIP-147: Add missing type parameters to StateStoreSupplier factories and KGroupedStream/Table methods

I updated this KIP as discarded. On 10/13/17 10:34 AM, Matthias J. Sax wrote: > Hi, > > with KIP-182 being implemented in 1.0 that will be released shortly, I > wanted to follow up on this KIP. It seems, that we don't need it any > longer, as KIP-182 resolves those issues. > > If you agree,

Re: [DISCUSS] KIP-147: Add missing type parameters to StateStoreSupplier factories and KGroupedStream/Table methods

Hi, with KIP-182 being implemented in 1.0 that will be released shortly, I wanted to follow up on this KIP. It seems, that we don't need it any longer, as KIP-182 resolves those issues. If you agree, please update the KIP wiki page accordingly and move the KIP to "discarded" table. Thanks a

Re: [DISCUSS] KIP-147: Add missing type parameters to StateStoreSupplier factories and KGroupedStream/Table methods

I think the discussion on Streams DSL refactoring will render this KIP obsolete. I'll leave is as under discussion until something is agreed and then move it to discarded. Cheers, Michał On 03/06/17 10:02, Michal Borowiecki wrote: I agree maintaining backwards-compatibility here adds a

Re: [DISCUSS] KIP-147: Add missing type parameters to StateStoreSupplier factories and KGroupedStream/Table methods

I agree maintaining backwards-compatibility here adds a lot of overhead. I haven't so far found a way to reconcile these elegantly. Whichever way we go it's better to take the pain sooner rather than later. Kafka 0.11.0.0 (through KAFKA-5045

Re: [DISCUSS] KIP-147: Add missing type parameters to StateStoreSupplier factories and KGroupedStream/Table methods

Hmm, i guess this won't work due to adding the additional to the StateStoreSupplier params on reduce, count, aggregate etc. On Sat, 3 Jun 2017 at 09:06 Damian Guy wrote: > Hi Michal, > > Thanks for the KIP - is there a way we can do this without having to > introduce

Re: [DISCUSS] KIP-147: Add missing type parameters to StateStoreSupplier factories and KGroupedStream/Table methods

Hi Michal, Thanks for the KIP - is there a way we can do this without having to introduce the new Typed.. Interfaces, overloaded methods etc? Is it possible that we just need to provide a couple of new methods on PersistentKeyValueFactory for windowed and sessionWindowed to return interfaces like

Re: [DISCUSS] KIP-147: Add missing type parameters to StateStoreSupplier factories and KGroupedStream/Table methods

Thanks Matthias, I appreciate people are busy now preparing the 0.11 release. One thing I would also appreciate input on is perhaps a better name for the new TypedStores class, I just picked it quickly but don't really like it. Perhaps StateStores would make for a better name? Cheers,

Re: [DISCUSS] KIP-147: Add missing type parameters to StateStoreSupplier factories and KGroupedStream/Table methods

Thanks for the update Michal. I did skip over the PR. Looks good to me, as far as I can tell. Maybe Damian, Xavier, or Ismael can comment on this. Would be good to get confirmation that the change is backward compatible. -Matthias On 5/27/17 11:11 AM, Michal Borowiecki wrote: > Hi all, > >

Re: [DISCUSS] KIP-147: Add missing type parameters to StateStoreSupplier factories and KGroupedStream/Table methods

Hi all, I've updated the KIP to reflect the proposed backwards-compatible approach: https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=69408481 Given the vast area of APIs affected, I think the PR is easier to read than the code excerpts in the KIP itself:

Re: [DISCUSS] KIP-147: Add missing type parameters to StateStoreSupplier factories and KGroupedStream/Table methods

To visualise this better, I've created a WIP PR: https://github.com/apache/kafka/pull/2992 tentatively having named the new Stores class TypedStores. Thanks, Michał On 07/05/17 10:16, Eno Thereska wrote: I like this KIP in general and I agree it’s needed. Perhaps Damian can comment on the

Re: [DISCUSS] KIP-147: Add missing type parameters to StateStoreSupplier factories and KGroupedStream/Table methods

I like this KIP in general and I agree it’s needed. Perhaps Damian can comment on the session store issue? Thanks Eno > On May 6, 2017, at 10:32 PM, Michal Borowiecki > wrote: > > Hi Matthias, > > Agreed. I tried your proposal and indeed it would work. > >

Re: [DISCUSS] KIP-147: Add missing type parameters to StateStoreSupplier factories and KGroupedStream/Table methods

Hi Matthias, Agreed. I tried your proposal and indeed it would work. However, I think to maintain full backward compatibility we would also need to deprecate Stores.create() and leave it unchanged, while providing a new method that returns the more strongly typed Factories. ( This is

Re: [DISCUSS] KIP-147: Add missing type parameters to StateStoreSupplier factories and KGroupedStream/Table methods

I had a quick look into this. With regard to backward compatibility, I think it would be required do introduce a new type `TypesStateStoreSupplier` (that extends `StateStoreSupplier`) and to overload all methods that take a `StateStoreSupplier` that accept the new type instead of the current one.

Re: [DISCUSS] KIP-147: Add missing type parameters to StateStoreSupplier factories and KGroupedStream/Table methods

Did not have time to have a look. But backward compatibility is a must from my point of view. -Matthias On 5/4/17 12:56 AM, Michal Borowiecki wrote: > Hello, > > I've updated the KIP with missing information. > > I would especially appreciate some comments on the compatibility aspects > of

Re: [DISCUSS] KIP-147: Add missing type parameters to StateStoreSupplier factories and KGroupedStream/Table methods

Hello, I've updated the KIP with missing information. I would especially appreciate some comments on the compatibility aspects of this as the proposed change is not fully backwards-compatible. In the absence of comments I shall call for a vote in the next few days. Thanks, Michal On

[DISCUSS] KIP-147: Add missing type parameters to StateStoreSupplier factories and KGroupedStream/Table methods

Hi community! I have just drafted KIP-147: Add missing type parameters to StateStoreSupplier factories and KGroupedStream/Table methods Please let me know if this a step in the right direction. All comments welcome.