Re: [DISCUSS] KIP-378: Enable Dependency Injection for Kafka Streams handlers

Moved this KIP into status "inactive". Feel free to resume and any time. -Matthias On 4/26/19 2:00 AM, Matthias J. Sax wrote: > What is the status of this KIP? > > -Matthias > > > On 3/18/19 5:11 PM, Guozhang Wang wrote: >> Hello Wladimir, >> >> Thanks for the replies. >> >> What do you mean

Re: [DISCUSS] KIP-378: Enable Dependency Injection for Kafka Streams handlers

What is the status of this KIP? -Matthias On 3/18/19 5:11 PM, Guozhang Wang wrote: > Hello Wladimir, > > Thanks for the replies. > > What do you mean by "the community has opted for the second more complex > solution"? Could you elaborate a bit more? > > Guozhang > > > On Sun, Mar 17, 2019

Re: [DISCUSS] KIP-378: Enable Dependency Injection for Kafka Streams handlers

Hello Wladimir, Thanks for the replies. What do you mean by "the community has opted for the second more complex solution"? Could you elaborate a bit more? Guozhang On Sun, Mar 17, 2019 at 3:45 PM Wladimir Schmidt wrote: > Hi Matthias, > > Sorry, due to other commitments I haven't started

Re: [DISCUSS] KIP-378: Enable Dependency Injection for Kafka Streams handlers

Hi Matthias, Sorry, due to other commitments I haven't started the other implementation yet. In the meantime, the community has opted for the second, more complex solution. I already had ideas in this regard, but their elaboration needs to be discussed more. Best greetings, Wladimir On

Re: [DISCUSS] KIP-378: Enable Dependency Injection for Kafka Streams handlers

Hi Wladimir, what is the status of this KIP? -Matthias On 1/9/19 4:17 PM, Guozhang Wang wrote: > Hello Wladimir, > > Just checking if you are still working on this KIP. We have the 2.2 KIP > freeze deadline by 24th this month, and it'll be great to complete this KIP > by then so 2.2.0 release

Re: [DISCUSS] KIP-378: Enable Dependency Injection for Kafka Streams handlers

Hello Wladimir, Just checking if you are still working on this KIP. We have the 2.2 KIP freeze deadline by 24th this month, and it'll be great to complete this KIP by then so 2.2.0 release could have this feature. Guozhang On Mon, Dec 3, 2018 at 11:26 PM Guozhang Wang wrote: > Hello

Re: [DISCUSS] KIP-378: Enable Dependency Injection for Kafka Streams handlers

Hello Wladimir, I've thought about the two options and I think I'm sold on the second option and actually I think it is better generalize it to be potentially used for other clients (producer, consumer) as while since they also have similar dependency injection requests for metrics reporter,

Re: [DISCUSS] KIP-378: Enable Dependency Injection for Kafka Streams handlers

Hello Guozhang, sure, the first approach is very straight-forward and allows minimal changes to the Kafka Streams API. On the other hand, second approach with the interface implementation looks more cleaner to me. I totally agree that this should be first discussed before will be implemented.

Re: [DISCUSS] KIP-378: Enable Dependency Injection for Kafka Streams handlers

Hello folks, I'd like to revive this thread for discussion. After reading the previous emails I think I'm still a bit leaning towards re-enabling to pass in StreamsConfig to Kafka Streams constructors compared with a ConfiguredStreamsFactory as additional parameters to overloaded KafkaStreams

Re: [DISCUSS] KIP-378: Enable Dependency Injection for Kafka Streams handlers

Hi Damian, The first approach was added only because it had been initially proposed in my pull request, which started a discussion and thus, the KIP-378 was born. Yes, I would like to have something "injectable". In this regard, a `ConfiguredStreamsFactory` (name is a subject to discussion)

Re: [DISCUSS] KIP-378: Enable Dependency Injection for Kafka Streams handlers

I just realized that there is not Jira for this KIP. Can you please create one? All KIPs need to have a Jira for tracking. Thanks. On 10/10/18 6:51 AM, Damian Guy wrote: > Hi Wladimir, > > Of the two approaches in the KIP - i feel the second approach is cleaner. > However, am i correct in

Re: [DISCUSS] KIP-378: Enable Dependency Injection for Kafka Streams handlers

Hi Wladimir, Of the two approaches in the KIP - i feel the second approach is cleaner. However, am i correct in assuming that you want to have the `ConfiguredStreamsFactory` as a ctor arg in `StreamsConfig` so that Spring can inject this for you? Otherwise you could just put the

Re: [DISCUSS] KIP-378: Enable Dependency Injection for Kafka Streams handlers

John, thanks for the explanation, now it makes much more sense to me. As for the concrete approach, to me it seems the first option requires less changes than the second (ConfiguredStreamsFactory based) approach, whereas the second one requires an additional interface that is overlapping with the

Re: [DISCUSS] KIP-378: Enable Dependency Injection for Kafka Streams handlers

Hi Wladimir, Thanks for the KIP! As I mentioned in the PR discussion, I personally prefer not to recommend overriding StreamsConfig for this purpose. It seems like a person wishing to create a DI shim would have to acquire quite a deep understanding of the class and its usage to figure out what

Re: [DISCUSS] KIP-378: Enable Dependency Injection for Kafka Streams handlers

Hi Guozhang, I'm going to drop in a little extra context from the preliminary PR discussion (https://github.com/apache/kafka/pull/5344). The issue isn't that it's impossible to use Streams within a Spring app, just that the interplay between our style of construction/configuration and Spring's

[DISCUSS] KIP-378: Enable Dependency Injection for Kafka Streams handlers

Dear colleagues, I am happy to inform you that I have just finished my first KIP (KIP-378: Enable Dependency Injection for Kafka Streams handlers ). Your feedback on this

Re: [DISCUSS] KIP-378: Enable Dependency Injection for Kafka Streams handlers

Hello Wladimir, Thanks for proposing the KIP. I think the injection can currently be done by passing in the key/value pair directly into the properties which can then be accessed from the `ProcessorContext#appConfigs` or `#appConfigsWithPrefix`. For example, when constructing the properties you

Re: [DISCUSS] KIP-378: Enable Dependency Injection for Kafka Streams handlers

Hi Wladimir, Thanks for your great KIP. Let me have a look. And let's discuss this KIP in depth after the release of 2.1.0. (The committers are very busy for it.) Best, Dongjin On Sun, Sep 30, 2018 at 10:49 PM Wladimir Schmidt wrote: > Dear colleagues, > > I am happy to inform you that I have

[DISCUSS] KIP-378: Enable Dependency Injection for Kafka Streams handlers

Dear colleagues, I am happy to inform you that I have just finished my first KIP (KIP-378: Enable Dependency Injection for Kafka Streams handlers ). Your feedback on this