Re: [DISCUSS] KIP-527: Add NothingSerde to Serdes

2019-10-16 Thread Nikolay Izhikov
Hello. I've got PR accepted by the Sophie Blee-Goldman. Tests are green. Please, others committers join the review. чт, 10 окт. 2019 г. в 16:52, Nikolay Izhikov : > Hello. > > This KIP was accepted. > > I created PR [1] for it. > Please, review. > > [1]

Re: [DISCUSS] KIP-527: Add NothingSerde to Serdes

2019-10-10 Thread Nikolay Izhikov
Hello. This KIP was accepted. I created PR [1] for it. Please, review. [1] https://github.com/apache/kafka/pull/7485 В Пн, 07/10/2019 в 14:56 -0700, Matthias J. Sax пишет: > Thanks, > > Overall LGTM. Can you maybe add the corresponding package name for the > new classes? > > > >

Re: [DISCUSS] KIP-527: Add NothingSerde to Serdes

2019-10-07 Thread Matthias J. Sax
Thanks, Overall LGTM. Can you maybe add the corresponding package name for the new classes? -Matthias On 9/30/19 9:26 AM, Nikolay Izhikov wrote: > Hello, Bruno. > > Thanks for feedback. > KIP [1] updated according to your comments. > > [1] >

Re: [DISCUSS] KIP-527: Add NothingSerde to Serdes

2019-09-30 Thread Nikolay Izhikov
Hello, Bruno. Thanks for feedback. KIP [1] updated according to your comments. [1] https://cwiki.apache.org/confluence/display/KAFKA/KIP-527%3A+Add+VoidSerde+to+Serdes В Пн, 30/09/2019 в 16:51 +0200, Bruno Cadonna пишет: > Hi Nikolay, > > Thank you for the KIP. > > I have a couple of minor

Re: [DISCUSS] KIP-527: Add NothingSerde to Serdes

2019-09-30 Thread Bruno Cadonna
Hi Nikolay, Thank you for the KIP. I have a couple of minor comments: 1. I would not put implementation details into the KIP as you did with the bodies of the constructor of the `VoidSerde` and the `serialize` and `deserialize` methods. IMO, the signatures suffice. The implementation is then

Re: [DISCUSS] KIP-527: Add NothingSerde to Serdes

2019-09-28 Thread Nikolay Izhikov
Hello. Any additional comments? Should I start a vote for this KIP? В Вт, 24/09/2019 в 16:20 +0300, Nikolay Izhikov пишет: > Hello, > > KIP [1] updated to VoidSerde. > > [1] > https://cwiki.apache.org/confluence/display/KAFKA/KIP-527%3A+Add+VoidSerde+to+Serdes > > > В Вт, 24/09/2019 в 09:11

Re: [DISCUSS] KIP-527: Add NothingSerde to Serdes

2019-09-24 Thread Nikolay Izhikov
Hello, KIP [1] updated to VoidSerde. [1] https://cwiki.apache.org/confluence/display/KAFKA/KIP-527%3A+Add+VoidSerde+to+Serdes В Вт, 24/09/2019 в 09:11 -0400, Andrew Otto пишет: > Ah it is! +1 to VoidSerde > > On Mon, Sep 23, 2019 at 11:25 PM Matthias J. Sax > wrote: > > > Because the

Re: [DISCUSS] KIP-527: Add NothingSerde to Serdes

2019-09-24 Thread Andrew Otto
Ah it is! +1 to VoidSerde On Mon, Sep 23, 2019 at 11:25 PM Matthias J. Sax wrote: > Because the actually data type is `Void`, I am wondering if `VoidSerde` > might be a more descriptive name? > > -Matthias > > On 9/23/19 12:25 PM, Nikolay Izhikov wrote: > > Hello, guys > > > > Any additional

Re: [DISCUSS] KIP-527: Add NothingSerde to Serdes

2019-09-23 Thread Matthias J. Sax
Because the actually data type is `Void`, I am wondering if `VoidSerde` might be a more descriptive name? -Matthias On 9/23/19 12:25 PM, Nikolay Izhikov wrote: > Hello, guys > > Any additional feeback on this KIP? > Should I start a vote? > > В Пт, 20/09/2019 в 08:52 +0300, Nikolay Izhikov

Re: [DISCUSS] KIP-527: Add NothingSerde to Serdes

2019-09-23 Thread Nikolay Izhikov
Hello, guys Any additional feeback on this KIP? Should I start a vote? В Пт, 20/09/2019 в 08:52 +0300, Nikolay Izhikov пишет: > Hello, Andrew. > > OK, if nobody mind, let's change it to Null. > > В Чт, 19/09/2019 в 13:54 -0400, Andrew Otto пишет: > > NullSerdes seems more descriptive, but up

Re: [DISCUSS] KIP-527: Add NothingSerde to Serdes

2019-09-19 Thread Nikolay Izhikov
Hello, Andrew. OK, if nobody mind, let's change it to Null. В Чт, 19/09/2019 в 13:54 -0400, Andrew Otto пишет: > NullSerdes seems more descriptive, but up to you! :) > > On Thu, Sep 19, 2019 at 1:37 PM Nikolay Izhikov wrote: > > > Hello, Andrew. > > > > Seems, usage null or nothing is

Re: [DISCUSS] KIP-527: Add NothingSerde to Serdes

2019-09-19 Thread Andrew Otto
NullSerdes seems more descriptive, but up to you! :) On Thu, Sep 19, 2019 at 1:37 PM Nikolay Izhikov wrote: > Hello, Andrew. > > Seems, usage null or nothing is matter of taste. I dont mind if we call it > NullSerde > > чт, 19 сент. 2019 г., 20:28 Andrew Otto : > > > Why 'NothingSerdes'

Re: [DISCUSS] KIP-527: Add NothingSerde to Serdes

2019-09-19 Thread Nikolay Izhikov
Hello, Andrew. Seems, usage null or nothing is matter of taste. I dont mind if we call it NullSerde чт, 19 сент. 2019 г., 20:28 Andrew Otto : > Why 'NothingSerdes' instead of 'NullSerdes'? > > On Thu, Sep 19, 2019 at 1:10 PM Nikolay Izhikov > wrote: > > > All, > > > > I'd like to start a

Re: [DISCUSS] KIP-527: Add NothingSerde to Serdes

2019-09-19 Thread Andrew Otto
Why 'NothingSerdes' instead of 'NullSerdes'? On Thu, Sep 19, 2019 at 1:10 PM Nikolay Izhikov wrote: > All, > > I'd like to start a discussion for adding a NothingSerde to Serdes. > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-527%3A+Add+NothingSerde+to+Serdes > > Your comments and

[DISCUSS] KIP-527: Add NothingSerde to Serdes

2019-09-19 Thread Nikolay Izhikov
All, I'd like to start a discussion for adding a NothingSerde to Serdes. https://cwiki.apache.org/confluence/display/KAFKA/KIP-527%3A+Add+NothingSerde+to+Serdes Your comments and suggestions are welcome. signature.asc Description: This is a digitally signed message part