Based on feedback during code review we made some minor adjustments to the
KIP:
- clarify that connect group id labels are only included in distributed mode
- rename metadata() to contextLabels() in the MetricsContext interface
- add context label configuration properties to kafka brokers as well
This looks useful, I think the only nit I would pick would be to name the
MetricsReporter method contextChanged (past tense), which seems more
conventional for methods like this.
On Tue, 2020-05-05 at 16:58 -0700, Xavier Léauté wrote:
[EXTERNAL EMAIL] Attention: This email was sent from
Thanks, Xavier. Looks great.
On Fri, May 8, 2020 at 7:31 PM Xavier Léauté wrote:
> > This does seem very useful. A minor request would be to mention the new
> > configs for Connect, Streams and clients, specifically that because they
> > are optional they will not hinder upgrades, and because
> This does seem very useful. A minor request would be to mention the new
> configs for Connect, Streams and clients, specifically that because they
> are optional they will not hinder upgrades, and because they are namespaced
> are unlikely to clash or conflict with other configs from extensions.
Thanks, Xavier.
This does seem very useful. A minor request would be to mention the new
configs for Connect, Streams and clients, specifically that because they
are optional they will not hinder upgrades, and because they are namespaced
are unlikely to clash or conflict with other configs from
This would be useful, thank you :)
On Tue, May 5, 2020 at 4:58 PM Xavier Léauté wrote:
> Hi Everyone,
>
> I've published a KIP to address some shortcoming of our current metrics
> reporter interface. Would appreciate feedback.
>
>
>
Hi Everyone,
I've published a KIP to address some shortcoming of our current metrics
reporter interface. Would appreciate feedback.
https://cwiki.apache.org/confluence/display/KAFKA/KIP-606%3A+Add+Metadata+Context+to+MetricsReporter
Thank you,
Xavier
