On Tue, Jun 8, 2021, at 09:53, Jun Rao wrote:
> Hi, Colin,
>
> Thanks for the update KIP.
>
> 2. BrokerRegistrationChangeRecord:
> 2.1 Should the listeners field be named EndPoints to be consistent with
> RegisterBrokerRecord?
Good point. I'll change this.
> 2.2 Does the listeners field indicat
Hi, Colin,
Thanks for the update KIP.
2. BrokerRegistrationChangeRecord:
2.1 Should the listeners field be named EndPoints to be consistent with
RegisterBrokerRecord?
2.2 Does the listeners field indicate the addition/removal or the full
current state of listeners?
2.3. Does BrokerRegistrationCha
I added a tagged "Listeners" field to BrokerRegistrationChangeRecord, as we
discussed earlier in this thread. This will be set only if the broker listeners
have changed.
best,
Colin
On Sat, Jun 5, 2021, at 09:03, Colin McCabe wrote:
> Right, we are not supporting upgrade (as discussed earlier)
Right, we are not supporting upgrade (as discussed earlier). However, since 2.8
was an official release that had the earlier versions of the records, I think
it's good to bump the version when we make incompatible changes. For
documentation purposes, it's good to be able to see the differences v
Hi, Colin,
1. Sounds good.
2. Yes, adding the listener fields will make it clear how
BrokerRegistrationChangeRecord
will be used.
Thanks,
Jun
On Thu, Jun 3, 2021 at 4:34 PM Colin McCabe wrote:
> On Thu, Jun 3, 2021, at 16:29, Jun Rao wrote:
> > Hi, Colin,
> >
> > Thanks for the KIP. Just a c
Quick question: given that upgrades are not supported, do we actually want
to introduce a new version for the RPCs?
Ismael
On Wed, Jun 2, 2021 at 11:02 AM Colin McCabe wrote:
> Hi all,
>
> I have posted a KIP about updating the KRaft metadata records for 3.0.
>
> Check it out at : https://cwiki
On Thu, Jun 3, 2021, at 16:29, Jun Rao wrote:
> Hi, Colin,
>
> Thanks for the KIP. Just a couple of minor comments.
>
Hi Jun,
Thanks for taking a look. Sorry I just started the vote thread before I saw
this! :)
> 1. Fields like RemovingReplicas are added as tagged fields in
> PartitionChangeR
Hi, Colin,
Thanks for the KIP. Just a couple of minor comments.
1. Fields like RemovingReplicas are added as tagged fields in
PartitionChangeRecord, but as non-tagged fields in PartitionRecord. Should
we make them consistent?
2. Should we add BrokerRegistrationChangeRecord later when it has more
Hi all,
I have posted a KIP about updating the KRaft metadata records for 3.0.
Check it out at : https://cwiki.apache.org/confluence/x/34zOCg
best,
Colin
