Re: [DISCUSS] KIP-927: Improve the kafka-metadata-quorum output

2023-05-15 Thread Federico Valeri
Hi Divij, I added this clarification and will start a vote soon. Thanks. On Mon, May 15, 2023 at 5:24 PM Divij Vaidya wrote: > > Thanks for providing answers to my suggestions folks. > > Based on your answers, it seems like the KIP wants to do, relative duration > = (now - timestamp), where "now

Re: [DISCUSS] KIP-927: Improve the kafka-metadata-quorum output

2023-05-15 Thread Divij Vaidya
Thanks for providing answers to my suggestions folks. Based on your answers, it seems like the KIP wants to do, relative duration = (now - timestamp), where "now" is in UTC (and not in your machine's locale/timezone). Perhaps, it's worth clarifying in the KIP? Other than that, no more comments fro

Re: [DISCUSS] KIP-927: Improve the kafka-metadata-quorum output

2023-05-11 Thread Federico Valeri
Hi Divij, thanks for having a look. On Wed, May 10, 2023 at 8:03 PM Divij Vaidya wrote: > > Thank you for the KIP. > > The current proposal has the limitation that it uses a duration syntax for > representation of a timestamp. Also, the syntax relies on the locale and > timezone of the caller mac

Re: [DISCUSS] KIP-927: Improve the kafka-metadata-quorum output

2023-05-10 Thread Luke Chen
Hi Fede, Thanks for the KIP. LGTM. @Divij I think the timestamp is timezone independent, so it should be fine. Luke On Thu, May 11, 2023 at 2:04 AM Divij Vaidya wrote: > Thank you for the KIP. > > The current proposal has the limitation that it uses a duration syntax for > representation of a

Re: [DISCUSS] KIP-927: Improve the kafka-metadata-quorum output

2023-05-10 Thread Divij Vaidya
Thank you for the KIP. The current proposal has the limitation that it uses a duration syntax for representation of a timestamp. Also, the syntax relies on the locale and timezone of the caller machine. This makes it difficult to share the output with others. As an example, let's say you want to s

[DISCUSS] KIP-927: Improve the kafka-metadata-quorum output

2023-05-10 Thread Federico Valeri
Hi all, I'd like to start a new discussion thread on KIP-927: Improve the kafka-metadata-quorum output. https://cwiki.apache.org/confluence/display/KAFKA/KIP-927%3A+Improve+the+kafka-metadata-quorum+output This KIP is small and proposes to add a new optional flag to have a human-readable timestam