Re: [DISCUSS] KIP 1047 - Introduce new org.apache.kafka.tools.api.Decoder to replace kafka.serializer.Decoder

2024-05-23 Thread Luke Chen
LGTM! Thanks for raising this improvement. Luke On Thu, May 23, 2024 at 12:52 AM Chia-Ping Tsai wrote: > Thanks for Josep's response > > > We can add this to 3.8.0, but keep in mind the KIP is not voted yet (as > far > as I can see), so I would highly encourage to start the vote thread ASAP > a

Re: [DISCUSS] KIP 1047 - Introduce new org.apache.kafka.tools.api.Decoder to replace kafka.serializer.Decoder

2024-05-22 Thread Chia-Ping Tsai
Thanks for Josep's response > We can add this to 3.8.0, but keep in mind the KIP is not voted yet (as far as I can see), so I would highly encourage to start the vote thread ASAP and strat with the implementation right after. sure. We will file a draft PR at the same time! Josep Prat 於 2024年5月2

Re: [DISCUSS] KIP 1047 - Introduce new org.apache.kafka.tools.api.Decoder to replace kafka.serializer.Decoder

2024-05-22 Thread Josep Prat
Hi all, We can add this to 3.8.0, but keep in mind the KIP is not voted yet (as far as I can see), so I would highly encourage to start the vote thread ASAP and strat with the implementation right after. Best, - Josep Prat Open Source Engineering Director, aivenjosep.p...@aiven.i

Re: [DISCUSS] KIP 1047 - Introduce new org.apache.kafka.tools.api.Decoder to replace kafka.serializer.Decoder

2024-05-22 Thread Chia-Ping Tsai
> One issue I also noted is that some of the existing Decoder implementations (StringDecoder for example) can accept configurations but currently DumpLogSegments does not provide a way to pass any configurations, it creates an empty VerifiableProperties object each time it instantiates a Decoder in

Re: [DISCUSS] KIP 1047 - Introduce new org.apache.kafka.tools.api.Decoder to replace kafka.serializer.Decoder

2024-05-22 Thread Chia-Ping Tsai
Thanks for Mickael response! >I'm wondering whether we need to introduce a new Decoder interface and instead if we could reuse Deserializer. We could deprecate the key-decoder-class and value-decoder-class flags and introduce new flags like key-deserializer-class and value-deserializer-class. One

Re: [DISCUSS] KIP 1047 - Introduce new org.apache.kafka.tools.api.Decoder to replace kafka.serializer.Decoder

2024-05-22 Thread Mickael Maison
Hi, Thanks for the KIP. Sorting this out in 3.8.0 would be really nice as it would allow us to migrate this tool in 4.0.0. We're unfortunately past the KIP deadline but maybe this is small enough to have an exception. I'm wondering whether we need to introduce a new Decoder interface and instead

Re: [DISCUSS] KIP 1047 - Introduce new org.apache.kafka.tools.api.Decoder to replace kafka.serializer.Decoder

2024-05-22 Thread Chia-Ping Tsai
Dear all, We know that 3.8.0 KIP is already frozen, but this is a small KIP and we need to ship it to 3.8.0 so as to remove the deprecated scala interface from 4.0. Best, Chia-Ping On 2024/05/22 14:05:16 Frank Yang wrote: > Hi team, > > Chia-Ping Tsai and I would like to propose KIP-1047 to m

[DISCUSS] KIP 1047 - Introduce new org.apache.kafka.tools.api.Decoder to replace kafka.serializer.Decoder

2024-05-22 Thread Frank Yang
Hi team, Chia-Ping Tsai and I would like to propose KIP-1047 to migrate kafka.serializer.Decoder from core module (scala) to tools module (java). Feedback and comments are welcome. KIP-1047: https://cwiki.apache.org/confluence/display/KAFKA/KIP-1047+Introduce+new+org.apache.kafka.tools.api.Dec