Re: [VOTE] KIP-122: Add Reset Consumer Group Offsets tooling

Thanks to everyone who voted and/or provided feedback! The vote passed with 4 binding +1s (Gwen, Grant, Jason, Becket) and 5 non-binding +1s (Matthias, Vahid, Bill, Dong, Mickael). El mié., 5 abr. 2017 a las 11:58, Jorge Esteban Quilcate Otoya (< quilcate.jo...@gmail.com>) escribió: > Thanks

Re: [VOTE] KIP-122: Add Reset Consumer Group Offsets tooling

Thanks Ismael! Response inline. El mar., 4 abr. 2017 a las 17:43, Ismael Juma () escribió: Sorry for the delay Jorge. Responses inline. On Thu, Mar 23, 2017 at 5:56 PM, Jorge Esteban Quilcate Otoya < quilcate.jo...@gmail.com> wrote: > @Ismael, thanks for your feedback! > 1.

Re: [VOTE] KIP-122: Add Reset Consumer Group Offsets tooling

@Ismael, thanks for your feedback! 1. Good point. I will add optional support for timezone as part of the datetime input. But, when datetime is without timezone, would it be more consistent to get the timezone from the cluster first and then reset based on that value? Not sure if it is possible to

Re: [VOTE] KIP-122: Add Reset Consumer Group Offsets tooling

Hi Jorge, Thanks for the detailed KIP. The tool looks very useful. A few comments: 1. We are using the default timezone of the client for the specified date. This seems a bit error prone. Would it be better to require the users to specify the time zone as part of the date time? We should at

Re: [VOTE] KIP-122: Add Reset Consumer Group Offsets tooling

+1 (non binding) Thanks for the KIP On Wed, Mar 22, 2017 at 11:00 AM, Jorge Esteban Quilcate Otoya wrote: > @Jason, thanks for your feedback! > You're right, we are not considering the old consumer, since we rely on the > KafkaConsumer#seek operations. I'm happy to

Re: [VOTE] KIP-122: Add Reset Consumer Group Offsets tooling

@Jason, thanks for your feedback! You're right, we are not considering the old consumer, since we rely on the KafkaConsumer#seek operations. I'm happy to update the KIP to make this explicit. About the second comment: I suppose that it would work, but I would like to include it to the test cases

Re: [VOTE] KIP-122: Add Reset Consumer Group Offsets tooling

Thanks for the KIP! +1 (non-binding) On Tue, Mar 21, 2017 at 6:24 PM, Becket Qin wrote: > +1 > > Thanks for the KIP. The tool is very useful. > > On Tue, Mar 21, 2017 at 4:46 PM, Jason Gustafson > wrote: > > > +1 This looks super useful! Might be

Re: [VOTE] KIP-122: Add Reset Consumer Group Offsets tooling

+1 Thanks for the KIP. The tool is very useful. On Tue, Mar 21, 2017 at 4:46 PM, Jason Gustafson wrote: > +1 This looks super useful! Might be worth mentioning somewhere > compatibility with the old consumer. It looks like offsets in zk are not > covered, which seems fine,

Re: [VOTE] KIP-122: Add Reset Consumer Group Offsets tooling

+1 This looks super useful! Might be worth mentioning somewhere compatibility with the old consumer. It looks like offsets in zk are not covered, which seems fine, but probably should be explicitly noted. Maybe you can also add a note saying that the tool can be used for old consumers which have

Re: [VOTE] KIP-122: Add Reset Consumer Group Offsets tooling

+1 (non-binding) On Tue, Mar 14, 2017 at 8:53 AM, Bill Bejeck wrote: > +1 > > On Tue, Mar 14, 2017 at 11:50 AM, Grant Henke wrote: > > > +1. Agreed. This is a great tool to have. > > > > On Tue, Mar 14, 2017 at 12:33 AM, Gwen Shapira

Re: [VOTE] KIP-122: Add Reset Consumer Group Offsets tooling

+1 On Tue, Mar 14, 2017 at 11:50 AM, Grant Henke wrote: > +1. Agreed. This is a great tool to have. > > On Tue, Mar 14, 2017 at 12:33 AM, Gwen Shapira wrote: > > > +1 (binding) > > > > Nice job - this is going to be super useful. > > > > On Thu, Feb 23,

Re: [VOTE] KIP-122: Add Reset Consumer Group Offsets tooling

+1 (non-binding) Thanks for the proposal. Regards, --Vahid From: Grant Henke <ghe...@cloudera.com> To: dev@kafka.apache.org Date: 03/14/2017 08:51 AM Subject: Re: [VOTE] KIP-122: Add Reset Consumer Group Offsets tooling +1. Agreed. This is a great tool to have. On Tu

Re: [VOTE] KIP-122: Add Reset Consumer Group Offsets tooling

+1. Agreed. This is a great tool to have. On Tue, Mar 14, 2017 at 12:33 AM, Gwen Shapira wrote: > +1 (binding) > > Nice job - this is going to be super useful. > > On Thu, Feb 23, 2017 at 4:46 PM, Jorge Esteban Quilcate Otoya < > quilcate.jo...@gmail.com> wrote: > > > Hi All,

Re: [VOTE] KIP-122: Add Reset Consumer Group Offsets tooling

+1 On 2/23/17 4:46 PM, Jorge Esteban Quilcate Otoya wrote: > Hi All, > > It seems that there is no further concern with the KIP-122. > At this point we would like to start the voting process. > > The KIP can be found here: >

[VOTE] KIP-122: Add Reset Consumer Group Offsets tooling

Hi All, It seems that there is no further concern with the KIP-122. At this point we would like to start the voting process. The KIP can be found here: https://cwiki.apache.org/confluence/display/KAFKA/KIP-122%3A+Add+Reset+Consumer+Group+Offsets+tooling Thanks! Jorge.