Re: [VOTE] KIP-303: Add Dynamic Routing Support in Kafka Streams' Topology Sink

2018-05-22 Thread Guozhang Wang
>> > > > > we should consider modifying on public APIs as well: >> > > > > StreamPartitioner#partition, to add the topic name string. Note it >> > will >> > > > be >> > > > > a incompatible change that requires users w

Re: [VOTE] KIP-303: Add Dynamic Routing Support in Kafka Streams' Topology Sink

2018-05-22 Thread Guozhang Wang
ations. > > > > > > > > > > I've updated the wiki page of KIP-303, please recast your vote on > > this > > > > > thread. Thanks!!! > > > > > > > > > > > > > > > Guozhang > > > > > > &g

Re: [VOTE] KIP-303: Add Dynamic Routing Support in Kafka Streams' Topology Sink

2018-05-22 Thread Bill Bejeck
> > > > > > > > > > > Guozhang > > > > > > > > > > > > On Thu, May 17, 2018 at 3:15 PM, John Roesler <j...@confluent.io> > > wrote: > > > > > > > >> +1 non-binding > > > >

Re: [VOTE] KIP-303: Add Dynamic Routing Support in Kafka Streams' Topology Sink

2018-05-22 Thread Ismael Juma
5 PM, John Roesler <j...@confluent.io> > wrote: > > > > > >> +1 non-binding > > >> > > >> On Thu, May 17, 2018 at 4:44 PM, Matthias J. Sax < > matth...@confluent.io > > > > > >> wrote: > > >> > > >>>

Re: [VOTE] KIP-303: Add Dynamic Routing Support in Kafka Streams' Topology Sink

2018-05-22 Thread Damian Guy
gt; which > > > >>> we should consider modifying on public APIs as well: > > > >>> StreamPartitioner#partition, to add the topic name string. Note it > > will > > > >> be > > > >>> a incompatible change

Re: [VOTE] KIP-303: Add Dynamic Routing Support in Kafka Streams' Topology Sink

2018-05-21 Thread Gwen Shapira
; >>> a incompatible change that requires users who have customized > > >>> StreamPartitioner implementations. > > >>> > > >>> I've updated the wiki page of KIP-303, please recast your vote on > this > > >>> thread. Thanks!!!

Re: [VOTE] KIP-303: Add Dynamic Routing Support in Kafka Streams' Topology Sink

2018-05-21 Thread Guozhang Wang
-303, please recast your vote on this > >>> thread. Thanks!!! > >>> > >>> > >>> Guozhang > >>> > >>> > >>> On Thu, May 17, 2018 at 3:15 PM, John Roesler <j...@confluent.io> > wrote: > >>>

Re: [VOTE] KIP-303: Add Dynamic Routing Support in Kafka Streams' Topology Sink

2018-05-21 Thread Matthias J. Sax
;>> On Thu, May 17, 2018 at 3:15 PM, John Roesler <j...@confluent.io> wrote: >>> >>>> +1 non-binding >>>> >>>> On Thu, May 17, 2018 at 4:44 PM, Matthias J. Sax <matth...@confluent.io >>> >>>> wrote: >>>>

Re: [VOTE] KIP-303: Add Dynamic Routing Support in Kafka Streams' Topology Sink

2018-05-21 Thread Guozhang Wang
;matth...@confluent.io > > > >> wrote: > >> > >>> +1 (binding) > >>> > >>> > >>> On 5/17/18 12:18 PM, Ted Yu wrote: > >>>> +1 > >>>> Original message From: Gwen Shapira <

Re: [VOTE] KIP-303: Add Dynamic Routing Support in Kafka Streams' Topology Sink

2018-05-21 Thread Matthias J. Sax
gt; -------- Original message ----From: Gwen Shapira < >> g...@confluent.io> >>> Date: 5/17/18 11:53 AM (GMT-08:00) To: dev <dev@kafka.apache.org> >>> Subject: Re: [VOTE] KIP-303: Add Dynamic Routing Support in Kafka >> Streams' >>> Topology Sink

Re: [VOTE] KIP-303: Add Dynamic Routing Support in Kafka Streams' Topology Sink

2018-05-21 Thread Guozhang Wang
fluent.io> > wrote: > > > +1 (binding) > > > > > > On 5/17/18 12:18 PM, Ted Yu wrote: > > > +1 > > > Original message From: Gwen Shapira < > g...@confluent.io> > > Date: 5/17/18 11:53 AM (GMT-08:00) To: dev <dev@

Re: [VOTE] KIP-303: Add Dynamic Routing Support in Kafka Streams' Topology Sink

2018-05-17 Thread John Roesler
/18 11:53 AM (GMT-08:00) To: dev <dev@kafka.apache.org> > Subject: Re: [VOTE] KIP-303: Add Dynamic Routing Support in Kafka Streams' > Topology Sink > > Yay, its about time :) > > > > +1 > > > > On Thu, May 17, 2018 at 12:38 PM, Guozhang Wang <wangg...@g

Re: [VOTE] KIP-303: Add Dynamic Routing Support in Kafka Streams' Topology Sink

2018-05-17 Thread Matthias J. Sax
+1 (binding) On 5/17/18 12:18 PM, Ted Yu wrote: > +1 > Original message From: Gwen Shapira <g...@confluent.io> > Date: 5/17/18 11:53 AM (GMT-08:00) To: dev <dev@kafka.apache.org> Subject: > Re: [VOTE] KIP-303: Add Dynamic Routing Support in Kafka S

Re: [VOTE] KIP-303: Add Dynamic Routing Support in Kafka Streams' Topology Sink

2018-05-17 Thread Ted Yu
+1 Original message From: Gwen Shapira <g...@confluent.io> Date: 5/17/18 11:53 AM (GMT-08:00) To: dev <dev@kafka.apache.org> Subject: Re: [VOTE] KIP-303: Add Dynamic Routing Support in Kafka Streams' Topology Sink Yay, its about time :) +1 On Thu, May 17, 2018

Re: [VOTE] KIP-303: Add Dynamic Routing Support in Kafka Streams' Topology Sink

2018-05-17 Thread Gwen Shapira
Google splits the URL into two lines and only the first half applies when you click, so it looks very broken. It is easy enough to find though. On Thu, May 17, 2018 at 12:54 PM, Guozhang Wang wrote: > https://cwiki.apache.org/confluence/display/KAFKA/KIP-303% >

Re: [VOTE] KIP-303: Add Dynamic Routing Support in Kafka Streams' Topology Sink

2018-05-17 Thread Guozhang Wang
https://cwiki.apache.org/confluence/display/KAFKA/KIP-303% 3A+Add+Dynamic+Routing+in+Streams+Sink works fine on my browser.. anyone else have the same issue? On Thu, May 17, 2018 at 11:51 AM, Damian Guy wrote: > Thanks Guozhang. +1 > > Note: the link to the KIP is broken >

Re: [VOTE] KIP-303: Add Dynamic Routing Support in Kafka Streams' Topology Sink

2018-05-17 Thread Gwen Shapira
Yay, its about time :) +1 On Thu, May 17, 2018 at 12:38 PM, Guozhang Wang wrote: > Hello folks, > > I'd like to start a voting thread on adding dynamic routing functionality > in Streams sink node. Please find a KIP here: > >

Re: [VOTE] KIP-303: Add Dynamic Routing Support in Kafka Streams' Topology Sink

2018-05-17 Thread Bill Bejeck
Thanks for the KIP. +1 -Bill On Thu, May 17, 2018 at 2:51 PM, Damian Guy wrote: > Thanks Guozhang. +1 > > Note: the link to the KIP is broken > > On Thu, 17 May 2018 at 11:38 Guozhang Wang wrote: > > > Hello folks, > > > > I'd like to start a voting

Re: [VOTE] KIP-303: Add Dynamic Routing Support in Kafka Streams' Topology Sink

2018-05-17 Thread Damian Guy
Thanks Guozhang. +1 Note: the link to the KIP is broken On Thu, 17 May 2018 at 11:38 Guozhang Wang wrote: > Hello folks, > > I'd like to start a voting thread on adding dynamic routing functionality > in Streams sink node. Please find a KIP here: > >

[VOTE] KIP-303: Add Dynamic Routing Support in Kafka Streams' Topology Sink

2018-05-17 Thread Guozhang Wang
Hello folks, I'd like to start a voting thread on adding dynamic routing functionality in Streams sink node. Please find a KIP here: https://cwiki.apache.org/confluence/display/KAFKA/KIP- 303%3A+Add+Dynamic+Routing+in+Streams+Sink And the PR itself ready for review as well under KAFKA-4936: