Re: [VOTE] KIP-360: Improve handling of unknown producer when using EOS

2019-08-21 Thread Jason Gustafson
Thanks Matthias. With that, I can close this vote. The total is +4 with 3 binding votes. -Jason On Wed, Aug 21, 2019 at 3:52 PM Matthias J. Sax wrote: > +1 (binding) > > On 4/10/19 12:17 AM, Magnus Edenhill wrote: > > +1 (non-binding) > > > > > > Den ons 10 apr. 2019 kl 02:38 skrev Guozhang

Re: [VOTE] KIP-360: Improve handling of unknown producer when using EOS

2019-08-21 Thread Matthias J. Sax
+1 (binding) On 4/10/19 12:17 AM, Magnus Edenhill wrote: > +1 (non-binding) > > > Den ons 10 apr. 2019 kl 02:38 skrev Guozhang Wang : > >> +1 (binding). Thanks for the written KIP! The approach lgtm. >> >> One minor thing: the name of "last epoch" maybe a bit misleading (although >> it is for

Re: [VOTE] KIP-360: Improve handling of unknown producer when using EOS

2019-04-10 Thread Magnus Edenhill
+1 (non-binding) Den ons 10 apr. 2019 kl 02:38 skrev Guozhang Wang : > +1 (binding). Thanks for the written KIP! The approach lgtm. > > One minor thing: the name of "last epoch" maybe a bit misleading (although > it is for internal usage only and will not be exposed to users) for future >

Re: [VOTE] KIP-360: Improve handling of unknown producer when using EOS

2019-04-09 Thread Guozhang Wang
+1 (binding). Thanks for the written KIP! The approach lgtm. One minor thing: the name of "last epoch" maybe a bit misleading (although it is for internal usage only and will not be exposed to users) for future developers, how about rename it to "required_epoch" and if it is set to "-1" it means

Re: [VOTE] KIP-360: Improve handling of unknown producer when using EOS

2019-04-09 Thread Jason Gustafson
Bump (for Guozhang) On Mon, Apr 8, 2019 at 8:55 AM Jason Gustafson wrote: > Hi All, > > I'd like to start a vote on KIP-360: > https://cwiki.apache.org/confluence/display/KAFKA/KIP-360%3A+Improve+handling+of+unknown+producer > . > > +1 from me (duh) > > Thanks, > Jason >

[VOTE] KIP-360: Improve handling of unknown producer when using EOS

2019-04-08 Thread Jason Gustafson
Hi All, I'd like to start a vote on KIP-360: https://cwiki.apache.org/confluence/display/KAFKA/KIP-360%3A+Improve+handling+of+unknown+producer . +1 from me (duh) Thanks, Jason