Re: [VOTE] KIP-399: Extend ProductionExceptionHandler to cover serialization exceptions

2020-01-19 Thread Anna McDonald
Hi All, With +1 binding votes from Guozhang, Matthias and Bill and non-binding +1 votes from Mitch, and M. Manna, the vote passes Thanks all, anna On Wed, Jan 15, 2020 at 9:54 PM Anna McDonald wrote: > > Done. Thanks for pointing that out. > > anna > > On Wed, Jan 15, 2020 at 8:52 PM Guozhang

Re: [VOTE] KIP-399: Extend ProductionExceptionHandler to cover serialization exceptions

2020-01-15 Thread Anna McDonald
Done. Thanks for pointing that out. anna On Wed, Jan 15, 2020 at 8:52 PM Guozhang Wang wrote: > > Hi Anna, > > Just a minor comment on the wiki page itself: > > ``` > > The new method, handleSerializationException, in ProductionExceptionHandler > will be invoked when > >1.

Re: [VOTE] KIP-399: Extend ProductionExceptionHandler to cover serialization exceptions

2020-01-15 Thread Guozhang Wang
Hi Anna, Just a minor comment on the wiki page itself: ``` The new method, handleSerializationException, in ProductionExceptionHandler will be invoked when 1. ClassCastException is thrown while serializing record key / value. We will continue to throw this exception and not invoke the

Re: [VOTE] KIP-399: Extend ProductionExceptionHandler to cover serialization exceptions

2020-01-15 Thread Matthias J. Sax
Thanks for pushing this KIP over the finish line! +1 (binding) -Matthias On 1/15/20 12:57 PM, Bill Bejeck wrote: > Thanks for the KIP. > > +1 (binding) > > -Bill > > On Wed, Jan 15, 2020 at 3:45 PM M. Manna wrote: > >> +1 (non-binding) >> >> Thanks for this KIP >> >> Regards, >> >> On

Re: [VOTE] KIP-399: Extend ProductionExceptionHandler to cover serialization exceptions

2020-01-15 Thread Bill Bejeck
Thanks for the KIP. +1 (binding) -Bill On Wed, Jan 15, 2020 at 3:45 PM M. Manna wrote: > +1 (non-binding) > > Thanks for this KIP > > Regards, > > On Wed, 15 Jan 2020 at 20:35, Mitchell wrote: > > > +1(non-binding) > > > > Very useful > > -mitch > > > > On Wed, Jan 15, 2020, 3:29 PM Anna

Re: [VOTE] KIP-399: Extend ProductionExceptionHandler to cover serialization exceptions

2020-01-15 Thread M. Manna
+1 (non-binding) Thanks for this KIP Regards, On Wed, 15 Jan 2020 at 20:35, Mitchell wrote: > +1(non-binding) > > Very useful > -mitch > > On Wed, Jan 15, 2020, 3:29 PM Anna McDonald > wrote: > > > Greetings, > > I would like to propose a vote on KIP-399, extending the > >

Re: [VOTE] KIP-399: Extend ProductionExceptionHandler to cover serialization exceptions

2020-01-15 Thread Mitchell
+1(non-binding) Very useful -mitch On Wed, Jan 15, 2020, 3:29 PM Anna McDonald wrote: > Greetings, > I would like to propose a vote on KIP-399, extending the > ProductionExceptionHandler to cover serialization exceptions. This KIP > is aimed at improving the error-handling semantics in Kafka

[VOTE] KIP-399: Extend ProductionExceptionHandler to cover serialization exceptions

2020-01-15 Thread Anna McDonald
Greetings, I would like to propose a vote on KIP-399, extending the ProductionExceptionHandler to cover serialization exceptions. This KIP is aimed at improving the error-handling semantics in Kafka Streams when Kafka Streams fails to serialize a message to the downstream sink. KIP details