Re: [VOTE] KIP-525 - Return topic metadata and configs in CreateTopics response

2019-09-24 Thread Rajini Sivaram
The vote has passed with 4 binding votes (Colin, Manikumar, Harsha, Rajini) and 2 non-binding votes (Satish, Kamal). I will update the KIP page and submit a PR. Many thanks for the discussion and votes. Regards, Rajini On Tue, Sep 24, 2019 at 9:22 AM Rajini Sivaram wrote: > > Hi Satish, I

Re: [VOTE] KIP-525 - Return topic metadata and configs in CreateTopics response

2019-09-24 Thread Rajini Sivaram
Hi Satish, I have updated the KIP to use TopicMetadataAndConfig for the inner class instead of CreateResult. I also fixed the version in the protocol to use 5 instead of 6 since the update to version 5 in KIP-482 will be going out in the same release as this KIP. Since both are minor changes

Re: [VOTE] KIP-525 - Return topic metadata and configs in CreateTopics response

2019-09-23 Thread Kamal Chandraprakash
+1 (non-binding), Thanks for the KIP! On Mon, Sep 23, 2019 at 10:45 AM Satish Duggana wrote: > Thanks for the KIP, +1 (non binding) > > This looks to be a useful API for admin tools. When we worked on an > admin tool for Kafka, we had to explicitly call the config API for > showing the configs

Re: [VOTE] KIP-525 - Return topic metadata and configs in CreateTopics response

2019-09-22 Thread Satish Duggana
Thanks for the KIP, +1 (non binding) This looks to be a useful API for admin tools. When we worked on an admin tool for Kafka, we had to explicitly call the config API for showing the configs for the newly created topic. I have a minor-nit comment on `CreateResult` which seems to be a slightly

Re: [VOTE] KIP-525 - Return topic metadata and configs in CreateTopics response

2019-09-22 Thread Harsha Chintalapani
+1 (binding). -Harsha On Sat, Sep 21, 2019 at 12:13 AM, Manikumar wrote: > +1 (binding), Thanks for the KIP. > > Thanks, > > On Sat, Sep 21, 2019 at 2:49 AM Colin McCabe wrote: > > +1 (binding). Thanks, Rajini. > > best, > Colin > > On Fri, Sep 20, 2019, at 00:43, Rajini Sivaram wrote: > > Hi

Re: [VOTE] KIP-525 - Return topic metadata and configs in CreateTopics response

2019-09-21 Thread Manikumar
+1 (binding), Thanks for the KIP. Thanks, On Sat, Sep 21, 2019 at 2:49 AM Colin McCabe wrote: > +1 (binding). Thanks, Rajini. > > best, > Colin > > On Fri, Sep 20, 2019, at 00:43, Rajini Sivaram wrote: > > Hi all, > > > > I would like to start vote on KIP-525 to return configs in CreateTopics

Re: [VOTE] KIP-525 - Return topic metadata and configs in CreateTopics response

2019-09-20 Thread Colin McCabe
+1 (binding). Thanks, Rajini. best, Colin On Fri, Sep 20, 2019, at 00:43, Rajini Sivaram wrote: > Hi all, > > I would like to start vote on KIP-525 to return configs in CreateTopics > response. This is a minor KIP that returns additional data in the response > without breaking compatibility. >

[VOTE] KIP-525 - Return topic metadata and configs in CreateTopics response

2019-09-20 Thread Rajini Sivaram
Hi all, I would like to start vote on KIP-525 to return configs in CreateTopics response. This is a minor KIP that returns additional data in the response without breaking compatibility. -