Re: [VOTE] KIP-570: Add leader epoch in StopReplicaRequest

2020-03-26 Thread Jason Gustafson
I have noticed it while implementing it. I plan to > use a > > > >> default > > > >> value as a sentinel in the protocol (e.g. -2) to cover this case. > > > >> > > > >> David > > > >> > > > >> On Wed, Mar

Re: [VOTE] KIP-570: Add leader epoch in StopReplicaRequest

2020-03-26 Thread David Jacot
wrote: > > >> > > >>> Hi, David, > > >>> > > >>> Thanks for the KIP. +1 from me too. Just one comment below. > > >>> > > >>> 1. Regarding the sentinel leader epoch to indicate topic deletio

Re: [VOTE] KIP-570: Add leader epoch in StopReplicaRequest

2020-03-25 Thread Ismael Juma
gt; that we need to use a different sentinel value to indicate that the > >>> leader > >>> epoch is not present when the controller is still on the old version > >>> during > >>> upgrade. > >>> > >>> Jun > >>> > >>>

Re: [VOTE] KIP-570: Add leader epoch in StopReplicaRequest

2020-03-25 Thread David Jacot
t;> Jun >>> >>> On Mon, Mar 2, 2020 at 11:20 AM Gwen Shapira wrote: >>> >>> > +1 >>> > >>> > On Mon, Feb 24, 2020, 2:16 AM David Jacot wrote: >>> > >>> > > Hi all, >>> > > >>> > > I would like to start a vote on KIP-570: Add leader epoch in >>> > > StopReplicaRequest >>> > > >>> > > The KIP is here: >>> > > >>> > > >>> > >>> https://cwiki.apache.org/confluence/display/KAFKA/KIP-570%3A+Add+leader+epoch+in+StopReplicaRequest >>> > > >>> > > Thanks, >>> > > David >>> > > >>> > >>> >>

Re: [VOTE] KIP-570: Add leader epoch in StopReplicaRequest

2020-03-06 Thread David Jacot
1:20 AM Gwen Shapira wrote: >> >> > +1 >> > >> > On Mon, Feb 24, 2020, 2:16 AM David Jacot wrote: >> > >> > > Hi all, >> > > >> > > I would like to start a vote on KIP-570: Add leader epoch in >> > > StopReplicaRequest >> > > >> > > The KIP is here: >> > > >> > > >> > >> https://cwiki.apache.org/confluence/display/KAFKA/KIP-570%3A+Add+leader+epoch+in+StopReplicaRequest >> > > >> > > Thanks, >> > > David >> > > >> > >> >

Re: [VOTE] KIP-570: Add leader epoch in StopReplicaRequest

2020-03-04 Thread David Jacot
2020 at 11:20 AM Gwen Shapira wrote: > > > +1 > > > > On Mon, Feb 24, 2020, 2:16 AM David Jacot wrote: > > > > > Hi all, > > > > > > I would like to start a vote on KIP-570: Add leader epoch in > > > StopReplicaRequest > > &g

Re: [VOTE] KIP-570: Add leader epoch in StopReplicaRequest

2020-03-03 Thread Jun Rao
during upgrade. Jun On Mon, Mar 2, 2020 at 11:20 AM Gwen Shapira wrote: > +1 > > On Mon, Feb 24, 2020, 2:16 AM David Jacot wrote: > > > Hi all, > > > > I would like to start a vote on KIP-570: Add leader epoch in > > StopReplicaRequest > > > > The

Re: [VOTE] KIP-570: Add leader epoch in StopReplicaRequest

2020-03-02 Thread Gwen Shapira
+1 On Mon, Feb 24, 2020, 2:16 AM David Jacot wrote: > Hi all, > > I would like to start a vote on KIP-570: Add leader epoch in > StopReplicaRequest > > The KIP is here: > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-570%3A+Add+leader+epoch+in+StopReplicaRequest > > Thanks, > David >

Re: [VOTE] KIP-570: Add leader epoch in StopReplicaRequest

2020-03-02 Thread Jason Gustafson
+1 On Mon, Feb 24, 2020 at 2:16 AM David Jacot wrote: > Hi all, > > I would like to start a vote on KIP-570: Add leader epoch in > StopReplicaRequest > > The KIP is here: > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-570%3A+Add+leader+epoch+in+StopReplicaRequest > > Thanks, > David >

[VOTE] KIP-570: Add leader epoch in StopReplicaRequest

2020-02-24 Thread David Jacot
Hi all, I would like to start a vote on KIP-570: Add leader epoch in StopReplicaRequest The KIP is here: https://cwiki.apache.org/confluence/display/KAFKA/KIP-570%3A+Add+leader+epoch+in+StopReplicaRequest Thanks, David