Re: [VOTE] KIP-917: Additional custom metadata for remote log segment

2023-07-10 Thread Ivan Yurchenko
Hi all, For your information: while developing this, I made a couple of minor changes to the KIP: 1. `nullableVersions` was added to the `CustomMetadata` schema. 2. `CustomMetadata` was made `null` by default. 3. The same changes as discussed for `RemoteLogSegmentMetadataRecord` were added for `Re

Re: [VOTE] KIP-917: Additional custom metadata for remote log segment

2023-06-19 Thread Josep Prat
Hi Ivan, Thanks and congrats for your first accepted KIP. Regarding the process, yes you are right. You should create an issue (this can be done pre-KIP as well), it would be good if you could link this vote thread in the JIRA. Then you need to update your KIP's wiki page with the status (approved

Re: [VOTE] KIP-917: Additional custom metadata for remote log segment

2023-06-19 Thread Ivan Yurchenko
Hi all, Thank you for your votes. The voting has been open for 7 days and we have: - 4 binding +1: Divij Vaidya, Luke Chen, Josep Prat, and Satish Duggana (based on today's state of https://kafka.apache.org/committers). - 2 non-binding +1: Kamal Chandraprakash and Matthew Benedict de Detrich. - N

Re: [VOTE] KIP-917: Additional custom metadata for remote log segment

2023-06-14 Thread Satish Duggana
Thanks Ivan for addressing the comments in the KIP, LGTM. +1 On Tue, 13 Jun 2023 at 18:31, Luke Chen wrote: > > Looks good. Thanks for the update. > > On Tue, Jun 13, 2023 at 8:08 PM Ivan Yurchenko > wrote: > > > Hi all! > > > > Thank you for your votes. > > > > Based on the proposal of Satish

Re: [VOTE] KIP-917: Additional custom metadata for remote log segment

2023-06-13 Thread Luke Chen
Looks good. Thanks for the update. On Tue, Jun 13, 2023 at 8:08 PM Ivan Yurchenko wrote: > Hi all! > > Thank you for your votes. > > Based on the proposal of Satish in the discussion thread, I modified the > KIP a little bit by lowering the default value of > `remote.log.metadata.custom.metadata

Re: [VOTE] KIP-917: Additional custom metadata for remote log segment

2023-06-13 Thread Ivan Yurchenko
Hi all! Thank you for your votes. Based on the proposal of Satish in the discussion thread, I modified the KIP a little bit by lowering the default value of `remote.log.metadata.custom.metadata.max.size` from 10 KiB to 128 bytes. I hope this doesn't change your vote, but feel free to raise your c

Re: [VOTE] KIP-917: Additional custom metadata for remote log segment

2023-06-13 Thread Josep Prat
Hi Ivan, Thank you very much for this KIP. +1 (binding) from me. Best, On Tue, Jun 13, 2023 at 10:03 AM Luke Chen wrote: > +1 (binding) from me. > > Thanks. > Luke > > On Tue, Jun 13, 2023 at 3:44 PM Matthew Benedict de Detrich > wrote: > > > > +1 (non binding). Thanks for KIP > > > > On Tue

Re: [VOTE] KIP-917: Additional custom metadata for remote log segment

2023-06-13 Thread Luke Chen
+1 (binding) from me. Thanks. Luke On Tue, Jun 13, 2023 at 3:44 PM Matthew Benedict de Detrich wrote: > > +1 (non binding). Thanks for KIP > > On Tue, Jun 13, 2023 at 3:38 AM Kamal Chandraprakash < > kamal.chandraprak...@gmail.com> wrote: > > > +1 (non-binding). Thanks for the KIP! > > > > On Mo

Re: [VOTE] KIP-917: Additional custom metadata for remote log segment

2023-06-13 Thread Matthew Benedict de Detrich
+1 (non binding). Thanks for KIP On Tue, Jun 13, 2023 at 3:38 AM Kamal Chandraprakash < kamal.chandraprak...@gmail.com> wrote: > +1 (non-binding). Thanks for the KIP! > > On Mon, Jun 12, 2023, 21:23 Divij Vaidya wrote: > > > I have reviewed the proposal and feel that it would be beneficial to >

Re: [VOTE] KIP-917: Additional custom metadata for remote log segment

2023-06-12 Thread Kamal Chandraprakash
+1 (non-binding). Thanks for the KIP! On Mon, Jun 12, 2023, 21:23 Divij Vaidya wrote: > I have reviewed the proposal and feel that it would be beneficial to > implement. > > Vote +1 (non-binding) > > > -- > Divij Vaidya > > > > On Mon, Jun 12, 2023 at 4:39 PM Ivan Yurchenko > wrote: > > > Hello

Re: [VOTE] KIP-917: Additional custom metadata for remote log segment

2023-06-12 Thread Divij Vaidya
I have reviewed the proposal and feel that it would be beneficial to implement. Vote +1 (non-binding) -- Divij Vaidya On Mon, Jun 12, 2023 at 4:39 PM Ivan Yurchenko wrote: > Hello, > > Some interest in KIP-917 was expressed in the discussion thread [1]. After > addressing all the comments t

[VOTE] KIP-917: Additional custom metadata for remote log segment

2023-06-12 Thread Ivan Yurchenko
Hello, Some interest in KIP-917 was expressed in the discussion thread [1]. After addressing all the comments there, I'm putting it up to a vote. Thanks! Best, Ivan [1] https://lists.apache.org/thread/qpccqd3jy5rzvbt5ngtzo3dg9pzp722y