[jira] [Commented] (KAFKA-1316) Refactor Sender

2014-06-19 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14037878#comment-14037878 ] Jay Kreps commented on KAFKA-1316: -- Updated reviewboard

[jira] [Commented] (KAFKA-1316) Refactor Sender

2014-06-18 Thread JIRA
[ https://issues.apache.org/jira/browse/KAFKA-1316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14035620#comment-14035620 ] Łukasz Drumiński commented on KAFKA-1316: - Hello everyone, I have a problem with

[jira] [Commented] (KAFKA-1316) Refactor Sender

2014-06-18 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14035911#comment-14035911 ] Jay Kreps commented on KAFKA-1316: -- Ack, this is dumb bug. Thanks! Will patch. Refactor

[jira] [Commented] (KAFKA-1316) Refactor Sender

2014-06-18 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14036582#comment-14036582 ] Jay Kreps commented on KAFKA-1316: -- Created reviewboard

[jira] [Commented] (KAFKA-1316) Refactor Sender

2014-06-10 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14027085#comment-14027085 ] Neha Narkhede commented on KAFKA-1316: -- 2. Ya, I kind of agree with you. These

[jira] [Commented] (KAFKA-1316) Refactor Sender

2014-06-10 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14027273#comment-14027273 ] Jay Kreps commented on KAFKA-1316: -- Created reviewboard

[jira] [Commented] (KAFKA-1316) Refactor Sender

2014-06-10 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14027276#comment-14027276 ] Jay Kreps commented on KAFKA-1316: -- Uploaded patch that has those new APIs. Refactor

[jira] [Commented] (KAFKA-1316) Refactor Sender

2014-06-10 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14027406#comment-14027406 ] Neha Narkhede commented on KAFKA-1316: -- Thanks for the updated patch, Jay. I'm +1 on

[jira] [Commented] (KAFKA-1316) Refactor Sender

2014-06-09 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14025663#comment-14025663 ] Neha Narkhede commented on KAFKA-1316: -- bq. So let's really put some thought into

[jira] [Commented] (KAFKA-1316) Refactor Sender

2014-06-09 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14025718#comment-14025718 ] Jay Kreps commented on KAFKA-1316: -- Thanks for the feedback Neha: 1. Makes sense, we can

[jira] [Commented] (KAFKA-1316) Refactor Sender

2014-06-09 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14025741#comment-14025741 ] Neha Narkhede commented on KAFKA-1316: -- 2. hmm.. let me explain. So, both use

[jira] [Commented] (KAFKA-1316) Refactor Sender

2014-06-09 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14025757#comment-14025757 ] Jay Kreps commented on KAFKA-1316: -- 2. Sure. I guess I don't feel this is necessarily bad

[jira] [Commented] (KAFKA-1316) Refactor Sender

2014-06-07 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14020899#comment-14020899 ] Jay Kreps commented on KAFKA-1316: -- Updated reviewboard

[jira] [Commented] (KAFKA-1316) Refactor Sender

2014-06-07 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14020901#comment-14020901 ] Jay Kreps commented on KAFKA-1316: -- I updated this patch to 1. Address a number of

[jira] [Commented] (KAFKA-1316) Refactor Sender

2014-06-03 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14017182#comment-14017182 ] Jay Kreps commented on KAFKA-1316: -- Updated reviewboard

[jira] [Commented] (KAFKA-1316) Refactor Sender

2014-05-30 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14013340#comment-14013340 ] Guozhang Wang commented on KAFKA-1316: -- This makes sense. Refactor Sender

[jira] [Commented] (KAFKA-1316) Refactor Sender

2014-05-28 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14011551#comment-14011551 ] Guozhang Wang commented on KAFKA-1316: -- Here are some more thoughts: If we are going

[jira] [Commented] (KAFKA-1316) Refactor Sender

2014-05-28 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14011735#comment-14011735 ] Jay Kreps commented on KAFKA-1316: -- [~guozhang] I think you are describing the case where

[jira] [Commented] (KAFKA-1316) Refactor Sender

2014-05-27 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14010153#comment-14010153 ] Jay Kreps commented on KAFKA-1316: -- Created reviewboard

[jira] [Commented] (KAFKA-1316) Refactor Sender

2014-05-27 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14010498#comment-14010498 ] Jay Kreps commented on KAFKA-1316: -- For (2) I think there are two solutions 1. Change the

[jira] [Commented] (KAFKA-1316) Refactor Sender

2014-05-21 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14005066#comment-14005066 ] Neha Narkhede commented on KAFKA-1316: -- [~jkreps] Thanks for writing this up. Thought

[jira] [Commented] (KAFKA-1316) Refactor Sender

2014-05-21 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14005179#comment-14005179 ] Jun Rao commented on KAFKA-1316: Is ready() blocking? If not, does the user have to keep

[jira] [Commented] (KAFKA-1316) Refactor Sender

2014-05-21 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14005249#comment-14005249 ] Jay Kreps commented on KAFKA-1316: -- Neha, yeah I'll post something as I get it in shape.

[jira] [Commented] (KAFKA-1316) Refactor Sender

2014-05-20 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14004009#comment-14004009 ] Jay Kreps commented on KAFKA-1316: -- I started on this and I think I have a design that at

[jira] [Commented] (KAFKA-1316) Refactor Sender

2014-05-15 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13992931#comment-13992931 ] Neha Narkhede commented on KAFKA-1316: -- [~jkreps] At a high level, this seems great.

[jira] [Commented] (KAFKA-1316) Refactor Sender

2014-05-14 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13996687#comment-13996687 ] Jun Rao commented on KAFKA-1316: Some of the failure handling seems to be common btw the

[jira] [Commented] (KAFKA-1316) Refactor Sender

2014-05-06 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13991361#comment-13991361 ] Jay Kreps commented on KAFKA-1316: -- Okay so here is my proposal. I want to refactor out a

[jira] [Commented] (KAFKA-1316) Refactor Sender

2014-05-06 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13991379#comment-13991379 ] Guozhang Wang commented on KAFKA-1316: -- I think we also need to refactor out the