[
https://issues.apache.org/jira/browse/KAFKA-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15119703#comment-15119703
]
Dana Powers commented on KAFKA-1493:
Hi all - it appears that the header checksum (HC) byte is
[
https://issues.apache.org/jira/browse/KAFKA-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15119920#comment-15119920
]
Magnus Edenhill commented on KAFKA-1493:
[~dana.powers] I can confirm this is the case, as you
[
https://issues.apache.org/jira/browse/KAFKA-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15120072#comment-15120072
]
Dana Powers commented on KAFKA-1493:
filed KAFKA-3160
> Use a well-documented LZ4 compression format
[
https://issues.apache.org/jira/browse/KAFKA-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14174217#comment-14174217
]
James Oliver commented on KAFKA-1493:
-
Updated reviewboard
[
https://issues.apache.org/jira/browse/KAFKA-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14174305#comment-14174305
]
Jun Rao commented on KAFKA-1493:
James,
Thanks for the patch. There are a few things
[
https://issues.apache.org/jira/browse/KAFKA-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14174356#comment-14174356
]
James Oliver commented on KAFKA-1493:
-
Jun,
My pleasure. The TODOs are parts of the
[
https://issues.apache.org/jira/browse/KAFKA-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14174473#comment-14174473
]
Jun Rao commented on KAFKA-1493:
James,
Thanks for the answer. We can leave the TODOs
[
https://issues.apache.org/jira/browse/KAFKA-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14174716#comment-14174716
]
James Oliver commented on KAFKA-1493:
-
Updated reviewboard
[
https://issues.apache.org/jira/browse/KAFKA-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14171082#comment-14171082
]
James Oliver commented on KAFKA-1493:
-
Sorry to not be more clear - I fixed a few
[
https://issues.apache.org/jira/browse/KAFKA-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14171732#comment-14171732
]
Jun Rao commented on KAFKA-1493:
James,
Thanks, got it now. Not sure how long it will
[
https://issues.apache.org/jira/browse/KAFKA-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14171748#comment-14171748
]
James Oliver commented on KAFKA-1493:
-
I implemented the OutputStream today. If I
[
https://issues.apache.org/jira/browse/KAFKA-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14169616#comment-14169616
]
James Oliver commented on KAFKA-1493:
-
Sure, I'll take a look at it now.
Use a
[
https://issues.apache.org/jira/browse/KAFKA-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14170071#comment-14170071
]
Jun Rao commented on KAFKA-1493:
James,
Thanks for the patch. A couple of more questions.
[
https://issues.apache.org/jira/browse/KAFKA-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14167153#comment-14167153
]
Jun Rao commented on KAFKA-1493:
James,
Could you help review the format in Ivan's patch?
[
https://issues.apache.org/jira/browse/KAFKA-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14165275#comment-14165275
]
Ivan Lyutov commented on KAFKA-1493:
Created reviewboard
[
https://issues.apache.org/jira/browse/KAFKA-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14158291#comment-14158291
]
Jun Rao commented on KAFKA-1493:
The easiest thing is probably to just take out LZ4 in
[
https://issues.apache.org/jira/browse/KAFKA-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14158408#comment-14158408
]
Theo Hultberg commented on KAFKA-1493:
--
If you're looking for a standard way to
[
https://issues.apache.org/jira/browse/KAFKA-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14142132#comment-14142132
]
Jun Rao commented on KAFKA-1493:
Since this is a blocker for 0.8.2, if we can't get this
[
https://issues.apache.org/jira/browse/KAFKA-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14131758#comment-14131758
]
James Oliver commented on KAFKA-1493:
-
I have today to work on this, I will see how
[
https://issues.apache.org/jira/browse/KAFKA-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14122037#comment-14122037
]
Guozhang Wang commented on KAFKA-1493:
--
Could we still have that for 0.8.2?
Use a
[
https://issues.apache.org/jira/browse/KAFKA-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14032832#comment-14032832
]
James Oliver commented on KAFKA-1493:
-
Snappy's block (default size 32kb) compression
[
https://issues.apache.org/jira/browse/KAFKA-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14033211#comment-14033211
]
Stephan Lachowsky commented on KAFKA-1493:
--
Given the way that the decoder works
[
https://issues.apache.org/jira/browse/KAFKA-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14033215#comment-14033215
]
Stephan Lachowsky commented on KAFKA-1493:
--
The lack of checksum in the
[
https://issues.apache.org/jira/browse/KAFKA-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14033274#comment-14033274
]
James Oliver commented on KAFKA-1493:
-
I agree that storing the uncompressed length as
[
https://issues.apache.org/jira/browse/KAFKA-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14030908#comment-14030908
]
Albert Strasheim commented on KAFKA-1493:
-
What does the format look like for a
25 matches
Mail list logo
