[jira] [Commented] (KAFKA-943) Move all configuration key string to constants

2013-07-11 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13706288#comment-13706288 ] Jay Kreps commented on KAFKA-943: - I cleaned up the bad config strings I saw in our example

[jira] [Commented] (KAFKA-943) Move all configuration key string to constants

2013-07-08 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13702279#comment-13702279 ] Jay Kreps commented on KAFKA-943: - That would work for me. > Move all conf

[jira] [Commented] (KAFKA-943) Move all configuration key string to constants

2013-07-07 Thread Sam Meder (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13701803#comment-13701803 ] Sam Meder commented on KAFKA-943: - How about an option that turns on strict validation?

[jira] [Commented] (KAFKA-943) Move all configuration key string to constants

2013-07-03 Thread Sam Meder (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13699128#comment-13699128 ] Sam Meder commented on KAFKA-943: - So we also have a config management system external to t

[jira] [Commented] (KAFKA-943) Move all configuration key string to constants

2013-07-03 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13699095#comment-13699095 ] Jay Kreps commented on KAFKA-943: - Yeah, I think the core disagreement is that we are optim

[jira] [Commented] (KAFKA-943) Move all configuration key string to constants

2013-07-03 Thread Sam Meder (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13699027#comment-13699027 ] Sam Meder commented on KAFKA-943: - I would actually argue that it is easier on external "co

[jira] [Commented] (KAFKA-943) Move all configuration key string to constants

2013-07-02 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13698401#comment-13698401 ] Jay Kreps commented on KAFKA-943: - Hey Sam, thanks for the patch it is great to get clean-u