Re: Fail-fast builds?

2018-12-21 Thread Satish Duggana
>>This would allow for fast failure on compilation and checkstyle problems, but let the whole test suite run in spite of test failures. +1 for that as it will be very useful. Thanks, Satish. On Fri, Dec 21, 2018 at 8:10 PM David Arthur wrote: > > Since this is a relatively simple change, I

Re: Fail-fast builds?

2018-12-21 Thread David Arthur
Since this is a relatively simple change, I went ahead and opened up a PR here https://github.com/apache/kafka/pull/6059 On Fri, Dec 21, 2018 at 2:15 AM Manikumar wrote: > +1 fo the suggestion. > > On Fri, Dec 21, 2018 at 2:38 AM David Arthur wrote: > > > In the jenkins.sh file, we have the

Re: Fail-fast builds?

2018-12-20 Thread Manikumar
+1 fo the suggestion. On Fri, Dec 21, 2018 at 2:38 AM David Arthur wrote: > In the jenkins.sh file, we have the following comment: > > "In order to provide faster feedback, the tasks are ordered so that faster > tasks are executed in every module before slower tasks (if possible)" > > > but

Fail-fast builds?

2018-12-20 Thread David Arthur
In the jenkins.sh file, we have the following comment: "In order to provide faster feedback, the tasks are ordered so that faster tasks are executed in every module before slower tasks (if possible)" but then we proceed to use the Gradle --continue flag. This means PRs won't get notified of