Re: [DISCUSS] KIP-918: MM2 Topic And Group Listener

2023-06-28 Thread Dániel Urbán
> > clusters, as the "traditional" way of finding replica topics is based > > on > > > > topic naming and the ReplicationPolicy. > > > > > > > > Thanks, > > > > Daniel > > > > > > > > hudeqi <16120...@bjtu.edu.cn> ezt írta (időpont: 2023. ápr. 19., > Sze, > > > > 10:58): > > > > > > > > > Thanks for your reply, Daniel. > > > > > Regarding the group list, do you mean that if the group of the > source > > > > > cluster has not committed an offset (the group does not exist or > the > > > > group > > > > > has not committed an offset to the topic being replicated), then > the > > > > > current metric cannot be collected? Then this involves the question > > of > > > > > motivation: Do we want to monitor the topic list and group list we > > > > > configured, or the topic list and group list that are currently > being > > > > > replicated? If it is the latter, shouldn't it be detected for a > group > > > > that > > > > > has not committed an offset? I don't know if I understand > correctly. > > > > > > > > > > best, > > > > > hudeqi > > > > > > > > > > > > > > > > -原始邮件- > > > > > > 发件人: "Dániel Urbán" > > > > > > 发送时间: 2023-04-19 15:50:01 (星期三) > > > > > > 收件人: dev@kafka.apache.org > > > > > > 抄送: > > > > > > 主题: Re: Re: [DISCUSS] KIP-918: MM2 Topic And Group Listener > > > > > > > > > > > > > > > > > > > > >

Re: [DISCUSS] KIP-918: MM2 Topic And Group Listener

2023-06-06 Thread Chris Egerton
(the group does not exist or the > > > group > > > > has not committed an offset to the topic being replicated), then the > > > > current metric cannot be collected? Then this involves the question > of > > > > motivation: Do we want to monitor the topic list and group list we > > > > configured, or the topic list and group list that are currently being > > > > replicated? If it is the latter, shouldn't it be detected for a group > > > that > > > > has not committed an offset? I don't know if I understand correctly. > > > > > > > > best, > > > > hudeqi > > > > > > > > > > > > > -原始邮件- > > > > > 发件人: "Dániel Urbán" > > > > > 发送时间: 2023-04-19 15:50:01 (星期三) > > > > > 收件人: dev@kafka.apache.org > > > > > 抄送: > > > > > 主题: Re: Re: [DISCUSS] KIP-918: MM2 Topic And Group Listener > > > > > > > > > > > > > > >

Re: [DISCUSS] KIP-918: MM2 Topic And Group Listener

2023-04-21 Thread Dániel Urbán
c list and group list that are currently being > > > replicated? If it is the latter, shouldn't it be detected for a group > > that > > > has not committed an offset? I don't know if I understand correctly. > > > > > > best, > > > hudeqi > > > > > > > > > > -原始邮件- > > > > 发件人: "Dániel Urbán" > > > > 发送时间: 2023-04-19 15:50:01 (星期三) > > > > 收件人: dev@kafka.apache.org > > > > 抄送: > > > > 主题: Re: Re: [DISCUSS] KIP-918: MM2 Topic And Group Listener > > > > > > > > > >

Re: [DISCUSS] KIP-918: MM2 Topic And Group Listener

2023-04-21 Thread Viktor Somogyi-Vass
n: Do we want to monitor the topic list and group list we > > configured, or the topic list and group list that are currently being > > replicated? If it is the latter, shouldn't it be detected for a group > that > > has not committed an offset? I don't know if I und

Re: [DISCUSS] KIP-918: MM2 Topic And Group Listener

2023-04-19 Thread Dániel Urbán
> > > -原始邮件- > > 发件人: "Dániel Urbán" > > 发送时间: 2023-04-19 15:50:01 (星期三) > > 收件人: dev@kafka.apache.org > > 抄送: > > 主题: Re: Re: [DISCUSS] KIP-918: MM2 Topic And Group Listener > > >

Re: [DISCUSS] KIP-918: MM2 Topic And Group Listener

2023-04-19 Thread hudeqi
understand correctly. best, hudeqi > -原始邮件- > 发件人: "Dániel Urbán" > 发送时间: 2023-04-19 15:50:01 (星期三) > 收件人: dev@kafka.apache.org > 抄送: > 主题: Re: Re: [DISCUSS] KIP-918: MM2 Topic And Group Listener >

Re: Re: [DISCUSS] KIP-918: MM2 Topic And Group Listener

2023-04-19 Thread Dániel Urbán
Hi hudeqi, Thank you for your comments! Related to the topic list: you are correct, the partition metrics are created eagerly, so even if a topic has no active traffic, the metrics are visible. I missed this fact when creating the KIP. For the group list: the group metrics are created lazily, so f

Re: Re: [DISCUSS] KIP-918: MM2 Topic And Group Listener

2023-04-18 Thread hudeqi
Hi, I have some questions about motivation. The problem to be solved by this kip is that it cannot accurately monitor the topic and group currently being replicated? From my point of view, using MirrorSourceMetrics.recordRate can monitor the configured topic list that is currently being replicat

Re: [DISCUSS] KIP-918: MM2 Topic And Group Listener

2023-04-18 Thread Dániel Urbán
Hello everyone, I would like to bump this KIP. Please consider reviewing it, as it would improve the monitoring capabilities around MM2. I also submitted a PR (https://github.com/apache/kafka/pull/13595) to demonstrate the current state of the KIP. Thanks in advance, Daniel Dániel Urbán ezt írt