Re: [VOTE] KIP-896: Remove old client protocol API versions in Kafka 4.0

2023-12-17 Thread Ismael Juma
Hi all, It turns out that kafka-python's protocol api versions support is worse than originally described - newer versions were defined but not actually supported in a few cases. I have updated the KIP to address this:

Re: [VOTE] KIP-896: Remove old client protocol API versions in Kafka 4.0

2023-12-15 Thread Ismael Juma
Hi Jason, Thanks for bringing this up. A couple of comments: 1. Yes, we should deprecate and remove the raw SASL protocol that preceded KIP-43 - the popular clients have supported SaslHandshake for a very long time. 2. Yes, kafka-python still uses SaslHandshake v0 and it doesn't support

Re: [VOTE] KIP-896: Remove old client protocol API versions in Kafka 4.0

2023-12-07 Thread Jason Gustafson
Minor correction: only `SaslHandshake` was introduced in KIP-43. `SaslAuthenticate` came later in KIP-152. On Thu, Dec 7, 2023 at 3:18 PM Jason Gustafson wrote: > Hey Ismael, > > I'm considering if we can do something in this KIP for the SASL baggage > we've accumulated. Prior to the existence

Re: [VOTE] KIP-896: Remove old client protocol API versions in Kafka 4.0

2023-12-07 Thread Jason Gustafson
Hey Ismael, I'm considering if we can do something in this KIP for the SASL baggage we've accumulated. Prior to the existence of the `SaslHandshake` API, we supported the raw SASL protocol. The main gap was that it did not support negotiation of the SASL method. This was fixed in

Re: [VOTE] KIP-896: Remove old client protocol API versions in Kafka 4.0

2023-11-24 Thread Ismael Juma
Hi all, I also vote +1. The vote passes with 4 binding +1s: 1. Colin McCabe 2. Jun Rao 3. Jose Sancio 4. Ismael Juma Thanks, Ismael On Tue, Nov 21, 2023 at 12:06 PM Ismael Juma wrote: > Hi all, > > I would like to start a vote on KIP-896. Please take a look and let us > know what you think.

Re: [VOTE] KIP-896: Remove old client protocol API versions in Kafka 4.0

2023-11-21 Thread Ismael Juma
Thanks Jun. I updated the KIP with this information and also linked to a JIRA that captures the items required for 3.7. Ismael On Tue, Nov 21, 2023 at 2:53 PM Jun Rao wrote: > Hi, Ismael, > > Thanks for the KIP. +1 > > It would be useful to clarify in the KIP that the new metric and new >

Re: [VOTE] KIP-896: Remove old client protocol API versions in Kafka 4.0

2023-11-21 Thread José Armando García Sancio
Thanks. LGTM. +1. On Tue, Nov 21, 2023 at 2:54 PM Jun Rao wrote: > > Hi, Ismael, > > Thanks for the KIP. +1 > > It would be useful to clarify in the KIP that the new metric and new > request log attribute will be added in Apache 3.7. > > Jun > > On Tue, Nov 21, 2023 at 1:57 PM Colin McCabe

Re: [VOTE] KIP-896: Remove old client protocol API versions in Kafka 4.0

2023-11-21 Thread Jun Rao
Hi, Ismael, Thanks for the KIP. +1 It would be useful to clarify in the KIP that the new metric and new request log attribute will be added in Apache 3.7. Jun On Tue, Nov 21, 2023 at 1:57 PM Colin McCabe wrote: > Ah. I forget that KIP-724 not only deprecated, but proposed a removal in > 4.0.

Re: [VOTE] KIP-896: Remove old client protocol API versions in Kafka 4.0

2023-11-21 Thread Colin McCabe
Ah. I forget that KIP-724 not only deprecated, but proposed a removal in 4.0. Great. +1 (binding) for KIP-896 best, Colin On Tue, Nov 21, 2023, at 12:36, Ismael Juma wrote: > Hi Colin, > > That change was proposed and approved via KIP-724: > >

Re: [VOTE] KIP-896: Remove old client protocol API versions in Kafka 4.0

2023-11-21 Thread Ismael Juma
Hi Colin, That change was proposed and approved via KIP-724: https://cwiki.apache.org/confluence/display/KAFKA/KIP-724%3A+Drop+support+for+message+formats+v0+and+v1 Ismael On Tue, Nov 21, 2023, 12:21 PM Colin McCabe wrote: > Hi Ismael, > > Can we state somewhere that the

Re: [VOTE] KIP-896: Remove old client protocol API versions in Kafka 4.0

2023-11-21 Thread Colin McCabe
Hi Ismael, Can we state somewhere that the message.format.version configuration will be gone in 4.0? We only will support one message format version (for now, at least). If we do want more versions later, I don't think we'll want to configure them via a static config. best, Colin On Tue,