Re: Review Request 21865: Patch for KAFKA-1438

2014-05-30 Thread Sriharsha Chintalapani
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21865/ --- (Updated May 30, 2014, 6:35 p.m.) Review request for kafka. Bugs: KAFKA-1438

Re: Review Request 21865: Patch for KAFKA-1438

2014-05-30 Thread Sriharsha Chintalapani
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21865/ --- (Updated May 30, 2014, 6:38 p.m.) Review request for kafka. Bugs: KAFKA-1438

Re: Review Request 21865: Patch for KAFKA-1438

2014-05-30 Thread Sriharsha Chintalapani
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21865/ --- (Updated May 30, 2014, 6:42 p.m.) Review request for kafka. Bugs: KAFKA-1438

Re: Review Request 21865: Patch for KAFKA-1438

2014-05-28 Thread Sriharsha Chintalapani
On May 28, 2014, 12:27 a.m., Guozhang Wang wrote: I get the same error as Neha on kafka-run-class.sh, could you double check if there is anything wrong with that diff? I did a git diff against origin/trunk and applied as a patch but the one uploaded to reviewboard having issue. I'll

Re: Review Request 21865: Patch for KAFKA-1438

2014-05-28 Thread Sriharsha Chintalapani
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21865/ --- (Updated May 28, 2014, 3:40 p.m.) Review request for kafka. Bugs: KAFKA-1438

Re: Review Request 21865: Patch for KAFKA-1438

2014-05-28 Thread Sriharsha Chintalapani
On May 28, 2014, 12:27 a.m., Guozhang Wang wrote: I get the same error as Neha on kafka-run-class.sh, could you double check if there is anything wrong with that diff? Sriharsha Chintalapani wrote: I did a git diff against origin/trunk and applied as a patch but the one uploaded

Re: Review Request 21865: Patch for KAFKA-1438

2014-05-27 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21865/#review43988 --- We also want to move the *Performance out of perf into tools and

Re: Review Request 21865: Patch for KAFKA-1438

2014-05-27 Thread Sriharsha Chintalapani
On May 27, 2014, 5:26 p.m., Neha Narkhede wrote: perf/src/main/scala/kafka/perf/ProducerPerformance.scala, line 42 https://reviews.apache.org/r/21865/diff/1/?file=589809#file589809line42 same here current perf project has its own log4j.properties under perf/config and it writes to

Re: Review Request 21865: Patch for KAFKA-1438

2014-05-27 Thread Sriharsha Chintalapani
On May 27, 2014, 5:26 p.m., Neha Narkhede wrote: We also want to move the *Performance out of perf into tools and remove the perf subproject The diff contains changes necessary for moving perf classes under tools. - Sriharsha

Re: Review Request 21865: Patch for KAFKA-1438

2014-05-27 Thread Neha Narkhede
On May 27, 2014, 5:26 p.m., Neha Narkhede wrote: We also want to move the *Performance out of perf into tools and remove the perf subproject Sriharsha Chintalapani wrote: The diff contains changes necessary for moving perf classes under tools. I applied the patch. It failed to

Re: Review Request 21865: Patch for KAFKA-1438

2014-05-27 Thread Sriharsha Chintalapani
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21865/ --- (Updated May 27, 2014, 6:45 p.m.) Review request for kafka. Bugs: KAFKA-1438

Re: Review Request 21865: Patch for KAFKA-1438

2014-05-27 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21865/#review44034 --- I get the following error while applying the patch- patching file

Re: Review Request 21865: Patch for KAFKA-1438

2014-05-27 Thread Sriharsha Chintalapani
On May 27, 2014, 8:40 p.m., Neha Narkhede wrote: I get the following error while applying the patch- patching file bin/windows/kafka-run-class.bat Hunk #1 FAILED at 36. Hunk #2 FAILED at 121. 2 out of 2 hunks FAILED -- saving rejects to file bin/windows/kafka-run-class.bat.rej

Re: Review Request 21865: Patch for KAFKA-1438

2014-05-27 Thread Neha Narkhede
On May 27, 2014, 8:40 p.m., Neha Narkhede wrote: I get the following error while applying the patch- patching file bin/windows/kafka-run-class.bat Hunk #1 FAILED at 36. Hunk #2 FAILED at 121. 2 out of 2 hunks FAILED -- saving rejects to file bin/windows/kafka-run-class.bat.rej

Re: Review Request 21865: Patch for KAFKA-1438

2014-05-27 Thread Sriharsha Chintalapani
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21865/ --- (Updated May 28, 2014, 12:08 a.m.) Review request for kafka. Bugs:

Re: Review Request 21865: Patch for KAFKA-1438

2014-05-27 Thread Sriharsha Chintalapani
On May 27, 2014, 8:40 p.m., Neha Narkhede wrote: I get the following error while applying the patch- patching file bin/windows/kafka-run-class.bat Hunk #1 FAILED at 36. Hunk #2 FAILED at 121. 2 out of 2 hunks FAILED -- saving rejects to file bin/windows/kafka-run-class.bat.rej

Re: Review Request 21865: Patch for KAFKA-1438

2014-05-27 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21865/#review44081 --- I get the same error as Neha on kafka-run-class.sh, could you