Re: Review Request 24620: Patch for KAFKA-1580

2014-08-15 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24620/#review50784 --- core/src/main/scala/kafka/server/KafkaApis.scala

Re: Review Request 24620: Patch for KAFKA-1580

2014-08-15 Thread Jonathan Natkins
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24620/ --- (Updated Aug. 15, 2014, 10:05 p.m.) Review request for kafka. Bugs:

Re: Review Request 24620: Patch for KAFKA-1580

2014-08-15 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24620/#review50786 --- Ship it! Ship It! - Joel Koshy On Aug. 15, 2014, 10:05 p.m.,

Re: Review Request 24620: Patch for KAFKA-1580

2014-08-14 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24620/#review50656 --- core/src/main/scala/kafka/server/KafkaApis.scala

Re: Review Request 24620: Patch for KAFKA-1580

2014-08-14 Thread Jonathan Natkins
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24620/ --- (Updated Aug. 14, 2014, 11:50 p.m.) Review request for kafka. Bugs:

Re: Review Request 24620: Patch for KAFKA-1580

2014-08-14 Thread Jonathan Natkins
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24620/ --- (Updated Aug. 14, 2014, 11:56 p.m.) Review request for kafka. Bugs:

Re: Review Request 24620: Patch for KAFKA-1580

2014-08-14 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24620/#review50669 --- clients/src/main/java/org/apache/kafka/common/protocol/Errors.java

Re: Review Request 24620: Patch for KAFKA-1580

2014-08-14 Thread Jonathan Natkins
On Aug. 15, 2014, 12:12 a.m., Neha Narkhede wrote: clients/src/main/java/org/apache/kafka/common/protocol/Errors.java, line 56 https://reviews.apache.org/r/24620/diff/3/?file=661064#file661064line56 I meant adding the existing InvalidTopicException here. I'm not sure if there is

Re: Review Request 24620: Patch for KAFKA-1580

2014-08-14 Thread Jonathan Natkins
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24620/ --- (Updated Aug. 15, 2014, 1:21 a.m.) Review request for kafka. Bugs:

Re: Review Request 24620: Patch for KAFKA-1580

2014-08-14 Thread Jonathan Natkins
On Aug. 15, 2014, 12:12 a.m., Neha Narkhede wrote: clients/src/main/java/org/apache/kafka/common/protocol/Errors.java, line 56 https://reviews.apache.org/r/24620/diff/3/?file=661064#file661064line56 I meant adding the existing InvalidTopicException here. I'm not sure if there is

Re: Review Request 24620: Patch for KAFKA-1580

2014-08-14 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24620/#review50698 --- Ship it! Ship It! - Neha Narkhede On Aug. 15, 2014, 1:21 a.m.,

Re: Review Request 24620: Patch for KAFKA-1580

2014-08-14 Thread Neha Narkhede
On Aug. 15, 2014, 12:12 a.m., Neha Narkhede wrote: clients/src/main/java/org/apache/kafka/common/protocol/Errors.java, line 56 https://reviews.apache.org/r/24620/diff/3/?file=661064#file661064line56 I meant adding the existing InvalidTopicException here. I'm not sure if there is