Re: Review Request 19828: Patch for KAFKA-1350

2014-03-31 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19828/#review39100 --- Ship it! Ship It! - Jun Rao On March 30, 2014, 6:29 a.m., Neha

Re: Review Request 19828: Patch for KAFKA-1350

2014-03-31 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19828/#review39104 --- Ship it! Ship It! - Guozhang Wang On March 30, 2014, 6:29 a.m.,

Re: Review Request 19828: Patch for KAFKA-1350

2014-03-31 Thread Guozhang Wang
On March 31, 2014, 1:40 a.m., Neha Narkhede wrote: core/src/main/scala/kafka/server/KafkaApis.scala, line 141 https://reviews.apache.org/r/19828/diff/2/?file=540411#file540411line141 I see what you are saying now. Yes, I think you are right. This patch only addresses the

Re: Review Request 19828: Patch for KAFKA-1350

2014-03-31 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19828/#review39107 --- Ship it! Ship It! - Joel Koshy On March 30, 2014, 6:29 a.m.,

Re: Review Request 19828: Patch for KAFKA-1350

2014-03-31 Thread Timothy Chen
On March 31, 2014, 1:40 a.m., Neha Narkhede wrote: core/src/main/scala/kafka/server/KafkaApis.scala, line 141 https://reviews.apache.org/r/19828/diff/2/?file=540411#file540411line141 I see what you are saying now. Yes, I think you are right. This patch only addresses the

Re: Review Request 19828: Patch for KAFKA-1350

2014-03-31 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19828/#review39109 --- Ship it! Ship It! - Timothy Chen On March 30, 2014, 6:29 a.m.,

Review Request 19828: Patch for KAFKA-1350

2014-03-30 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19828/ --- Review request for kafka. Bugs: KAFKA-1350

Re: Review Request 19828: Patch for KAFKA-1350

2014-03-30 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19828/ --- (Updated March 30, 2014, 6:28 a.m.) Review request for kafka. Bugs:

Re: Review Request 19828: Patch for KAFKA-1350

2014-03-30 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19828/ --- (Updated March 30, 2014, 6:29 a.m.) Review request for kafka. Bugs:

Re: Review Request 19828: Patch for KAFKA-1350

2014-03-30 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19828/#review39013 --- core/src/main/scala/kafka/server/KafkaApis.scala

Re: Review Request 19828: Patch for KAFKA-1350

2014-03-30 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19828/#review39017 --- core/src/main/scala/kafka/server/KafkaApis.scala

Re: Review Request 19828: Patch for KAFKA-1350

2014-03-30 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19828/#review39021 --- core/src/main/scala/kafka/server/KafkaApis.scala

Re: Review Request 19828: Patch for KAFKA-1350

2014-03-30 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19828/#review39022 --- core/src/main/scala/kafka/server/KafkaApis.scala