Re: Review Request 29751: Patch for kafka-1851

2015-01-09 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29751/#review67476 --- Ship it! Ship It! - Neha Narkhede On Jan. 9, 2015, 2:53 a.m.,

Re: Review Request 29751: Patch for kafka-1851

2015-01-09 Thread Ewen Cheslack-Postava
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29751/#review67499 --- core/src/main/scala/kafka/server/KafkaApis.scala

Re: Review Request 29751: Patch for kafka-1851

2015-01-09 Thread Jun Rao
On Jan. 9, 2015, 8:01 p.m., Ewen Cheslack-Postava wrote: core/src/main/scala/kafka/server/KafkaApis.scala, line 512 https://reviews.apache.org/r/29751/diff/1/?file=813957#file813957line512 You could just change getOffsets so it doesn't have this behavior instead of checking the

Review Request 29751: Patch for kafka-1851

2015-01-08 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29751/ --- Review request for kafka. Bugs: kafka-1851