On March 31, 2015, 9:20 p.m., Joel Koshy wrote:
core/src/main/scala/kafka/tools/ContinuousValidationTest.java, line 1
https://reviews.apache.org/r/30809/diff/4/?file=903374#file903374line1
This should definitely not be in tools - this should probably live
somewhere under
On April 2, 2015, 1:38 a.m., Jun Rao wrote:
core/src/main/scala/kafka/tools/ContinuousValidationTest.java, lines 431-437
https://reviews.apache.org/r/30809/diff/4/?file=903374#file903374line431
Could we add a description of the test (what kind of data is generated,
how does
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30809/#review78630
---
Thanks for the patch. A few high level comments.
1. I think we are
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30809/#review78270
---
bin/kafka-run-class.sh
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30809/#review77732
---
bin/kafka-run-class.sh
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30809/
---
(Updated March 23, 2015, 6:54 p.m.)
Review request for kafka.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30809/#review76835
---
Also, I think we can move ValidatingProducer/Consumer and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30809/#review76157
---
This looks like a very good start. I think the framework is
On March 12, 2015, 12:13 a.m., Jiangjie Qin wrote:
core/src/main/scala/kafka/tools/ContinuousValidationTest.java, line 183
https://reviews.apache.org/r/30809/diff/3/?file=889855#file889855line183
This is essentially a sync approach, can we use callback to do this?
Abhishek Nigam
On March 12, 2015, 12:13 a.m., Jiangjie Qin wrote:
core/src/main/scala/kafka/tools/ContinuousValidationTest.java, line 183
https://reviews.apache.org/r/30809/diff/3/?file=889855#file889855line183
This is essentially a sync approach, can we use callback to do this?
This is
On March 11, 2015, 11:12 p.m., Gwen Shapira wrote:
This looks like a very good start. I think the framework is flexible enough
to allow us to add a variety of upgrade tests. I'm looking forward to it.
I have few comments, but mostly I'm still confused on how this will be
used.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30809/#review76173
---
core/src/main/scala/kafka/tools/ContinuousValidationTest.java
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30809/#review73382
---
build.gradle
https://reviews.apache.org/r/30809/#comment119686
On March 10, 2015, 11:44 p.m., Guozhang Wang wrote:
This is from some old review comments, I will upload rest of them soon.
- Guozhang
---
This is an automatically generated e-mail. To reply, visit:
On Feb. 18, 2015, 12:06 a.m., Mayuresh Gharat wrote:
core/src/main/scala/kafka/tools/ContinuousValidationTest.java, line 400
https://reviews.apache.org/r/30809/diff/1/?file=859055#file859055line400
The common format of commenting is :
// this is a comment
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30809/
---
(Updated March 9, 2015, 11:55 p.m.)
Review request for kafka.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30809/#review73061
---
core/src/main/scala/kafka/tools/ContinuousValidationTest.java
On Feb. 18, 2015, 12:06 a.m., Mayuresh Gharat wrote:
core/src/main/scala/kafka/tools/ContinuousValidationTest.java, line 168
https://reviews.apache.org/r/30809/diff/1/?file=859055#file859055line168
same here can we use isInterrupted()?
On Feb. 18, 2015, 12:06 a.m., Mayuresh Gharat wrote:
core/src/main/scala/kafka/tools/ContinuousValidationTest.java, line 207
https://reviews.apache.org/r/30809/diff/1/?file=859055#file859055line207
This might end up in infinite loop if something goes wrong with
cluster, right?
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30809/#review72786
---
core/src/main/scala/kafka/tools/ContinuousValidationTest.java
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30809/
---
(Updated Feb. 18, 2015, 1:59 a.m.)
Review request for kafka.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30809/
---
(Updated Feb. 9, 2015, 11:53 p.m.)
Review request for kafka.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30809/
---
Review request for kafka.
Bugs: KAFKA-1888
23 matches
Mail list logo
