Re: Review Request 32937: Patch for KAFKA-2102

2015-04-26 Thread Tim Brooks
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32937/ --- (Updated April 27, 2015, 12:26 a.m.) Review request for kafka. Bugs:

Re: Review Request 32937: Patch for KAFKA-2102

2015-04-17 Thread Tim Brooks
On April 16, 2015, 5:34 a.m., Ewen Cheslack-Postava wrote: clients/src/main/java/org/apache/kafka/clients/MetadataBookkeeper.java, line 25 https://reviews.apache.org/r/32937/diff/3/?file=931249#file931249line25 This patch will definitely need a comment somewhere explaining the

Re: Review Request 32937: Patch for KAFKA-2102

2015-04-15 Thread Tim Brooks
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32937/ --- (Updated April 16, 2015, 12:56 a.m.) Review request for kafka. Bugs:

Re: Review Request 32937: Patch for KAFKA-2102

2015-04-15 Thread Ewen Cheslack-Postava
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32937/#review80298 --- This version looks a lot better than the original patch -- it's a

Review Request 32937: Patch for KAFKA-2102

2015-04-07 Thread Tim Brooks
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32937/ --- Review request for kafka. Bugs: KAFKA-2102

Re: Review Request 32937: Patch for KAFKA-2102

2015-04-07 Thread Tim Brooks
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32937/ --- (Updated April 8, 2015, 5:21 a.m.) Review request for kafka. Bugs: