---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34554/#review92917
---
Ship it!
Thanks for the patch. Looks good. +1 after addressing a
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34554/
---
(Updated July 25, 2015, 1:12 a.m.)
Review request for kafka, Joel Koshy and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34554/
---
(Updated July 25, 2015, 1:11 a.m.)
Review request for kafka, Joel Koshy and
On July 17, 2015, 4:43 a.m., Jun Rao wrote:
core/src/main/scala/kafka/server/ConfigHandler.scala, lines 64-65
https://reviews.apache.org/r/34554/diff/5/?file=1011630#file1011630line64
Could we just use Pool?
Nice.. didn't know about that util.
- Aditya
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34554/
---
(Updated July 17, 2015, 6:14 p.m.)
Review request for kafka, Joel Koshy and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34554/
---
(Updated July 17, 2015, 6:14 p.m.)
Review request for kafka, Joel Koshy and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34554/
---
(Updated July 17, 2015, 6:18 p.m.)
Review request for kafka, Joel Koshy and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34554/
---
(Updated July 17, 2015, 6:20 p.m.)
Review request for kafka, Joel Koshy and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34554/#review92008
---
Thanks for the latest patch. Have a few more comments below.
On July 9, 2015, 2:28 a.m., Jun Rao wrote:
core/src/main/scala/kafka/server/ConfigHandler.scala, line 27
https://reviews.apache.org/r/34554/diff/3/?file=1001960#file1001960line27
Do we need JavaConversions? If this is needed, it would be better to
import it in the context where
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34554/
---
(Updated July 14, 2015, 5:36 p.m.)
Review request for kafka, Joel Koshy and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34554/
---
(Updated July 14, 2015, 5:37 p.m.)
Review request for kafka, Joel Koshy and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34554/
---
(Updated July 14, 2015, 5:34 p.m.)
Review request for kafka, Joel Koshy and
On July 9, 2015, 2:28 a.m., Jun Rao wrote:
core/src/main/scala/kafka/admin/ConfigCommand.scala, line 123
https://reviews.apache.org/r/34554/diff/3/?file=1001954#file1001954line123
Could we list the valid configs name for each entity-type as we did in
TopicCommand?
I've listed
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34554/#review91038
---
Thanks for the new patch. Just a couple of minor comments below.
On July 7, 2015, 2:18 a.m., Jun Rao wrote:
Thanks for the patch. A few more comments below.
1. The patch doesn't apply. Could you rebase?
2. Also, we need the logic to read all existing client configs. Is that in
a separate jira?
Aditya Auradkar wrote:
1. Will do.
2.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34554/
---
(Updated July 8, 2015, 2:12 a.m.)
Review request for kafka and Joel Koshy.
On July 7, 2015, 2:18 a.m., Jun Rao wrote:
Thanks for the patch. A few more comments below.
1. The patch doesn't apply. Could you rebase?
2. Also, we need the logic to read all existing client configs. Is that in
a separate jira?
1. Will do.
2. Hey Jun - I didn't understand what
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34554/
---
(Updated July 8, 2015, 2:13 a.m.)
Review request for kafka and Joel Koshy.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34554/#review90622
---
Thanks for the patch. A few more comments below.
1. The patch
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34554/
---
(Updated July 2, 2015, 1:38 a.m.)
Review request for kafka and Joel Koshy.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34554/
---
(Updated July 2, 2015, 1:39 a.m.)
Review request for kafka and Joel Koshy.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34554/
---
(Updated May 21, 2015, 5:55 p.m.)
Review request for kafka.
Bugs: KAFKA-2205
23 matches
Mail list logo
