Re: Review Request 35371: Patch for KAFKA-2266

2015-06-12 Thread Jason Gustafson
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35371/ --- (Updated June 12, 2015, 4:19 p.m.) Review request for kafka. Bugs:

Re: Review Request 35371: Patch for KAFKA-2266

2015-06-12 Thread Jason Gustafson
On June 12, 2015, 1:18 a.m., Jun Rao wrote: clients/src/test/java/org/apache/kafka/common/network/SelectorTest.java, lines 256-257 https://reviews.apache.org/r/35371/diff/1/?file=983518#file983518line256 Waiting a second on this could be long and is not always reliable.

Review Request 35371: Patch for KAFKA-2266

2015-06-11 Thread Jason Gustafson
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35371/ --- Review request for kafka. Bugs: KAFKA-2266

Re: Review Request 35371: Patch for KAFKA-2266

2015-06-11 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35371/#review87667 --- Thanks for the patch. Good catch! A minor comment below.