[
https://issues.apache.org/jira/browse/KAFKA-17416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-17416.
Fix Version/s: 4.0.0
Resolution: Fixed
> Add a checkstyle rule to suppress
Chia-Ping Tsai created KAFKA-17416:
--
Summary: Add a checkstyle rule to suppress all generated code
Key: KAFKA-17416
URL: https://issues.apache.org/jira/browse/KAFKA-17416
Project: Kafka
David Arthur created KAFKA-17381:
Summary: Reduce log output from checkstyle task
Key: KAFKA-17381
URL: https://issues.apache.org/jira/browse/KAFKA-17381
Project: Kafka
Issue Type: Task
[
https://issues.apache.org/jira/browse/KAFKA-16643?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-16643.
Fix Version/s: 3.9.0
Resolution: Fixed
> Add ModifierOrder checkstyle r
/commit/342e69192f62b89b7d1ea824aeecc09c38899d72
> Add import ordering checkstyle rule and configure an automatic formatter
>
>
> Key: KAFKA-12572
> URL: https://issues.apache.
Greg Harris created KAFKA-16643:
---
Summary: Add ModifierOrder checkstyle rule
Key: KAFKA-16643
URL: https://issues.apache.org/jira/browse/KAFKA-16643
Project: Kafka
Issue Type: Task
[
https://issues.apache.org/jira/browse/KAFKA-15476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Divij Vaidya resolved KAFKA-15476.
--
Resolution: Fixed
> Improve checkstyle performa
Divij Vaidya created KAFKA-15476:
Summary: Improve checkstyle performance
Key: KAFKA-15476
URL: https://issues.apache.org/jira/browse/KAFKA-15476
Project: Kafka
Issue Type: Improvement
Matthew de Detrich created KAFKA-14332:
--
Summary: Split out checkstyle configs between test and main
Key: KAFKA-14332
URL: https://issues.apache.org/jira/browse/KAFKA-14332
Project: Kafka
Dejan Stojadinović created KAFKA-12771:
--
Summary: CheckStyle attempted upgrade (8.36.2 -->> 8.41.1) summons
a pack of 'Indentation' errors
Key: KAFKA-12771
URL: https://issues.apache.org/j
Dejan Stojadinović created KAFKA-12770:
--
Summary: Jenkins build: allow the CheckStyle version to be
specified via parameter
Key: KAFKA-12770
URL: https://issues.apache.org/jira/browse/KAFKA-12770
Dongjin Lee created KAFKA-12572:
---
Summary: Add import ordering checkstyle rule and configure an
automatic formatter
Key: KAFKA-12572
URL: https://issues.apache.org/jira/browse/KAFKA-12572
Project
le will raise an error if the import-order violating
source file exists.
If you have any proposals or ideas, don't hesitate to give me a reply. I
will create a regular issue of it and update the PR.
Regards,
Dongjin
[^1]: In my case, I am using CheckStyle-IDEA:
https://plugins.jetbrains.com/p
y of them.
>>
>> I'm pretty sure I'm personally responsible for some of the wacky import
>> ordering way back when, before I set my IDE configuration straight. It took
>> me a while to notice because we never had a checkstyle rule for import
>> order.
>&g
ike :)
>
> I generally prefer option 2, but would definitely be happy with any of them.
>
> I'm pretty sure I'm personally responsible for some of the wacky import
> ordering way back when, before I set my IDE configuration straight. It took
> me a while to notice because
ever had a checkstyle rule for import
order.
So thank you for proposing this.
Sophie
On Thu, Oct 22, 2020 at 11:17 PM Bruno Cadonna wrote:
> Hi Dongjin,
>
> Thank you that you put me into the committer section, but I am actually
> not a committer.
>
> Best,
> Bruno
>
Hi Dongjin,
Thank you that you put me into the committer section, but I am actually
not a committer.
Best,
Bruno
On 23.10.20 07:46, Dongjin Lee wrote:
As of Present:
Committers:
- Bruno: 2 and 3.
- Gwen: (No Specific Preference)
Non-Committers:
- Brandon: 2.
- Dongjin: 2 and 3.
Let's h
As of Present:
Committers:
- Bruno: 2 and 3.
- Gwen: (No Specific Preference)
Non-Committers:
- Brandon: 2.
- Dongjin: 2 and 3.
Let's hold on for 2 or 3 committers.
Best,
Dongjin
On Fri, Oct 23, 2020 at 10:09 AM Gwen Shapira wrote:
> I don't have any specific preference on the style. But I
I don't have any specific preference on the style. But I am glad you
are bringing it up. Every other project I worked on had a specific
import style, and the random import changes in PRs are pretty
annoying.
On Wed, Oct 14, 2020 at 10:36 PM Dongjin Lee wrote:
>
> Hello. I hope to open a discussio
I like option 2.
Brandon Brown
> On Oct 15, 2020, at 1:36 AM, Dongjin Lee wrote:
>
> Hello. I hope to open a discussion about the import order in Java code.
>
> As Nikolay stated recently[^1], Kafka uses a relatively strict code style
> for Java code. However, it misses any rule on import or
Hi Dongjin,
Thank you for bringing this up.
I like options 2 and 3.
Best,
Bruno
On 15.10.20 07:36, Dongjin Lee wrote:
Hello. I hope to open a discussion about the import order in Java code.
As Nikolay stated recently[^1], Kafka uses a relatively strict code style
for Java code. However, it m
Hello. I hope to open a discussion about the import order in Java code.
As Nikolay stated recently[^1], Kafka uses a relatively strict code style
for Java code. However, it misses any rule on import order. For this
reason, the code formatting settings of every local dev environment are
different f
[
https://issues.apache.org/jira/browse/KAFKA-7308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ismael Juma resolved KAFKA-7308.
Resolution: Fixed
Fix Version/s: 2.1.0
> Fix rat and checkstyle plugins configuration
Ismael Juma created KAFKA-7308:
--
Summary: Fix rat and checkstyle plugins configuration for Java 11
support
Key: KAFKA-7308
URL: https://issues.apache.org/jira/browse/KAFKA-7308
Project: Kafka
Ted Yu created KAFKA-6735:
-
Summary: Document how to skip findbugs / checkstyle when running
unit test
Key: KAFKA-6735
URL: https://issues.apache.org/jira/browse/KAFKA-6735
Project: Kafka
Issue
GitHub user makearl opened a pull request:
https://github.com/apache/kafka-site/pull/106
MINOR: Fix typo in checkstyle command
Fix a typo in the [Coding
Guidelines](http://kafka.apache.org/coding-guide.html) for Kafka Streams
checkstyle commands
You can merge this pull request
Github user asfgit closed the pull request at:
https://github.com/apache/kafka/pull/3431
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
GitHub user ijuma opened a pull request:
https://github.com/apache/kafka/pull/3431
MINOR: Adjust checkstyle suppression paths to work on Windows
Use the file name whenever possible and replace / with [/\\]
when it's not.
Also remove unnecessary suppresions.
Yo
Github user asfgit closed the pull request at:
https://github.com/apache/kafka/pull/1380
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
GitHub user ijuma opened a pull request:
https://github.com/apache/kafka/pull/1380
MINOR: Fix checkstyle failure in `StreamsConfigTest`
I removed the hamcrest matcher to unbreak the build, but we probably want
to tweak the `import-control.xml` as it currently only allows it for
Github user asfgit closed the pull request at:
https://github.com/apache/kafka/pull/1317
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
GitHub user guozhangwang opened a pull request:
https://github.com/apache/kafka/pull/1317
MINOR: Modify checkstyle to allow import classes only used in javadoc
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/guozhangwang/kafka
Github user asfgit closed the pull request at:
https://github.com/apache/kafka/pull/1116
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
GitHub user ewencp opened a pull request:
https://github.com/apache/kafka/pull/1116
KAFKA-3435: Follow up to fix checkstyle
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ewencp/kafka kafka-3435-follow-up
Alternatively you can
Github user asfgit closed the pull request at:
https://github.com/apache/kafka/pull/1000
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
GitHub user ewencp opened a pull request:
https://github.com/apache/kafka/pull/1000
HOTFIX: Fix checkstyle failure in KStreams by providing fully qualified
class names.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ewencp
by pull request 703
[https://github.com/apache/kafka/pull/703]
> Ensure Checkstyle runs on all Java code
> ---
>
> Key: KAFKA-3020
> URL: https://issues.apache.org/jira/browse/KAFKA-3020
>
uest at:
https://github.com/apache/kafka/pull/703
> Ensure Checkstyle runs on all Java code
> ---
>
> Key: KAFKA-3020
> URL: https://issues.apache.org/jira/browse/KAFKA-3020
> Project: Kafka
>
Github user asfgit closed the pull request at:
https://github.com/apache/kafka/pull/703
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabl
pull request:
https://github.com/apache/kafka/pull/703
KAFKA-3020: Ensure CheckStyle runs on all Java code
- Adds CheckStyle to core and examples modules
- Fixes any existing CheckStyle issues
You can merge this pull request into a Git repository by running:
$ git pull h
pull request at:
https://github.com/apache/kafka/pull/703
> Ensure Checkstyle runs on all Java code
> ---
>
> Key: KAFKA-3020
> URL: https://issues.apache.org/jira/browse/KAFKA-3020
> Project: Kafka
Github user granthenke closed the pull request at:
https://github.com/apache/kafka/pull/703
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is e
GitHub user granthenke reopened a pull request:
https://github.com/apache/kafka/pull/703
KAFKA-3020: Ensure CheckStyle runs on all Java code
- Adds CheckStyle to core and examples modules
- Fixes any existing CheckStyle issues
You can merge this pull request into a Git
[
https://issues.apache.org/jira/browse/KAFKA-3020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Grant Henke updated KAFKA-3020:
---
Status: Patch Available (was: In Progress)
> Ensure Checkstyle runs on all Java c
pull request:
https://github.com/apache/kafka/pull/703
KAFKA-3020: Ensure CheckStyle runs on all Java code
- Adds CheckStyle to core and examples modules
- Fixes any existing CheckStyle issues
You can merge this pull request into a Git repository by running:
$ git pull h
GitHub user granthenke opened a pull request:
https://github.com/apache/kafka/pull/703
KAFKA-3020: Ensure CheckStyle runs on all Java code
- Adds CheckStyle to core and examples modules
- Fixes any existing CheckStyle issues
You can merge this pull request into a Git repository
[
https://issues.apache.org/jira/browse/KAFKA-3020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Work on KAFKA-3020 started by Grant Henke.
--
> Ensure Checkstyle runs on all Java c
Grant Henke created KAFKA-3020:
--
Summary: Ensure Checkstyle runs on all Java code
Key: KAFKA-3020
URL: https://issues.apache.org/jira/browse/KAFKA-3020
Project: Kafka
Issue Type: Sub-task
Github user SinghAsDev closed the pull request at:
https://github.com/apache/kafka/pull/347
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is e
GitHub user SinghAsDev opened a pull request:
https://github.com/apache/kafka/pull/347
MINOR: fix checkstyle failures
@guozhangwang could you take a look at this. These failures are a bit
annoying as it never leads to a successful build.
You can merge this pull request into a Git
Github user asfgit closed the pull request at:
https://github.com/apache/kafka/pull/261
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabl
GitHub user ijuma opened a pull request:
https://github.com/apache/kafka/pull/261
HOTFIX: Checkstyle import fix
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ijuma/kafka checkstyle-import-fix
Alternatively you can review and
the original description led me to
an incorrect conclusion regarding checkstyle. Thank both for the PRs.
> Checkstyle reporting failure in trunk due to unused imports in Selector.java
>
>
>
-z'd the import deletion. Thanks for
fixing.
> Checkstyle reporting failure in trunk due to unused imports in Selector.java
>
>
> Key: KAFKA-2549
> URL: https://issue
this problem was introduced is:
https://github.com/apache/kafka/commit/d88b5bdfde0b6d020e687f6d59ad88d577910ae9
Not the one you mentioned. And that commit was merged today, not weeks ago. OK,
I feel less bad about checkstyle and incremental builds.
> Checkstyle reporting failure in trunk
ited the description.
> Checkstyle reporting failure in trunk due to unused imports in Selector.java
>
>
> Key: KAFKA-2549
> URL: https://issues.apache.org/jir
/d02ca36ca1cccdb6962191b97f54ce96b9d75abc#diff-db8f8be6ef2f1c81515d1ed83b3ab107
in which the Selector.java was modified with some unused imports so the trunk
can not execute test targets as it fails in client section during checkstyle
stage. (was: Again introduced in
https://github.com/apache/kafka/commit
uest at:
https://github.com/apache/kafka/pull/215
> Checkstyle reporting failure in trunk due to unused imports in Selector.java
>
>
> Key: KAFKA-2549
> URL: https://iss
[
https://issues.apache.org/jira/browse/KAFKA-2549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gwen Shapira resolved KAFKA-2549.
-
Resolution: Fixed
Reviewer: Gwen Shapira
Thanks for the quick fix!
> Checkstyle report
Github user asfgit closed the pull request at:
https://github.com/apache/kafka/pull/215
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabl
scription is a bit misleading because the
compiler failure that you recently reported was due to a different commit.
> Checkstyle reporting failure in trunk due to unused imports in Selector.java
>
>
>
uild config or the Jenkins jobs because
this was merged weeks ago and it has gone undetected since. I've been running
`gradlew test` every day without errors.
An easy workaround is to run clean as part of the Jenkins builds, but a better
fix would be to make sure checkstyle works correctly withou
GitHub user Parth-Brahmbhatt opened a pull request:
https://github.com/apache/kafka/pull/215
KAFKA-2549: Fixing checkstyle failure resulting due to unused importsâ¦
⦠in Selector.
You can merge this pull request into a Git repository by running:
$ git pull https
pull request:
https://github.com/apache/kafka/pull/215
KAFKA-2549: Fixing checkstyle failure resulting due to unused imports…
… in Selector.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Parth-Brahmbhatt/kafka KAFKA-
Parth Brahmbhatt created KAFKA-2549:
---
Summary: Checkstyle reporting failure in trunk due to unused
imports in Selector.java
Key: KAFKA-2549
URL: https://issues.apache.org/jira/browse/KAFKA-2549
[
https://issues.apache.org/jira/browse/KAFKA-2513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14731295#comment-14731295
]
Ismael Juma commented on KAFKA-2513:
[~ewencp], by your argument, checks
[
https://issues.apache.org/jira/browse/KAFKA-2513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ashish K Singh resolved KAFKA-2513.
---
Resolution: Won't Fix
> Checkstyle is not executed until gradle'
have. However, if you have strong opinion
against it, we can drop this.
> Checkstyle is not executed until gradle's tests phase
> -
>
> Key: KAFKA-2513
> URL: https://issues.apache.or
a space between "for" and the paranthesis
2. casts must have spaces after them as well
3. You're not allowed to put parentheses around ternary operators unless they
are absolutely required. I actually think we should remove this one, it really
hurts clarity in some cases.
they can just choose to do {{compile}}.
However, I think there is some value to have checkstyle execute as part of
{{jar}}, but just my opinion.
> Checkstyle is not executed until gradle's tests phase
> -
>
>
that there's a separate command that
depends on the compile task and people can choose what they want. Are you
saying that you would not want it to run for the `jar` command either?
> Checkstyle is not executed until gradle&#
delete
anyway...
> Checkstyle is not executed until gradle's tests phase
> -
>
> Key: KAFKA-2513
> URL: https://issues.apache.org/jira/browse/KAFKA-2513
> Project: Kafka
>
han tests. Depending on jar by itself is
not too good though because it won't be run when one runs the tests. I'd have
to look at the build to have an actual proposal though.
> Checkstyle is not executed unti
ghts?
> Checkstyle is not executed until gradle's tests phase
> -
>
> Key: KAFKA-2513
> URL: https://issues.apache.org/jira/browse/KAFKA-2513
> Project: Kafka
> Issue Type: Bug
&
Ashish K Singh created KAFKA-2513:
-
Summary: Checkstyle is not executed until gradle's tests phase
Key: KAFKA-2513
URL: https://issues.apache.org/jira/browse/KAFKA-2513
Project: Kafka
get messed up, closing it now.
> Integrate checkstyle for Java code
> --
>
> Key: KAFKA-2141
> URL: https://issues.apache.org/jira/browse/KAFKA-2141
> Project: Kafka
> Issue Type: Bug
>
[
https://issues.apache.org/jira/browse/KAFKA-2141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guozhang Wang resolved KAFKA-2141.
--
Resolution: Not A Problem
> Integrate checkstyle for Java c
sn't in the clients/ directory?
I tried to set that up but somehow the mixture of scala and java caused
confusion...
> Integrate checkstyle for Java code
> --
>
> Key: KAFKA-2141
> URL: https://issues.apache.or
Guozhang Wang created KAFKA-2141:
Summary: Integrate checkstyle for Java code
Key: KAFKA-2141
URL: https://issues.apache.org/jira/browse/KAFKA-2141
Project: Kafka
Issue Type: Bug
Available)
Committed in 1c6d5bbac67.
> Integrate checkstyle for java code
> --
>
> Key: KAFKA-1915
> URL: https://issues.apache.org/jira/browse/KAFKA-1915
> Project: Kafka
> Is
After checkstyle is tuned, maybe we can add that as part of pre-commit
testing, KAFKA-1856.
On Tue, Feb 3, 2015 at 8:59 PM, Jay Kreps wrote:
> I just committed the checkstyle patch (KAFKA-1915). This will do the
> checkstyle evaluation when you run the unit tests and error on
I just committed the checkstyle patch (KAFKA-1915). This will do the
checkstyle evaluation when you run the unit tests and error on style
inconsistencies. It can be hard to say which checks are more trouble than
they are worth or are two pedantic. Let's give this a try and see if it is
annoyi
p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1915
> https://issues.apache.org/jira/browse/KAFKA-1915
>
>
> Repository: kafka
>
>
> Description
> ---
>
> KAFKA-1915: Add checkstyle for java code.
>
>
> Diffs
>
To reply, visit:
> https://reviews.apache.org/r/30547/
> ---
>
> (Updated Feb. 3, 2015, 5:17 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1915
> https://issues.apache.org/jira/browse/KAFKA-1915
>
>
> Repository: kafka
>
>
> De
[
https://issues.apache.org/jira/browse/KAFKA-1915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jay Kreps updated KAFKA-1915:
-
Attachment: KAFKA-1915_2015-02-03_09:17:34.patch
> Integrate checkstyle for java c
rg/r/30547/diff/
against branch trunk
> Integrate checkstyle for java code
> --
>
> Key: KAFKA-1915
> URL: https://issues.apache.org/jira/browse/KAFKA-1915
> Project: Kafka
> Issue Type: Improvem
https://issues.apache.org/jira/browse/KAFKA-1915
Repository: kafka
Description (updated)
---
KAFKA-1915: Add checkstyle for java code.
Diffs (updated)
-
README.md 9bdcf7052434d3025b816779afe1d00561969bb3
build.gradle 68443725868c438176e68b04c0642f0e9fa29e23
checkstyle
ither way is there a way to suppress it via an annotation or
> > something like that? For example, in some cases "unnecessary" parantheses
> > may actually make some code much easier to read. I'm guessing no, since
> > checkstyle is completely outside of compilati
; https://issues.apache.org/jira/browse/KAFKA-1915
>
>
> Repository: kafka
>
>
> Description
> ---
>
> Add checkstyle.
>
>
> Diffs
> -
>
> build.gradle 68443725868c438176e68b04c0642f0e9fa29e23
> checkstyle/checkstyle.xml PR
e much easier to read. I'm guessing no, since checkstyle
is completely outside of compilation.
checkstyle/checkstyle.xml
<https://reviews.apache.org/r/30547/#comment116065>
Speaking of which... we need an ASF license header on this xml file itself
no? probably after th
[
https://issues.apache.org/jira/browse/KAFKA-1915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jay Kreps updated KAFKA-1915:
-
Attachment: KAFKA-1915.patch
> Integrate checkstyle for java c
[
https://issues.apache.org/jira/browse/KAFKA-1915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jay Kreps updated KAFKA-1915:
-
Status: Patch Available (was: Open)
> Integrate checkstyle for java c
rg/r/30547/diff/
against branch trunk
> Integrate checkstyle for java code
> --
>
> Key: KAFKA-1915
> URL: https://issues.apache.org/jira/browse/KAFKA-1915
> Project: Kafka
> Issue Type: Improvem
/browse/KAFKA-1915
Repository: kafka
Description
---
Add checkstyle.
Diffs
-
build.gradle 68443725868c438176e68b04c0642f0e9fa29e23
checkstyle/checkstyle.xml PRE-CREATION
checkstyle/import-control.xml PRE-CREATION
clients/src/main/java/org/apache/kafka/clients
Jay Kreps created KAFKA-1915:
Summary: Integrate checkstyle for java code
Key: KAFKA-1915
URL: https://issues.apache.org/jira/browse/KAFKA-1915
Project: Kafka
Issue Type: Improvement
95 matches
Mail list logo
