Re: Review Request 26373: Patch for KAFKA-1647

2014-10-21 Thread Jiangjie Qin
On Oct. 21, 2014, 12:18 a.m., Jun Rao wrote: core/src/main/scala/kafka/server/ReplicaManager.scala, lines 481-506 https://reviews.apache.org/r/26373/diff/3/?file=725140#file725140line481 This doesn't quite fix the original problem though. The original problem is that if the

[jira] [Updated] (KAFKA-1481) Stop using dashes AND underscores as separators in MBean names

2014-10-21 Thread Vladimir Tretyakov (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vladimir Tretyakov updated KAFKA-1481: -- Attachment: KAFKA-1481_2014-10-21_09-14-35.patch Stop using dashes AND underscores as

[jira] [Commented] (KAFKA-1481) Stop using dashes AND underscores as separators in MBean names

2014-10-21 Thread Vladimir Tretyakov (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14178039#comment-14178039 ] Vladimir Tretyakov commented on KAFKA-1481: --- Hi, added last patch

[jira] [Commented] (KAFKA-1718) Message Size Too Large error when only small messages produced with Snappy

2014-10-21 Thread Wojciech Kuranowski (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14178396#comment-14178396 ] Wojciech Kuranowski commented on KAFKA-1718: I have compiled kafka 0.8.2 with

Re: [DISCUSS] Release 0.8.2-beta before 0.8.2?

2014-10-21 Thread Joel Koshy
KAFKA-1634 is orthogonal to 1583 right? (BTW sorry about the delay in reviewing 1583 - I'm on it.) KAFKA-1634 shouldn't be too difficult to address so I'm hoping we can get that in 0.8.2 if not the beta release. Joel On Mon, Oct 20, 2014 at 09:14:17PM -0700, Jun Rao wrote: I move KAFKA-1634 to

[jira] [Commented] (KAFKA-1718) Message Size Too Large error when only small messages produced with Snappy

2014-10-21 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14178519#comment-14178519 ] Sriharsha Chintalapani commented on KAFKA-1718: --- I ran sizeInBytes for

[jira] [Updated] (KAFKA-1721) Snappy compressor is not thread safe

2014-10-21 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1721?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1721: - Component/s: compression Snappy compressor is not thread safe

[jira] [Updated] (KAFKA-1678) add new options for reassign partition to better manager dead brokers

2014-10-21 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Stein updated KAFKA-1678: - Hey [~gwenshap], I have a freed up engineer this week and next to work on this ticket is it ok if I assign

Re: [DISCUSS] Release 0.8.2-beta before 0.8.2?

2014-10-21 Thread Joe Stein
Can Kafka-1583 go into 0.8.3 on trunk once ready? It is marked now for 0.9.0. I am about to move the JIRAs open and patch resolved to 0.8.3 from 0.8.2. On Tue, Oct 21, 2014 at 11:00 AM, Joel Koshy jjkosh...@gmail.com wrote: KAFKA-1634 is orthogonal to 1583 right? (BTW sorry about the delay in

[jira] [Updated] (KAFKA-1566) Kafka environment configuration (kafka-env.sh)

2014-10-21 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Stein updated KAFKA-1566: - Fix Version/s: (was: 0.8.2) (was: 0.9.0) 0.8.3 Kafka

[jira] [Updated] (KAFKA-1700) examples directory - README and shell scripts are out of date

2014-10-21 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Stein updated KAFKA-1700: - Fix Version/s: (was: 0.8.2) 0.8.3 examples directory - README and shell scripts

[jira] [Updated] (KAFKA-686) 0.8 Kafka broker should give a better error message when running against 0.7 zookeeper

2014-10-21 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-686?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Stein updated KAFKA-686: Fix Version/s: (was: 0.8.2) 0.8.3 0.8 Kafka broker should give a better error

[jira] [Updated] (KAFKA-438) Code cleanup in MessageTest

2014-10-21 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Stein updated KAFKA-438: Fix Version/s: (was: 0.8.2) 0.8.3 Code cleanup in MessageTest

[jira] [Updated] (KAFKA-1351) String.format is very expensive in Scala

2014-10-21 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Stein updated KAFKA-1351: - Fix Version/s: (was: 0.8.2) 0.8.3 String.format is very expensive in Scala

[jira] [Updated] (KAFKA-1420) Replace AdminUtils.createOrUpdateTopicPartitionAssignmentPathInZK with TestUtils.createTopic in unit tests

2014-10-21 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Stein updated KAFKA-1420: - Fix Version/s: (was: 0.8.2) 0.8.3 Replace

[jira] [Updated] (KAFKA-1561) Data Loss for Incremented Replica Factor and Leader Election

2014-10-21 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Stein updated KAFKA-1561: - Fix Version/s: (was: 0.8.2) 0.8.3 Data Loss for Incremented Replica Factor and

[jira] [Updated] (KAFKA-1374) LogCleaner (compaction) does not support compressed topics

2014-10-21 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Stein updated KAFKA-1374: - Fix Version/s: (was: 0.8.2) 0.8.3 LogCleaner (compaction) does not support

[jira] [Updated] (KAFKA-795) Improvements to PreferredReplicaLeaderElection tool

2014-10-21 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-795?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Stein updated KAFKA-795: Fix Version/s: (was: 0.8.2) 0.8.3 Improvements to PreferredReplicaLeaderElection

[jira] [Updated] (KAFKA-1660) Ability to call close() with a timeout on the Java Kafka Producer.

2014-10-21 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Stein updated KAFKA-1660: - Fix Version/s: (was: 0.8.2) 0.8.3 Ability to call close() with a timeout on the

[jira] [Updated] (KAFKA-1659) Ability to cleanly abort the KafkaProducer

2014-10-21 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Stein updated KAFKA-1659: - Fix Version/s: (was: 0.8.2) 0.8.3 Ability to cleanly abort the KafkaProducer

[jira] [Updated] (KAFKA-1499) Broker-side compression configuration

2014-10-21 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Stein updated KAFKA-1499: - Fix Version/s: (was: 0.8.2) 0.8.3 Broker-side compression configuration

[jira] [Updated] (KAFKA-934) kafka hadoop consumer and producer use older 0.19.2 hadoop api's

2014-10-21 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Stein updated KAFKA-934: Fix Version/s: (was: 0.8.2) 0.8.3 kafka hadoop consumer and producer use older

[jira] [Updated] (KAFKA-313) Add JSON output and looping options to ConsumerOffsetChecker

2014-10-21 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Stein updated KAFKA-313: Fix Version/s: (was: 0.8.2) 0.8.3 Add JSON output and looping options to

[jira] [Updated] (KAFKA-1230) shell script files under bin don't work with cygwin (bash on windows)

2014-10-21 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Stein updated KAFKA-1230: - Fix Version/s: (was: 0.8.2) 0.8.3 shell script files under bin don't work with

[jira] [Updated] (KAFKA-1675) bootstrapping tidy-up

2014-10-21 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Stein updated KAFKA-1675: - Fix Version/s: (was: 0.8.2) 0.8.3 bootstrapping tidy-up -

[jira] [Updated] (KAFKA-1651) Removed some extra whitespace in KafkaServer.scala

2014-10-21 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Stein updated KAFKA-1651: - Fix Version/s: (was: 0.8.2) 0.8.3 Removed some extra whitespace in

[jira] [Updated] (KAFKA-1481) Stop using dashes AND underscores as separators in MBean names

2014-10-21 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Stein updated KAFKA-1481: - Fix Version/s: (was: 0.8.2) 0.8.3 Stop using dashes AND underscores as separators

Re: [Java New Producer] Snappy NPE Issue

2014-10-21 Thread Bhavesh Mistry
Hi Ewen, It seems Leo has fixed the snappy lib for this issue. Here are changes: https://github.com/xerial/snappy-java/commit/7b86642f75c280debf3c1983053ea7f8635b48a5 Here is Jar with fix: https://oss.sonatype.org/content/repositories/snapshots/org/xerial/snappy/snappy-java/1.1.1.4-SNAPSHOT/

Re: [DISCUSS] Release 0.8.2-beta before 0.8.2?

2014-10-21 Thread Jun Rao
KAFKA-1583 will only be in trunk. It would be nice if we fix KAFKA-1634 in 0.8.2 too (may need a separate patch). If we can get a patch ready, we can include it in 0.8.2 final. Thanks, Jun On Tue, Oct 21, 2014 at 8:00 AM, Joel Koshy jjkosh...@gmail.com wrote: KAFKA-1634 is orthogonal to 1583

Re: Review Request 26373: Patch for KAFKA-1647

2014-10-21 Thread Jun Rao
On Oct. 21, 2014, 12:18 a.m., Jun Rao wrote: core/src/main/scala/kafka/server/ReplicaManager.scala, lines 481-506 https://reviews.apache.org/r/26373/diff/3/?file=725140#file725140line481 This doesn't quite fix the original problem though. The original problem is that if the

Re: Review Request 26666: Patch for KAFKA-1653

2014-10-21 Thread Neha Narkhede
On Oct. 21, 2014, 4:44 p.m., Neha Narkhede wrote: core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala, line 111 https://reviews.apache.org/r/2/diff/2/?file=723448#file723448line111 I ran a quick test on the following reassignment file and it didn't warn me about

[jira] [Comment Edited] (KAFKA-1718) Message Size Too Large error when only small messages produced with Snappy

2014-10-21 Thread Wojciech Kuranowski (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14178396#comment-14178396 ] Wojciech Kuranowski edited comment on KAFKA-1718 at 10/21/14 4:47 PM:

[jira] [Commented] (KAFKA-1678) add new options for reassign partition to better manager dead brokers

2014-10-21 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14178620#comment-14178620 ] Neha Narkhede commented on KAFKA-1678: -- There are a few more usability issues with

[jira] [Commented] (KAFKA-1678) add new options for reassign partition to better manager dead brokers

2014-10-21 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14178630#comment-14178630 ] Joe Stein commented on KAFKA-1678: -- Agreed, can this ticket be an update for those two

[jira] [Commented] (KAFKA-1678) add new options for reassign partition to better manager dead brokers

2014-10-21 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14178637#comment-14178637 ] Neha Narkhede commented on KAFKA-1678: -- Yes, I don't mind if it is part of the same

[jira] [Commented] (KAFKA-1678) add new options for reassign partition to better manager dead brokers

2014-10-21 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14178646#comment-14178646 ] Gwen Shapira commented on KAFKA-1678: - All yours, [~joestein]. add new options for

Re: [DISCUSS] Release 0.8.2-beta before 0.8.2?

2014-10-21 Thread Gwen Shapira
Note that I added a patch with 0.8.2 documentation to KAFKA-1555 (in order to document the new min.isr behavior). We need to get this committed in SVN before the release, and probably document few more things (new producer for example). Gwen On Tue, Oct 21, 2014 at 12:07 PM, Jun Rao

[jira] [Commented] (KAFKA-1481) Stop using dashes AND underscores as separators in MBean names

2014-10-21 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14178739#comment-14178739 ] Jun Rao commented on KAFKA-1481: Otis, Yes, we can include this in the 0.8.2 final

[jira] [Assigned] (KAFKA-1683) Implement a session concept in the socket server

2014-10-21 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira reassigned KAFKA-1683: --- Assignee: Gwen Shapira Implement a session concept in the socket server

[jira] [Commented] (KAFKA-1687) SASL tests

2014-10-21 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14178791#comment-14178791 ] Gwen Shapira commented on KAFKA-1687: - MiniKDC can be used to test with Kerberos

[jira] [Created] (KAFKA-1722) static analysis code coverage for pci audit needs

2014-10-21 Thread Joe Stein (JIRA)
Joe Stein created KAFKA-1722: Summary: static analysis code coverage for pci audit needs Key: KAFKA-1722 URL: https://issues.apache.org/jira/browse/KAFKA-1722 Project: Kafka Issue Type: Bug

[jira] [Updated] (KAFKA-1722) static analysis code coverage for pci audit needs

2014-10-21 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Stein updated KAFKA-1722: - Component/s: security static analysis code coverage for pci audit needs

[jira] [Comment Edited] (KAFKA-1688) Add authorization interface and naive implementation

2014-10-21 Thread Don Bosco Durai (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14178799#comment-14178799 ] Don Bosco Durai edited comment on KAFKA-1688 at 10/21/14 6:33 PM:

[jira] [Updated] (KAFKA-1555) provide strong consistency with reasonable availability

2014-10-21 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-1555: -- Reviewer: Joel Koshy (was: Jun Rao) provide strong consistency with reasonable availability

[jira] [Commented] (KAFKA-1481) Stop using dashes AND underscores as separators in MBean names

2014-10-21 Thread Vladimir Tretyakov (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14178815#comment-14178815 ] Vladimir Tretyakov commented on KAFKA-1481: --- Hi, Jun, will be perfect! Stop

[jira] [Assigned] (KAFKA-1684) Implement TLS/SSL authentication

2014-10-21 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1684?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Stein reassigned KAFKA-1684: Assignee: Ivan Lyutov Implement TLS/SSL authentication

Re: Review Request 26666: Patch for KAFKA-1653

2014-10-21 Thread Ewen Cheslack-Postava
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2/ --- (Updated Oct. 21, 2014, 6:58 p.m.) Review request for kafka. Bugs:

[jira] [Commented] (KAFKA-1653) Duplicate broker ids allowed in replica assignment

2014-10-21 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14178845#comment-14178845 ] Ewen Cheslack-Postava commented on KAFKA-1653: -- Updated reviewboard

[jira] [Updated] (KAFKA-1653) Duplicate broker ids allowed in replica assignment

2014-10-21 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ewen Cheslack-Postava updated KAFKA-1653: - Attachment: KAFKA-1653_2014-10-21_11:57:50.patch Duplicate broker ids allowed in

[jira] [Commented] (KAFKA-1721) Snappy compressor is not thread safe

2014-10-21 Thread Bhavesh Mistry (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14178856#comment-14178856 ] Bhavesh Mistry commented on KAFKA-1721: --- I have filled

Re: Kafka Security

2014-10-21 Thread Joe Stein
Hi, quick circle back around so folks are aware. The security tickets are tracked here https://issues.apache.org/jira/browse/KAFKA/component/12324383/?selectedTab=com.atlassian.jira.jira-projects-plugin:component-issues-panel If you want to jump in on a ticket please do! If no one is assigned

[jira] [Commented] (KAFKA-1710) [New Java Producer Potential Deadlock] Producer Deadlock when all messages is being sent to single partition

2014-10-21 Thread Bhavesh Mistry (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14179014#comment-14179014 ] Bhavesh Mistry commented on KAFKA-1710: --- [~jkreps], I am sorry I did not get back

[jira] [Comment Edited] (KAFKA-1710) [New Java Producer Potential Deadlock] Producer Deadlock when all messages is being sent to single partition

2014-10-21 Thread Bhavesh Mistry (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14179014#comment-14179014 ] Bhavesh Mistry edited comment on KAFKA-1710 at 10/21/14 8:26 PM:

[jira] [Comment Edited] (KAFKA-1710) [New Java Producer Potential Deadlock] Producer Deadlock when all messages is being sent to single partition

2014-10-21 Thread Bhavesh Mistry (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14179014#comment-14179014 ] Bhavesh Mistry edited comment on KAFKA-1710 at 10/21/14 8:28 PM:

[jira] [Comment Edited] (KAFKA-1710) [New Java Producer Potential Deadlock] Producer Deadlock when all messages is being sent to single partition

2014-10-21 Thread Bhavesh Mistry (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14179014#comment-14179014 ] Bhavesh Mistry edited comment on KAFKA-1710 at 10/21/14 8:29 PM:

Review Request 26994: Patch for KAFKA-1719

2014-10-21 Thread Jiangjie Qin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26994/ --- Review request for kafka. Bugs: KAFKA-1719

[jira] [Updated] (KAFKA-1719) Make mirror maker exit when one consumer/producer thread exits.

2014-10-21 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiangjie Qin updated KAFKA-1719: Attachment: KAFKA-1719.patch Make mirror maker exit when one consumer/producer thread exits.

[jira] [Commented] (KAFKA-1719) Make mirror maker exit when one consumer/producer thread exits.

2014-10-21 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14179047#comment-14179047 ] Jiangjie Qin commented on KAFKA-1719: - Created reviewboard

[jira] [Commented] (KAFKA-1647) Replication offset checkpoints (high water marks) can be lost on hard kills and restarts

2014-10-21 Thread Andrew Olson (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14179077#comment-14179077 ] Andrew Olson commented on KAFKA-1647: - [~nehanarkhede] Will this correction be

[jira] [Commented] (KAFKA-1477) add authentication layer and initial JKS x509 implementation for brokers, producers and consumer for network communication

2014-10-21 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14179081#comment-14179081 ] Jay Kreps commented on KAFKA-1477: -- I took a look at this patch in a little more detail,

[jira] [Commented] (KAFKA-1481) Stop using dashes AND underscores as separators in MBean names

2014-10-21 Thread Bhavesh Mistry (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14179092#comment-14179092 ] Bhavesh Mistry commented on KAFKA-1481: --- Hi [~junrao], Can you please let me know

[VOTE] 0.8.2-beta Release Candidate 1

2014-10-21 Thread Joe Stein
This is the first candidate for release of Apache Kafka 0.8.2-beta Release Notes for the 0.8.2-beta release https://people.apache.org/~joestein/kafka-0.8.2-beta-candidate1/RELEASE_NOTES.html *** Please download, test and vote by Friday, October 24th, 2pm PT Kafka's KEYS file containing PGP keys

[jira] [Commented] (KAFKA-1481) Stop using dashes AND underscores as separators in MBean names

2014-10-21 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14179102#comment-14179102 ] Jun Rao commented on KAFKA-1481: Thanks for the patch. Some comments below. 20.

[jira] [Updated] (KAFKA-1647) Replication offset checkpoints (high water marks) can be lost on hard kills and restarts

2014-10-21 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Stein updated KAFKA-1647: - Fix Version/s: 0.8.2 Replication offset checkpoints (high water marks) can be lost on hard kills and

[jira] [Created] (KAFKA-1723) make the metrics name in new producer more standard

2014-10-21 Thread Jun Rao (JIRA)
Jun Rao created KAFKA-1723: -- Summary: make the metrics name in new producer more standard Key: KAFKA-1723 URL: https://issues.apache.org/jira/browse/KAFKA-1723 Project: Kafka Issue Type: Sub-task

[jira] [Commented] (KAFKA-1723) make the metrics name in new producer more standard

2014-10-21 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14179128#comment-14179128 ] Jun Rao commented on KAFKA-1723: One way to address this issue is to change the jmx name

[jira] [Commented] (KAFKA-1481) Stop using dashes AND underscores as separators in MBean names

2014-10-21 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14179132#comment-14179132 ] Jun Rao commented on KAFKA-1481: Bhavesh, Created a subtask to track the metric name in

Re: Review Request 26994: Patch for KAFKA-1719

2014-10-21 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26994/#review57680 --- core/src/main/scala/kafka/tools/MirrorMaker.scala

Re: [DISCUSSION] Message Metadata

2014-10-21 Thread Guozhang Wang
Hi Jun, Regarding 4) in your comment, after thinking it for a while I cannot come up a way to it along with log compaction without adding new fields into the current format on message set. Do you have a better way that do not require protocol changes? Guozhang On Mon, Oct 20, 2014 at 9:53 AM,

[jira] [Reopened] (KAFKA-1555) provide strong consistency with reasonable availability

2014-10-21 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy reopened KAFKA-1555: --- I'm reopening this so we won't forget about the documentation patch. If you prefer, we can open a

Re: Review Request 24676: Rebase KAFKA-1583

2014-10-21 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24676/#review57235 --- Very nicely done. These are all minor comments - all but one

[jira] [Commented] (KAFKA-1583) Kafka API Refactoring

2014-10-21 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14179460#comment-14179460 ] Joel Koshy commented on KAFKA-1583: --- I posted review comments, mostly minor. Did you

[jira] [Commented] (KAFKA-1718) Message Size Too Large error when only small messages produced with Snappy

2014-10-21 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14179472#comment-14179472 ] Jun Rao commented on KAFKA-1718: Yes, the broker does recompress all messages in the

[jira] [Commented] (KAFKA-1718) Message Size Too Large error when only small messages produced with Snappy

2014-10-21 Thread Evan Huus (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14179485#comment-14179485 ] Evan Huus commented on KAFKA-1718: -- ??I guess your go producer can send multiple

[jira] [Comment Edited] (KAFKA-1718) Message Size Too Large error when only small messages produced with Snappy

2014-10-21 Thread Evan Huus (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14179485#comment-14179485 ] Evan Huus edited comment on KAFKA-1718 at 10/22/14 2:26 AM: