On May 6, 2015, 10:50 p.m., Jun Rao wrote:
clients/src/main/java/org/apache/kafka/common/network/Selector.java, lines
198-199
https://reviews.apache.org/r/33065/diff/4/?file=947532#file947532line198
Could we just iterate the keySet directly instead of making a copy
first?
We
I'm working on the C# client. The current Kafka Protocol page says this:
it should not generally be necessary to maintain multiple connections to a
single broker from a single client instance (i.e. connection pooling)
But then says this:
The server guarantees that on a single TCP connection,
[
https://issues.apache.org/jira/browse/KAFKA-1682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14542422#comment-14542422
]
Jun Rao commented on KAFKA-1682:
3. The SSL work is now being done in KAFKA-1690, on top
Michael,
The ssl work in now being done in
https://issues.apache.org/jira/browse/KAFKA-1690. It would be great if you
can help review it too. Also updated the top level security jira
accordingly.
Thanks,
Jun
On Wed, May 13, 2015 at 11:23 AM, Michael Herstine
mherst...@linkedin.com.invalid
Roger,
For 1), the producer actually doesn't move buffered data around during
leadership change. The producer buffer is per partition, independent of
what the current leader of that partition is. Does the issue happen w/o
retry? Does this happen in a particular version of snappy?
For 2),
On May 13, 2015, 3:40 p.m., Jun Rao wrote:
clients/src/main/java/org/apache/kafka/common/network/Selector.java, lines
286-291
https://reviews.apache.org/r/33620/diff/5/?file=957067#file957067line286
I am a bit confused how this works during the handshake. During the
handshake,
[
https://issues.apache.org/jira/browse/KAFKA-1690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14542437#comment-14542437
]
Sriharsha Chintalapani commented on KAFKA-1690:
---
[~junrao] Supporting
Just had a few minor questions before I join the vote thread.
Apologies if these have been discussed:
- Do we need DecreasePartitionsNotAllowed? i.e., can we just return
InvalidPartitions instead?
- AdminClient.listTopics: should we allow listing all partitions? Or
do you intend for the
[
https://issues.apache.org/jira/browse/KAFKA-790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14542808#comment-14542808
]
saiprasad mishra commented on KAFKA-790:
[~nehanarkhede]
I know its kind of later
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34170/
---
(Updated May 13, 2015, 10:32 p.m.)
Review request for kafka.
Bugs:
On May 13, 2015, 5:14 p.m., Jay Kreps wrote:
clients/src/main/java/org/apache/kafka/common/metrics/stats/SampledStat.java,
line 126
https://reviews.apache.org/r/34170/diff/1/?file=958216#file958216line126
how come we are removing the event count threshold.
Oh.. My bad, I should
On May 13, 2015, 5:14 p.m., Jay Kreps wrote:
clients/src/main/java/org/apache/kafka/common/metrics/stats/Rate.java, line
62
https://reviews.apache.org/r/34170/diff/1/?file=958215#file958215line62
Is this actually right? I agree you'll get discontinuities as the
measured time
[
https://issues.apache.org/jira/browse/KAFKA-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dong Lin updated KAFKA-2191:
Attachment: KAFKA-2191_2015-05-13_15:32:15.patch
Measured rate should not be infinite
[
https://issues.apache.org/jira/browse/KAFKA-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14542851#comment-14542851
]
Dong Lin commented on KAFKA-2191:
-
Updated reviewboard
On May 13, 2015, 11:50 p.m., Aditya Auradkar wrote:
clients/src/main/java/org/apache/kafka/common/metrics/stats/SampledStat.java,
line 45
https://reviews.apache.org/r/34170/diff/2/?file=958605#file958605line45
I think this is a good catch.
Just so I understand, this
On May 13, 2015, 11:50 p.m., Aditya Auradkar wrote:
clients/src/main/java/org/apache/kafka/common/metrics/stats/SampledStat.java,
line 45
https://reviews.apache.org/r/34170/diff/2/?file=958605#file958605line45
I think this is a good catch.
Just so I understand, this
My gut reaction is that this isn't that important for folks otherwise they
would have complained already. If it is a blocker for folks upgrading to
0.8.2.1 then we should do a 0.8.2.2 release with this fix in it. For 0.9.0.
we are pushing for folks to start using the new consumer and that is the
On May 13, 2015, 3:40 p.m., Jun Rao wrote:
clients/src/main/java/org/apache/kafka/common/network/TransportLayer.java,
line 98
https://reviews.apache.org/r/33620/diff/5/?file=957068#file957068line98
This seems to be ssl specific. Is this needed in the interface? It
doesn't seem
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34170/#review83687
---
Hello Warren,
I seems your C# client is both a producer and a consumer. Then with the
behavior of the broker, your suspension is correct that a long pooling
fetch using the same TCP connection will block subsequent produce /
metadata requests.
I think the statement that it should not generally
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33620/#review83322
---
Thanks for the patch. A few comments below. The following unit
[
https://issues.apache.org/jira/browse/KAFKA-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14542135#comment-14542135
]
Dong Lin commented on KAFKA-2191:
-
Created reviewboard
[
https://issues.apache.org/jira/browse/KAFKA-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dong Lin updated KAFKA-2191:
Status: Patch Available (was: Open)
Measured rate should not be infinite
[
https://issues.apache.org/jira/browse/KAFKA-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dong Lin updated KAFKA-2191:
Attachment: KAFKA-2191.patch
Measured rate should not be infinite
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34170/
---
Review request for kafka.
Bugs: KAFKA-2191
[
https://issues.apache.org/jira/browse/KAFKA-1690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14542145#comment-14542145
]
Jun Rao commented on KAFKA-1690:
Also, could anyone comment on whether we need to support
Not sure if it is related, but we could verify it with Roger's scenario.
Roger, what is your snappy version? Could you try version 1.1.1.7 and see
if this issue still persists?
Guozhang
On Tue, May 12, 2015 at 10:01 PM, Jiangjie Qin j...@linkedin.com.invalid
wrote:
Does this related to
On May 13, 2015, 5:14 p.m., Jay Kreps wrote:
clients/src/main/java/org/apache/kafka/common/metrics/stats/Rate.java, line
62
https://reviews.apache.org/r/34170/diff/1/?file=958215#file958215line62
Is this actually right? I agree you'll get discontinuities as the
measured time
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33731/#review83707
---
Pool is meant to be a simple, general purpose and very thin wrapper
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33731/#review83694
---
Thanks for the patch. A few comments.
1. The changes in Pool are
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34170/#review83629
---
On May 13, 2015, 3:40 p.m., Jun Rao wrote:
clients/src/main/java/org/apache/kafka/clients/CommonClientConfigs.java,
lines 61-112
https://reviews.apache.org/r/33620/diff/4/?file=955770#file955770line61
Those properties will be used by broker config as well, right? Should
we put
On May 13, 2015, 3:40 p.m., Jun Rao wrote:
Thanks for the patch. A few comments below. The following unit tests seem
to fail.
org.apache.kafka.common.network.SSLFactoryTest
testSSLFactoryConfiguration FAILED
java.lang.IllegalArgumentException: TLSv1.2
at
[
https://issues.apache.org/jira/browse/KAFKA-1690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14542282#comment-14542282
]
Sriharsha Chintalapani commented on KAFKA-1690:
---
[~junrao] I think we don't
[
https://issues.apache.org/jira/browse/KAFKA-1690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jun Rao updated KAFKA-1690:
---
Status: In Progress (was: Patch Available)
[~rsivaram], could you help review the patch too and especially
[
https://issues.apache.org/jira/browse/KAFKA-2167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Neelesh Srinivas Salian updated KAFKA-2167:
---
Fix Version/s: 0.8.2.0
Status: Patch Available (was: Open)
Here
Regarding the SSL code‹ is there an RB available? I don¹t see a recent
patch uploaded to https://issues.apache.org/jira/browse/KAFKA-1684Š How
can other folks see the code?
On 5/12/15, 12:07 PM, Gwen Shapira gshap...@cloudera.com wrote:
My notes from the hangout:
* KIP-11: Based on feedback
[
https://issues.apache.org/jira/browse/KAFKA-2167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14542308#comment-14542308
]
Neelesh Srinivas Salian commented on KAFKA-2167:
Updated fix version from
[
https://issues.apache.org/jira/browse/KAFKA-2167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Neelesh Srinivas Salian updated KAFKA-2167:
---
Fix Version/s: (was: 0.8.2.0)
0.8.3
ZkUtils
GitHub user xuwei-k opened a pull request:
https://github.com/apache/kafka/pull/65
remove unnecessary imports
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/xuwei-k/kafka remove-imports
Alternatively you can review and apply
Dong Lin created KAFKA-2191:
---
Summary: Measured rate should not be infinite
Key: KAFKA-2191
URL: https://issues.apache.org/jira/browse/KAFKA-2191
Project: Kafka
Issue Type: Bug
[
https://issues.apache.org/jira/browse/KAFKA-2176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Igor Maravić updated KAFKA-2176:
Status: Open (was: Patch Available)
DefaultPartitioner doesn't perform consistent hashing based
[
https://issues.apache.org/jira/browse/KAFKA-2176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14541484#comment-14541484
]
Igor Maravić commented on KAFKA-2176:
-
Partitioning is working as expected with new
[
https://issues.apache.org/jira/browse/KAFKA-2176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Igor Maravić resolved KAFKA-2176.
-
Resolution: Won't Fix
DefaultPartitioner doesn't perform consistent hashing based on
[
https://issues.apache.org/jira/browse/KAFKA-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14541498#comment-14541498
]
antoine vianey commented on KAFKA-1911:
---
it should handle the case of a producer
[
https://issues.apache.org/jira/browse/KAFKA-2169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14542708#comment-14542708
]
Jun Rao commented on KAFKA-2169:
Thought a bit more about this. When handling
46 matches
Mail list logo
