On May 14, 2015, 10:21 a.m., Rajini Sivaram wrote:
clients/src/main/java/org/apache/kafka/common/network/Authenticator.java,
line 47
https://reviews.apache.org/r/33620/diff/5/?file=957060#file957060line47
Don't think authenticator interface should handle selection
interestOps.
On May 14, 2015, 10:21 a.m., Rajini Sivaram wrote:
clients/src/test/java/org/apache/kafka/common/network/SSLSelectorTest.java,
line 36
https://reviews.apache.org/r/33620/diff/5/?file=957076#file957076line36
All these tests were hanging when I ran them from a Windows machine
On May 14, 2015, 10:21 a.m., Rajini Sivaram wrote:
clients/src/main/java/org/apache/kafka/common/network/SSLTransportLayer.java,
lines 268-280
https://reviews.apache.org/r/33620/diff/5/?file=957065#file957065line268
Graceful close needs close handshake messages to be be
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33620/#review83767
---
[
https://issues.apache.org/jira/browse/KAFKA-2147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14543666#comment-14543666
]
Evan Huus commented on KAFKA-2147:
--
Increasing the producer batch size has substantially
On May 14, 2015, 10:21 a.m., Rajini Sivaram wrote:
clients/src/main/java/org/apache/kafka/common/network/SSLTransportLayer.java,
line 190
https://reviews.apache.org/r/33620/diff/5/?file=957065#file957065line190
I think when delegated tasks are run asynchronously, selection
[
https://issues.apache.org/jira/browse/KAFKA-2147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jun Rao updated KAFKA-2147:
---
Attachment: KAFKA-2147_2015-05-14_09:41:56.patch
Unbalanced replication can cause extreme purgatory growth
On May 13, 2015, 3:40 p.m., Jun Rao wrote:
clients/src/main/java/org/apache/kafka/clients/CommonClientConfigs.java,
lines 61-112
https://reviews.apache.org/r/33620/diff/4/?file=955770#file955770line61
Those properties will be used by broker config as well, right? Should
we put
On May 6, 2015, 10:50 p.m., Jun Rao wrote:
core/src/main/scala/kafka/network/SocketServer.scala, line 455
https://reviews.apache.org/r/33065/diff/4/?file=947565#file947565line455
This is just registering for reads, not for writes, right?
Maybe I misunderstood, but it looks like
I'm also not sure how useful it is, but there is some discussion on it
here:
https://issues.apache.org/jira/browse/KAFKA-1597
On Thu, May 14, 2015 at 09:26:02PM +0300, Gwen Shapira wrote:
Hi,
As part of KAFKA-1928, we need to consolidate existing SocketServer metrics
into Selector metrics.
On May 13, 2015, 5:14 p.m., Jay Kreps wrote:
clients/src/main/java/org/apache/kafka/common/metrics/stats/Rate.java, line
62
https://reviews.apache.org/r/34170/diff/1/?file=958215#file958215line62
Is this actually right? I agree you'll get discontinuities as the
measured time
For ListTopics, we decided not to add a ListTopics request for now and just
rely on passing in an empty list to TMR. We can revisit this in the future
if it becomes an issue.
Thanks,
Jun
On Wed, May 13, 2015 at 3:31 PM, Joel Koshy jjkosh...@gmail.com wrote:
Just had a few minor questions
Hi,
As part of KAFKA-1928, we need to consolidate existing SocketServer metrics
into Selector metrics.
The two metrics are:
1. NetworkProcessorAvgIdlePercent
2. ResponsesBeingSent
NetworkProcessorAvgIdlePercent is currently implemented as Meter, which
seems to translate nicely into
[
https://issues.apache.org/jira/browse/KAFKA-1690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14544028#comment-14544028
]
Jun Rao commented on KAFKA-1690:
[~sriharsha], what about SASL? So we also rely on
[
https://issues.apache.org/jira/browse/KAFKA-2147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14543979#comment-14543979
]
Jun Rao commented on KAFKA-2147:
Updated reviewboard
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34125/
---
(Updated May 14, 2015, 4:42 p.m.)
Review request for kafka.
Bugs: KAFKA-2147
[
https://issues.apache.org/jira/browse/KAFKA-2147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14543761#comment-14543761
]
Evan Huus commented on KAFKA-2147:
--
OK, it appears the patch does not fix this issue, we
[
https://issues.apache.org/jira/browse/KAFKA-2147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14543986#comment-14543986
]
Jun Rao commented on KAFKA-2147:
I added a bit more instrumentation. Could you apply the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33620/#review83777
---
+1
On Thu, May 07, 2015 at 04:25:06PM -0700, Jun Rao wrote:
+1 on the vote.
Thanks,
Jun
On Thu, May 7, 2015 at 8:29 AM, Andrii Biletskyi
andrii.bilets...@stealth.ly wrote:
Jun,
1. My bad, updated description, but forgot the schema itself. Fixed.
2. Okay, changed that.
I don't believe we're using the ResponsesBeingSent information at all. I
know we use NetworkProcessorAvgIdlePercent to keep track of the utilization
of the pool.
-Todd
On Thu, May 14, 2015 at 11:36 AM, Joel Koshy jjkosh...@gmail.com wrote:
I'm also not sure how useful it is, but there is some
Erik created KAFKA-2192:
---
Summary: Async producer is not async when not connected
Key: KAFKA-2192
URL: https://issues.apache.org/jira/browse/KAFKA-2192
Project: Kafka
Issue Type: Bug
[
https://issues.apache.org/jira/browse/KAFKA-2193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tom Lee updated KAFKA-2193:
---
Description:
Our Kafka cluster recently experienced some intermittent network DNS
resolution issues such
Tom Lee created KAFKA-2193:
--
Summary: Intermittent network + DNS issues can cause brokers to
permanently drop out of a cluster
Key: KAFKA-2193
URL: https://issues.apache.org/jira/browse/KAFKA-2193
Project:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33088/#review83851
---
Ship it!
Ship It!
- Guozhang Wang
On May 14, 2015, 7:38 a.m.,
On May 6, 2015, 10:50 p.m., Jun Rao wrote:
clients/src/main/java/org/apache/kafka/common/network/Selector.java, lines
311-315
https://reviews.apache.org/r/33065/diff/4/?file=947532#file947532line311
In this case, we should probably just propagate the exception and
potentially
[
https://issues.apache.org/jira/browse/KAFKA-1928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gwen Shapira updated KAFKA-1928:
Attachment: KAFKA-1928_2015-05-15.patch
Move kafka.network over to using the network classes in
[
https://issues.apache.org/jira/browse/KAFKA-1928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gwen Shapira updated KAFKA-1928:
Attachment: (was: KAFKA-1928_2015-05-15.patch)
Move kafka.network over to using the network
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33065/
---
(Updated May 14, 2015, 9:30 p.m.)
Review request for kafka.
Changes
---
[
https://issues.apache.org/jira/browse/KAFKA-1334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14544431#comment-14544431
]
Guozhang Wang commented on KAFKA-1334:
--
Committed the first draft patch to trunk.
[
https://issues.apache.org/jira/browse/KAFKA-1334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guozhang Wang updated KAFKA-1334:
-
Status: In Progress (was: Patch Available)
Add failure detection capability to the coordinator
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33065/#review83841
---
core/src/main/scala/kafka/network/SocketServer.scala
On May 6, 2015, 10:50 p.m., Jun Rao wrote:
clients/src/main/java/org/apache/kafka/common/network/Selector.java, lines
311-315
https://reviews.apache.org/r/33065/diff/4/?file=947532#file947532line311
In this case, we should probably just propagate the exception and
potentially
[
https://issues.apache.org/jira/browse/KAFKA-1928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gwen Shapira updated KAFKA-1928:
Attachment: KAFKA-1928_2015-05-15.patch
Move kafka.network over to using the network classes in
See https://builds.apache.org/job/Kafka-trunk/489/changes
Changes:
[wangguoz] KAFKA-1334; Add the heartbeat logic to consumer coordinator;
reviewed by Guozhang Wang
--
[...truncated 2413 lines...]
at
The C# client (kafka-net) isn't written by me; I'm just working on it. It
has a separate producer and consumer, but the client is designed to connect
to each broker exactly once and then reuse (multiplex over) that one
connection across all consumers and producers.
It's a bit disappointing to
On May 6, 2015, 10:50 p.m., Jun Rao wrote:
clients/src/main/java/org/apache/kafka/common/network/Selector.java, lines
311-315
https://reviews.apache.org/r/33065/diff/4/?file=947532#file947532line311
In this case, we should probably just propagate the exception and
potentially
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33065/
---
(Updated May 14, 2015, 9:51 p.m.)
Review request for kafka.
Changes
---
[
https://issues.apache.org/jira/browse/KAFKA-2190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14544610#comment-14544610
]
Jiangjie Qin commented on KAFKA-2190:
-
Created reviewboard
[
https://issues.apache.org/jira/browse/KAFKA-2190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jiangjie Qin updated KAFKA-2190:
Attachment: KAFKA-2190.patch
Incorporate close(timeout) to Mirror Maker
[
https://issues.apache.org/jira/browse/KAFKA-2190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jiangjie Qin updated KAFKA-2190:
Status: Patch Available (was: Open)
Incorporate close(timeout) to Mirror Maker
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34241/
---
Review request for kafka.
Bugs: KAFKA-2190
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33065/
---
(Updated May 15, 2015, 12:07 a.m.)
Review request for kafka.
Changes
---
+1 for dropping ResponsesBeingSent.
Thanks,
Jun
On Thu, May 14, 2015 at 4:38 PM, Jiangjie Qin j...@linkedin.com.invalid
wrote:
I think we probably can drop this completely. The new selector should have
provided enough metrics to describe the IO thread status. And it is async
anyway, so
I think we probably can drop this completely. The new selector should have
provided enough metrics to describe the IO thread status. And it is async
anyway, so ³being sent² does not look really helpful.
Jiangjie (Becket) Qin
On 5/14/15, 1:06 PM, Todd Palino tpal...@gmail.com wrote:
I don't
[
https://issues.apache.org/jira/browse/KAFKA-1690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14544793#comment-14544793
]
Sriharsha Chintalapani commented on KAFKA-1690:
---
[~junrao] In SASL lets
[
https://issues.apache.org/jira/browse/KAFKA-1928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gwen Shapira updated KAFKA-1928:
Attachment: KAFKA-1928_2015-05-15_03%3A05%3A37.patch.patch
Move kafka.network over to using the
[
https://issues.apache.org/jira/browse/KAFKA-1928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gwen Shapira updated KAFKA-1928:
Attachment: (was: KAFKA-1928_2015-05-15_03%3A05%3A37.patch.patch)
Move kafka.network over to
Hey Joe,
Actually this API was asked for before, and we have several use cases in
LinkedIn as well. I thought we have added that in KAFKA-1650 but obviously
I forgot to do that.
My understanding is that we won¹t really deprecate high level consumer
until we move to 0.9.0. So we can have this API
[
https://issues.apache.org/jira/browse/KAFKA-1928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gwen Shapira updated KAFKA-1928:
Attachment: KAFKA-1928_2015-05-15_03.patch
Move kafka.network over to using the network classes in
Hey Becket, yeah good point. Officially there is no 0.8.3
https://cwiki.apache.org/confluence/display/KAFKA/Future+release+plan release
planned.
I agree we should have the new consumer beta and a patch for the old one.
If we do that in 0.8.3 that makes good sense, yup. We should also include
On May 14, 2015, 10:21 a.m., Rajini Sivaram wrote:
clients/src/main/java/org/apache/kafka/common/network/Authenticator.java,
line 47
https://reviews.apache.org/r/33620/diff/5/?file=957060#file957060line47
Don't think authenticator interface should handle selection
interestOps.
On May 13, 2015, 5:14 p.m., Jay Kreps wrote:
clients/src/main/java/org/apache/kafka/common/metrics/stats/Rate.java, line
62
https://reviews.apache.org/r/34170/diff/1/?file=958215#file958215line62
Is this actually right? I agree you'll get discontinuities as the
measured time
On May 13, 2015, 5:14 p.m., Jay Kreps wrote:
clients/src/main/java/org/apache/kafka/common/metrics/stats/Rate.java, line
62
https://reviews.apache.org/r/34170/diff/1/?file=958215#file958215line62
Is this actually right? I agree you'll get discontinuities as the
measured time
On May 13, 2015, 11:50 p.m., Aditya Auradkar wrote:
clients/src/main/java/org/apache/kafka/common/metrics/stats/SampledStat.java,
line 45
https://reviews.apache.org/r/34170/diff/2/?file=958605#file958605line45
I think this is a good catch.
Just so I understand, this
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34170/
---
(Updated May 14, 2015, 7:34 a.m.)
Review request for kafka.
Bugs: KAFKA-2191
[
https://issues.apache.org/jira/browse/KAFKA-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14543329#comment-14543329
]
Dong Lin commented on KAFKA-2191:
-
Updated reviewboard
[
https://issues.apache.org/jira/browse/KAFKA-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dong Lin updated KAFKA-2191:
Attachment: KAFKA-2191_2015-05-14_00:34:30.patch
Measured rate should not be infinite
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33088/
---
(Updated May 14, 2015, 7:38 a.m.)
Review request for kafka.
Bugs: KAFKA-1334
[
https://issues.apache.org/jira/browse/KAFKA-1334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=1454#comment-1454
]
Onur Karaman commented on KAFKA-1334:
-
Updated reviewboard
[
https://issues.apache.org/jira/browse/KAFKA-1334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Onur Karaman updated KAFKA-1334:
Attachment: KAFKA-1334_2015-05-14_00:38:39.patch
Add failure detection capability to the
Joel,
- DecreasePartitionNotAllowed. Yeah, that's kind of subcase of
InvalidPartitions...
But since client can always request topic metadata and check what exactly is
was wrong with Partitions argument, I think, yes, we can remove
DecreasePartitionNotAllowed
and use InvalidPartitions instead.
On May 7, 2015, 10:07 p.m., Guozhang Wang wrote:
core/src/main/scala/kafka/coordinator/CoordinatorMetadata.scala, line 53
https://reviews.apache.org/r/33088/diff/10/?file=950430#file950430line53
Add @nonthreadsafe for this function.
Onur Karaman wrote:
It would be awkward to
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33620/#review83741
---
checkstyle/import-control.xml
64 matches
Mail list logo
