---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33620/#review92599
---
On July 22, 2015, 3 p.m., Jun Rao wrote:
clients/src/main/java/org/apache/kafka/common/network/SSLTransportLayer.java,
lines 231-234
https://reviews.apache.org/r/33620/diff/12/?file=1017027#file1017027line231
Still some questions on this.
1. When handshakeStatus is
[
https://issues.apache.org/jira/browse/KAFKA-2350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14637126#comment-14637126
]
Jay Kreps commented on KAFKA-2350:
--
[~becket_qin] Cool, we're on the same page, that was
On July 22, 2015, 3 p.m., Jun Rao wrote:
clients/src/main/java/org/apache/kafka/common/network/SSLTransportLayer.java,
lines 361-374
https://reviews.apache.org/r/33620/diff/12/?file=1017027#file1017027line361
Hmm, if status is ok and handshakeStatus is NEED_UNWRAP, could we get
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36681/#review92604
---
Hey Ashish, this looks pretty good to me. Just some minor comments.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33620/#review92405
---
On July 22, 2015, 3 p.m., Jun Rao wrote:
clients/src/main/java/org/apache/kafka/common/network/SSLTransportLayer.java,
line 411
https://reviews.apache.org/r/33620/diff/12/?file=1017027#file1017027line411
Is renegotiation actually supported? It seems that renegotiation can
On July 21, 2015, 11:15 p.m., Gwen Shapira wrote:
core/src/main/scala/kafka/network/SocketServer.scala, line 400
https://reviews.apache.org/r/36664/diff/1/?file=1018238#file1018238line400
So in case of unexpected exception, we log an error and keep running?
Isn't it
On July 21, 2015, 11:15 p.m., Gwen Shapira wrote:
core/src/main/scala/kafka/network/SocketServer.scala, line 465
https://reviews.apache.org/r/36664/diff/1/?file=1018238#file1018238line465
Turns out that catching Throwable is a really bad idea:
[
https://issues.apache.org/jira/browse/KAFKA-2350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14637219#comment-14637219
]
Yasuhiro Matsuda commented on KAFKA-2350:
-
I think overloading
[
https://issues.apache.org/jira/browse/KAFKA-2350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14637317#comment-14637317
]
Jay Kreps commented on KAFKA-2350:
--
[~hachikuji] Yeah I agree that would help this case.
[
https://issues.apache.org/jira/browse/KAFKA-2350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14637187#comment-14637187
]
Jason Gustafson edited comment on KAFKA-2350 at 7/22/15 5:01 PM:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36664/#review92607
---
LGTM overall. Could you address Ismael's comments as well before
[
https://issues.apache.org/jira/browse/KAFKA-2352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14637208#comment-14637208
]
Jiangjie Qin commented on KAFKA-2352:
-
Can you verify whether the messages you passed
[
https://issues.apache.org/jira/browse/KAFKA-2350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14637338#comment-14637338
]
Gwen Shapira commented on KAFKA-2350:
-
Agree with [~yasuhiro.matsuda].
The notion of
Tangent: I think we should complete the move of Produce / Fetch RPC to
the client libraries before we add more revisions to this protocol.
On Wed, Jul 22, 2015 at 11:02 AM, Jiangjie Qin
j...@linkedin.com.invalid wrote:
I missed yesterday's KIP hangout. I'm currently working on another KIP for
+1 (non binding)
Can we have a wiki for procedure and let people verify the steps? After
that we can update the Apache project page.
On Tue, Jul 21, 2015 at 5:38 PM, Edward Ribeiro edward.ribe...@gmail.com
wrote:
+1 (non binding)
On Tue, Jul 21, 2015 at 7:36 PM, Jay Kreps j...@confluent.io
[
https://issues.apache.org/jira/browse/KAFKA-2350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14637179#comment-14637179
]
Guozhang Wang commented on KAFKA-2350:
--
Currently there is already a function for
I missed yesterday's KIP hangout. I'm currently working on another KIP for
enriched metadata of messages. Guozhang has already created a wiki page
before (
https://cwiki.apache.org/confluence/display/KAFKA/Kafka+Enriched+Message+Metadata).
We plan to fill the relative offset to the offset field in
Since I've been dealing with the fallout of this particular problem all
week, I'll add a few thoughts...
On Wed, Jul 22, 2015 at 10:51 AM, Gwen Shapira gshap...@cloudera.com
wrote:
On July 21, 2015, 11:15 p.m., Gwen Shapira wrote:
core/src/main/scala/kafka/network/SocketServer.scala,
I don't think we have consumer coordinator in 0.8.2 brokers. So
KafkaConsumer in 0.8.3 will only be able to subscribe to partitions
explicitly. Subscribing to a topic won't work with 0.8.2 brokers.
Jiangjie (Becket) Qin
On Wed, Jul 22, 2015 at 4:26 AM, Stevo Slavić ssla...@gmail.com wrote:
I'm
[
https://issues.apache.org/jira/browse/KAFKA-2342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14637525#comment-14637525
]
ASF GitHub Bot commented on KAFKA-2342:
---
Github user asfgit closed the pull request
[
https://issues.apache.org/jira/browse/KAFKA-2342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guozhang Wang resolved KAFKA-2342.
--
Resolution: Fixed
Fix Version/s: 0.9.0
Issue resolved by pull request 88
[
https://issues.apache.org/jira/browse/KAFKA-2342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14637533#comment-14637533
]
Stevo Slavic commented on KAFKA-2342:
-
[~guozhang], fix version 0.9.0 or 0.8.3?
[
https://issues.apache.org/jira/browse/KAFKA-2342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guozhang Wang updated KAFKA-2342:
-
Fix Version/s: (was: 0.9.0)
0.8.3
KafkaConsumer rebalance with in-flight
Hi,
On 22 Jul 2015 19:32, Jiangjie Qin j...@linkedin.com.invalid wrote:
+1 (non binding)
Can we have a wiki for procedure and let people verify the steps? After
that we can update the Apache project page.
Yes, I linked to the page in the original message:
On July 21, 2015, 11:15 p.m., Gwen Shapira wrote:
core/src/main/scala/kafka/network/SocketServer.scala, line 465
https://reviews.apache.org/r/36664/diff/1/?file=1018238#file1018238line465
Turns out that catching Throwable is a really bad idea:
Hello Folks,
I wish to contribute to Kafka internals. And, one of the things which can
help me do that is understanding how kafka uses zookeeper. I have some of
these basic doubts:-
1. Is zookeeper primarily used for locking ? If yes, in what cases and what
kind of nodes does it use -
[
https://issues.apache.org/jira/browse/KAFKA-2350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14637187#comment-14637187
]
Jason Gustafson commented on KAFKA-2350:
[~becket_qin] [~jkreps] Currently
On July 22, 2015, 10:40 a.m., Ismael Juma wrote:
core/src/main/scala/kafka/network/SocketServer.scala, line 467
https://reviews.apache.org/r/36664/diff/2/?file=1018375#file1018375line467
As far as I can see `ClosedChannelException`, `IllegalStateException`
and
Github user asfgit closed the pull request at:
https://github.com/apache/kafka/pull/88
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
[
https://issues.apache.org/jira/browse/KAFKA-2342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14637539#comment-14637539
]
Guozhang Wang commented on KAFKA-2342:
--
[~sslavic] corrected, thanks.
KafkaConsumer
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36590/#review92557
---
Hey guys, I realized that most of this code has changed as the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36681/
---
Review request for kafka.
Bugs: KAFKA-2275
[
https://issues.apache.org/jira/browse/KAFKA-2275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14636378#comment-14636378
]
Ashish K Singh commented on KAFKA-2275:
---
Created reviewboard
Hello folks,
I'd like to ask the community about its opinion on the partitioning
functions in Kafka.
With KAFKA-2091 https://issues.apache.org/jira/browse/KAFKA-2091
integrated we are now able to have custom partitioners in the producer.
The question now becomes *which* partitioners should ship
Hi Gwen,
On Sun, Jul 19, 2015 at 2:26 AM, Gwen Shapira gshap...@cloudera.com wrote:
So, as an experiment, I created:
https://apachekafka.slack.com
I figured we'll give it a whirl for a week or two for dev discussions,
see how it goes and if we have activity we can add this to the website
[
https://issues.apache.org/jira/browse/KAFKA-2092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14636353#comment-14636353
]
Jason Gustafson commented on KAFKA-2092:
[~azaroth], I'm actually not sure that
On Apache Mahout project we're using Slack as well - for release
coordination. It was found that extra Slack channel does not really fit
into Apache way - it was overused, there were too many design discussions
going on there, to which community at large has no access to, was not and
could not be
On Mon, Jul 20, 2015 at 10:45 PM, Grant Henke ghe...@cloudera.com wrote:
In one run of the core tests I found the following:
- 4584 regular files (REG)
- 376 .jar files
- Not much one can/should do here. Many are from gradle itself.
- 2392 kafka .log files
-
I'm getting Unknown api code 11 even when both client and server are
0.8.3/trunk, when KafkaConsumer.subscribe(String... topics) is used.
Bug?
Kind regards,
Stevo Slavic.
On Fri, Apr 24, 2015 at 7:13 PM, Neha Narkhede n...@confluent.io wrote:
Yes, I was clearly confused :-)
On Fri, Apr 24,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36670/#review92571
---
core/src/test/scala/unit/kafka/admin/DeleteTopicTest.scala (line
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36664/#review92574
---
core/src/main/scala/kafka/network/SocketServer.scala (line 401)
On July 22, 2015, 10:29 a.m., Ismael Juma wrote:
core/src/test/scala/unit/kafka/admin/DeleteTopicTest.scala, line 269
https://reviews.apache.org/r/36670/diff/1/?file=1018343#file1018343line269
Should `verifyTopicDeletion` be inside `finally`? I don't think so
because you don't
Stevo Slavic created KAFKA-2356:
---
Summary: Support retrieving partitions of ConsumerRecords
Key: KAFKA-2356
URL: https://issues.apache.org/jira/browse/KAFKA-2356
Project: Kafka
Issue Type:
GitHub user sslavic opened a pull request:
https://github.com/apache/kafka/pull/92
ConsumerRecords are organized per topic partition
ConsumerRecords has records organized per topic partition, not per topic as
ConsumerRecords javadoc suggested.
You can merge this pull request into
See https://builds.apache.org/job/KafkaPreCommit/160/changes
[
https://issues.apache.org/jira/browse/KAFKA-2350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14637753#comment-14637753
]
Jason Gustafson commented on KAFKA-2350:
[~jkreps] This is a little unrelated to
[
https://issues.apache.org/jira/browse/KAFKA-2350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14637792#comment-14637792
]
Jiangjie Qin commented on KAFKA-2350:
-
[~guozhang] In the last case you mentioned, is
[
https://issues.apache.org/jira/browse/KAFKA-2004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14637419#comment-14637419
]
sutanu das commented on KAFKA-2004:
---
We just want to stream each logfile as event from
[
https://issues.apache.org/jira/browse/KAFKA-1893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14638028#comment-14638028
]
Jason Gustafson commented on KAFKA-1893:
[~singhashish] Sure, no problem.
Allow
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36670/
---
(Updated July 23, 2015, 1:23 a.m.)
Review request for kafka.
Bugs:
[
https://issues.apache.org/jira/browse/KAFKA-2355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14638036#comment-14638036
]
Edward Ribeiro commented on KAFKA-2355:
---
Updated reviewboard
[
https://issues.apache.org/jira/browse/KAFKA-2355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Edward Ribeiro updated KAFKA-2355:
--
Attachment: KAFKA-2355_2015-07-22_22:23:13.patch
Add an unit test to validate the deletion of
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36681/#review92700
---
Ship it!
Just one question on the unit test. Otherwise, LGTM.
[
https://issues.apache.org/jira/browse/KAFKA-2350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14638063#comment-14638063
]
Jiangjie Qin commented on KAFKA-2350:
-
Yes, that is what I meant.
Isn't it the case
[
https://issues.apache.org/jira/browse/KAFKA-2350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14638070#comment-14638070
]
Jiangjie Qin commented on KAFKA-2350:
-
I think an explicit configuration makes sense.
Ordering gurantee should be optional. If someone needs ordering, they can
always fall back on exclusive consumer strategy
On Wednesday, July 22, 2015, Ashish Singh asi...@cloudera.com wrote:
Hey, don't you think that would be against the basic ordering guarantees
Kafka provides?
On Wed, Jul
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36681/#review92696
---
On July 22, 2015, 10:40 a.m., Ismael Juma wrote:
core/src/main/scala/kafka/network/SocketServer.scala, line 401
https://reviews.apache.org/r/36664/diff/2/?file=1018375#file1018375line401
Is it intentional to ignore `java.lang.Error` too?
I think java.lang.Error is a subclass of
[
https://issues.apache.org/jira/browse/KAFKA-2351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14638076#comment-14638076
]
Mayuresh Gharat commented on KAFKA-2351:
[~junrao], [~guozhang] can you take a
Why have partition at all, if I don't need to scale topic. Coupling topic
scalability with consumer scalability just goes against messaging systems
core principle of decoupling consumer and producers
On Wednesday, July 22, 2015, Aditya Auradkar aaurad...@linkedin.com.invalid
wrote:
Hi,
Why
On July 22, 2015, 5:13 p.m., Guozhang Wang wrote:
LGTM overall. Could you address Ismael's comments as well before check-in?
Thanks, Guozhang. I updated patch to address Ismael's comments.
- Jiangjie
---
This is an automatically
[
https://issues.apache.org/jira/browse/KAFKA-2350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14638139#comment-14638139
]
Jay Kreps commented on KAFKA-2350:
--
[~hachikuji] yeah i vote for pause/resume (or
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33620/#review92711
---
[
https://issues.apache.org/jira/browse/KAFKA-2350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14638182#comment-14638182
]
Jiangjie Qin commented on KAFKA-2350:
-
[~yasuhiro.matsuda] [~jkreps] [~hachikuji]
Hi, This is reference to stackoverflow question
http://stackoverflow.com/questions/31547216/kafka-log-deletion-and-load-balancing-across-consumers
Since Kafka 0.8 already maintains a client offset, i would like to request
a feature, where a single partition consumption can be round robin across
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36681/#review92644
---
Ship it!
LGTM. I think we can checkin after Jason's comments get
On July 21, 2015, 11:15 p.m., Gwen Shapira wrote:
core/src/main/scala/kafka/network/SocketServer.scala, line 465
https://reviews.apache.org/r/36664/diff/1/?file=1018238#file1018238line465
Turns out that catching Throwable is a really bad idea:
Hi,
Why not simply have as many partitions as the set of consumers you want to
round robin across?
Aditya
On Wed, Jul 22, 2015 at 2:37 PM, Ashish Singh asi...@cloudera.com wrote:
Hey, don't you think that would be against the basic ordering guarantees
Kafka provides?
On Wed, Jul 22, 2015
Hey, don't you think that would be against the basic ordering guarantees
Kafka provides?
On Wed, Jul 22, 2015 at 2:14 PM, J A mbatth...@gmail.com wrote:
Hi, This is reference to stackoverflow question
[
https://issues.apache.org/jira/browse/KAFKA-2004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14637745#comment-14637745
]
Ashish K Singh commented on KAFKA-2004:
---
Spark streaming supports reading from
[
https://issues.apache.org/jira/browse/KAFKA-2275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ashish K Singh updated KAFKA-2275:
--
Attachment: KAFKA-2275_2015-07-22_16:09:34.patch
Add a ListTopics() API to the new consumer
[
https://issues.apache.org/jira/browse/KAFKA-2350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14637890#comment-14637890
]
Guozhang Wang commented on KAFKA-2350:
--
[~becket_qin] OK I understand now. The
[
https://issues.apache.org/jira/browse/KAFKA-2275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14637889#comment-14637889
]
Ashish K Singh commented on KAFKA-2275:
---
Updated reviewboard
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36681/
---
(Updated July 22, 2015, 11:09 p.m.)
Review request for kafka.
Bugs:
[
https://issues.apache.org/jira/browse/KAFKA-2353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jiangjie Qin updated KAFKA-2353:
Attachment: KAFKA-2353_2015-07-22_17:51:42.patch
SocketServer.Processor should catch exception and
On July 22, 2015, 4:43 p.m., Jason Gustafson wrote:
Hey Ashish, this looks pretty good to me. Just some minor comments.
Thanks for the review! Addressed your concerns.
On July 22, 2015, 4:43 p.m., Jason Gustafson wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36670/
---
(Updated July 23, 2015, 12:38 a.m.)
Review request for kafka.
Bugs:
[
https://issues.apache.org/jira/browse/KAFKA-2355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Edward Ribeiro updated KAFKA-2355:
--
Attachment: KAFKA-2355_2015-07-22_21:37:51.patch
Add an unit test to validate the deletion of
[
https://issues.apache.org/jira/browse/KAFKA-2355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14637984#comment-14637984
]
Edward Ribeiro commented on KAFKA-2355:
---
Updated reviewboard
[
https://issues.apache.org/jira/browse/KAFKA-1893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14637894#comment-14637894
]
Ashish K Singh commented on KAFKA-1893:
---
[~hachikuji] I think after working on
Jiangjie,
Seems I was misunderstood; KafakConsumer.poll after subscribing to topic
via KafkaConsumer.subscribe(String... topics) does not work, Unknown api
code 11 error, even with both client and broker being latest 0.8.3/trunk.
Will try to create a failing test and open bug report.
Kind
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36670/#review92688
---
core/src/test/scala/unit/kafka/admin/DeleteTopicTest.scala (line
[
https://issues.apache.org/jira/browse/KAFKA-2355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14637996#comment-14637996
]
Edward Ribeiro commented on KAFKA-2355:
---
Hi [~ijuma] and [~granthenke], I have
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36664/
---
(Updated July 23, 2015, 12:51 a.m.)
Review request for kafka.
Bugs:
[
https://issues.apache.org/jira/browse/KAFKA-2353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14638008#comment-14638008
]
Jiangjie Qin commented on KAFKA-2353:
-
Updated reviewboard
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33620/#review92314
---
Thanks for the patch. Looks good overall. A few comments below.
[
https://issues.apache.org/jira/browse/KAFKA-2345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stevo Slavic updated KAFKA-2345:
Affects Version/s: 0.8.2.0
Attempt to delete a topic already marked for deletion throws
89 matches
Mail list logo
