---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18846/
---
Review request for kafka.
Bugs: KAFKA-1189
[
https://issues.apache.org/jira/browse/KAFKA-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13922642#comment-13922642
]
Martin Kleppmann commented on KAFKA-1189:
-
Created reviewboard
[
https://issues.apache.org/jira/browse/KAFKA-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Martin Kleppmann updated KAFKA-1189:
Attachment: KAFKA-1189.patch
kafka-server-stop.sh doesn't stop broker
[
https://issues.apache.org/jira/browse/KAFKA-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13922649#comment-13922649
]
Martin Kleppmann commented on KAFKA-1189:
-
This happens if the broker is started
[
https://issues.apache.org/jira/browse/KAFKA-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Martin Kleppmann updated KAFKA-1189:
Status: Patch Available (was: Open)
kafka-server-stop.sh doesn't stop broker
Do we want to release with this? This basically shows up in the quick start
or any usage. Frankly I would not trust a system that did something like
this under basic usage with my data
-Jay
On Tue, Mar 4, 2014 at 9:21 PM, Jun Rao jun...@gmail.com wrote:
Not sure why the message count
Jay Kreps created KAFKA-1293:
Summary: Mirror maker housecleaning
Key: KAFKA-1293
URL: https://issues.apache.org/jira/browse/KAFKA-1293
Project: Kafka
Issue Type: Bug
Components: tools
[
https://issues.apache.org/jira/browse/KAFKA-1070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jay Kreps updated KAFKA-1070:
-
Labels: usability (was: )
Auto-assign node id
---
Key: KAFKA-1070
Jay Kreps created KAFKA-1294:
Summary: Enable leadership balancing by default
Key: KAFKA-1294
URL: https://issues.apache.org/jira/browse/KAFKA-1294
Project: Kafka
Issue Type: Improvement
Evan Zacks created KAFKA-1295:
-
Summary: CLONE (0.8.1) - Minor typos in documentation
Key: KAFKA-1295
URL: https://issues.apache.org/jira/browse/KAFKA-1295
Project: Kafka
Issue Type: Bug
[
https://issues.apache.org/jira/browse/KAFKA-1295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13922743#comment-13922743
]
Evan Zacks commented on KAFKA-1295:
---
Updated patch for 0.8.1 per [~jkreps] update in
[
https://issues.apache.org/jira/browse/KAFKA-1295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Evan Zacks updated KAFKA-1295:
--
Affects Version/s: (was: 0.8.0)
0.8.1
CLONE (0.8.1) - Minor typos in
[
https://issues.apache.org/jira/browse/KAFKA-1295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Evan Zacks updated KAFKA-1295:
--
Description:
Several typos (misspellings, missing punctuation) appear in the introduction,
[
https://issues.apache.org/jira/browse/KAFKA-1295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Evan Zacks updated KAFKA-1295:
--
Attachment: KAFKA-1295-doc-typos.patch
Adapted from patch for BNMA-1269.
CLONE (0.8.1) - Minor typos
[
https://issues.apache.org/jira/browse/KAFKA-1295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Evan Zacks reassigned KAFKA-1295:
-
Assignee: (was: Evan Zacks)
CLONE (0.8.1) - Minor typos in documentation
Some more inconsistent command-line options:
--clientId in kafka-simple-consumer-perf-test.sh and
kafka-simple-consumer-shell.sh
-name, -loggc and -daemon in kafka-run-class.sh and kafka-server-start.sh
(single dash instead of a double dash)
It's aesthetics, but I agree that it's important.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18774/
---
(Updated March 6, 2014, 5:24 p.m.)
Review request for kafka.
Bugs:
On March 5, 2014, 6:33 p.m., Neha Narkhede wrote:
core/src/main/scala/kafka/tools/newproducer/MirrorMaker.scala, line 159
https://reviews.apache.org/r/18774/diff/1/?file=510875#file510875line159
I had initially added multiple producer support to the mirror maker
until we are
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18846/#review36368
---
Ship it!
Ship It!
- Neha Narkhede
On March 6, 2014, 3:26 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18846/#review36371
---
Could you test that works on both mac and linux?
- Jun Rao
On
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18774/
---
(Updated March 6, 2014, 5:36 p.m.)
Review request for kafka.
Bugs:
[
https://issues.apache.org/jira/browse/KAFKA-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Neha Narkhede updated KAFKA-1189:
-
Resolution: Fixed
Assignee: Martin Kleppmann
Status: Resolved (was: Patch
I agree this is annoying. Do you feel this is a blocker for the 0.8.1
release?. This happens when you kill the console consumer, at the which
point you probably won't care what the output is.
On Thu, Mar 6, 2014 at 8:20 AM, Jay Kreps jay.kr...@gmail.com wrote:
Do we want to release with this?
On March 5, 2014, 6:33 p.m., Neha Narkhede wrote:
core/src/main/scala/kafka/tools/newproducer/MirrorMaker.scala, line 159
https://reviews.apache.org/r/18774/diff/1/?file=510875#file510875line159
I had initially added multiple producer support to the mirror maker
until we are
On March 6, 2014, 5:37 p.m., Jun Rao wrote:
Could you test that works on both mac and linux?
Jun: yes, I've tested both on Mac OS 10.8.5 and Ubuntu 12.04. The behavior is
the same on both: the nohup'ed process ignores SIGINT, but shuts down correctly
on SIGTERM.
- Martin
On March 6, 2014, 5:37 p.m., Jun Rao wrote:
Could you test that works on both mac and linux?
Martin Kleppmann wrote:
Jun: yes, I've tested both on Mac OS 10.8.5 and Ubuntu 12.04. The
behavior is the same on both: the nohup'ed process ignores SIGINT, but shuts
down correctly on
On March 6, 2014, 5:37 p.m., Jun Rao wrote:
Could you test that works on both mac and linux?
Martin Kleppmann wrote:
Jun: yes, I've tested both on Mac OS 10.8.5 and Ubuntu 12.04. The
behavior is the same on both: the nohup'ed process ignores SIGINT, but shuts
down correctly on
On March 6, 2014, 5:37 p.m., Jun Rao wrote:
Could you test that works on both mac and linux?
Martin Kleppmann wrote:
Jun: yes, I've tested both on Mac OS 10.8.5 and Ubuntu 12.04. The
behavior is the same on both: the nohup'ed process ignores SIGINT, but shuts
down correctly on
[
https://issues.apache.org/jira/browse/KAFKA-1275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13922873#comment-13922873
]
Joel Koshy commented on KAFKA-1275:
---
I had skimmed through the log compaction write-up
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18712/#review36390
---
Ship it!
core/src/main/scala/kafka/producer/ConsoleProducer.scala
Issue Subscription
Filter: outstanding kafka patches (84 issues)
The list of outstanding kafka patches
Subscriber: kafka-mailing-list
Key Summary
KAFKA-1264 Make ConsoleProducer compression codec configurable
https://issues.apache.org/jira/browse/KAFKA-1264
KAFKA-1253
On March 6, 2014, 6:47 p.m., Jun Rao wrote:
core/src/main/scala/kafka/producer/ConsoleProducer.scala, lines 115-126
https://reviews.apache.org/r/18712/diff/4/?file=511668#file511668line115
Perhaps we just need to keep one of the two options and set different
properties in the old
On March 6, 2014, 1:47 a.m., Neha Narkhede wrote:
core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala, line
307
https://reviews.apache.org/r/18022/diff/1-2/?file=483587#file483587line307
ZookeeperConsumerConnector is getting really large. I think it might be
[
https://issues.apache.org/jira/browse/KAFKA-1275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13922928#comment-13922928
]
Joel Koshy commented on KAFKA-1275:
---
Also, may want to make a note of the difference
[
https://issues.apache.org/jira/browse/KAFKA-1275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13922944#comment-13922944
]
Joe Stein commented on KAFKA-1275:
--
I am a bit confused by
3.The offset for a message
[
https://issues.apache.org/jira/browse/KAFKA-1275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13923015#comment-13923015
]
Jay Kreps commented on KAFKA-1275:
--
Hey Joe/Joel,
I clarified the guarantees and fixed
[
https://issues.apache.org/jira/browse/KAFKA-1275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13923034#comment-13923034
]
Joe Stein commented on KAFKA-1275:
--
ah ha! got it now :) VERY COOL.
So the KeyedMessage
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18712/#review36425
---
Ship it!
core/src/main/scala/kafka/producer/ConsoleProducer.scala
[
https://issues.apache.org/jira/browse/KAFKA-1275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13923060#comment-13923060
]
Joe Stein commented on KAFKA-1275:
--
Maybe an example after the paragraph
Log compaction
[
https://issues.apache.org/jira/browse/KAFKA-1275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13923060#comment-13923060
]
Joe Stein edited comment on KAFKA-1275 at 3/6/14 9:05 PM:
--
Maybe
On March 6, 2014, 9 p.m., Guozhang Wang wrote:
core/src/main/scala/kafka/producer/ConsoleProducer.scala, line 308
https://reviews.apache.org/r/18712/diff/4/?file=511668#file511668line308
What about wrap producer configs in propertyOpt to read from a file,
like ReplayLogProducer
On March 5, 2014, 6:33 p.m., Neha Narkhede wrote:
core/src/main/scala/kafka/tools/newproducer/MirrorMaker.scala, line 159
https://reviews.apache.org/r/18774/diff/1/?file=510875#file510875line159
I had initially added multiple producer support to the mirror maker
until we are
Neha Narkhede created KAFKA-1296:
Summary: Improve error reporting in new mirror maker
Key: KAFKA-1296
URL: https://issues.apache.org/jira/browse/KAFKA-1296
Project: Kafka
Issue Type:
[
https://issues.apache.org/jira/browse/KAFKA-1296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Neha Narkhede updated KAFKA-1296:
-
Summary: Improve error reporting in new mirror maker and console producer
(was: Improve error
[
https://issues.apache.org/jira/browse/KAFKA-1296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Neha Narkhede updated KAFKA-1296:
-
Description: In the new mirror maker (like the old MM), the MM
asynchronously sends data through
On March 5, 2014, 6:33 p.m., Neha Narkhede wrote:
core/src/main/scala/kafka/tools/newproducer/MirrorMaker.scala, line 159
https://reviews.apache.org/r/18774/diff/1/?file=510875#file510875line159
I had initially added multiple producer support to the mirror maker
until we are
Jay Kreps created KAFKA-1298:
Summary: Controlled shutdown tool doesn't seem to work out of the
box
Key: KAFKA-1298
URL: https://issues.apache.org/jira/browse/KAFKA-1298
Project: Kafka
Issue
[
https://issues.apache.org/jira/browse/KAFKA-1275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13923355#comment-13923355
]
Guozhang Wang commented on KAFKA-1275:
--
One more minor thing: in the quick start, we
[
https://issues.apache.org/jira/browse/KAFKA-1275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13923364#comment-13923364
]
Jay Kreps commented on KAFKA-1275:
--
Yeah, I was waiting to see the final binary release
[
https://issues.apache.org/jira/browse/KAFKA-1296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13923374#comment-13923374
]
Jay Kreps commented on KAFKA-1296:
--
Yeah this should be easy enough, just add a callback
[
https://issues.apache.org/jira/browse/KAFKA-1298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13923370#comment-13923370
]
Jay Kreps commented on KAFKA-1298:
--
In the short term I need to document in because that
[
https://issues.apache.org/jira/browse/KAFKA-1298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13923378#comment-13923378
]
Sriram Subramanian commented on KAFKA-1298:
---
I dont think we have enabled it by
[
https://issues.apache.org/jira/browse/KAFKA-1298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13923390#comment-13923390
]
Joel Koshy commented on KAFKA-1298:
---
I think the tool itself may be useful to have (say
[
https://issues.apache.org/jira/browse/KAFKA-1240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jun Rao updated KAFKA-1240:
---
Attachment: KAFKA-1240_2014-03-06_17:42:06.patch
Add ability to existing system tests to use the new
[
https://issues.apache.org/jira/browse/KAFKA-1240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13923393#comment-13923393
]
Jun Rao commented on KAFKA-1240:
Updated reviewboard https://reviews.apache.org/r/18774/
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18774/
---
(Updated March 7, 2014, 1:42 a.m.)
Review request for kafka.
Bugs:
[
https://issues.apache.org/jira/browse/KAFKA-1298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13923396#comment-13923396
]
Neha Narkhede commented on KAFKA-1298:
--
One fix would be to change the definition of
[
https://issues.apache.org/jira/browse/KAFKA-1253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guozhang Wang reassigned KAFKA-1253:
Assignee: Guozhang Wang
Implement compression in new producer
[
https://issues.apache.org/jira/browse/KAFKA-1253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guozhang Wang updated KAFKA-1253:
-
Attachment: KAFKA-1253_2014-03-06_17:48:11.patch
Implement compression in new producer
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18299/
---
(Updated March 7, 2014, 1:48 a.m.)
Review request for kafka.
Summary
[
https://issues.apache.org/jira/browse/KAFKA-1298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13923408#comment-13923408
]
Jay Kreps commented on KAFKA-1298:
--
Cool so for 0.8.1 I just want to document what you
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18774/#review36473
---
Ship it!
core/src/main/scala/kafka/utils/Utils.scala
On March 7, 2014, 1:58 a.m., Neha Narkhede wrote:
core/src/main/scala/kafka/utils/Utils.scala, line 560
https://reviews.apache.org/r/18774/diff/3/?file=513166#file513166line560
Can we change this to error(Error... exception, e).
e.getMessage is not terribly useful
On the
Neha Narkhede created KAFKA-1299:
Summary: Standardize configs across tools
Key: KAFKA-1299
URL: https://issues.apache.org/jira/browse/KAFKA-1299
Project: Kafka
Issue Type: Improvement
[
https://issues.apache.org/jira/browse/KAFKA-1299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Neha Narkhede updated KAFKA-1299:
-
Description:
We have quite a few tools that have a set of options relevant to the tool but
then
[
https://issues.apache.org/jira/browse/KAFKA-1281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Neha Narkhede updated KAFKA-1281:
-
Resolution: Fixed
Status: Resolved (was: Patch Available)
Committed to trunk
add the
[
https://issues.apache.org/jira/browse/KAFKA-1262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Neha Narkhede resolved KAFKA-1262.
--
Resolution: Cannot Reproduce
I think this is fixed now.
Producer halts on broker bounces
[
https://issues.apache.org/jira/browse/KAFKA-1240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jun Rao resolved KAFKA-1240.
Resolution: Fixed
Fix Version/s: 0.8.2
Thanks for the review. Committed to trunk.
Add ability to
[
https://issues.apache.org/jira/browse/KAFKA-1299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13923524#comment-13923524
]
Jay Kreps commented on KAFKA-1299:
--
I agree. Perhaps we can make a ProducerOptions and
69 matches
Mail list logo
