[jira] [Commented] (KAFKA-170) Support for non-blocking polling on multiple streams

2014-05-27 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14009835#comment-14009835 ] Guozhang Wang commented on KAFKA-170: - Claude, in 0.9 we are going to rewrite our

[jira] [Resolved] (KAFKA-1444) kafka.javaapi.TopicMetadata and PartitionMetadata doesn't forward the toString method

2014-05-27 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede resolved KAFKA-1444. -- Resolution: Fixed Thanks for the patch, pushed to trunk kafka.javaapi.TopicMetadata and

[jira] [Closed] (KAFKA-1444) kafka.javaapi.TopicMetadata and PartitionMetadata doesn't forward the toString method

2014-05-27 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede closed KAFKA-1444. kafka.javaapi.TopicMetadata and PartitionMetadata doesn't forward the toString method

Re: Review Request 21865: Patch for KAFKA-1438

2014-05-27 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21865/#review43988 --- We also want to move the *Performance out of perf into tools and

Re: Review Request 21865: Patch for KAFKA-1438

2014-05-27 Thread Sriharsha Chintalapani
On May 27, 2014, 5:26 p.m., Neha Narkhede wrote: perf/src/main/scala/kafka/perf/ProducerPerformance.scala, line 42 https://reviews.apache.org/r/21865/diff/1/?file=589809#file589809line42 same here current perf project has its own log4j.properties under perf/config and it writes to

Re: Review Request 21865: Patch for KAFKA-1438

2014-05-27 Thread Sriharsha Chintalapani
On May 27, 2014, 5:26 p.m., Neha Narkhede wrote: We also want to move the *Performance out of perf into tools and remove the perf subproject The diff contains changes necessary for moving perf classes under tools. - Sriharsha

Re: Review Request 21865: Patch for KAFKA-1438

2014-05-27 Thread Neha Narkhede
On May 27, 2014, 5:26 p.m., Neha Narkhede wrote: We also want to move the *Performance out of perf into tools and remove the perf subproject Sriharsha Chintalapani wrote: The diff contains changes necessary for moving perf classes under tools. I applied the patch. It failed to

Re: Review Request 21883: Patch for KAFKA-1459

2014-05-27 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21883/#review44014 --- Ship it! Ship It! - Neha Narkhede On May 24, 2014, 2:05 a.m.,

[jira] [Closed] (KAFKA-1311) Add a flag to turn off delete topic until it is stable

2014-05-27 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy closed KAFKA-1311. - Add a flag to turn off delete topic until it is stable

[jira] [Closed] (KAFKA-1317) KafkaServer 0.8.1 not responding to .shutdown() cleanly, possibly related to TopicDeletionManager or MetricsMeter state

2014-05-27 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy closed KAFKA-1317. - KafkaServer 0.8.1 not responding to .shutdown() cleanly, possibly related to TopicDeletionManager or

[jira] [Closed] (KAFKA-1323) log.dirs server property no longer supports relative directories

2014-05-27 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy closed KAFKA-1323. - log.dirs server property no longer supports relative directories

[jira] [Closed] (KAFKA-1315) log.dirs property in KafkaServer intolerant of trailing slash

2014-05-27 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy closed KAFKA-1315. - log.dirs property in KafkaServer intolerant of trailing slash

[jira] [Closed] (KAFKA-1380) 0.8.1.1 release candidate

2014-05-27 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy closed KAFKA-1380. - 0.8.1.1 release candidate - Key: KAFKA-1380

[jira] [Closed] (KAFKA-1362) Publish sources and javadoc jars

2014-05-27 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy closed KAFKA-1362. - Publish sources and javadoc jars Key: KAFKA-1362

[jira] [Closed] (KAFKA-1365) Second Manual preferred replica leader election command always fails

2014-05-27 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy closed KAFKA-1365. - Second Manual preferred replica leader election command always fails

[jira] [Closed] (KAFKA-1358) Broker throws exception when reconnecting to zookeeper

2014-05-27 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy closed KAFKA-1358. - Broker throws exception when reconnecting to zookeeper

[jira] [Closed] (KAFKA-1398) Topic config changes can be lost and cause fatal exceptions on broker restarts

2014-05-27 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy closed KAFKA-1398. - Topic config changes can be lost and cause fatal exceptions on broker restarts

[jira] [Closed] (KAFKA-1289) Misc. nitpicks in log cleaner

2014-05-27 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy closed KAFKA-1289. - Misc. nitpicks in log cleaner - Key: KAFKA-1289

[jira] [Closed] (KAFKA-1319) kafka jar doesn't depend on metrics-annotation any more

2014-05-27 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy closed KAFKA-1319. - kafka jar doesn't depend on metrics-annotation any more

[jira] [Resolved] (KAFKA-1380) 0.8.1.1 release candidate

2014-05-27 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy resolved KAFKA-1380. --- Resolution: Fixed 0.8.1.1 release candidate - Key:

[jira] [Closed] (KAFKA-1288) add enclosing dir in release tar gz

2014-05-27 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy closed KAFKA-1288. - add enclosing dir in release tar gz --- Key: KAFKA-1288

[jira] [Commented] (KAFKA-1438) Migrate kafka client tools

2014-05-27 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14010100#comment-14010100 ] Sriharsha Chintalapani commented on KAFKA-1438: --- Updated reviewboard

[jira] [Updated] (KAFKA-1438) Migrate kafka client tools

2014-05-27 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sriharsha Chintalapani updated KAFKA-1438: -- Attachment: KAFKA-1438_2014-05-27_11:45:29.patch Migrate kafka client tools

Re: Review Request 21865: Patch for KAFKA-1438

2014-05-27 Thread Sriharsha Chintalapani
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21865/ --- (Updated May 27, 2014, 6:45 p.m.) Review request for kafka. Bugs: KAFKA-1438

[jira] [Closed] (KAFKA-1355) Reduce/optimize update metadata requests sent during leader election

2014-05-27 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy closed KAFKA-1355. - Reduce/optimize update metadata requests sent during leader election

Review Request 21937: KAFKA-1316 WIP refactor of sender.

2014-05-27 Thread Jay Kreps
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21937/ --- Review request for kafka. Bugs: KAFKA-1316

[jira] [Commented] (KAFKA-1316) Refactor Sender

2014-05-27 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14010153#comment-14010153 ] Jay Kreps commented on KAFKA-1316: -- Created reviewboard

[jira] [Commented] (KAFKA-1438) Migrate kafka client tools

2014-05-27 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14010155#comment-14010155 ] Sriharsha Chintalapani commented on KAFKA-1438: --- Updated reviewboard

[jira] [Updated] (KAFKA-1438) Migrate kafka client tools

2014-05-27 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sriharsha Chintalapani updated KAFKA-1438: -- Attachment: KAFKA-1438_2014-05-27_12:16:00.patch Migrate kafka client tools

[jira] [Created] (KAFKA-1471) Add Producer Unit Tests for LZ4 and LZ4HC compression

2014-05-27 Thread James Oliver (JIRA)
James Oliver created KAFKA-1471: --- Summary: Add Producer Unit Tests for LZ4 and LZ4HC compression Key: KAFKA-1471 URL: https://issues.apache.org/jira/browse/KAFKA-1471 Project: Kafka Issue

[jira] [Commented] (KAFKA-1471) Add Producer Unit Tests for LZ4 and LZ4HC compression

2014-05-27 Thread James Oliver (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14010167#comment-14010167 ] James Oliver commented on KAFKA-1471: - Created reviewboard against branch trunk Add

[jira] [Updated] (KAFKA-1471) Add Producer Unit Tests for LZ4 and LZ4HC compression

2014-05-27 Thread James Oliver (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Oliver updated KAFKA-1471: Attachment: KAFKA-1471.patch Add Producer Unit Tests for LZ4 and LZ4HC compression

Review Request 21938: Patch for KAFKA-1471

2014-05-27 Thread James Oliver
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21938/ --- Review request for kafka. Bugs: KAFKA-1471

[jira] [Commented] (KAFKA-1471) Add Producer Unit Tests for LZ4 and LZ4HC compression

2014-05-27 Thread James Oliver (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14010168#comment-14010168 ] James Oliver commented on KAFKA-1471: - Created reviewboard

[jira] [Updated] (KAFKA-1471) Add Producer Unit Tests for LZ4 and LZ4HC compression

2014-05-27 Thread James Oliver (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Oliver updated KAFKA-1471: Attachment: KAFKA-1471.patch Add Producer Unit Tests for LZ4 and LZ4HC compression

Re: Review Request 21865: Patch for KAFKA-1438

2014-05-27 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21865/#review44034 --- I get the following error while applying the patch- patching file

[jira] [Resolved] (KAFKA-1459) kafka.tools.ConsumerOffsetChecker throws NoNodeException

2014-05-27 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede resolved KAFKA-1459. -- Resolution: Fixed Assignee: Sriharsha Chintalapani Thanks for the patch, pushed to trunk

[jira] [Closed] (KAFKA-1459) kafka.tools.ConsumerOffsetChecker throws NoNodeException

2014-05-27 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede closed KAFKA-1459. kafka.tools.ConsumerOffsetChecker throws NoNodeException

Re: Review Request 21616: Patch for KAFKA-924

2014-05-27 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21616/#review43991 --- core/src/main/scala/kafka/consumer/ConsoleConsumer.scala

Jenkins build is back to normal : Kafka-trunk #191

2014-05-27 Thread Apache Jenkins Server
See https://builds.apache.org/job/Kafka-trunk/191/changes

[jira] [Commented] (KAFKA-997) Provide a strict verification mode when reading configuration properties

2014-05-27 Thread Sam Meder (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14010310#comment-14010310 ] Sam Meder commented on KAFKA-997: - Looked at this a bit more a while ago and am just going

Re: Review Request 21865: Patch for KAFKA-1438

2014-05-27 Thread Sriharsha Chintalapani
On May 27, 2014, 8:40 p.m., Neha Narkhede wrote: I get the following error while applying the patch- patching file bin/windows/kafka-run-class.bat Hunk #1 FAILED at 36. Hunk #2 FAILED at 121. 2 out of 2 hunks FAILED -- saving rejects to file bin/windows/kafka-run-class.bat.rej

[jira] [Resolved] (KAFKA-924) Specify console consumer properties via a single --property command line parameter

2014-05-27 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-924?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede resolved KAFKA-924. - Resolution: Fixed Assignee: Sriharsha Chintalapani Thanks for the patches, pushed to trunk

Re: Review Request 21865: Patch for KAFKA-1438

2014-05-27 Thread Neha Narkhede
On May 27, 2014, 8:40 p.m., Neha Narkhede wrote: I get the following error while applying the patch- patching file bin/windows/kafka-run-class.bat Hunk #1 FAILED at 36. Hunk #2 FAILED at 121. 2 out of 2 hunks FAILED -- saving rejects to file bin/windows/kafka-run-class.bat.rej

[jira] [Created] (KAFKA-1472) Add the compression ratio metrics in the new producer

2014-05-27 Thread Guozhang Wang (JIRA)
Guozhang Wang created KAFKA-1472: Summary: Add the compression ratio metrics in the new producer Key: KAFKA-1472 URL: https://issues.apache.org/jira/browse/KAFKA-1472 Project: Kafka Issue

Build failed in Jenkins: Kafka-trunk #192

2014-05-27 Thread Apache Jenkins Server
See https://builds.apache.org/job/Kafka-trunk/192/changes Changes: [neha.narkhede] KAFKA-1459 kafka.tools.ConsumerOffsetChecker throws NoNodeException; reviewed by Neha Narkhede [neha.narkhede] KAFKA-924. Specify console consumer properties via a single --property command line parameter;

[jira] [Comment Edited] (KAFKA-1316) Refactor Sender

2014-05-27 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14010498#comment-14010498 ] Jay Kreps edited comment on KAFKA-1316 at 5/27/14 11:38 PM:

[jira] [Commented] (KAFKA-1316) Refactor Sender

2014-05-27 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14010498#comment-14010498 ] Jay Kreps commented on KAFKA-1316: -- For (2) I think there are two solutions 1. Change the

Re: Review Request 21883: Patch for KAFKA-1459

2014-05-27 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21883/#review44068 --- core/src/main/scala/kafka/tools/ConsumerOffsetChecker.scala

Re: Review Request 21865: Patch for KAFKA-1438

2014-05-27 Thread Sriharsha Chintalapani
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21865/ --- (Updated May 28, 2014, 12:08 a.m.) Review request for kafka. Bugs:

[jira] [Updated] (KAFKA-1438) Migrate kafka client tools

2014-05-27 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sriharsha Chintalapani updated KAFKA-1438: -- Attachment: KAFKA-1438_2014-05-27_17:08:59.patch Migrate kafka client tools

[jira] [Commented] (KAFKA-1438) Migrate kafka client tools

2014-05-27 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14010538#comment-14010538 ] Sriharsha Chintalapani commented on KAFKA-1438: --- Updated reviewboard

Re: Review Request 21865: Patch for KAFKA-1438

2014-05-27 Thread Sriharsha Chintalapani
On May 27, 2014, 8:40 p.m., Neha Narkhede wrote: I get the following error while applying the patch- patching file bin/windows/kafka-run-class.bat Hunk #1 FAILED at 36. Hunk #2 FAILED at 121. 2 out of 2 hunks FAILED -- saving rejects to file bin/windows/kafka-run-class.bat.rej

Re: Review Request 21616: Patch for KAFKA-924

2014-05-27 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21616/#review44074 --- Ship it! Ship It! - Guozhang Wang On May 27, 2014, 9:51 p.m.,

[jira] [Updated] (KAFKA-1438) Migrate kafka client tools

2014-05-27 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1438: - Description: Currently the console/perf client tools scatter across different packages, we'd

Re: Review Request 21865: Patch for KAFKA-1438

2014-05-27 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21865/#review44081 --- I get the same error as Neha on kafka-run-class.sh, could you

Re: Review Request 21663: Patch for KAFKA-1456

2014-05-27 Thread James Oliver
Yeah I meant to get to that Friday... Created subtask KAFKA-1471 to address this https://reviews.apache.org/r/21938/ On Mon, May 26, 2014 at 8:40 AM, Joe Stein crypt...@gmail.com wrote: This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21663/ On

Re: Review Request 21878: KAFKA-1468: Misc. improvements to test scripts from benchmarking

2014-05-27 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21878/#review44087 ---

Re: Review Request 21883: Patch for KAFKA-1459

2014-05-27 Thread Sriharsha Chintalapani
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21883/ --- (Updated May 28, 2014, 3:19 a.m.) Review request for kafka. Bugs: KAFKA-1459

[jira] [Commented] (KAFKA-1459) kafka.tools.ConsumerOffsetChecker throws NoNodeException

2014-05-27 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14010710#comment-14010710 ] Sriharsha Chintalapani commented on KAFKA-1459: --- Updated reviewboard

[jira] [Updated] (KAFKA-1459) kafka.tools.ConsumerOffsetChecker throws NoNodeException

2014-05-27 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sriharsha Chintalapani updated KAFKA-1459: -- Attachment: KAFKA-1459_2014-05-27_20:19:55.patch

Kafka meetup during Hadoop Summit

2014-05-27 Thread Neha Narkhede
Hi, We are hosting a Kafka meetup during Hadoop Summit at LinkedIn on June 3rd. Agenda includes the following talks followed by networking. Operating Kafka at Scale by Clark Haskins and Todd Palino@LinkedIn Secure Kafka by Rajasekar Elango@Salesforce Samza - Stream processing at scale on Kafka

[jira] [Resolved] (KAFKA-1470) Quickstart documentation contains a minor typo

2014-05-27 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao resolved KAFKA-1470. Resolution: Fixed Assignee: Baris Can Daylik Thanks for the patch. Committed. Quickstart

Re: Review Request 21883: Patch for KAFKA-1459

2014-05-27 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21883/#review44093 --- Ship it! Neha, would you like to check this in as a follow-up? -