[jira] [Updated] (KAFKA-1523) Implement transaction manager module

[ https://issues.apache.org/jira/browse/KAFKA-1523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated KAFKA-1523: Attachment: KAFKA-1523_2014-08-08_21:36:52.patch > Implement transaction manager module > -

[jira] [Commented] (KAFKA-1523) Implement transaction manager module

[ https://issues.apache.org/jira/browse/KAFKA-1523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14091646#comment-14091646 ] Dong Lin commented on KAFKA-1523: - Updated reviewboard https://reviews.apache.org/r/23568/

Re: Review Request 23568: Patch for KAFKA-1523

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23568/ --- (Updated Aug. 9, 2014, 4:36 a.m.) Review request for kafka. Bugs: KAFKA-1523

Re: Review Request 23567: Patch for KAFKA-1522

> On Aug. 8, 2014, 10:51 p.m., Joel Koshy wrote: > > core/src/main/scala/kafka/api/TransactionRequest.scala, line 41 > > > > > > Although this is "sort-of" a constructor it is a regular method so > > start with lower c

[jira] [Commented] (KAFKA-1522) Transactional messaging request/response definitions

[ https://issues.apache.org/jira/browse/KAFKA-1522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14091643#comment-14091643 ] Dong Lin commented on KAFKA-1522: - Updated reviewboard https://reviews.apache.org/r/23567/

[jira] [Updated] (KAFKA-1522) Transactional messaging request/response definitions

[ https://issues.apache.org/jira/browse/KAFKA-1522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated KAFKA-1522: Attachment: KAFKA-1522_2014-08-08_21:21:15.patch > Transactional messaging request/response definitions > -

Re: Review Request 23567: Patch for KAFKA-1522

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23567/ --- (Updated Aug. 9, 2014, 4:21 a.m.) Review request for kafka. Bugs: KAFKA-1522

[jira] [Commented] (KAFKA-1581) Log cleaner should have an option to ignore messages without keys

[ https://issues.apache.org/jira/browse/KAFKA-1581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14091622#comment-14091622 ] Todd Palino commented on KAFKA-1581: I suggest that you should just skip any invalid m

Build failed in Jenkins: Kafka-trunk #242

See Changes: [junrao] kafka-1578; Controller should de-register all listeners upon designation; patched by Guozhang Wang; reviewed by Jun Rao -- [...truncated 228 lines...] kafka.producer.AsyncProdu

[jira] [Updated] (KAFKA-1567) Metric memory leaking after closing the clients

[ https://issues.apache.org/jira/browse/KAFKA-1567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiangjie Qin updated KAFKA-1567: Attachment: KAFKA-1567_2014-08-08_18:44:20.patch > Metric memory leaking after closing the clients

[jira] [Commented] (KAFKA-1567) Metric memory leaking after closing the clients

[ https://issues.apache.org/jira/browse/KAFKA-1567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14091570#comment-14091570 ] Jiangjie Qin commented on KAFKA-1567: - Updated reviewboard https://reviews.apache.org/

Re: Review Request 24196: Patch for KAFKA-1567

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24196/ --- (Updated Aug. 9, 2014, 1:44 a.m.) Review request for kafka. Bugs: KAFKA-1567

[jira] [Created] (KAFKA-1584) TestUtils createBrokerConfig method argument mismatch

parin jogani created KAFKA-1584: --- Summary: TestUtils createBrokerConfig method argument mismatch Key: KAFKA-1584 URL: https://issues.apache.org/jira/browse/KAFKA-1584 Project: Kafka Issue Type:

[jira] [Commented] (KAFKA-1524) Implement transactional producer

[ https://issues.apache.org/jira/browse/KAFKA-1524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14091410#comment-14091410 ] Joel Koshy commented on KAFKA-1524: --- [~raulcf] will take a look at the updated patch. In

[jira] [Commented] (KAFKA-1524) Implement transactional producer

[ https://issues.apache.org/jira/browse/KAFKA-1524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14091412#comment-14091412 ] Joel Koshy commented on KAFKA-1524: --- BTW, that is described here: https://cwiki.apache.

Re: Review Request 23567: Patch for KAFKA-1522

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23567/#review50081 --- core/src/main/scala/kafka/api/TransactionRequest.scala

[jira] [Updated] (KAFKA-1582) System Test should wait for producer to finish

[ https://issues.apache.org/jira/browse/KAFKA-1582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated KAFKA-1582: Attachment: KAFKA-1582.patch > System Test should wait for producer to finish > ---

[jira] [Commented] (KAFKA-1582) System Test should wait for producer to finish

[ https://issues.apache.org/jira/browse/KAFKA-1582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14091342#comment-14091342 ] Dong Lin commented on KAFKA-1582: - Created reviewboard https://reviews.apache.org/r/24510/

[jira] [Created] (KAFKA-1583) Kafka API Refactoring

Guozhang Wang created KAFKA-1583: Summary: Kafka API Refactoring Key: KAFKA-1583 URL: https://issues.apache.org/jira/browse/KAFKA-1583 Project: Kafka Issue Type: Bug Reporter: Guo

Review Request 24510: Patch for KAFKA-1582

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24510/ --- Review request for kafka. Bugs: KAFKA-1582 https://issues.apache.org/jira/b

[jira] [Created] (KAFKA-1582) System Test should wait for producer to finish

Dong Lin created KAFKA-1582: --- Summary: System Test should wait for producer to finish Key: KAFKA-1582 URL: https://issues.apache.org/jira/browse/KAFKA-1582 Project: Kafka Issue Type: Bug

[jira] [Resolved] (KAFKA-1578) Controller should de-register all listeners upon designation

[ https://issues.apache.org/jira/browse/KAFKA-1578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao resolved KAFKA-1578. Resolution: Fixed Fix Version/s: (was: 0.9.0) 0.8.2 Thanks for the patch. +1

[jira] [Commented] (KAFKA-1578) Controller should de-register all listeners upon designation

[ https://issues.apache.org/jira/browse/KAFKA-1578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14091237#comment-14091237 ] Guozhang Wang commented on KAFKA-1578: -- Updated reviewboard https://reviews.apache.or

[jira] [Updated] (KAFKA-1578) Controller should de-register all listeners upon designation

[ https://issues.apache.org/jira/browse/KAFKA-1578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1578: - Attachment: KAFKA-1578_2014-08-08_13:13:39.patch > Controller should de-register all listeners up

Re: Review Request 24480: Fix KAFKA-1578

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24480/ --- (Updated Aug. 8, 2014, 8:13 p.m.) Review request for kafka. Bugs: KAFKA-1578

Re: Review Request 24480: Fix KAFKA-1578

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24480/#review50069 --- Looks good. Just a couple of minor comments below. core/src/main/s

Re: Review Request 24006: Patch for KAFKA-1420

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24006/#review50060 --- Ship it! Looks good to me, just a couple minor comments below. co

[jira] [Created] (KAFKA-1581) Log cleaner should have an option to ignore messages without keys

Joel Koshy created KAFKA-1581: - Summary: Log cleaner should have an option to ignore messages without keys Key: KAFKA-1581 URL: https://issues.apache.org/jira/browse/KAFKA-1581 Project: Kafka Is

[jira] [Created] (KAFKA-1580) Reject producer requests to internal topics

Joel Koshy created KAFKA-1580: - Summary: Reject producer requests to internal topics Key: KAFKA-1580 URL: https://issues.apache.org/jira/browse/KAFKA-1580 Project: Kafka Issue Type: Bug

Re: Review Request 24480: Fix KAFKA-1578

> On Aug. 8, 2014, 6:10 p.m., Joel Koshy wrote: > > I don't see a diff with v1 - did you mean to update the diff to deregister > > the broker change listener as well? > > Guozhang Wang wrote: > You can clikc on "Diff r2" of the previous tab of Review request changed. My bad actually. The R

[jira] [Commented] (KAFKA-1578) Controller should de-register all listeners upon designation

[ https://issues.apache.org/jira/browse/KAFKA-1578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14091122#comment-14091122 ] Guozhang Wang commented on KAFKA-1578: -- Updated reviewboard https://reviews.apache.or

[jira] [Updated] (KAFKA-1578) Controller should de-register all listeners upon designation

[ https://issues.apache.org/jira/browse/KAFKA-1578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1578: - Attachment: KAFKA-1578_2014-08-08_11:39:06.patch > Controller should de-register all listeners up

Re: Review Request 24480: Fix KAFKA-1578

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24480/ --- (Updated Aug. 8, 2014, 6:39 p.m.) Review request for kafka. Bugs: KAFKA-1578

[jira] [Commented] (KAFKA-1510) Force offset commits when migrating consumer offsets from zookeeper to kafka

[ https://issues.apache.org/jira/browse/KAFKA-1510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14091103#comment-14091103 ] Joel Koshy commented on KAFKA-1510: --- Would you be able to update your patch to take into

[jira] [Commented] (KAFKA-1510) Force offset commits when migrating consumer offsets from zookeeper to kafka

[ https://issues.apache.org/jira/browse/KAFKA-1510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14091100#comment-14091100 ] Joel Koshy commented on KAFKA-1510: --- [~nmarasoi] I realized later there is actually a fl

Re: Review Request 24480: Fix KAFKA-1578

> On Aug. 8, 2014, 6:10 p.m., Joel Koshy wrote: > > I don't see a diff with v1 - did you mean to update the diff to deregister > > the broker change listener as well? You can clikc on "Diff r2" of the previous tab of Review request changed. - Guozhang ---

Re: Review Request 24480: Fix KAFKA-1578

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24480/#review50055 --- I don't see a diff with v1 - did you mean to update the diff to dere

[jira] [Updated] (KAFKA-1578) Controller should de-register all listeners upon designation

[ https://issues.apache.org/jira/browse/KAFKA-1578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1578: - Attachment: KAFKA-1578_2014-08-08_10:28:11.patch > Controller should de-register all listeners up

[jira] [Commented] (KAFKA-1578) Controller should de-register all listeners upon designation

[ https://issues.apache.org/jira/browse/KAFKA-1578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14090995#comment-14090995 ] Guozhang Wang commented on KAFKA-1578: -- Updated reviewboard https://reviews.apache.or

Re: Review Request 24480: Fix KAFKA-1578

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24480/ --- (Updated Aug. 8, 2014, 5:28 p.m.) Review request for kafka. Bugs: KAFKA-1578

[jira] [Created] (KAFKA-1579) End-to-End tool to measure performance and correctness test

Raul Castro Fernandez created KAFKA-1579: Summary: End-to-End tool to measure performance and correctness test Key: KAFKA-1579 URL: https://issues.apache.org/jira/browse/KAFKA-1579 Project: Ka

[jira] [Comment Edited] (KAFKA-1282) Disconnect idle socket connection in Selector

[ https://issues.apache.org/jira/browse/KAFKA-1282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14090832#comment-14090832 ] nicu marasoiu edited comment on KAFKA-1282 at 8/8/14 3:37 PM: --

Re: Review Request 24196: Patch for KAFKA-1567

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24196/#review50036 --- Thanks for the patch. A few comments below. core/src/main/scala/ka

[jira] [Commented] (KAFKA-1282) Disconnect idle socket connection in Selector

[ https://issues.apache.org/jira/browse/KAFKA-1282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14090832#comment-14090832 ] nicu marasoiu commented on KAFKA-1282: -- Hi, I will spend 1-2 hours per day the next