In the scala clients we have the socket.timeout config as we are using
blocking IOs, when such timeout is reached the TimeoutException will be
thrown from the socket and the client can handle it accordingly; in the
java clients we are switching to non-blocking IOs and hence we will not
have the
[
https://issues.apache.org/jira/browse/KAFKA-1952?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jun Rao updated KAFKA-1952:
---
Fix Version/s: (was: 0.8.2.0)
0.8.2.1
High CPU Usage in 0.8.2 release
See https://builds.apache.org/job/Kafka-trunk/393/changes
Changes:
[wangguoz] KAFKA-1805; ProducerRecord should implement equals and hashCode;
reviewed by Guozhang Wang
--
[...truncated 1695 lines...]
kafka.log.LogManagerTest testLeastLoadedAssignment
[
https://issues.apache.org/jira/browse/KAFKA-1805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14325187#comment-14325187
]
Guozhang Wang commented on KAFKA-1805:
--
Thanks for the patch, committed to trunk.
See https://builds.apache.org/job/KafkaPreCommit/7/changes
Changes:
[jjkoshy] KAFKA-1943; MessageSizeTooLarge and MessageSetSizeTooLarge should not
be counted toward broker-side producer failure rate
[jjkoshy] KAFKA-1914; Include total produce/fetch stats in broker topic metrics.
Yeah there was a separate thread on adding a client-side timeout to
requests. We should have this in the new java clients, it just isn't there
yet. When we do this the flush() call will implicitly have the same timeout
as the requests (since they will complete or fail by then). I think this
makes
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30848/#review72837
---
Ship it!
Ship It!
- Joel Koshy
On Feb. 10, 2015, 10:17 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31140/#review72849
---
Couple of comments to call out.
On Feb. 18, 2015, 2:06 a.m., Guozhang Wang wrote:
core/src/main/scala/kafka/server/DelayedOperation.scala, line 286
https://reviews.apache.org/r/31140/diff/1/?file=866729#file866729line286
We can move the debug statement out of the synchronized block.
Good point.
On Feb. 18,
[
https://issues.apache.org/jira/browse/KAFKA-1914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aditya A Auradkar updated KAFKA-1914:
-
Attachment: KAFKA-1914_2015-02-17_15:46:27.patch
Count TotalProduceRequestRate and
On Feb. 17, 2015, 11:02 p.m., Guozhang Wang wrote:
core/src/test/scala/unit/kafka/server/SimpleFetchTest.scala, line 137
https://reviews.apache.org/r/30570/diff/1/?file=846133#file846133line137
Should this be BrokerTopicStats.getBrokerAllTopicsStats()?
Good catch. Fixed
- Aditya
[
https://issues.apache.org/jira/browse/KAFKA-1914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14325135#comment-14325135
]
Aditya A Auradkar commented on KAFKA-1914:
--
Updated reviewboard
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30763/#review72821
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30570/
---
(Updated Feb. 17, 2015, 11:46 p.m.)
Review request for kafka and Joel Koshy.
On Feb. 18, 2015, 12:41 a.m., Joel Koshy wrote:
core/src/main/scala/kafka/server/KafkaRequestHandler.scala, line 108
https://reviews.apache.org/r/30570/diff/2/?file=866690#file866690line108
I think the aggregate rates here are redundant to what's already there
in RequestChannel's
[
https://issues.apache.org/jira/browse/KAFKA-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joel Koshy reassigned KAFKA-1962:
-
Assignee: Joel Koshy
I'll combine this with KAFKA-1953
Restore delayed request metrics
[
https://issues.apache.org/jira/browse/KAFKA-1660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14325210#comment-14325210
]
Parth Brahmbhatt commented on KAFKA-1660:
-
[~jkreps] I have updated the review
See https://builds.apache.org/job/KafkaPreCommit/6/changes
Changes:
[wangguoz] KAFKA-1805; ProducerRecord should implement equals and hashCode;
reviewed by Guozhang Wang
--
[...truncated 562 lines...]
org.apache.kafka.common.config.ConfigDefTest
[
https://issues.apache.org/jira/browse/KAFKA-1914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joel Koshy resolved KAFKA-1914.
---
Resolution: Fixed
Committed to trunk
Count TotalProduceRequestRate and TotalFetchRequestRate in
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31140/#review72875
---
core/src/main/scala/kafka/server/DelayedOperation.scala
See https://builds.apache.org/job/Kafka-trunk/394/changes
Changes:
[jjkoshy] KAFKA-1943; MessageSizeTooLarge and MessageSetSizeTooLarge should not
be counted toward broker-side producer failure rate
[jjkoshy] KAFKA-1914; Include total produce/fetch stats in broker topic metrics.
[
https://issues.apache.org/jira/browse/KAFKA-1660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14325207#comment-14325207
]
Parth Brahmbhatt commented on KAFKA-1660:
-
Updated reviewboard
[
https://issues.apache.org/jira/browse/KAFKA-1660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Parth Brahmbhatt updated KAFKA-1660:
Attachment: KAFKA-1660_2015-02-17_16:41:19.patch
Ability to call close() with a timeout on
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30570/#review72845
---
Ship it!
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29467/
---
(Updated Feb. 18, 2015, 12:41 a.m.)
Review request for kafka.
Bugs:
[
https://issues.apache.org/jira/browse/KAFKA-1953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14325327#comment-14325327
]
Joel Koshy commented on KAFKA-1953:
---
Updated reviewboard
[
https://issues.apache.org/jira/browse/KAFKA-1953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joel Koshy updated KAFKA-1953:
--
Attachment: KAFKA-1953_2015-02-17_18:23:55.patch
Disambiguate metrics from different purgatories
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30570/#review72817
---
core/src/test/scala/unit/kafka/server/SimpleFetchTest.scala
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31140/
---
Review request for kafka.
Bugs: KAFKA-1953
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31140/
---
(Updated Feb. 18, 2015, 2:23 a.m.)
Review request for kafka.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30809/#review72786
---
core/src/main/scala/kafka/tools/ContinuousValidationTest.java
[
https://issues.apache.org/jira/browse/KAFKA-1805?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guozhang Wang updated KAFKA-1805:
-
Assignee: Parth Brahmbhatt (was: Thomas Omans)
Kafka ProducerRecord should implement equals
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30570/#review72836
---
Ship it!
Ship It!
- Guozhang Wang
On Feb. 17, 2015, 11:46 p.m.,
[
https://issues.apache.org/jira/browse/KAFKA-1805?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guozhang Wang resolved KAFKA-1805.
--
Resolution: Fixed
Kafka ProducerRecord should implement equals
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29467/
---
(Updated Feb. 18, 2015, 12:36 a.m.)
Review request for kafka.
Bugs:
[
https://issues.apache.org/jira/browse/KAFKA-1953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joel Koshy updated KAFKA-1953:
--
Status: Patch Available (was: Open)
Disambiguate metrics from different purgatories
[
https://issues.apache.org/jira/browse/KAFKA-1953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joel Koshy updated KAFKA-1953:
--
Attachment: KAFKA-1953.patch
Disambiguate metrics from different purgatories
[
https://issues.apache.org/jira/browse/KAFKA-1953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14325219#comment-14325219
]
Joel Koshy commented on KAFKA-1953:
---
Created reviewboard
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30809/
---
(Updated Feb. 18, 2015, 1:59 a.m.)
Review request for kafka.
Bugs:
[
https://issues.apache.org/jira/browse/KAFKA-1960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joel Koshy resolved KAFKA-1960.
---
Resolution: Fixed
Assignee: Tong Li
Thanks for the patch - committed to trunk.
.gitignore
[
https://issues.apache.org/jira/browse/KAFKA-1959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joel Koshy resolved KAFKA-1959.
---
Resolution: Fixed
Assignee: Tong Li
Thanks for the patch - committed to trunk.
Class
[
https://issues.apache.org/jira/browse/KAFKA-1952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14325439#comment-14325439
]
Jun Rao commented on KAFKA-1952:
Attach a patch for trunk. The CPU load and the end to end
Hello all,
Completely new to kafka and scala but thought I would get my feet
wet with a few of the newbie tasks.
I was able to get the source up and running in the Scala IDE and I
am able to debug the examples, however when I try to debug any of the
unit tests in core (for example the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31097/#review72911
---
Ship it!
Ship It!
- Joel Koshy
On Feb. 16, 2015, 9:48 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31088/#review72910
---
Ship it!
Ship It!
- Joel Koshy
On Feb. 16, 2015, 4:37 p.m.,
On Feb. 4, 2015, 2:15 a.m., Joel Koshy wrote:
core/src/main/scala/kafka/api/OffsetCommitRequest.scala, line 48
https://reviews.apache.org/r/27391/diff/11/?file=832423#file832423line48
I our convention is to include the if in the previous line.
Guozhang Wang wrote:
I checked
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31150/#review72907
---
Ship it!
core/src/main/scala/kafka/server/DelayedOperation.scala
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31150/
---
Review request for kafka.
Bugs: kafka-1952
[
https://issues.apache.org/jira/browse/KAFKA-1952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14325435#comment-14325435
]
Jun Rao commented on KAFKA-1952:
Created reviewboard
[
https://issues.apache.org/jira/browse/KAFKA-1952?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jun Rao updated KAFKA-1952:
---
Attachment: kafka-1952.patch
High CPU Usage in 0.8.2 release
---
On Feb. 13, 2015, 7:01 p.m., Joel Koshy wrote:
core/src/main/scala/kafka/server/OffsetManager.scala, line 215
https://reviews.apache.org/r/29912/diff/3/?file=862699#file862699line215
Minor comment. I think this may be better to pass in to the
OffsetManager.
We should
[
https://issues.apache.org/jira/browse/KAFKA-1961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14324505#comment-14324505
]
Neha Narkhede commented on KAFKA-1961:
--
That's a good catch [~gwenshap]. Seems like a
Joel Koshy created KAFKA-1962:
-
Summary: Restore delayed request metrics
Key: KAFKA-1962
URL: https://issues.apache.org/jira/browse/KAFKA-1962
Project: Kafka
Issue Type: Sub-task
Joel Koshy created KAFKA-1963:
-
Summary: Add unit tests to check presence of all metrics
Key: KAFKA-1963
URL: https://issues.apache.org/jira/browse/KAFKA-1963
Project: Kafka
Issue Type: Bug
[
https://issues.apache.org/jira/browse/KAFKA-1694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14324755#comment-14324755
]
Guozhang Wang commented on KAFKA-1694:
--
[~abiletskyi], I am wondering if we can split
[
https://issues.apache.org/jira/browse/KAFKA-1961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14324770#comment-14324770
]
Jay Kreps commented on KAFKA-1961:
--
Makes sense.
[~jjkoshy] Deleting the topic would
I've reviewed both (but can't commit obviously)
They are both safe (a rename and an addition to .gitignore).
The addition to .gitignore will be very useful for anyone who uses system
tests (which should be all of us).
The rename is useful only to those using IBM JDK (i.e. not all of us), but
Dear kafka developers,
New to this community and put up two really small patch sets with
open issues, can any one please review and comment and get them merged if
all possible? Thanks
https://reviews.apache.org/r/31097/
https://reviews.apache.org/r/31097/
Tong Li
OpenStack Kafka
Dear kafka developers,
New to this community and put up two really small patch sets with
open issues, can any one please review and comment and get them merged if
all possible? Thanks
https://reviews.apache.org/r/31088/
https://reviews.apache.org/r/31097/
Tong Li
OpenStack Community
[
https://issues.apache.org/jira/browse/KAFKA-1778?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Abhishek Nigam reassigned KAFKA-1778:
-
Assignee: Abhishek Nigam
Create new re-elect controller admin function
[
https://issues.apache.org/jira/browse/KAFKA-1961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14324545#comment-14324545
]
Jay Kreps commented on KAFKA-1961:
--
This would be hard to do accidentally, right, you
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30848/#review72749
---
Ship it!
Ship It!
- Guozhang Wang
On Feb. 10, 2015, 10:17 p.m.,
[
https://issues.apache.org/jira/browse/KAFKA-1867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14324659#comment-14324659
]
Sriharsha Chintalapani commented on KAFKA-1867:
---
[~nehanarkhede] pinging for
[
https://issues.apache.org/jira/browse/KAFKA-1961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14324724#comment-14324724
]
Gwen Shapira commented on KAFKA-1961:
-
[~jkreps] - by accidentally I mean, I don't
On Feb. 13, 2015, 7:01 p.m., Joel Koshy wrote:
core/src/main/scala/kafka/server/OffsetManager.scala, line 215
https://reviews.apache.org/r/29912/diff/3/?file=862699#file862699line215
Minor comment. I think this may be better to pass in to the
OffsetManager.
We should
On Feb. 3, 2015, 7:14 p.m., Guozhang Wang wrote:
clients/src/main/java/org/apache/kafka/common/protocol/ApiKeys.java, lines
39-42
https://reviews.apache.org/r/29301/diff/7/?file=821315#file821315line39
How about merge them into one request? The format could be:
topic
Gwen,
Really appreciate it. Thanks so much. Anyone else please review them?
Here are the links again.
https://reviews.apache.org/r/31088/
https://reviews.apache.org/r/31097/
Tong Li
OpenStack Community Development
Building 501/B205
liton...@us.ibm.com
From: Gwen Shapira
[
https://issues.apache.org/jira/browse/KAFKA-1961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14324917#comment-14324917
]
Joel Koshy commented on KAFKA-1961:
---
Yes it would be inconsistent in that you would lose
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30763/#review72794
---
I'm thinking the flush call timeout will naturally be the timeout for a
produce request, No?
Currently it seems we don¹t have a timeout for client requests, should we
have one?
‹Jiangjie (Becket) Qin
On 2/16/15, 8:19 PM, Jay Kreps jay.kr...@gmail.com wrote:
Yes, I think we all agree it would
[
https://issues.apache.org/jira/browse/KAFKA-1961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14324924#comment-14324924
]
Jay Kreps commented on KAFKA-1961:
--
Yeah I think since the cache would be totally out of
On Tue, 17 Feb 2015, at 08:57, dev-h...@kafka.apache.org wrote:
Hi! This is the ezmlm program. I'm managing the
dev@kafka.apache.org mailing list.
I'm working for my owner, who can be reached
at dev-ow...@kafka.apache.org.
To confirm that you would like
d...@dyachkov.org
added
GitHub user arcz opened a pull request:
https://github.com/apache/kafka/pull/44
Update DelayedFetch.scala
Fix typo
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/arcz/kafka patch-1
Alternatively you can review and apply these
73 matches
Mail list logo
