Re: Review Request 35076: Patch for KAFKA-2248

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35076/#review86754 --- Ship it! Thanks for this patch. I have a question below on why it f

Re: Review Request 33378: Patch for KAFKA-2136

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33378/#review86428 --- Overall, looks good. General comment on the naming: delay vs thrott

Re: Review Request 33196: Patch for KAFKA-2123

> On May 31, 2015, 9:10 p.m., Guozhang Wang wrote: > > Thanks for the explanation Ewen. I agree that a delayed scheduler would be > > a good fit here, but was originally more concerned about the complexity we > > introduced by adding two queues (one for delayed actions and another for > > hand

Re: Review Request 33196: Patch for KAFKA-2123

> On May 31, 2015, 9:10 p.m., Guozhang Wang wrote: > > Thanks for the explanation Ewen. I agree that a delayed scheduler would be > > a good fit here, but was originally more concerned about the complexity we > > introduced by adding two queues (one for delayed actions and another for > > hand

Re: [DISCUSS] KIP-25 System test improvements

Not completely random places :) People may use Cloudera / HWX distributions which include Kafka, but want to verify that these bits match a specific upstream release. I think having the tests separately will be useful for this. In this case, finding the tests are not a big issue - we'll add a down

Re: [DISCUSS] KIP-25 System test improvements

Hey Gwen, Currently the test and code are downloaded at the same time. Supposedly the tests in the same repository should cover match the code. Are you saying people downloaded a release from some random place and want to verify it? If that is the case, does that mean people still need to find the

Re: Review Request 34789: Patch for KAFKA-2168

> On June 4, 2015, 6:21 p.m., Ewen Cheslack-Postava wrote: > > clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java, > > line 671 > > > > > > It looks like these were already issues before this c

[jira] [Commented] (KAFKA-2247) Merge kafka.utils.Time and kafka.common.utils.Time

[ https://issues.apache.org/jira/browse/KAFKA-2247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14573803#comment-14573803 ] Gwen Shapira commented on KAFKA-2247: - It seems fairly easy except that kafka.utils.Ti

Re: Review Request 33049: Patch for KAFKA-2084

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33049/ --- (Updated June 4, 2015, 11:32 p.m.) Review request for kafka, Joel Koshy and Jun

[jira] [Commented] (KAFKA-2084) byte rate metrics per client ID (producer and consumer)

[ https://issues.apache.org/jira/browse/KAFKA-2084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14573798#comment-14573798 ] Aditya A Auradkar commented on KAFKA-2084: -- Updated reviewboard https://reviews.a

Re: Review Request 33049: Patch for KAFKA-2084

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33049/ --- (Updated June 4, 2015, 11:31 p.m.) Review request for kafka, Joel Koshy and Jun

[jira] [Updated] (KAFKA-2084) byte rate metrics per client ID (producer and consumer)

[ https://issues.apache.org/jira/browse/KAFKA-2084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya A Auradkar updated KAFKA-2084: - Attachment: KAFKA-2084_2015-06-04_16:31:22.patch > byte rate metrics per client ID (produc

Re: [DISCUSS] KIP-25 System test improvements

Hi, Reviving the discussion a bit :) I think it will be nice if each Kafka version that we release will also have a separate "tests" artifact that users can download, untar and easily run against a Kafka cluster of the same version. The idea is that if someone downloads packages that claim to co

Re: Review Request 33049: Patch for KAFKA-2084

> On June 3, 2015, 3:57 p.m., Joel Koshy wrote: > > core/src/main/scala/kafka/server/KafkaServer.scala, line 200 > > > > > > Can we consider migrating the server to use the Time interface in > > clients and just use

[jira] [Updated] (KAFKA-2210) KafkaAuthorizer: Add all public entities, config changes and changes to KafkaAPI and kafkaServer to allow pluggable authorizer implementation.

[ https://issues.apache.org/jira/browse/KAFKA-2210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Parth Brahmbhatt updated KAFKA-2210: Attachment: KAFKA-2210_2015-06-04_16:07:39.patch > KafkaAuthorizer: Add all public entities,

[jira] [Commented] (KAFKA-2210) KafkaAuthorizer: Add all public entities, config changes and changes to KafkaAPI and kafkaServer to allow pluggable authorizer implementation.

[ https://issues.apache.org/jira/browse/KAFKA-2210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14573759#comment-14573759 ] Parth Brahmbhatt commented on KAFKA-2210: - Updated reviewboard https://reviews.apa

Re: Review Request 34492: Patch for KAFKA-2210

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34492/ --- (Updated June 4, 2015, 11:07 p.m.) Review request for kafka. Bugs: KAFKA-2210

[jira] [Comment Edited] (KAFKA-2096) Enable keepalive socket option for broker to prevent socket leak

[ https://issues.apache.org/jira/browse/KAFKA-2096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14573661#comment-14573661 ] Alex the Rocker edited comment on KAFKA-2096 at 6/4/15 9:56 PM:

[jira] [Commented] (KAFKA-2096) Enable keepalive socket option for broker to prevent socket leak

[ https://issues.apache.org/jira/browse/KAFKA-2096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14573661#comment-14573661 ] Alex the Rocker commented on KAFKA-2096: We also have got the same issue with Kafk

[jira] [Commented] (KAFKA-2120) Add a request timeout to NetworkClient

[ https://issues.apache.org/jira/browse/KAFKA-2120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14573643#comment-14573643 ] Jason Gustafson commented on KAFKA-2120: The new consumer will also be able to tak

[jira] [Commented] (KAFKA-2168) New consumer poll() can block other calls like position(), commit(), and close() indefinitely

[ https://issues.apache.org/jira/browse/KAFKA-2168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14573627#comment-14573627 ] Jason Gustafson commented on KAFKA-2168: Updated reviewboard https://reviews.apach

[jira] [Updated] (KAFKA-2168) New consumer poll() can block other calls like position(), commit(), and close() indefinitely

[ https://issues.apache.org/jira/browse/KAFKA-2168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson updated KAFKA-2168: --- Attachment: KAFKA-2168_2015-06-04_14:36:04.patch > New consumer poll() can block other calls l

Re: Review Request 34789: Patch for KAFKA-2168

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34789/ --- (Updated June 4, 2015, 9:36 p.m.) Review request for kafka. Bugs: KAFKA-2168

[jira] [Assigned] (KAFKA-1894) Avoid long or infinite blocking in the consumer

[ https://issues.apache.org/jira/browse/KAFKA-1894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson reassigned KAFKA-1894: -- Assignee: Jason Gustafson > Avoid long or infinite blocking in the consumer > -

[jira] [Updated] (KAFKA-2252) Socket connection closing is logged, but not corresponding opening of socket

[ https://issues.apache.org/jira/browse/KAFKA-2252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Rosenberg updated KAFKA-2252: --- Description: (using 0.8.2.1) We see a large number of "Closing socket connection" logging to t

[jira] [Created] (KAFKA-2252) Socket connection closing is logged, but not corresponding opening of socket

Jason Rosenberg created KAFKA-2252: -- Summary: Socket connection closing is logged, but not corresponding opening of socket Key: KAFKA-2252 URL: https://issues.apache.org/jira/browse/KAFKA-2252 Projec

[jira] [Resolved] (KAFKA-2154) MetadataResponse is Empty on a Fresh Cluster

[ https://issues.apache.org/jira/browse/KAFKA-2154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Bourgoin resolved KAFKA-2154. --- Resolution: Duplicate Fix Version/s: 0.8.3 > MetadataResponse is Empty on a Fresh Clust

[jira] [Commented] (KAFKA-2154) MetadataResponse is Empty on a Fresh Cluster

[ https://issues.apache.org/jira/browse/KAFKA-2154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14573543#comment-14573543 ] Keith Bourgoin commented on KAFKA-2154: --- Confirmed fixed in 0.8.3. Thanks for the he

Re: Review Request 34789: Patch for KAFKA-2168

> On June 3, 2015, 6:44 a.m., Ewen Cheslack-Postava wrote: > > clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java, > > line 1091 > > > > > > Since poll() can trigger auto offset commits, and t

[jira] [Updated] (KAFKA-2245) Add response tests for ConsumerCoordinator

[ https://issues.apache.org/jira/browse/KAFKA-2245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Onur Karaman updated KAFKA-2245: Summary: Add response tests for ConsumerCoordinator (was: Add tests for ConsumerCoordinator) > Add

[jira] [Updated] (KAFKA-2251) "Connection reset by peer" IOExceptions should not be logged as ERROR

[ https://issues.apache.org/jira/browse/KAFKA-2251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Rosenberg updated KAFKA-2251: --- Description: It's normal to see lots of these exceptions logged in the broker logs: {code} 20

[jira] [Created] (KAFKA-2251) "Connection reset by peer" IOExceptions should not be logged as ERROR

Jason Rosenberg created KAFKA-2251: -- Summary: "Connection reset by peer" IOExceptions should not be logged as ERROR Key: KAFKA-2251 URL: https://issues.apache.org/jira/browse/KAFKA-2251 Project: Kafk

[jira] [Updated] (KAFKA-2245) Add tests for ConsumerCoordinator

[ https://issues.apache.org/jira/browse/KAFKA-2245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Onur Karaman updated KAFKA-2245: Status: Patch Available (was: Open) > Add tests for ConsumerCoordinator > -

[jira] [Commented] (KAFKA-2245) Add tests for ConsumerCoordinator

[ https://issues.apache.org/jira/browse/KAFKA-2245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14573479#comment-14573479 ] Onur Karaman commented on KAFKA-2245: - Created reviewboard https://reviews.apache.org/

[jira] [Updated] (KAFKA-2245) Add tests for ConsumerCoordinator

[ https://issues.apache.org/jira/browse/KAFKA-2245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Onur Karaman updated KAFKA-2245: Attachment: KAFKA-2245.patch > Add tests for ConsumerCoordinator > -

Review Request 35086: add response tests for ConsumerCoordinator

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35086/ --- Review request for kafka. Bugs: KAFKA-2245 https://issues.apache.org/jira/b

[jira] [Created] (KAFKA-2250) ConcurrentModificationException in metrics reporting

Jason Rosenberg created KAFKA-2250: -- Summary: ConcurrentModificationException in metrics reporting Key: KAFKA-2250 URL: https://issues.apache.org/jira/browse/KAFKA-2250 Project: Kafka Issue

[jira] [Commented] (KAFKA-1682) Security for Kafka

[ https://issues.apache.org/jira/browse/KAFKA-1682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14573439#comment-14573439 ] Sriharsha Chintalapani commented on KAFKA-1682: --- [~guozhang] I don't think K

[jira] [Commented] (KAFKA-1682) Security for Kafka

[ https://issues.apache.org/jira/browse/KAFKA-1682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14573422#comment-14573422 ] Guozhang Wang commented on KAFKA-1682: -- [~junrao] I am wondering if KAFKA-1927 needs

Newbie question on graddle startup error

Hi, I have been using Kafka as DevOps user for a few months now and am now looking at "building/testing" Kafka from source code.My gradle build is failing (source from GitHub) with the error show below.This is a windows laptop with 4 GB memory and about 3 GB free RAM.I have also tried increasing

[jira] [Assigned] (KAFKA-2245) Add tests for ConsumerCoordinator

[ https://issues.apache.org/jira/browse/KAFKA-2245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Onur Karaman reassigned KAFKA-2245: --- Assignee: Onur Karaman (was: Guozhang Wang) > Add tests for ConsumerCoordinator > --

Re: Review Request 34789: Patch for KAFKA-2168

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34789/#review86651 --- clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsum

[jira] [Created] (KAFKA-2249) KafkaConfig does not preserve original Properties

Gwen Shapira created KAFKA-2249: --- Summary: KafkaConfig does not preserve original Properties Key: KAFKA-2249 URL: https://issues.apache.org/jira/browse/KAFKA-2249 Project: Kafka Issue Type: Bug

Re: Review Request 34789: Patch for KAFKA-2168

> On June 3, 2015, 6:44 a.m., Ewen Cheslack-Postava wrote: > > clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java, > > line 1091 > > > > > > Since poll() can trigger auto offset commits, and t

Re: Review Request 34789: Patch for KAFKA-2168

> On June 3, 2015, 6:44 a.m., Ewen Cheslack-Postava wrote: > > clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java, > > line 1091 > > > > > > Since poll() can trigger auto offset commits, and t

Re: Review Request 35076: Patch for KAFKA-2248

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35076/#review86649 --- Ship it! Ship It! - Gwen Shapira On June 4, 2015, 4:35 p.m., Ewe

[jira] [Commented] (KAFKA-2161) Fix a few copyrights

[ https://issues.apache.org/jira/browse/KAFKA-2161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14573098#comment-14573098 ] Ewen Cheslack-Postava commented on KAFKA-2161: -- Follow up with Rat patch is i

[jira] [Commented] (KAFKA-2248) Use Apache Rat to enforce copyright headers

[ https://issues.apache.org/jira/browse/KAFKA-2248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14573097#comment-14573097 ] Ewen Cheslack-Postava commented on KAFKA-2248: -- Patch is mostly lifted from t

[jira] [Updated] (KAFKA-2161) Fix a few copyrights

[ https://issues.apache.org/jira/browse/KAFKA-2161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ewen Cheslack-Postava updated KAFKA-2161: - Resolution: Fixed Fix Version/s: 0.8.3 Status: Resolved (was: Pa

[jira] [Updated] (KAFKA-2248) Use Apache Rat to enforce copyright headers

[ https://issues.apache.org/jira/browse/KAFKA-2248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ewen Cheslack-Postava updated KAFKA-2248: - Attachment: KAFKA-2248.patch > Use Apache Rat to enforce copyright headers > -

[jira] [Commented] (KAFKA-2248) Use Apache Rat to enforce copyright headers

[ https://issues.apache.org/jira/browse/KAFKA-2248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14573095#comment-14573095 ] Ewen Cheslack-Postava commented on KAFKA-2248: -- Created reviewboard https://r

[jira] [Updated] (KAFKA-2248) Use Apache Rat to enforce copyright headers

[ https://issues.apache.org/jira/browse/KAFKA-2248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ewen Cheslack-Postava updated KAFKA-2248: - Status: Patch Available (was: Open) > Use Apache Rat to enforce copyright headers

Review Request 35076: Patch for KAFKA-2248

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35076/ --- Review request for kafka. Bugs: KAFKA-2248 https://issues.apache.org/jira/b

[jira] [Created] (KAFKA-2248) Use Apache Rat to enforce copyright headers

Ewen Cheslack-Postava created KAFKA-2248: Summary: Use Apache Rat to enforce copyright headers Key: KAFKA-2248 URL: https://issues.apache.org/jira/browse/KAFKA-2248 Project: Kafka Iss